From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: Chris Wilson <chris@chris-wilson.co.uk>, Tvrtko Ursulin <tursulin@ursulin.net>, igt-dev@lists.freedesktop.org Cc: Intel-gfx@lists.freedesktop.org Subject: Re: [igt-dev] [PATH i-g-t 2/2] tests: add slice power programming test Date: Thu, 6 Sep 2018 10:31:21 +0100 [thread overview] Message-ID: <5f939f9c-f009-aee1-1cd1-4fb09e3b4b83@linux.intel.com> (raw) In-Reply-To: <153621721956.3050.7177978376005330137@skylake-alporthouse-com> On 06/09/2018 08:00, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2018-09-05 15:25:44) >> From: Lionel Landwerlin <lionel.g.landwerlin@intel.com> >> >> Verifies that the kernel programs slices correctly based by reading >> the value of PWR_CLK_STATE register or MI_SET_PREDICATE on platforms >> before Cannonlake. >> >> v2: Add subslice tests (Lionel) >> Use MI_SET_PREDICATE for further verification when available (Lionel) >> >> v3: Rename to gem_ctx_rpcs (Lionel) >> >> v4: Update kernel API (Lionel) >> Add 0 value test (Lionel) >> Exercise invalid values (Lionel) >> >> v5: Add perf tests (Lionel) >> >> v6: Add new sysfs entry tests (Lionel) >> >> v7: Test rsvd fields >> Update for kernel series changes >> >> v8: Drop test_no_sseu_support() test (Kelvin) >> Drop drm_intel_*() apis (Chris) >> >> v9: by Chris: >> Drop all do_ioctl/do_ioctl_err() >> Use gem_context_[gs]et_param() >> Use gem_read() instead of mapping memory >> by Lionel: >> Test dynamic sseu on/off more >> >> Tvrtko Ursulin: >> >> v10: >> * Various style tweaks and refactorings. >> * New test coverage. > > I didn't notice any testing of: > - param->size It exists in test_invalid_args. > - feeding garbage into param->value user pointer (always cleared before > use, perhaps just poison instead), along with abusive pointers. Also in test_invalid_args - but only the null pointer. I can add an unmapped or read-only one. > E.g., how does the code fare if we pass in an unfaulted GGTT mmap? Would not fare well. :I It would be best to be able to reject them but how? We'll hit the same problem in future other patches so to support this, I think we need to refactor Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: Chris Wilson <chris@chris-wilson.co.uk>, Tvrtko Ursulin <tursulin@ursulin.net>, igt-dev@lists.freedesktop.org Cc: Intel-gfx@lists.freedesktop.org Subject: Re: [igt-dev] [Intel-gfx] [PATH i-g-t 2/2] tests: add slice power programming test Date: Thu, 6 Sep 2018 10:31:21 +0100 [thread overview] Message-ID: <5f939f9c-f009-aee1-1cd1-4fb09e3b4b83@linux.intel.com> (raw) In-Reply-To: <153621721956.3050.7177978376005330137@skylake-alporthouse-com> On 06/09/2018 08:00, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2018-09-05 15:25:44) >> From: Lionel Landwerlin <lionel.g.landwerlin@intel.com> >> >> Verifies that the kernel programs slices correctly based by reading >> the value of PWR_CLK_STATE register or MI_SET_PREDICATE on platforms >> before Cannonlake. >> >> v2: Add subslice tests (Lionel) >> Use MI_SET_PREDICATE for further verification when available (Lionel) >> >> v3: Rename to gem_ctx_rpcs (Lionel) >> >> v4: Update kernel API (Lionel) >> Add 0 value test (Lionel) >> Exercise invalid values (Lionel) >> >> v5: Add perf tests (Lionel) >> >> v6: Add new sysfs entry tests (Lionel) >> >> v7: Test rsvd fields >> Update for kernel series changes >> >> v8: Drop test_no_sseu_support() test (Kelvin) >> Drop drm_intel_*() apis (Chris) >> >> v9: by Chris: >> Drop all do_ioctl/do_ioctl_err() >> Use gem_context_[gs]et_param() >> Use gem_read() instead of mapping memory >> by Lionel: >> Test dynamic sseu on/off more >> >> Tvrtko Ursulin: >> >> v10: >> * Various style tweaks and refactorings. >> * New test coverage. > > I didn't notice any testing of: > - param->size It exists in test_invalid_args. > - feeding garbage into param->value user pointer (always cleared before > use, perhaps just poison instead), along with abusive pointers. Also in test_invalid_args - but only the null pointer. I can add an unmapped or read-only one. > E.g., how does the code fare if we pass in an unfaulted GGTT mmap? Would not fare well. :I It would be best to be able to reject them but how? We'll hit the same problem in future other patches so to support this, I think we need to refactor Regards, Tvrtko _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-09-06 9:31 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-05 14:25 [PATH i-g-t 0/2] Per context dynamic (sub)slice power-gating Tvrtko Ursulin 2018-09-05 14:25 ` [igt-dev] " Tvrtko Ursulin 2018-09-05 14:25 ` [PATH i-g-t 1/2] headers: bump Tvrtko Ursulin 2018-09-05 14:25 ` [igt-dev] " Tvrtko Ursulin 2018-09-05 14:25 ` [PATH i-g-t 2/2] tests: add slice power programming test Tvrtko Ursulin 2018-09-05 14:25 ` [igt-dev] " Tvrtko Ursulin 2018-09-05 22:57 ` Chris Wilson 2018-09-05 22:57 ` Chris Wilson 2018-09-06 7:00 ` Chris Wilson 2018-09-06 7:00 ` Chris Wilson 2018-09-06 9:31 ` Tvrtko Ursulin [this message] 2018-09-06 9:31 ` [igt-dev] [Intel-gfx] " Tvrtko Ursulin 2018-09-06 9:50 ` [igt-dev] " Chris Wilson 2018-09-06 9:50 ` [igt-dev] [Intel-gfx] " Chris Wilson 2018-09-11 11:34 ` [PATH i-g-t v11 " Tvrtko Ursulin 2018-09-11 11:34 ` [igt-dev] " Tvrtko Ursulin 2018-09-11 11:45 ` Chris Wilson 2018-09-11 11:45 ` Chris Wilson 2018-09-11 12:00 ` Tvrtko Ursulin 2018-09-11 12:00 ` [Intel-gfx] " Tvrtko Ursulin 2018-09-11 14:42 ` [PATH i-g-t v12 " Tvrtko Ursulin 2018-09-11 14:42 ` [igt-dev] " Tvrtko Ursulin 2018-09-12 11:53 ` Chris Wilson 2018-09-12 11:53 ` [igt-dev] [Intel-gfx] " Chris Wilson 2018-09-13 10:38 ` Tvrtko Ursulin 2018-09-13 10:38 ` [igt-dev] [Intel-gfx] " Tvrtko Ursulin 2018-09-13 10:48 ` Chris Wilson 2018-09-13 10:48 ` [igt-dev] [Intel-gfx] " Chris Wilson 2018-09-14 16:04 ` [PATCH i-g-t v13 2/2] tests/gem_ctx_sseu: Dynamic (sub)slice programming tests Tvrtko Ursulin 2018-09-14 16:04 ` [Intel-gfx] " Tvrtko Ursulin 2018-09-14 16:07 ` [igt-dev] " Chris Wilson 2018-09-14 16:07 ` Chris Wilson 2018-09-14 16:17 ` Chris Wilson 2018-09-14 16:17 ` Chris Wilson 2018-09-17 9:33 ` Tvrtko Ursulin 2018-09-17 9:33 ` [Intel-gfx] " Tvrtko Ursulin 2018-09-17 10:38 ` Chris Wilson 2018-09-17 10:38 ` [Intel-gfx] " Chris Wilson 2018-09-17 11:28 ` [PATCH i-g-t v14 " Tvrtko Ursulin 2018-09-17 11:28 ` [Intel-gfx] " Tvrtko Ursulin 2018-09-17 12:04 ` [igt-dev] " Chris Wilson 2018-09-17 12:04 ` Chris Wilson 2018-09-18 13:41 ` [PATCH i-g-t v15 " Tvrtko Ursulin 2018-09-18 13:41 ` [igt-dev] " Tvrtko Ursulin 2018-09-05 16:46 ` [igt-dev] ✓ Fi.CI.BAT: success for Per context dynamic (sub)slice power-gating Patchwork 2018-09-05 22:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2018-09-11 18:13 ` [igt-dev] ✓ Fi.CI.BAT: success for Per context dynamic (sub)slice power-gating (rev3) Patchwork 2018-09-11 23:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2018-09-14 17:22 ` [igt-dev] ✓ Fi.CI.BAT: success for Per context dynamic (sub)slice power-gating (rev4) Patchwork 2018-09-14 22:22 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 2018-09-17 12:21 ` [igt-dev] ✗ Fi.CI.BAT: failure for Per context dynamic (sub)slice power-gating (rev5) Patchwork 2018-09-17 18:21 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork 2018-09-17 20:43 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2018-09-18 14:02 ` [igt-dev] ✓ Fi.CI.BAT: success for Per context dynamic (sub)slice power-gating (rev6) Patchwork 2018-09-18 15:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5f939f9c-f009-aee1-1cd1-4fb09e3b4b83@linux.intel.com \ --to=tvrtko.ursulin@linux.intel.com \ --cc=Intel-gfx@lists.freedesktop.org \ --cc=chris@chris-wilson.co.uk \ --cc=igt-dev@lists.freedesktop.org \ --cc=tursulin@ursulin.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.