From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Jerome Anand <jerome.anand@intel.com>
Cc: tiwai@suse.de, intel-gfx@lists.freedesktop.org,
broonie@kernel.org, rakesh.a.ughreja@intel.com,
alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH 1/7] drm/i915: setup bridge for HDMI LPE audio driver
Date: Thu, 15 Dec 2016 13:04:21 -0600 [thread overview]
Message-ID: <73eef0cf-b9c2-7baf-046e-3dbb66c19895@linux.intel.com> (raw)
In-Reply-To: <20161214125227.iasl2ff4ud6cdize@phenom.ffwll.local>
>>> +static void lpe_audio_irq_unmask(struct irq_data *d) {
>>> + struct drm_i915_private *dev_priv = d->chip_data;
>>> + unsigned long irqflags;
>>> + u32 val = (I915_LPE_PIPE_A_INTERRUPT |
>>> + I915_LPE_PIPE_B_INTERRUPT);
>>
>> PIPE_C missing?
>>
>
> No PIPE_C on vlv
Good catch Daniel.
We initially had PIPE_C everyhwere, thinking that it's harmless on
Baytrail. Ville had a comment that there was no PIPE_C on BYT so we
removed it for Baytrail-only code, here it makes no sense to me. we have
the same problem in lpe_audio_irq_mask
>> Besides the few bikesheds seems all reasonable, with those addressed
>>
>> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>>
>
> Thanks
>
>> ... for merging through sound tree. Since we're super early in 4.11
a topic
>> branch for me to pull in to avoid sync headaches would be good.
Thanks for the reviews and ack, we'll fix the comments shortly.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-12-15 19:04 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 18:10 [PATCH 0/7] Add support for Legacy HDMI audio drivers Jerome Anand
2016-12-12 6:53 ` ✓ Fi.CI.BAT: success for Add support for Legacy HDMI audio drivers (rev2) Patchwork
2016-12-12 18:10 ` [PATCH 1/7] drm/i915: setup bridge for HDMI LPE audio driver Jerome Anand
2016-12-14 11:43 ` Takashi Iwai
2016-12-15 6:06 ` Anand, Jerome
2016-12-14 12:52 ` Daniel Vetter
2016-12-14 13:03 ` Takashi Iwai
2016-12-15 6:10 ` Anand, Jerome
2016-12-15 19:04 ` Pierre-Louis Bossart [this message]
2016-12-12 18:10 ` [PATCH 2/7] drm/i915: Add support for audio driver notifications Jerome Anand
2016-12-14 11:50 ` Takashi Iwai
2016-12-15 10:18 ` Anand, Jerome
2016-12-15 11:48 ` Ville Syrjälä
2016-12-14 12:55 ` Daniel Vetter
2016-12-14 13:13 ` Takashi Iwai
2016-12-15 19:32 ` Pierre-Louis Bossart
2016-12-15 10:21 ` Anand, Jerome
2016-12-12 18:10 ` [PATCH 3/7] ALSA: add shell for Intel HDMI LPE audio driver Jerome Anand
2016-12-14 12:45 ` Takashi Iwai
2016-12-15 10:55 ` Anand, Jerome
2016-12-15 11:14 ` Takashi Iwai
2016-12-15 11:44 ` Mark Brown
2016-12-15 20:37 ` [alsa-devel] " Pierre-Louis Bossart
2016-12-15 21:01 ` Takashi Iwai
2016-12-12 18:10 ` [PATCH 4/7] ALSA: x86: hdmi: Add audio support for BYT and CHT Jerome Anand
2016-12-14 12:56 ` Takashi Iwai
2016-12-15 11:08 ` Anand, Jerome
2016-12-12 18:10 ` [PATCH 5/7] ALSA: x86: hdmi: Improve position reporting Jerome Anand
2016-12-14 12:57 ` Takashi Iwai
2016-12-14 14:09 ` Pierre-Louis Bossart
2016-12-14 14:36 ` Takashi Iwai
2016-12-14 23:39 ` [alsa-devel] " Pierre-Louis Bossart
2016-12-12 18:10 ` [PATCH 6/7] ALSA: x86: hdmi: Fixup some monitor Jerome Anand
2016-12-14 12:58 ` Takashi Iwai
2016-12-12 18:10 ` [PATCH 7/7] ALSA: x86: hdmi: continue playback even when display resolution changes Jerome Anand
2016-12-14 13:01 ` Takashi Iwai
2016-12-15 11:14 ` Anand, Jerome
2016-12-15 20:44 ` [alsa-devel] " Pierre-Louis Bossart
2016-12-14 11:07 ` [PATCH 0/7] Add support for Legacy HDMI audio drivers Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73eef0cf-b9c2-7baf-046e-3dbb66c19895@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jerome.anand@intel.com \
--cc=rakesh.a.ughreja@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.