Re: [PATCH 5/7] ALSA: x86: hdmi: Improve position reporting

From: Takashi Iwai <tiwai@suse.de>
To: Jerome Anand <jerome.anand@intel.com>
Cc: alsa-devel@alsa-project.org, intel-gfx@lists.freedesktop.org,
	broonie@kernel.org, rakesh.a.ughreja@intel.com
Subject: Re: [PATCH 5/7] ALSA: x86: hdmi: Improve position reporting
Date: Wed, 14 Dec 2016 13:57:05 +0100	[thread overview]
Message-ID: <s5hr35aekim.wl-tiwai@suse.de> (raw)
In-Reply-To: <20161212181043.12512-6-jerome.anand@intel.com>

On Mon, 12 Dec 2016 19:10:41 +0100,
Jerome Anand wrote:
> 
> Use a hw register to calculate sub-period position reports.
> This makes PulseAudio happier.
> 
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Signed-off-by: Jerome Anand <jerome.anand@intel.com>

There is no big merit to keep this a separate patch.
Please fold into the main patch.
You can put some comment in the code for explanation.

thanks,

Takashi

> ---
>  sound/x86/intel_hdmi_audio.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
> index 461b7d7..d9ce750 100644
> --- a/sound/x86/intel_hdmi_audio.c

> +++ b/sound/x86/intel_hdmi_audio.c
> @@ -1492,6 +1492,8 @@ static snd_pcm_uframes_t snd_intelhad_pcm_pointer(
>  {
>  	struct snd_intelhad *intelhaddata;
>  	u32 bytes_rendered = 0;
> +	u32 t;
> +	int buf_id;
>  
>  	/* pr_debug("snd_intelhad_pcm_pointer called\n"); */
>  
> @@ -1502,6 +1504,14 @@ static snd_pcm_uframes_t snd_intelhad_pcm_pointer(
>  		return SNDRV_PCM_POS_XRUN;
>  	}
>  
> +	buf_id = intelhaddata->curr_buf % 4;
> +	had_read_register(AUD_BUF_A_LENGTH + (buf_id * HAD_REG_WIDTH), &t);
> +	if (t == 0) {
> +		pr_debug("discovered buffer done for buf %d\n", buf_id);
> +		/* had_process_buffer_done(intelhaddata); */
> +	}
> +	t = intelhaddata->buf_info[buf_id].buf_size - t;
> +
>  	if (intelhaddata->stream_info.buffer_rendered)
>  		div_u64_rem(intelhaddata->stream_info.buffer_rendered,
>  			intelhaddata->stream_info.ring_buf_size,
> @@ -1509,7 +1519,7 @@ static snd_pcm_uframes_t snd_intelhad_pcm_pointer(
>  
>  	intelhaddata->stream_info.buffer_ptr = bytes_to_frames(
>  						substream->runtime,
> -						bytes_rendered);
> +						bytes_rendered + t);
>  	return intelhaddata->stream_info.buffer_ptr;
>  }
>  
> -- 
> 2.9.3
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx