Re: [PATCH 5/7] ALSA: x86: hdmi: Improve position reporting

From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, intel-gfx@lists.freedesktop.org,
	broonie@kernel.org, rakesh.a.ughreja@intel.com
Subject: Re: [PATCH 5/7] ALSA: x86: hdmi: Improve position reporting
Date: Wed, 14 Dec 2016 15:36:04 +0100	[thread overview]
Message-ID: <s5hy3zid1d7.wl-tiwai@suse.de> (raw)
In-Reply-To: <5d237318-61b3-fb22-be28-dfcc88554d20@linux.intel.com>

On Wed, 14 Dec 2016 15:09:20 +0100,
Pierre-Louis Bossart wrote:
> 
> On 12/14/16 6:57 AM, Takashi Iwai wrote:
> > On Mon, 12 Dec 2016 19:10:41 +0100,
> > Jerome Anand wrote:
> >>
> >> Use a hw register to calculate sub-period position reports.
> >> This makes PulseAudio happier.
> >>
> >> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
> >> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> >> Signed-off-by: Jerome Anand <jerome.anand@intel.com>
> >
> > There is no big merit to keep this a separate patch.
> > Please fold into the main patch.
> > You can put some comment in the code for explanation.
> 
> The reason we kept this patch and the next separate is purely
> procedural: they were contributed by Canonical in their Baytrail
> Compute Stick kernel, and we didn't want to squash this blindly,
> especially since David has gone silent.
> I don't mind folding this code into the Intel patches but I wasn't
> sure this was appropriate or even allowed.

Merging the code must be OK, that's the point of the original patch
having David's sign-off.  (If the code merge isn't allowed, how can we
work on the kernel tree at all? ;)
It'd be better, though, to mention about the merged code and his
sign-off portion in the commit log.

OTOH, I don't mind too much to split this out, either, if you find it
more comfortable.  But still it's better to put some comments in the
code itself, not only in the changelog.

thanks,

Takashi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx