From: "Hiremath, Vaibhav" <hvaibhav@ti.com> To: "Cousson, Benoit" <b-cousson@ti.com> Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "paul@pwsan.com" <paul@pwsan.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>, "N, Mugunthan V" <mugunthanvnm@ti.com>, Richard Cochran <richardcochran@gmail.com> Subject: RE: [PATCH 4/4] arm/dts: am33xx: Add CPSW and MDIO module nodes for AM33XX Date: Wed, 31 Oct 2012 19:52:13 +0000 [thread overview] Message-ID: <79CD15C6BA57404B839C016229A409A83EB56C41@DBDE01.ent.ti.com> (raw) In-Reply-To: <50914107.2090909@ti.com> On Wed, Oct 31, 2012 at 20:47:27, Cousson, Benoit wrote: > Hi, > > On 10/29/2012 09:21 AM, Vaibhav Hiremath wrote: > > From: Mugunthan V N <mugunthanvnm@ti.com> > > > > Add CPSW and MDIO related device tree data for AM33XX. > > Also enable them into board/evm dts files by providing > > respective phy-id. > > Is there any bindings documentation for that device? > Yes, the base DT binding documentation is present in file Documentation/devicetree/bindings/net/cpsw.txt > > Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com> > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> > > Cc: Richard Cochran <richardcochran@gmail.com> > > Cc: Benoit Cousson <b-cousson@ti.com> > > --- > > arch/arm/boot/dts/am335x-bone.dts | 8 ++++++ > > arch/arm/boot/dts/am335x-evm.dts | 8 ++++++ > > arch/arm/boot/dts/am33xx.dtsi | 50 +++++++++++++++++++++++++++++++++++++ > > 3 files changed, 66 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts > > index c634f87..e233cfa 100644 > > --- a/arch/arm/boot/dts/am335x-bone.dts > > +++ b/arch/arm/boot/dts/am335x-bone.dts > > @@ -78,3 +78,11 @@ > > }; > > }; > > }; > > + > > +&cpsw_emac0 { > > + phy_id = "4a101000.mdio:00"; > > Why are you using that kind of interface? You seem to want a reference > to a device. > > Cannot you have something less hard coded like: > phy_id = <&davinci_mdio>, <0>; > > > > +}; > > + > > +&cpsw_emac1 { > > + phy_id = "4a101000.mdio:01"; > > +}; > > diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts > > index 185d632..415c3b3 100644 > > --- a/arch/arm/boot/dts/am335x-evm.dts > > +++ b/arch/arm/boot/dts/am335x-evm.dts > > @@ -118,3 +118,11 @@ > > }; > > }; > > }; > > + > > +&cpsw_emac0 { > > + phy_id = "4a101000.mdio:00"; > > +}; > > + > > +&cpsw_emac1 { > > + phy_id = "4a101000.mdio:01"; > > +}; > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > > index bb31bff..f6bea04 100644 > > --- a/arch/arm/boot/dts/am33xx.dtsi > > +++ b/arch/arm/boot/dts/am33xx.dtsi > > @@ -210,5 +210,55 @@ > > interrupt-parent = <&intc>; > > interrupts = <91>; > > }; > > + > > + mac: ethernet@4A100000 { > > hexa data should be in lower case. > Oops. Will correct it. > > + compatible = "ti,cpsw"; > > + ti,hwmods = "cpgmac0"; > > + cpdma_channels = <8>; > > + host_port_no = <0>; > > + cpdma_reg_ofs = <0x800>; > > + cpdma_sram_ofs = <0xa00>; > > + ale_reg_ofs = <0xd00>; > > + ale_entries = <1024>; > > + host_port_reg_ofs = <0x108>; > > + hw_stats_reg_ofs = <0x900>; > > + bd_ram_ofs = <0x2000>; > > + bd_ram_size = <0x2000>; > > + no_bd_ram = <0>; > > + rx_descs = <64>; > > + mac_control = <0x20>; > > Do you have to store all these data in the DTS? Cannot it be in the driver? > > Do you expect to have several instance of the same IP with different > parameters here? > I will let Mugunthan respond to this. > > + slaves = <2>; > > + reg = <0x4a100000 0x800 > > + 0x4a101200 0x100 > > + 0x4a101000 0x100>; > > Please align the address. Ok. > > > + #address-cells = <1>; > > + #size-cells = <1>; > > + interrupt-parent = <&intc>; > > + /* c0_rx_thresh_pend c0_rx_pend c0_tx_pend c0_misc_pend*/ > > Please use a standard multi-line comment instead of trying to put > everything in one line. > Oops. Will correct it. > > + interrupts = <40 41 42 43>; > > + ranges; > > You should add blank line here for readability. > OK. > > + cpsw_emac0: slave@0 { > > Mmm, you are using some address later and here some relative number, > that does not looks very consistent. > > > + slave_reg_ofs = <0x208>; > > Is it an offset from 4a100000? Cannot you use the address for the slave > name? > > Something like that: cpsw_emac0: slave@4a100208 > > > + sliver_reg_ofs = <0xd80>; > > + /* Filled in by U-Boot */ > > + mac-address = [ 00 00 00 00 00 00 ]; > > + }; > > You should add blank line here for readability. > Ok Thanks, Vaibhav
WARNING: multiple messages have this Message-ID (diff)
From: hvaibhav@ti.com (Hiremath, Vaibhav) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/4] arm/dts: am33xx: Add CPSW and MDIO module nodes for AM33XX Date: Wed, 31 Oct 2012 19:52:13 +0000 [thread overview] Message-ID: <79CD15C6BA57404B839C016229A409A83EB56C41@DBDE01.ent.ti.com> (raw) In-Reply-To: <50914107.2090909@ti.com> On Wed, Oct 31, 2012 at 20:47:27, Cousson, Benoit wrote: > Hi, > > On 10/29/2012 09:21 AM, Vaibhav Hiremath wrote: > > From: Mugunthan V N <mugunthanvnm@ti.com> > > > > Add CPSW and MDIO related device tree data for AM33XX. > > Also enable them into board/evm dts files by providing > > respective phy-id. > > Is there any bindings documentation for that device? > Yes, the base DT binding documentation is present in file Documentation/devicetree/bindings/net/cpsw.txt > > Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com> > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> > > Cc: Richard Cochran <richardcochran@gmail.com> > > Cc: Benoit Cousson <b-cousson@ti.com> > > --- > > arch/arm/boot/dts/am335x-bone.dts | 8 ++++++ > > arch/arm/boot/dts/am335x-evm.dts | 8 ++++++ > > arch/arm/boot/dts/am33xx.dtsi | 50 +++++++++++++++++++++++++++++++++++++ > > 3 files changed, 66 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts > > index c634f87..e233cfa 100644 > > --- a/arch/arm/boot/dts/am335x-bone.dts > > +++ b/arch/arm/boot/dts/am335x-bone.dts > > @@ -78,3 +78,11 @@ > > }; > > }; > > }; > > + > > +&cpsw_emac0 { > > + phy_id = "4a101000.mdio:00"; > > Why are you using that kind of interface? You seem to want a reference > to a device. > > Cannot you have something less hard coded like: > phy_id = <&davinci_mdio>, <0>; > > > > +}; > > + > > +&cpsw_emac1 { > > + phy_id = "4a101000.mdio:01"; > > +}; > > diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts > > index 185d632..415c3b3 100644 > > --- a/arch/arm/boot/dts/am335x-evm.dts > > +++ b/arch/arm/boot/dts/am335x-evm.dts > > @@ -118,3 +118,11 @@ > > }; > > }; > > }; > > + > > +&cpsw_emac0 { > > + phy_id = "4a101000.mdio:00"; > > +}; > > + > > +&cpsw_emac1 { > > + phy_id = "4a101000.mdio:01"; > > +}; > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > > index bb31bff..f6bea04 100644 > > --- a/arch/arm/boot/dts/am33xx.dtsi > > +++ b/arch/arm/boot/dts/am33xx.dtsi > > @@ -210,5 +210,55 @@ > > interrupt-parent = <&intc>; > > interrupts = <91>; > > }; > > + > > + mac: ethernet at 4A100000 { > > hexa data should be in lower case. > Oops. Will correct it. > > + compatible = "ti,cpsw"; > > + ti,hwmods = "cpgmac0"; > > + cpdma_channels = <8>; > > + host_port_no = <0>; > > + cpdma_reg_ofs = <0x800>; > > + cpdma_sram_ofs = <0xa00>; > > + ale_reg_ofs = <0xd00>; > > + ale_entries = <1024>; > > + host_port_reg_ofs = <0x108>; > > + hw_stats_reg_ofs = <0x900>; > > + bd_ram_ofs = <0x2000>; > > + bd_ram_size = <0x2000>; > > + no_bd_ram = <0>; > > + rx_descs = <64>; > > + mac_control = <0x20>; > > Do you have to store all these data in the DTS? Cannot it be in the driver? > > Do you expect to have several instance of the same IP with different > parameters here? > I will let Mugunthan respond to this. > > + slaves = <2>; > > + reg = <0x4a100000 0x800 > > + 0x4a101200 0x100 > > + 0x4a101000 0x100>; > > Please align the address. Ok. > > > + #address-cells = <1>; > > + #size-cells = <1>; > > + interrupt-parent = <&intc>; > > + /* c0_rx_thresh_pend c0_rx_pend c0_tx_pend c0_misc_pend*/ > > Please use a standard multi-line comment instead of trying to put > everything in one line. > Oops. Will correct it. > > + interrupts = <40 41 42 43>; > > + ranges; > > You should add blank line here for readability. > OK. > > + cpsw_emac0: slave at 0 { > > Mmm, you are using some address later and here some relative number, > that does not looks very consistent. > > > + slave_reg_ofs = <0x208>; > > Is it an offset from 4a100000? Cannot you use the address for the slave > name? > > Something like that: cpsw_emac0: slave at 4a100208 > > > + sliver_reg_ofs = <0xd80>; > > + /* Filled in by U-Boot */ > > + mac-address = [ 00 00 00 00 00 00 ]; > > + }; > > You should add blank line here for readability. > Ok Thanks, Vaibhav
next prev parent reply other threads:[~2012-10-31 19:52 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-10-29 8:21 # (c) 2007, Joe Perches <joe@perches.com> Vaibhav Hiremath 2012-10-29 8:21 ` Vaibhav Hiremath 2012-10-29 8:21 ` Vaibhav Hiremath 2012-10-29 8:21 ` [PATCH-V2 0/4] ARM: AM33XX: net: Add DT support to CPGMAC and MDIO driver Vaibhav Hiremath 2012-10-29 8:21 ` Vaibhav Hiremath 2012-10-29 8:21 ` Vaibhav Hiremath 2012-10-29 8:33 ` Richard Cochran 2012-10-29 8:33 ` Richard Cochran 2012-10-29 8:21 ` [PATCH 1/4] net: davinci_mdio: Fix typo mistake in calling runtime-pm api Vaibhav Hiremath 2012-10-29 8:21 ` Vaibhav Hiremath 2012-10-29 8:21 ` Vaibhav Hiremath 2012-10-30 21:33 ` Peter Korsgaard 2012-10-30 21:33 ` Peter Korsgaard 2012-10-30 21:33 ` Peter Korsgaard 2012-10-29 8:21 ` [PATCH 2/4] net: cpsw: Add parent<->child relation support between cpsw and mdio Vaibhav Hiremath 2012-10-29 8:21 ` Vaibhav Hiremath 2012-10-29 8:21 ` Vaibhav Hiremath 2012-10-30 21:34 ` Peter Korsgaard 2012-10-30 21:34 ` Peter Korsgaard 2012-10-30 21:34 ` Peter Korsgaard 2012-10-29 8:21 ` [PATCH 3/4] ARM: OMAP3+: hwmod: Add AM33XX HWMOD data for davinci_mdio module Vaibhav Hiremath 2012-10-29 8:21 ` Vaibhav Hiremath 2012-10-29 8:21 ` Vaibhav Hiremath 2012-10-30 21:35 ` Peter Korsgaard 2012-10-30 21:35 ` Peter Korsgaard 2012-10-30 21:35 ` Peter Korsgaard 2012-10-29 8:21 ` [PATCH 4/4] arm/dts: am33xx: Add CPSW and MDIO module nodes for AM33XX Vaibhav Hiremath 2012-10-29 8:21 ` Vaibhav Hiremath 2012-10-29 8:21 ` Vaibhav Hiremath 2012-10-30 21:35 ` Peter Korsgaard 2012-10-30 21:35 ` Peter Korsgaard 2012-10-30 21:35 ` Peter Korsgaard 2012-10-31 15:17 ` Benoit Cousson 2012-10-31 15:17 ` Benoit Cousson 2012-10-31 15:17 ` Benoit Cousson 2012-10-31 19:52 ` Hiremath, Vaibhav [this message] 2012-10-31 19:52 ` Hiremath, Vaibhav 2012-11-01 7:45 ` Richard Cochran 2012-11-01 7:45 ` Richard Cochran 2012-11-01 9:28 ` Cousson, Benoit 2012-11-01 9:28 ` Cousson, Benoit 2012-11-01 9:28 ` Cousson, Benoit 2012-11-03 17:45 ` [PATCH RFC net-next 0/1] Simplify the CPSW DT Richard Cochran 2012-11-03 17:45 ` Richard Cochran 2012-11-03 17:45 ` Richard Cochran 2012-11-03 17:45 ` [PATCH RFC net-next 1/1] cpsw: simplify the setup of the register pointers Richard Cochran 2012-11-03 17:45 ` Richard Cochran 2012-11-03 17:45 ` Richard Cochran 2012-11-02 8:46 ` [PATCH 4/4] arm/dts: am33xx: Add CPSW and MDIO module nodes for AM33XX N, Mugunthan V 2012-11-02 8:46 ` N, Mugunthan V 2012-11-02 8:56 ` Richard Cochran 2012-11-02 8:56 ` Richard Cochran 2012-11-02 10:42 ` N, Mugunthan V 2012-11-02 10:42 ` N, Mugunthan V 2012-11-02 15:19 ` Richard Cochran 2012-11-02 15:19 ` Richard Cochran 2012-11-08 12:59 ` Mugunthan V N 2012-11-08 12:59 ` Mugunthan V N 2012-11-08 12:59 ` Mugunthan V N 2012-10-29 9:25 ` # (c) 2007, Joe Perches <joe@perches.com> Vaibhav Hiremath 2012-10-29 9:25 ` Vaibhav Hiremath 2012-10-29 9:25 ` Vaibhav Hiremath
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=79CD15C6BA57404B839C016229A409A83EB56C41@DBDE01.ent.ti.com \ --to=hvaibhav@ti.com \ --cc=b-cousson@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=mugunthanvnm@ti.com \ --cc=netdev@vger.kernel.org \ --cc=paul@pwsan.com \ --cc=richardcochran@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.