From: Peter Korsgaard <jacmet@sunsite.dk>
To: Vaibhav Hiremath <hvaibhav@ti.com>
Cc: <netdev@vger.kernel.org>, <paul@pwsan.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>, Mugunthan V N <mugunthanvnm@ti.com>,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH 1/4] net: davinci_mdio: Fix typo mistake in calling runtime-pm api
Date: Tue, 30 Oct 2012 22:33:53 +0100 [thread overview]
Message-ID: <877gq7hcfy.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1351498881-32482-3-git-send-email-hvaibhav@ti.com> (Vaibhav Hiremath's message of "Mon, 29 Oct 2012 13:51:18 +0530")
>>>>> "Vaibhav" == Vaibhav Hiremath <hvaibhav@ti.com> writes:
Vaibhav> By mistake (most likely a copy-paste), instead of pm_runtime_get_sync()
Vaibhav> api, driver is calling pm_runtime_put_sync() api in resume callback
Vaibhav> function. The bug was introduced by commit id (ae2c07aaf74:
Vaibhav> davinci_mdio: runtime PM support).
Vaibhav> Now, the reason why it didn't impact functionality is, the patch has
Vaibhav> been tested on AM335x-EVM and BeagleBone platform while submitting;
Vaibhav> and in case of AM335x the MDIO driver doesn't control the module
Vaibhav> enable/disable part, which is handled by CPSW driver.
Vaibhav> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
Vaibhav> Cc: Mugunthan V N <mugunthanvnm@ti.com>
Vaibhav> Cc: Richard Cochran <richardcochran@gmail.com>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
--
Bye, Peter Korsgaard
WARNING: multiple messages have this Message-ID (diff)
From: Peter Korsgaard <jacmet@sunsite.dk>
To: Vaibhav Hiremath <hvaibhav@ti.com>
Cc: netdev@vger.kernel.org, paul@pwsan.com,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
Mugunthan V N <mugunthanvnm@ti.com>,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH 1/4] net: davinci_mdio: Fix typo mistake in calling runtime-pm api
Date: Tue, 30 Oct 2012 22:33:53 +0100 [thread overview]
Message-ID: <877gq7hcfy.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1351498881-32482-3-git-send-email-hvaibhav@ti.com> (Vaibhav Hiremath's message of "Mon, 29 Oct 2012 13:51:18 +0530")
>>>>> "Vaibhav" == Vaibhav Hiremath <hvaibhav@ti.com> writes:
Vaibhav> By mistake (most likely a copy-paste), instead of pm_runtime_get_sync()
Vaibhav> api, driver is calling pm_runtime_put_sync() api in resume callback
Vaibhav> function. The bug was introduced by commit id (ae2c07aaf74:
Vaibhav> davinci_mdio: runtime PM support).
Vaibhav> Now, the reason why it didn't impact functionality is, the patch has
Vaibhav> been tested on AM335x-EVM and BeagleBone platform while submitting;
Vaibhav> and in case of AM335x the MDIO driver doesn't control the module
Vaibhav> enable/disable part, which is handled by CPSW driver.
Vaibhav> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
Vaibhav> Cc: Mugunthan V N <mugunthanvnm@ti.com>
Vaibhav> Cc: Richard Cochran <richardcochran@gmail.com>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
--
Bye, Peter Korsgaard
WARNING: multiple messages have this Message-ID (diff)
From: jacmet@sunsite.dk (Peter Korsgaard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] net: davinci_mdio: Fix typo mistake in calling runtime-pm api
Date: Tue, 30 Oct 2012 22:33:53 +0100 [thread overview]
Message-ID: <877gq7hcfy.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1351498881-32482-3-git-send-email-hvaibhav@ti.com> (Vaibhav Hiremath's message of "Mon, 29 Oct 2012 13:51:18 +0530")
>>>>> "Vaibhav" == Vaibhav Hiremath <hvaibhav@ti.com> writes:
Vaibhav> By mistake (most likely a copy-paste), instead of pm_runtime_get_sync()
Vaibhav> api, driver is calling pm_runtime_put_sync() api in resume callback
Vaibhav> function. The bug was introduced by commit id (ae2c07aaf74:
Vaibhav> davinci_mdio: runtime PM support).
Vaibhav> Now, the reason why it didn't impact functionality is, the patch has
Vaibhav> been tested on AM335x-EVM and BeagleBone platform while submitting;
Vaibhav> and in case of AM335x the MDIO driver doesn't control the module
Vaibhav> enable/disable part, which is handled by CPSW driver.
Vaibhav> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
Vaibhav> Cc: Mugunthan V N <mugunthanvnm@ti.com>
Vaibhav> Cc: Richard Cochran <richardcochran@gmail.com>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2012-10-30 21:34 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 8:21 # (c) 2007, Joe Perches <joe@perches.com> Vaibhav Hiremath
2012-10-29 8:21 ` Vaibhav Hiremath
2012-10-29 8:21 ` Vaibhav Hiremath
2012-10-29 8:21 ` [PATCH-V2 0/4] ARM: AM33XX: net: Add DT support to CPGMAC and MDIO driver Vaibhav Hiremath
2012-10-29 8:21 ` Vaibhav Hiremath
2012-10-29 8:21 ` Vaibhav Hiremath
2012-10-29 8:33 ` Richard Cochran
2012-10-29 8:33 ` Richard Cochran
2012-10-29 8:21 ` [PATCH 1/4] net: davinci_mdio: Fix typo mistake in calling runtime-pm api Vaibhav Hiremath
2012-10-29 8:21 ` Vaibhav Hiremath
2012-10-29 8:21 ` Vaibhav Hiremath
2012-10-30 21:33 ` Peter Korsgaard [this message]
2012-10-30 21:33 ` Peter Korsgaard
2012-10-30 21:33 ` Peter Korsgaard
2012-10-29 8:21 ` [PATCH 2/4] net: cpsw: Add parent<->child relation support between cpsw and mdio Vaibhav Hiremath
2012-10-29 8:21 ` Vaibhav Hiremath
2012-10-29 8:21 ` Vaibhav Hiremath
2012-10-30 21:34 ` Peter Korsgaard
2012-10-30 21:34 ` Peter Korsgaard
2012-10-30 21:34 ` Peter Korsgaard
2012-10-29 8:21 ` [PATCH 3/4] ARM: OMAP3+: hwmod: Add AM33XX HWMOD data for davinci_mdio module Vaibhav Hiremath
2012-10-29 8:21 ` Vaibhav Hiremath
2012-10-29 8:21 ` Vaibhav Hiremath
2012-10-30 21:35 ` Peter Korsgaard
2012-10-30 21:35 ` Peter Korsgaard
2012-10-30 21:35 ` Peter Korsgaard
2012-10-29 8:21 ` [PATCH 4/4] arm/dts: am33xx: Add CPSW and MDIO module nodes for AM33XX Vaibhav Hiremath
2012-10-29 8:21 ` Vaibhav Hiremath
2012-10-29 8:21 ` Vaibhav Hiremath
2012-10-30 21:35 ` Peter Korsgaard
2012-10-30 21:35 ` Peter Korsgaard
2012-10-30 21:35 ` Peter Korsgaard
2012-10-31 15:17 ` Benoit Cousson
2012-10-31 15:17 ` Benoit Cousson
2012-10-31 15:17 ` Benoit Cousson
2012-10-31 19:52 ` Hiremath, Vaibhav
2012-10-31 19:52 ` Hiremath, Vaibhav
2012-11-01 7:45 ` Richard Cochran
2012-11-01 7:45 ` Richard Cochran
2012-11-01 9:28 ` Cousson, Benoit
2012-11-01 9:28 ` Cousson, Benoit
2012-11-01 9:28 ` Cousson, Benoit
2012-11-03 17:45 ` [PATCH RFC net-next 0/1] Simplify the CPSW DT Richard Cochran
2012-11-03 17:45 ` Richard Cochran
2012-11-03 17:45 ` Richard Cochran
2012-11-03 17:45 ` [PATCH RFC net-next 1/1] cpsw: simplify the setup of the register pointers Richard Cochran
2012-11-03 17:45 ` Richard Cochran
2012-11-03 17:45 ` Richard Cochran
2012-11-02 8:46 ` [PATCH 4/4] arm/dts: am33xx: Add CPSW and MDIO module nodes for AM33XX N, Mugunthan V
2012-11-02 8:46 ` N, Mugunthan V
2012-11-02 8:56 ` Richard Cochran
2012-11-02 8:56 ` Richard Cochran
2012-11-02 10:42 ` N, Mugunthan V
2012-11-02 10:42 ` N, Mugunthan V
2012-11-02 15:19 ` Richard Cochran
2012-11-02 15:19 ` Richard Cochran
2012-11-08 12:59 ` Mugunthan V N
2012-11-08 12:59 ` Mugunthan V N
2012-11-08 12:59 ` Mugunthan V N
2012-10-29 9:25 ` # (c) 2007, Joe Perches <joe@perches.com> Vaibhav Hiremath
2012-10-29 9:25 ` Vaibhav Hiremath
2012-10-29 9:25 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gq7hcfy.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=hvaibhav@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.