From: Kevin Hilman <khilman@baylibre.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Carlo Caione <carlo@caione.org>,
"linux-mmc\@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"open list\:ARM\/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
"linux-arm-kernel\@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 00/13] mmc: meson-gx: driver fixups and upgrades
Date: Wed, 30 Aug 2017 12:03:43 -0700 [thread overview]
Message-ID: <7hr2vsdgj4.fsf@baylibre.com> (raw)
In-Reply-To: <CAPDyKFogy=L=BDKtMhKCN0nMLi-Yy5SHgAhB_=jog+CX91breA@mail.gmail.com> (Ulf Hansson's message of "Wed, 30 Aug 2017 15:13:57 +0200")
Hi Ulf,
Ulf Hansson <ulf.hansson@linaro.org> writes:
> On 28 August 2017 at 16:29, Jerome Brunet <jbrunet@baylibre.com> wrote:
>> The patchset features several bugfixes, rework and upgrade for the
>> meson-gx MMC driver.
>>
>> The main goal is to improve readability and enable new high speed
>> modes, such as eMMC DDR52 and sdcard UHS modes up to SDR50 (100Mhz)
>>
>> SDR104 is not working with a few cards on the p200 and the
>> libretech-cc. I suspect that 200Mhz might be a bit too fast for the PCB
>> of these boards, adding noise to the signal and eventually breaking
>> the communication with some cards. The same cards are working well on a
>> laptop or the nanopi-k2 at 200Mhz.
>>
>> This series has been tested on gxbb-p200, gxbb-nanopi-k2 and
>> gxl-s905x-libretech-cc
>>
>> Changes since v2 [1]:
>> * Drop patches 1 to 3: Applied.
>> * Drop patch 4: Debug stuff which should not have been sent.
>> * Added fix to previous patch 3:
>> If the clock register is not initialized before registering the clk
>> with CCF, the framework will complain about an illegal divider value.
>> This had gone unnoticed because it was later fixed by the clock init
>> rework.
>>
>> Ulf, I know it is getting late but it would be nice if patch #1 of
>> this v3 could go with 3 patches you already applied. The rest can
>> wait for the following cycle.
>
> I decided to pick them all, so applied for next!
>
Just to double-check, so I can plan for the DT patches
accordingly... you are queuing this for v4.14, right?
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Carlo Caione <carlo@caione.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 00/13] mmc: meson-gx: driver fixups and upgrades
Date: Wed, 30 Aug 2017 12:03:43 -0700 [thread overview]
Message-ID: <7hr2vsdgj4.fsf@baylibre.com> (raw)
In-Reply-To: <CAPDyKFogy=L=BDKtMhKCN0nMLi-Yy5SHgAhB_=jog+CX91breA@mail.gmail.com> (Ulf Hansson's message of "Wed, 30 Aug 2017 15:13:57 +0200")
Hi Ulf,
Ulf Hansson <ulf.hansson@linaro.org> writes:
> On 28 August 2017 at 16:29, Jerome Brunet <jbrunet@baylibre.com> wrote:
>> The patchset features several bugfixes, rework and upgrade for the
>> meson-gx MMC driver.
>>
>> The main goal is to improve readability and enable new high speed
>> modes, such as eMMC DDR52 and sdcard UHS modes up to SDR50 (100Mhz)
>>
>> SDR104 is not working with a few cards on the p200 and the
>> libretech-cc. I suspect that 200Mhz might be a bit too fast for the PCB
>> of these boards, adding noise to the signal and eventually breaking
>> the communication with some cards. The same cards are working well on a
>> laptop or the nanopi-k2 at 200Mhz.
>>
>> This series has been tested on gxbb-p200, gxbb-nanopi-k2 and
>> gxl-s905x-libretech-cc
>>
>> Changes since v2 [1]:
>> * Drop patches 1 to 3: Applied.
>> * Drop patch 4: Debug stuff which should not have been sent.
>> * Added fix to previous patch 3:
>> If the clock register is not initialized before registering the clk
>> with CCF, the framework will complain about an illegal divider value.
>> This had gone unnoticed because it was later fixed by the clock init
>> rework.
>>
>> Ulf, I know it is getting late but it would be nice if patch #1 of
>> this v3 could go with 3 patches you already applied. The rest can
>> wait for the following cycle.
>
> I decided to pick them all, so applied for next!
>
Just to double-check, so I can plan for the DT patches
accordingly... you are queuing this for v4.14, right?
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 00/13] mmc: meson-gx: driver fixups and upgrades
Date: Wed, 30 Aug 2017 12:03:43 -0700 [thread overview]
Message-ID: <7hr2vsdgj4.fsf@baylibre.com> (raw)
In-Reply-To: <CAPDyKFogy=L=BDKtMhKCN0nMLi-Yy5SHgAhB_=jog+CX91breA@mail.gmail.com> (Ulf Hansson's message of "Wed, 30 Aug 2017 15:13:57 +0200")
Hi Ulf,
Ulf Hansson <ulf.hansson@linaro.org> writes:
> On 28 August 2017 at 16:29, Jerome Brunet <jbrunet@baylibre.com> wrote:
>> The patchset features several bugfixes, rework and upgrade for the
>> meson-gx MMC driver.
>>
>> The main goal is to improve readability and enable new high speed
>> modes, such as eMMC DDR52 and sdcard UHS modes up to SDR50 (100Mhz)
>>
>> SDR104 is not working with a few cards on the p200 and the
>> libretech-cc. I suspect that 200Mhz might be a bit too fast for the PCB
>> of these boards, adding noise to the signal and eventually breaking
>> the communication with some cards. The same cards are working well on a
>> laptop or the nanopi-k2 at 200Mhz.
>>
>> This series has been tested on gxbb-p200, gxbb-nanopi-k2 and
>> gxl-s905x-libretech-cc
>>
>> Changes since v2 [1]:
>> * Drop patches 1 to 3: Applied.
>> * Drop patch 4: Debug stuff which should not have been sent.
>> * Added fix to previous patch 3:
>> If the clock register is not initialized before registering the clk
>> with CCF, the framework will complain about an illegal divider value.
>> This had gone unnoticed because it was later fixed by the clock init
>> rework.
>>
>> Ulf, I know it is getting late but it would be nice if patch #1 of
>> this v3 could go with 3 patches you already applied. The rest can
>> wait for the following cycle.
>
> I decided to pick them all, so applied for next!
>
Just to double-check, so I can plan for the DT patches
accordingly... you are queuing this for v4.14, right?
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v3 00/13] mmc: meson-gx: driver fixups and upgrades
Date: Wed, 30 Aug 2017 12:03:43 -0700 [thread overview]
Message-ID: <7hr2vsdgj4.fsf@baylibre.com> (raw)
In-Reply-To: <CAPDyKFogy=L=BDKtMhKCN0nMLi-Yy5SHgAhB_=jog+CX91breA@mail.gmail.com> (Ulf Hansson's message of "Wed, 30 Aug 2017 15:13:57 +0200")
Hi Ulf,
Ulf Hansson <ulf.hansson@linaro.org> writes:
> On 28 August 2017 at 16:29, Jerome Brunet <jbrunet@baylibre.com> wrote:
>> The patchset features several bugfixes, rework and upgrade for the
>> meson-gx MMC driver.
>>
>> The main goal is to improve readability and enable new high speed
>> modes, such as eMMC DDR52 and sdcard UHS modes up to SDR50 (100Mhz)
>>
>> SDR104 is not working with a few cards on the p200 and the
>> libretech-cc. I suspect that 200Mhz might be a bit too fast for the PCB
>> of these boards, adding noise to the signal and eventually breaking
>> the communication with some cards. The same cards are working well on a
>> laptop or the nanopi-k2 at 200Mhz.
>>
>> This series has been tested on gxbb-p200, gxbb-nanopi-k2 and
>> gxl-s905x-libretech-cc
>>
>> Changes since v2 [1]:
>> * Drop patches 1 to 3: Applied.
>> * Drop patch 4: Debug stuff which should not have been sent.
>> * Added fix to previous patch 3:
>> If the clock register is not initialized before registering the clk
>> with CCF, the framework will complain about an illegal divider value.
>> This had gone unnoticed because it was later fixed by the clock init
>> rework.
>>
>> Ulf, I know it is getting late but it would be nice if patch #1 of
>> this v3 could go with 3 patches you already applied. The rest can
>> wait for the following cycle.
>
> I decided to pick them all, so applied for next!
>
Just to double-check, so I can plan for the DT patches
accordingly... you are queuing this for v4.14, right?
Kevin
next prev parent reply other threads:[~2017-08-30 19:03 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 14:29 [PATCH v3 00/13] mmc: meson-gx: driver fixups and upgrades Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` [PATCH v3 01/13] mmc: meson-gx: initialize sane clk default before clock register Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` [PATCH v3 02/13] mmc: meson-gx: cfg init overwrite values Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` [PATCH v3 03/13] mmc: meson-gx: rework set_ios function Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` [PATCH v3 04/13] mmc: meson-gx: rework clk_set function Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` [PATCH v3 05/13] mmc: meson-gx: rework clock init function Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` [PATCH v3 06/13] mmc: meson-gx: fix dual data rate mode frequencies Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` [PATCH v3 07/13] mmc: meson-gx: work around clk-stop issue Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` [PATCH v3 08/13] mmc: meson-gx: simplify interrupt handler Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` [PATCH v3 09/13] mmc: meson-gx: implement card_busy callback Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` [PATCH v3 10/13] mmc: meson-gx: use CCF to handle the clock phases Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` [PATCH v3 11/13] mmc: meson-gx: implement voltage switch callback Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` [PATCH v3 12/13] mmc: meson-gx: change default tx phase Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` [PATCH v3 13/13] mmc: meson-gx: rework tuning function Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-28 14:29 ` Jerome Brunet
2017-08-30 13:13 ` [PATCH v3 00/13] mmc: meson-gx: driver fixups and upgrades Ulf Hansson
2017-08-30 13:13 ` Ulf Hansson
2017-08-30 13:13 ` Ulf Hansson
2017-08-30 13:13 ` Ulf Hansson
2017-08-30 19:03 ` Kevin Hilman [this message]
2017-08-30 19:03 ` Kevin Hilman
2017-08-30 19:03 ` Kevin Hilman
2017-08-30 19:03 ` Kevin Hilman
2017-08-31 10:46 ` Ulf Hansson
2017-08-31 10:46 ` Ulf Hansson
2017-08-31 10:46 ` Ulf Hansson
2017-08-31 10:46 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hr2vsdgj4.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=carlo@caione.org \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.