All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 01/10] omap: Use separate init_irq functions to avoid cpu_is_omap tests early
Date: Mon, 27 Jun 2011 10:08:48 -0700	[thread overview]
Message-ID: <87fwmvcicf.fsf@ti.com> (raw)
In-Reply-To: <20110620092327.357.92354.stgit@kaulin> (Tony Lindgren's message of "Mon, 20 Jun 2011 02:23:28 -0700")

Tony Lindgren <tony@atomide.com> writes:

> This allows us to remove cpu_is_omap calls from init_irq functions.
> There should not be any need for cpu_is_omap calls as at this point.
> During the timer init we only care about SoC generation, and not about
> subrevisions.
>
> The main reason for the patch is that we want to initialize only
> minimal omap specific code from the init_early call.
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> Reviewed-by: Kevin Hilman <khilman@ti.com>
> ---
>  arch/arm/mach-omap1/board-ams-delta.c      |    2 +-
>  arch/arm/mach-omap1/board-fsample.c        |    2 +-
>  arch/arm/mach-omap1/board-generic.c        |    2 +-
>  arch/arm/mach-omap1/board-h2.c             |    2 +-
>  arch/arm/mach-omap1/board-h3.c             |    2 +-
>  arch/arm/mach-omap1/board-htcherald.c      |    2 +-
>  arch/arm/mach-omap1/board-innovator.c      |    2 +-
>  arch/arm/mach-omap1/board-nokia770.c       |    2 +-
>  arch/arm/mach-omap1/board-osk.c            |    2 +-
>  arch/arm/mach-omap1/board-palmte.c         |    2 +-
>  arch/arm/mach-omap1/board-palmtt.c         |    2 +-
>  arch/arm/mach-omap1/board-palmz71.c        |    2 +-
>  arch/arm/mach-omap1/board-perseus2.c       |    2 +-
>  arch/arm/mach-omap1/board-sx1.c            |    2 +-
>  arch/arm/mach-omap1/board-voiceblue.c      |    2 +-
>  arch/arm/mach-omap1/irq.c                  |    2 +-
>  arch/arm/mach-omap2/board-2430sdp.c        |    2 +-
>  arch/arm/mach-omap2/board-3430sdp.c        |    2 +-
>  arch/arm/mach-omap2/board-3630sdp.c        |    2 +-
>  arch/arm/mach-omap2/board-am3517crane.c    |    2 +-
>  arch/arm/mach-omap2/board-am3517evm.c      |    2 +-
>  arch/arm/mach-omap2/board-apollon.c        |    2 +-
>  arch/arm/mach-omap2/board-cm-t35.c         |    2 +-

Note this board has another machine_desc added in devel-board which
doesn't have the changes necessary for this.

When using devel-timer + devel-board, this is also needed to compile, so
devel-timer should probably be rebased on devel-board (or vice versa.)

Kevin

diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c
index 43dda76..b5d0d77 100644
--- a/arch/arm/mach-omap2/board-cm-t35.c
+++ b/arch/arm/mach-omap2/board-cm-t35.c
@@ -687,7 +687,7 @@ MACHINE_START(CM_T3730, "Compulab CM-T3730")
 	.reserve        = omap_reserve,
 	.map_io         = omap3_map_io,
 	.init_early     = cm_t35_init_early,
-	.init_irq       = omap_init_irq,
+	.init_irq       = omap3_init_irq,
 	.init_machine   = cm_t3730_init,
-	.timer          = &omap_timer,
+	.timer          = &omap3_timer,
 MACHINE_END

WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/10] omap: Use separate init_irq functions to avoid cpu_is_omap tests early
Date: Mon, 27 Jun 2011 10:08:48 -0700	[thread overview]
Message-ID: <87fwmvcicf.fsf@ti.com> (raw)
In-Reply-To: <20110620092327.357.92354.stgit@kaulin> (Tony Lindgren's message of "Mon, 20 Jun 2011 02:23:28 -0700")

Tony Lindgren <tony@atomide.com> writes:

> This allows us to remove cpu_is_omap calls from init_irq functions.
> There should not be any need for cpu_is_omap calls as at this point.
> During the timer init we only care about SoC generation, and not about
> subrevisions.
>
> The main reason for the patch is that we want to initialize only
> minimal omap specific code from the init_early call.
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> Reviewed-by: Kevin Hilman <khilman@ti.com>
> ---
>  arch/arm/mach-omap1/board-ams-delta.c      |    2 +-
>  arch/arm/mach-omap1/board-fsample.c        |    2 +-
>  arch/arm/mach-omap1/board-generic.c        |    2 +-
>  arch/arm/mach-omap1/board-h2.c             |    2 +-
>  arch/arm/mach-omap1/board-h3.c             |    2 +-
>  arch/arm/mach-omap1/board-htcherald.c      |    2 +-
>  arch/arm/mach-omap1/board-innovator.c      |    2 +-
>  arch/arm/mach-omap1/board-nokia770.c       |    2 +-
>  arch/arm/mach-omap1/board-osk.c            |    2 +-
>  arch/arm/mach-omap1/board-palmte.c         |    2 +-
>  arch/arm/mach-omap1/board-palmtt.c         |    2 +-
>  arch/arm/mach-omap1/board-palmz71.c        |    2 +-
>  arch/arm/mach-omap1/board-perseus2.c       |    2 +-
>  arch/arm/mach-omap1/board-sx1.c            |    2 +-
>  arch/arm/mach-omap1/board-voiceblue.c      |    2 +-
>  arch/arm/mach-omap1/irq.c                  |    2 +-
>  arch/arm/mach-omap2/board-2430sdp.c        |    2 +-
>  arch/arm/mach-omap2/board-3430sdp.c        |    2 +-
>  arch/arm/mach-omap2/board-3630sdp.c        |    2 +-
>  arch/arm/mach-omap2/board-am3517crane.c    |    2 +-
>  arch/arm/mach-omap2/board-am3517evm.c      |    2 +-
>  arch/arm/mach-omap2/board-apollon.c        |    2 +-
>  arch/arm/mach-omap2/board-cm-t35.c         |    2 +-

Note this board has another machine_desc added in devel-board which
doesn't have the changes necessary for this.

When using devel-timer + devel-board, this is also needed to compile, so
devel-timer should probably be rebased on devel-board (or vice versa.)

Kevin

diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c
index 43dda76..b5d0d77 100644
--- a/arch/arm/mach-omap2/board-cm-t35.c
+++ b/arch/arm/mach-omap2/board-cm-t35.c
@@ -687,7 +687,7 @@ MACHINE_START(CM_T3730, "Compulab CM-T3730")
 	.reserve        = omap_reserve,
 	.map_io         = omap3_map_io,
 	.init_early     = cm_t35_init_early,
-	.init_irq       = omap_init_irq,
+	.init_irq       = omap3_init_irq,
 	.init_machine   = cm_t3730_init,
-	.timer          = &omap_timer,
+	.timer          = &omap3_timer,
 MACHINE_END

  parent reply	other threads:[~2011-06-27 17:08 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-20  9:23 [PATCH 00/10] init_early cleanup for omap init_irq and init_timer Tony Lindgren
2011-06-20  9:23 ` Tony Lindgren
2011-06-20  9:23 ` [PATCH 01/10] omap: Use separate init_irq functions to avoid cpu_is_omap tests early Tony Lindgren
2011-06-20  9:23   ` Tony Lindgren
2011-06-20  9:54   ` Russell King - ARM Linux
2011-06-20  9:54     ` Russell King - ARM Linux
2011-06-20 10:14     ` Tony Lindgren
2011-06-20 10:14       ` Tony Lindgren
2011-06-27 17:08   ` Kevin Hilman [this message]
2011-06-27 17:08     ` Kevin Hilman
2011-06-20  9:23 ` [PATCH 02/10] omap: Set separate timer init functions to avoid cpu_is_omap tests Tony Lindgren
2011-06-20  9:23   ` Tony Lindgren
2011-06-20  9:23 ` [PATCH 03/10] omap: Move dmtimer defines to dmtimer.h Tony Lindgren
2011-06-20  9:23   ` Tony Lindgren
2011-06-20  9:56   ` Russell King - ARM Linux
2011-06-20  9:56     ` Russell King - ARM Linux
2011-06-20 10:17     ` Tony Lindgren
2011-06-20 10:17       ` Tony Lindgren
2011-06-20  9:23 ` [PATCH 04/10] omap: Make a subset of dmtimer functions into inline functions Tony Lindgren
2011-06-20  9:23   ` Tony Lindgren
2011-06-20  9:23 ` [PATCH 05/10] omap2+: Use dmtimer macros for clockevent Tony Lindgren
2011-06-20  9:23   ` Tony Lindgren
2011-06-23 17:07   ` Kevin Hilman
2011-06-23 17:07     ` Kevin Hilman
2011-06-27  7:39     ` Tony Lindgren
2011-06-27  7:39       ` Tony Lindgren
2011-06-20  9:23 ` [PATCH 06/10] omap2+: Remove gptimer_wakeup for now Tony Lindgren
2011-06-20  9:23   ` Tony Lindgren
2011-06-20  9:39   ` Santosh Shilimkar
2011-06-20  9:39     ` Santosh Shilimkar
2011-06-20  9:48     ` Tony Lindgren
2011-06-20  9:48       ` Tony Lindgren
2011-06-23 15:05       ` Kevin Hilman
2011-06-23 15:05         ` Kevin Hilman
2011-06-23 15:13         ` Santosh Shilimkar
2011-06-23 15:13           ` Santosh Shilimkar
2011-06-27  8:08           ` Tony Lindgren
2011-06-27  8:08             ` Tony Lindgren
2011-06-27 16:30             ` Kevin Hilman
2011-06-27 16:30               ` Kevin Hilman
2011-06-27 18:16               ` Tony Lindgren
2011-06-27 18:16                 ` Tony Lindgren
2011-06-27 17:32   ` Kevin Hilman
2011-06-27 17:32     ` Kevin Hilman
2011-06-27 19:19     ` Tony Lindgren
2011-06-27 19:19       ` Tony Lindgren
2011-06-27 21:16       ` Kevin Hilman
2011-06-27 21:16         ` Kevin Hilman
2011-06-20  9:23 ` [PATCH 07/10] omap2+: Reserve clocksource and timesource and initialize dmtimer later Tony Lindgren
2011-06-20  9:23   ` Tony Lindgren
2011-06-23 17:01   ` Kevin Hilman
2011-06-23 17:01     ` Kevin Hilman
2011-06-27  7:48     ` Tony Lindgren
2011-06-27  7:48       ` Tony Lindgren
2011-06-27 16:41       ` Kevin Hilman
2011-06-27 16:41         ` Kevin Hilman
2011-06-23 17:13   ` Kevin Hilman
2011-06-23 17:13     ` Kevin Hilman
2011-06-27  7:51     ` Tony Lindgren
2011-06-27  7:51       ` Tony Lindgren
2011-06-27 10:44       ` Tony Lindgren
2011-06-27 10:44         ` Tony Lindgren
2011-06-20  9:23 ` [PATCH 08/10] omap2+: Use dmtimer macros for clocksource Tony Lindgren
2011-06-20  9:23   ` Tony Lindgren
2011-06-23 15:28   ` Kevin Hilman
2011-06-23 15:28     ` Kevin Hilman
2011-06-23 16:47     ` Kevin Hilman
2011-06-23 16:47       ` Kevin Hilman
2011-06-23 17:10   ` Kevin Hilman
2011-06-23 17:10     ` Kevin Hilman
2011-06-27  7:54     ` Tony Lindgren
2011-06-27  7:54       ` Tony Lindgren
2011-06-27 10:48       ` Tony Lindgren
2011-06-27 10:48         ` Tony Lindgren
2011-06-27 16:41         ` Kevin Hilman
2011-06-27 16:41           ` Kevin Hilman
2011-06-20  9:23 ` [PATCH 09/10] omap2+: Remove omap2_gp_clockevent_set_gptimer Tony Lindgren
2011-06-20  9:23   ` Tony Lindgren
2011-06-20  9:23 ` [PATCH 10/10] omap2+: Rename timer-gp.c into timer.c to combine timer init functions Tony Lindgren
2011-06-20  9:23   ` Tony Lindgren
  -- strict thread matches above, loose matches on Subject: below --
2011-03-28 22:21 [PATCH 00/10] omap init_early changes for irq and timer init Tony Lindgren
2011-03-28 22:21 ` [PATCH 01/10] omap: Use separate init_irq functions to avoid cpu_is_omap tests early Tony Lindgren
2011-03-28 22:21   ` Tony Lindgren
2011-03-29 17:11   ` Kevin Hilman
2011-03-29 17:11     ` Kevin Hilman
2011-03-29 17:14     ` Tony Lindgren
2011-03-29 17:14       ` Tony Lindgren
2011-05-17 11:28       ` Tony Lindgren
2011-05-17 11:28         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fwmvcicf.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.