From: Kevin Hilman <khilman@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 06/10] omap2+: Remove gptimer_wakeup for now
Date: Mon, 27 Jun 2011 09:30:08 -0700 [thread overview]
Message-ID: <87hb7bdypb.fsf@ti.com> (raw)
In-Reply-To: <20110627080804.GG23145@atomide.com> (Tony Lindgren's message of "Mon, 27 Jun 2011 01:08:05 -0700")
Tony Lindgren <tony@atomide.com> writes:
> * Santosh Shilimkar <santosh.shilimkar@ti.com> [110623 08:09]:
>> On 6/23/2011 8:35 PM, Kevin Hilman wrote:
>> >Tony Lindgren<tony@atomide.com> writes:
>> >
>> >So now, the only thing OMAP-specific is the debugfs file used to trigger
>> >it.
>> >
>> >>Maybe Kevin can just carry it along in the PM branch for now?
>> >
>> >I'd prefer to keep it in mainline as this is a very important feature
>> >for the PM functionality already in mainline.
>> >
>> I agree with Kevin and that's what have been saying from begining when
>> we decided to drop this feature. The new patch from Kevin is already
>> doing this in more generic way than that was before.
>
> To me Kevin's later patch makes more sense, but still has few issues:
>
> - It keeps the dependency between PM debug code and sys_timer code.
> That's yet another artificial blocker for making PM code a loadable
> module. We really don't want to export anything from the sys_timer code.
>
> - The interface for programming a wake-up timer should be Linux generic,
> not omap specific.
>
> Further, it's a CONFIG_PM_DEBUG patch. So that code should not be
> in the mainline kernel.
Huh?
Please clarify why PM debug code shouldn't be in mainline?
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/10] omap2+: Remove gptimer_wakeup for now
Date: Mon, 27 Jun 2011 09:30:08 -0700 [thread overview]
Message-ID: <87hb7bdypb.fsf@ti.com> (raw)
In-Reply-To: <20110627080804.GG23145@atomide.com> (Tony Lindgren's message of "Mon, 27 Jun 2011 01:08:05 -0700")
Tony Lindgren <tony@atomide.com> writes:
> * Santosh Shilimkar <santosh.shilimkar@ti.com> [110623 08:09]:
>> On 6/23/2011 8:35 PM, Kevin Hilman wrote:
>> >Tony Lindgren<tony@atomide.com> writes:
>> >
>> >So now, the only thing OMAP-specific is the debugfs file used to trigger
>> >it.
>> >
>> >>Maybe Kevin can just carry it along in the PM branch for now?
>> >
>> >I'd prefer to keep it in mainline as this is a very important feature
>> >for the PM functionality already in mainline.
>> >
>> I agree with Kevin and that's what have been saying from begining when
>> we decided to drop this feature. The new patch from Kevin is already
>> doing this in more generic way than that was before.
>
> To me Kevin's later patch makes more sense, but still has few issues:
>
> - It keeps the dependency between PM debug code and sys_timer code.
> That's yet another artificial blocker for making PM code a loadable
> module. We really don't want to export anything from the sys_timer code.
>
> - The interface for programming a wake-up timer should be Linux generic,
> not omap specific.
>
> Further, it's a CONFIG_PM_DEBUG patch. So that code should not be
> in the mainline kernel.
Huh?
Please clarify why PM debug code shouldn't be in mainline?
Kevin
next prev parent reply other threads:[~2011-06-27 16:30 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 9:23 [PATCH 00/10] init_early cleanup for omap init_irq and init_timer Tony Lindgren
2011-06-20 9:23 ` Tony Lindgren
2011-06-20 9:23 ` [PATCH 01/10] omap: Use separate init_irq functions to avoid cpu_is_omap tests early Tony Lindgren
2011-06-20 9:23 ` Tony Lindgren
2011-06-20 9:54 ` Russell King - ARM Linux
2011-06-20 9:54 ` Russell King - ARM Linux
2011-06-20 10:14 ` Tony Lindgren
2011-06-20 10:14 ` Tony Lindgren
2011-06-27 17:08 ` Kevin Hilman
2011-06-27 17:08 ` Kevin Hilman
2011-06-20 9:23 ` [PATCH 02/10] omap: Set separate timer init functions to avoid cpu_is_omap tests Tony Lindgren
2011-06-20 9:23 ` Tony Lindgren
2011-06-20 9:23 ` [PATCH 03/10] omap: Move dmtimer defines to dmtimer.h Tony Lindgren
2011-06-20 9:23 ` Tony Lindgren
2011-06-20 9:56 ` Russell King - ARM Linux
2011-06-20 9:56 ` Russell King - ARM Linux
2011-06-20 10:17 ` Tony Lindgren
2011-06-20 10:17 ` Tony Lindgren
2011-06-20 9:23 ` [PATCH 04/10] omap: Make a subset of dmtimer functions into inline functions Tony Lindgren
2011-06-20 9:23 ` Tony Lindgren
2011-06-20 9:23 ` [PATCH 05/10] omap2+: Use dmtimer macros for clockevent Tony Lindgren
2011-06-20 9:23 ` Tony Lindgren
2011-06-23 17:07 ` Kevin Hilman
2011-06-23 17:07 ` Kevin Hilman
2011-06-27 7:39 ` Tony Lindgren
2011-06-27 7:39 ` Tony Lindgren
2011-06-20 9:23 ` [PATCH 06/10] omap2+: Remove gptimer_wakeup for now Tony Lindgren
2011-06-20 9:23 ` Tony Lindgren
2011-06-20 9:39 ` Santosh Shilimkar
2011-06-20 9:39 ` Santosh Shilimkar
2011-06-20 9:48 ` Tony Lindgren
2011-06-20 9:48 ` Tony Lindgren
2011-06-23 15:05 ` Kevin Hilman
2011-06-23 15:05 ` Kevin Hilman
2011-06-23 15:13 ` Santosh Shilimkar
2011-06-23 15:13 ` Santosh Shilimkar
2011-06-27 8:08 ` Tony Lindgren
2011-06-27 8:08 ` Tony Lindgren
2011-06-27 16:30 ` Kevin Hilman [this message]
2011-06-27 16:30 ` Kevin Hilman
2011-06-27 18:16 ` Tony Lindgren
2011-06-27 18:16 ` Tony Lindgren
2011-06-27 17:32 ` Kevin Hilman
2011-06-27 17:32 ` Kevin Hilman
2011-06-27 19:19 ` Tony Lindgren
2011-06-27 19:19 ` Tony Lindgren
2011-06-27 21:16 ` Kevin Hilman
2011-06-27 21:16 ` Kevin Hilman
2011-06-20 9:23 ` [PATCH 07/10] omap2+: Reserve clocksource and timesource and initialize dmtimer later Tony Lindgren
2011-06-20 9:23 ` Tony Lindgren
2011-06-23 17:01 ` Kevin Hilman
2011-06-23 17:01 ` Kevin Hilman
2011-06-27 7:48 ` Tony Lindgren
2011-06-27 7:48 ` Tony Lindgren
2011-06-27 16:41 ` Kevin Hilman
2011-06-27 16:41 ` Kevin Hilman
2011-06-23 17:13 ` Kevin Hilman
2011-06-23 17:13 ` Kevin Hilman
2011-06-27 7:51 ` Tony Lindgren
2011-06-27 7:51 ` Tony Lindgren
2011-06-27 10:44 ` Tony Lindgren
2011-06-27 10:44 ` Tony Lindgren
2011-06-20 9:23 ` [PATCH 08/10] omap2+: Use dmtimer macros for clocksource Tony Lindgren
2011-06-20 9:23 ` Tony Lindgren
2011-06-23 15:28 ` Kevin Hilman
2011-06-23 15:28 ` Kevin Hilman
2011-06-23 16:47 ` Kevin Hilman
2011-06-23 16:47 ` Kevin Hilman
2011-06-23 17:10 ` Kevin Hilman
2011-06-23 17:10 ` Kevin Hilman
2011-06-27 7:54 ` Tony Lindgren
2011-06-27 7:54 ` Tony Lindgren
2011-06-27 10:48 ` Tony Lindgren
2011-06-27 10:48 ` Tony Lindgren
2011-06-27 16:41 ` Kevin Hilman
2011-06-27 16:41 ` Kevin Hilman
2011-06-20 9:23 ` [PATCH 09/10] omap2+: Remove omap2_gp_clockevent_set_gptimer Tony Lindgren
2011-06-20 9:23 ` Tony Lindgren
2011-06-20 9:23 ` [PATCH 10/10] omap2+: Rename timer-gp.c into timer.c to combine timer init functions Tony Lindgren
2011-06-20 9:23 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hb7bdypb.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.