From: Thomas Gleixner <tglx@linutronix.de> To: David Woodhouse <dwmw2@infradead.org>, x86@kernel.org Cc: iommu <iommu@lists.linux-foundation.org>, kvm <kvm@vger.kernel.org>, linux-hyperv@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com> Subject: Re: [PATCH 07/13] irqdomain: Add max_affinity argument to irq_domain_alloc_descs() Date: Tue, 06 Oct 2020 23:26:22 +0200 [thread overview] Message-ID: <87lfgj59mp.fsf@nanos.tec.linutronix.de> (raw) In-Reply-To: <20201005152856.974112-7-dwmw2@infradead.org> On Mon, Oct 05 2020 at 16:28, David Woodhouse wrote: > From: David Woodhouse <dwmw@amazon.co.uk> > > This is the maximum possible set of CPUs which can be used. Use it > to calculate the default affinity requested from __irq_alloc_descs() > by first attempting to find the intersection with irq_default_affinity, > or falling back to using just the max_affinity if the intersection > would be empty. And why do we need that as yet another argument? This is an optional property of the irq domain, really and no caller has any business with that. > int irq_domain_alloc_descs(int virq, unsigned int cnt, irq_hw_number_t hwirq, > - int node, const struct irq_affinity_desc *affinity) > + int node, const struct irq_affinity_desc *affinity, > + const struct cpumask *max_affinity) > { > + cpumask_var_t default_affinity; > unsigned int hint; > + int i; > + > + /* Check requested per-IRQ affinities are in the possible range */ > + if (affinity && max_affinity) { > + for (i = 0; i < cnt; i++) > + if (!cpumask_subset(&affinity[i].mask, max_affinity)) > + return -EINVAL; https://lore.kernel.org/r/alpine.DEB.2.20.1701171956290.3645@nanos What is preventing the affinity spreading code from spreading the masks out to unusable CPUs? The changelog is silent about that part. > + /* > + * Generate default affinity. Either the possible subset of > + * irq_default_affinity if such a subset is non-empty, or fall > + * back to the provided max_affinity if there is no intersection. .. > + * And just a copy of irq_default_affinity in the > + * !CONFIG_CPUMASK_OFFSTACK case. We know that already... > + */ > + memset(&default_affinity, 0, sizeof(default_affinity)); Right, memset() before allocating is useful. > + if ((max_affinity && > + !cpumask_subset(irq_default_affinity, max_affinity))) { > + if (!alloc_cpumask_var(&default_affinity, GFP_KERNEL)) > + return -ENOMEM; > + cpumask_and(default_affinity, max_affinity, > + irq_default_affinity); > + if (cpumask_empty(default_affinity)) > + cpumask_copy(default_affinity, max_affinity); > + } else if (cpumask_available(default_affinity)) > + cpumask_copy(default_affinity, irq_default_affinity); That's garbage and unreadable. Thanks, tglx
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de> To: David Woodhouse <dwmw2@infradead.org>, x86@kernel.org Cc: Paolo Bonzini <pbonzini@redhat.com>, iommu <iommu@lists.linux-foundation.org>, linux-hyperv@vger.kernel.org, kvm <kvm@vger.kernel.org> Subject: Re: [PATCH 07/13] irqdomain: Add max_affinity argument to irq_domain_alloc_descs() Date: Tue, 06 Oct 2020 23:26:22 +0200 [thread overview] Message-ID: <87lfgj59mp.fsf@nanos.tec.linutronix.de> (raw) In-Reply-To: <20201005152856.974112-7-dwmw2@infradead.org> On Mon, Oct 05 2020 at 16:28, David Woodhouse wrote: > From: David Woodhouse <dwmw@amazon.co.uk> > > This is the maximum possible set of CPUs which can be used. Use it > to calculate the default affinity requested from __irq_alloc_descs() > by first attempting to find the intersection with irq_default_affinity, > or falling back to using just the max_affinity if the intersection > would be empty. And why do we need that as yet another argument? This is an optional property of the irq domain, really and no caller has any business with that. > int irq_domain_alloc_descs(int virq, unsigned int cnt, irq_hw_number_t hwirq, > - int node, const struct irq_affinity_desc *affinity) > + int node, const struct irq_affinity_desc *affinity, > + const struct cpumask *max_affinity) > { > + cpumask_var_t default_affinity; > unsigned int hint; > + int i; > + > + /* Check requested per-IRQ affinities are in the possible range */ > + if (affinity && max_affinity) { > + for (i = 0; i < cnt; i++) > + if (!cpumask_subset(&affinity[i].mask, max_affinity)) > + return -EINVAL; https://lore.kernel.org/r/alpine.DEB.2.20.1701171956290.3645@nanos What is preventing the affinity spreading code from spreading the masks out to unusable CPUs? The changelog is silent about that part. > + /* > + * Generate default affinity. Either the possible subset of > + * irq_default_affinity if such a subset is non-empty, or fall > + * back to the provided max_affinity if there is no intersection. .. > + * And just a copy of irq_default_affinity in the > + * !CONFIG_CPUMASK_OFFSTACK case. We know that already... > + */ > + memset(&default_affinity, 0, sizeof(default_affinity)); Right, memset() before allocating is useful. > + if ((max_affinity && > + !cpumask_subset(irq_default_affinity, max_affinity))) { > + if (!alloc_cpumask_var(&default_affinity, GFP_KERNEL)) > + return -ENOMEM; > + cpumask_and(default_affinity, max_affinity, > + irq_default_affinity); > + if (cpumask_empty(default_affinity)) > + cpumask_copy(default_affinity, max_affinity); > + } else if (cpumask_available(default_affinity)) > + cpumask_copy(default_affinity, irq_default_affinity); That's garbage and unreadable. Thanks, tglx _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-10-06 21:26 UTC|newest] Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-05 15:28 [PATCH 0/13] Fix per-domain IRQ affinity, allow >255 CPUs on x86 without IRQ remapping David Woodhouse 2020-10-05 15:28 ` David Woodhouse 2020-10-05 15:28 ` [PATCH 01/13] x86/apic: Use x2apic in guest kernels even with unusable CPUs David Woodhouse 2020-10-05 15:28 ` David Woodhouse 2020-10-05 15:28 ` [PATCH 02/13] x86/msi: Only use high bits of MSI address for DMAR unit David Woodhouse 2020-10-05 15:28 ` David Woodhouse 2020-10-06 20:45 ` Thomas Gleixner 2020-10-06 20:45 ` Thomas Gleixner 2020-10-05 15:28 ` [PATCH 03/13] x86/ioapic: Handle Extended Destination ID field in RTE David Woodhouse 2020-10-05 15:28 ` David Woodhouse 2020-10-05 15:28 ` [PATCH 04/13] x86/apic: Support 15 bits of APIC ID in IOAPIC/MSI where available David Woodhouse 2020-10-05 15:28 ` David Woodhouse 2020-10-05 15:28 ` [PATCH 05/13] genirq: Prepare for default affinity to be passed to __irq_alloc_descs() David Woodhouse 2020-10-05 15:28 ` David Woodhouse 2020-10-06 21:01 ` Thomas Gleixner 2020-10-06 21:01 ` Thomas Gleixner 2020-10-06 21:07 ` David Woodhouse 2020-10-06 21:07 ` David Woodhouse 2020-10-05 15:28 ` [PATCH 06/13] genirq: Add default_affinity argument " David Woodhouse 2020-10-05 15:28 ` David Woodhouse 2020-10-06 21:06 ` Thomas Gleixner 2020-10-06 21:06 ` Thomas Gleixner 2020-10-05 15:28 ` [PATCH 07/13] irqdomain: Add max_affinity argument to irq_domain_alloc_descs() David Woodhouse 2020-10-05 15:28 ` David Woodhouse 2020-10-06 21:26 ` Thomas Gleixner [this message] 2020-10-06 21:26 ` Thomas Gleixner 2020-10-07 7:19 ` David Woodhouse 2020-10-07 7:19 ` David Woodhouse 2020-10-07 13:37 ` Thomas Gleixner 2020-10-07 13:37 ` Thomas Gleixner 2020-10-07 14:10 ` David Woodhouse 2020-10-07 14:10 ` David Woodhouse 2020-10-07 15:57 ` Thomas Gleixner 2020-10-07 15:57 ` Thomas Gleixner 2020-10-07 16:11 ` David Woodhouse 2020-10-07 16:11 ` David Woodhouse 2020-10-07 20:53 ` Thomas Gleixner 2020-10-07 20:53 ` Thomas Gleixner 2020-10-08 7:21 ` David Woodhouse 2020-10-08 7:21 ` David Woodhouse 2020-10-08 9:34 ` Thomas Gleixner 2020-10-08 9:34 ` Thomas Gleixner 2020-10-08 11:10 ` David Woodhouse 2020-10-08 11:10 ` David Woodhouse 2020-10-08 12:40 ` Thomas Gleixner 2020-10-08 12:40 ` Thomas Gleixner 2020-10-09 7:54 ` David Woodhouse 2020-10-09 7:54 ` David Woodhouse 2020-10-05 15:28 ` [PATCH 08/13] genirq: Add irq_domain_set_affinity() David Woodhouse 2020-10-05 15:28 ` David Woodhouse 2020-10-06 21:32 ` Thomas Gleixner 2020-10-06 21:32 ` Thomas Gleixner 2020-10-07 7:22 ` David Woodhouse 2020-10-07 7:22 ` David Woodhouse 2020-10-05 15:28 ` [PATCH 09/13] x86/irq: Add x86_non_ir_cpumask David Woodhouse 2020-10-05 15:28 ` David Woodhouse 2020-10-06 21:42 ` Thomas Gleixner 2020-10-06 21:42 ` Thomas Gleixner 2020-10-07 7:25 ` David Woodhouse 2020-10-07 7:25 ` David Woodhouse 2020-10-05 15:28 ` [PATCH 10/13] x86/irq: Limit IOAPIC and MSI domains' affinity without IR David Woodhouse 2020-10-05 15:28 ` David Woodhouse 2020-10-06 21:54 ` Thomas Gleixner 2020-10-06 21:54 ` Thomas Gleixner 2020-10-07 7:48 ` David Woodhouse 2020-10-07 7:48 ` David Woodhouse 2020-10-07 12:59 ` Thomas Gleixner 2020-10-07 12:59 ` Thomas Gleixner 2020-10-07 13:08 ` David Woodhouse 2020-10-07 13:08 ` David Woodhouse 2020-10-07 14:05 ` Thomas Gleixner 2020-10-07 14:05 ` Thomas Gleixner 2020-10-07 14:23 ` David Woodhouse 2020-10-07 14:23 ` David Woodhouse 2020-10-07 16:02 ` Thomas Gleixner 2020-10-07 16:02 ` Thomas Gleixner 2020-10-07 16:15 ` David Woodhouse 2020-10-07 16:15 ` David Woodhouse 2020-10-07 15:05 ` David Woodhouse 2020-10-07 15:05 ` David Woodhouse 2020-10-07 15:25 ` Thomas Gleixner 2020-10-07 15:25 ` Thomas Gleixner 2020-10-07 15:46 ` David Woodhouse 2020-10-07 15:46 ` David Woodhouse 2020-10-07 17:23 ` Thomas Gleixner 2020-10-07 17:23 ` Thomas Gleixner 2020-10-07 17:34 ` David Woodhouse 2020-10-07 17:34 ` David Woodhouse 2020-10-05 15:28 ` [PATCH 11/13] x86/smp: Allow more than 255 CPUs even without interrupt remapping David Woodhouse 2020-10-05 15:28 ` David Woodhouse 2020-10-05 15:28 ` [PATCH 12/13] iommu/irq_remapping: Kill most of hyperv-iommu.c now it's redundant David Woodhouse 2020-10-05 15:28 ` David Woodhouse 2020-10-05 15:28 ` [PATCH 13/13] x86/kvm: Add KVM_FEATURE_MSI_EXT_DEST_ID David Woodhouse 2020-10-05 15:28 ` David Woodhouse 2020-10-07 8:14 ` Paolo Bonzini 2020-10-07 8:14 ` Paolo Bonzini 2020-10-07 8:59 ` David Woodhouse 2020-10-07 8:59 ` David Woodhouse 2020-10-07 11:15 ` Paolo Bonzini 2020-10-07 11:15 ` Paolo Bonzini 2020-10-07 12:04 ` David Woodhouse 2020-10-07 12:04 ` David Woodhouse
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87lfgj59mp.fsf@nanos.tec.linutronix.de \ --to=tglx@linutronix.de \ --cc=dwmw2@infradead.org \ --cc=iommu@lists.linux-foundation.org \ --cc=kvm@vger.kernel.org \ --cc=linux-hyperv@vger.kernel.org \ --cc=pbonzini@redhat.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.