From: Joe Perches <joe@perches.com> To: Nick Desaulniers <ndesaulniers@google.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Andrey Ryabinin <aryabinin@virtuozzo.com>, akataria@vmware.com, boris.ostrovsky@oracle.com, brijesh.singh@amd.com, Cao jin <caoj.fnst@cn.fujitsu.com>, Greg KH <gregkh@linuxfoundation.org>, hpa@zytor.com, "J. Kiszka" <jan.kiszka@siemens.com>, jarkko.sakkinen@linux.intel.com, jgross@suse.com, Josh Poimboeuf <jpoimboe@redhat.com>, kirill.shutemov@linux.intel.com, mingo@redhat.com, mjg59@google.com, Matthias Kaehlcke <mka@chromium.org>, Philippe Ombredanne <pombredanne@nexb.com>, rostedt@goodmis.org, Thomas Gleixner <tglx@linutronix.de>, thomas.lendacky@amd.com, Thiebaud Weksteen <tweek@google.com>, linux-efi@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, x86@kernel.org, virtualization@lists.linux-foundation.org, Alistair Strachan <astrachan@google.com>, Manoj Gupta <manojgupta@google.com>, Greg Hackmann <ghackmann@google.com>, sedat.dilek@gmail.com, tstellar@redhat.com, Kees Cook <keescook@google.com>, Masahiro Yamada <yamada.masahiro@socionext.com>, Michal Marek <michal.lkml@markovi.net>, Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>, geert@linux-m68k.org, Will Deacon <will.deacon@arm.com>, mawilcox@microsoft.com, Arnd Bergmann <arnd@arndb.de>, David Rientjes <rientjes@google.com> Subject: Re: [PATCH v2 1/2] compiler-gcc.h: add gnu_inline to all inline declarations Date: Tue, 05 Jun 2018 14:59:25 -0700 [thread overview] Message-ID: <91704f8e949fd48869e1b36b959780cf19e96d44.camel@perches.com> (raw) In-Reply-To: <CAKwvOd=zuy0BJC3f3EKT_9Mg83qdZxAxw_RJ4okAMKrpKjJRHQ@mail.gmail.com> On Tue, 2018-06-05 at 12:50 -0700, Nick Desaulniers wrote: > On Tue, Jun 5, 2018 at 12:14 PM Joe Perches <joe@perches.com> wrote: > > > > On Tue, 2018-06-05 at 10:23 -0700, Joe Perches wrote: > > > Perhaps these are simpler as > > > > > > #define __inline__ inline > > > #define __inline inline > > > > Currently, there are these uses of inline variants in the kernel > > > > $ git grep -w inline | wc -l > > 68410 > > $ git grep -w __inline__ | wc -l > > 503 > > $ git grep -w __inline | wc -l > > 57 > > > > So it seems it's also reasonable to sed all uses of __inline to inline > > and perhaps remove __inline eventually altogether. > > (perhaps there are still too many __inline__ uses) > > Yeah, that sounds good. Should I split that into 3 patches: > > > Excluding scripts and a few other files, > > here's a possible patch done with: > > > > $ git grep -w --name-only __inline | \ > > grep -vP '^(?:arch/alpha/|include/|scripts/)' | \ > > xargs sed -r -i -e 's/\b__inline\b/inline/g' \ > > -e 's/\binline\s+static\b/static inline/g' > > --- > > Documentation/trace/tracepoint-analysis.rst | 2 +- > > drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 4 ++-- > > drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- > > drivers/staging/rtl8723bs/include/drv_types.h | 6 +++--- > > drivers/staging/rtl8723bs/include/ieee80211.h | 6 +++--- > > drivers/staging/rtl8723bs/include/osdep_service.h | 10 +++++----- > > drivers/staging/rtl8723bs/include/osdep_service_linux.h | 14 +++++++------- > > drivers/staging/rtl8723bs/include/rtw_mlme.h | 14 +++++++------- > > drivers/staging/rtl8723bs/include/rtw_recv.h | 16 ++++++++-------- > > drivers/staging/rtl8723bs/include/sta_info.h | 2 +- > > drivers/staging/rtl8723bs/include/wifi.h | 14 +++++++------- > > drivers/staging/rtl8723bs/include/wlan_bssdef.h | 2 +- > > lib/zstd/mem.h | 2 +- > > 13 files changed, 47 insertions(+), 47 deletions(-) > > > 1 for documentation, 1 for rtl8723bs, 1 for zstd? Seems sensible to me. > Follow up set or include in v3? Your choice. Probably a follow up would work best. Also, the remaining __inline uses would be: arch/alpha/include/asm/compiler.h:#undef __inline include/linux/compiler-gcc.h:#define __inline __inline __attribute__((always_inline,unused)) notrace include/linux/compiler-gcc.h:#define __inline __inline __attribute__((unused)) notrace scripts/checkpatch.pl:our $Inline = qr{inline|__always_inline|noinline|__inline|__inline__}; scripts/checkpatch.pl:# Check for __inline__ and __inline, prefer inline scripts/checkpatch.pl: $line =~ /\b(__inline__|__inline)\b/) { scripts/checkpatch.pl: $fixed[$fixlinenr] =~ s/\b(__inline__|__inline)\b/inline/; scripts/genksyms/keywords.c: { "__inline", INLINE_KEYW }, scripts/kernel-doc: $prototype =~ s/^__inline +//; So all of these could be removed/updated appropriately too
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com> To: Nick Desaulniers <ndesaulniers@google.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Andrey Ryabinin <aryabinin@virtuozzo.com>, akataria@vmware.com, boris.ostrovsky@oracle.com, brijesh.singh@amd.com, Cao jin <caoj.fnst@cn.fujitsu.com>, Greg KH <gregkh@linuxfoundation.org>, hpa@zytor.com, "J. Kiszka" <jan.kiszka@siemens.com>, jarkko.sakkinen@linux.intel.com, jgross@suse.com, Josh Poimboeuf <jpoimboe@redhat.com>, kirill.shutemov@linux.intel.com, mingo@redhat.com, mjg59@google.com, Matthias Kaehlcke <mka@chromium.org>, Philippe Ombredanne <pombredanne@nexb.com>, rostedt@goodmis.org, Thomas Gleixner <tglx@linutronix.de>, thomas.lendacky@amd.com, Thiebaud Weksteen <tweek@google.com>, linux-efi@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, x86@kernel.org, virtua Subject: Re: [PATCH v2 1/2] compiler-gcc.h: add gnu_inline to all inline declarations Date: Tue, 05 Jun 2018 14:59:25 -0700 [thread overview] Message-ID: <91704f8e949fd48869e1b36b959780cf19e96d44.camel@perches.com> (raw) In-Reply-To: <CAKwvOd=zuy0BJC3f3EKT_9Mg83qdZxAxw_RJ4okAMKrpKjJRHQ@mail.gmail.com> On Tue, 2018-06-05 at 12:50 -0700, Nick Desaulniers wrote: > On Tue, Jun 5, 2018 at 12:14 PM Joe Perches <joe@perches.com> wrote: > > > > On Tue, 2018-06-05 at 10:23 -0700, Joe Perches wrote: > > > Perhaps these are simpler as > > > > > > #define __inline__ inline > > > #define __inline inline > > > > Currently, there are these uses of inline variants in the kernel > > > > $ git grep -w inline | wc -l > > 68410 > > $ git grep -w __inline__ | wc -l > > 503 > > $ git grep -w __inline | wc -l > > 57 > > > > So it seems it's also reasonable to sed all uses of __inline to inline > > and perhaps remove __inline eventually altogether. > > (perhaps there are still too many __inline__ uses) > > Yeah, that sounds good. Should I split that into 3 patches: > > > Excluding scripts and a few other files, > > here's a possible patch done with: > > > > $ git grep -w --name-only __inline | \ > > grep -vP '^(?:arch/alpha/|include/|scripts/)' | \ > > xargs sed -r -i -e 's/\b__inline\b/inline/g' \ > > -e 's/\binline\s+static\b/static inline/g' > > --- > > Documentation/trace/tracepoint-analysis.rst | 2 +- > > drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 4 ++-- > > drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- > > drivers/staging/rtl8723bs/include/drv_types.h | 6 +++--- > > drivers/staging/rtl8723bs/include/ieee80211.h | 6 +++--- > > drivers/staging/rtl8723bs/include/osdep_service.h | 10 +++++----- > > drivers/staging/rtl8723bs/include/osdep_service_linux.h | 14 +++++++------- > > drivers/staging/rtl8723bs/include/rtw_mlme.h | 14 +++++++------- > > drivers/staging/rtl8723bs/include/rtw_recv.h | 16 ++++++++-------- > > drivers/staging/rtl8723bs/include/sta_info.h | 2 +- > > drivers/staging/rtl8723bs/include/wifi.h | 14 +++++++------- > > drivers/staging/rtl8723bs/include/wlan_bssdef.h | 2 +- > > lib/zstd/mem.h | 2 +- > > 13 files changed, 47 insertions(+), 47 deletions(-) > > > 1 for documentation, 1 for rtl8723bs, 1 for zstd? Seems sensible to me. > Follow up set or include in v3? Your choice. Probably a follow up would work best. Also, the remaining __inline uses would be: arch/alpha/include/asm/compiler.h:#undef __inline include/linux/compiler-gcc.h:#define __inline __inline __attribute__((always_inline,unused)) notrace include/linux/compiler-gcc.h:#define __inline __inline __attribute__((unused)) notrace scripts/checkpatch.pl:our $Inline = qr{inline|__always_inline|noinline|__inline|__inline__}; scripts/checkpatch.pl:# Check for __inline__ and __inline, prefer inline scripts/checkpatch.pl: $line =~ /\b(__inline__|__inline)\b/) { scripts/checkpatch.pl: $fixed[$fixlinenr] =~ s/\b(__inline__|__inline)\b/inline/; scripts/genksyms/keywords.c: { "__inline", INLINE_KEYW }, scripts/kernel-doc: $prototype =~ s/^__inline +//; So all of these could be removed/updated appropriately too
next prev parent reply other threads:[~2018-06-05 21:59 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-05 17:05 [PATCH v2 0/2] extern inline native_save_fl for paravirt Nick Desaulniers 2018-06-05 17:05 ` [PATCH v2 1/2] compiler-gcc.h: add gnu_inline to all inline declarations Nick Desaulniers 2018-06-05 17:23 ` Joe Perches 2018-06-05 17:55 ` Nick Desaulniers 2018-06-05 17:55 ` Nick Desaulniers 2018-06-05 19:13 ` Joe Perches 2018-06-05 19:50 ` Nick Desaulniers 2018-06-05 19:50 ` Nick Desaulniers 2018-06-05 21:59 ` Joe Perches 2018-06-05 21:59 ` Joe Perches [this message] 2018-06-05 21:59 ` Joe Perches 2018-06-06 8:05 ` Sedat Dilek 2018-06-06 8:05 ` Sedat Dilek 2018-06-06 16:39 ` hpa 2018-06-06 16:39 ` hpa 2018-06-06 16:39 ` hpa 2018-06-08 14:34 ` Sedat Dilek 2018-06-08 14:34 ` Sedat Dilek 2018-06-05 19:13 ` Joe Perches 2018-06-07 17:26 ` Nick Desaulniers 2018-06-07 17:26 ` Nick Desaulniers 2018-06-07 17:29 ` Nick Desaulniers 2018-06-07 17:29 ` Nick Desaulniers 2018-06-07 18:31 ` Joe Perches 2018-06-07 18:31 ` Joe Perches 2018-06-07 18:51 ` Nick Desaulniers 2018-06-07 18:51 ` Nick Desaulniers 2018-06-07 18:31 ` Joe Perches 2018-06-07 17:33 ` Nick Desaulniers 2018-06-07 17:33 ` Nick Desaulniers 2018-06-05 17:23 ` Joe Perches 2018-06-05 17:05 ` [PATCH v2 2/2] x86: paravirt: make native_save_fl extern inline Nick Desaulniers 2018-06-05 17:28 ` H. Peter Anvin 2018-06-05 17:28 ` H. Peter Anvin 2018-06-05 17:28 ` H. Peter Anvin 2018-06-05 17:28 ` H. Peter Anvin 2018-06-05 17:31 ` H. Peter Anvin 2018-06-05 17:31 ` H. Peter Anvin 2018-06-05 17:31 ` H. Peter Anvin 2018-06-05 17:31 ` H. Peter Anvin 2018-06-05 17:46 ` Sedat Dilek 2018-06-05 17:46 ` Sedat Dilek 2018-06-05 17:52 ` Nick Desaulniers 2018-06-05 17:52 ` Nick Desaulniers 2018-06-05 18:06 ` H. Peter Anvin 2018-06-05 18:06 ` H. Peter Anvin 2018-06-05 21:28 ` Arnd Bergmann 2018-06-05 21:28 ` Arnd Bergmann 2018-06-05 21:31 ` Arnd Bergmann 2018-06-05 21:31 ` Arnd Bergmann 2018-06-05 21:51 ` Nick Desaulniers 2018-06-05 21:51 ` Nick Desaulniers 2018-06-05 21:31 ` Arnd Bergmann 2018-06-05 21:28 ` Arnd Bergmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=91704f8e949fd48869e1b36b959780cf19e96d44.camel@perches.com \ --to=joe@perches.com \ --cc=akataria@vmware.com \ --cc=akpm@linux-foundation.org \ --cc=ard.biesheuvel@linaro.org \ --cc=arnd@arndb.de \ --cc=aryabinin@virtuozzo.com \ --cc=astrachan@google.com \ --cc=boris.ostrovsky@oracle.com \ --cc=brijesh.singh@amd.com \ --cc=caoj.fnst@cn.fujitsu.com \ --cc=geert@linux-m68k.org \ --cc=ghackmann@google.com \ --cc=gregkh@linuxfoundation.org \ --cc=hpa@zytor.com \ --cc=jan.kiszka@siemens.com \ --cc=jarkko.sakkinen@linux.intel.com \ --cc=jgross@suse.com \ --cc=jpoimboe@redhat.com \ --cc=keescook@google.com \ --cc=kirill.shutemov@linux.intel.com \ --cc=linux-efi@vger.kernel.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=manojgupta@google.com \ --cc=mawilcox@microsoft.com \ --cc=michal.lkml@markovi.net \ --cc=mingo@redhat.com \ --cc=mjg59@google.com \ --cc=mka@chromium.org \ --cc=ndesaulniers@google.com \ --cc=pombredanne@nexb.com \ --cc=rientjes@google.com \ --cc=rostedt@goodmis.org \ --cc=sedat.dilek@gmail.com \ --cc=tglx@linutronix.de \ --cc=thomas.lendacky@amd.com \ --cc=tstellar@redhat.com \ --cc=tweek@google.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=will.deacon@arm.com \ --cc=x86@kernel.org \ --cc=yamada.masahiro@socionext.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.