From: "H. Peter Anvin" <hpa@zytor.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
akataria@vmware.com, boris.ostrovsky@oracle.com,
brijesh.singh@amd.com, Cao jin <caoj.fnst@cn.fujitsu.com>,
Greg KH <gregkh@linuxfoundation.org>,
"J. Kiszka" <jan.kiszka@siemens.com>,
jarkko.sakkinen@linux.intel.com, jgross@suse.com,
Josh Poimboeuf <jpoimboe@redhat.com>,
kirill.shutemov@linux.intel.com, mingo@redhat.com,
mjg59@google.com, Matthias Kaehlcke <mka@chromium.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
rostedt@goodmis.org, Thomas Gleixner <tglx@linutronix.de>,
thomas.lendacky@amd.com, Thiebaud Weksteen <tweek@google.com>,
linux-efi@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, virtualization@lists.linux-foundation.org,
Alistair Strachan <astrachan@google.com>,
Manoj Gupta <manojgupta@google.com>,
Greg Hackmann <ghackmann@google.com>,
sedat.dilek@gmail.com, tstellar@redhat.com,
Kees Cook <keescook@google.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
geert@linux-m68k.org, Will Deacon <will.deacon@arm.com>,
mawilcox@microsoft.com, Arnd Bergmann <arnd@arndb.de>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH v2 2/2] x86: paravirt: make native_save_fl extern inline
Date: Tue, 5 Jun 2018 11:06:22 -0700 [thread overview]
Message-ID: <a40b7e04-8d7c-b26f-4cb9-457bf0fd4a6a@zytor.com> (raw)
In-Reply-To: <CAKwvOdk0v4gY04_pbMeUT7Ly5oRHetKorQXnjp_UVBabK74Ekw@mail.gmail.com>
On 06/05/18 10:52, Nick Desaulniers wrote:
>
> Does the kernel have a different calling convention for 32b x86? How
> does that work? regparm=3? Does that need to be added to the
> declaration?
>
Yes, -mregparm=3. No, doesn't need to be added to the declaration.
>> Something like this added to <asm/asm.h> might be useful; then you can
>> simply:
>>
>> push %_ASM_ARG1
>>
>> Version with fixed typo...
>
> Oh, nice, thanks! I'll pick this up and add it to my patch set for v3
> (or did you want me to review/sign-off now?) I can pick up Sedat's
> suggestion.
>
Add it to your patchset and add your own signoff underneath mine.
-hpa
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: linux-efi@vger.kernel.org, brijesh.singh@amd.com,
boris.ostrovsky@oracle.com, "J. Kiszka" <jan.kiszka@siemens.com>,
Will Deacon <will.deacon@arm.com>,
jarkko.sakkinen@linux.intel.com,
virtualization@lists.linux-foundation.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Manoj Gupta <manojgupta@google.com>,
akataria@vmware.com, Thiebaud Weksteen <tweek@google.com>,
mawilcox@microsoft.com, x86@kernel.org,
Greg Hackmann <ghackmann@google.com>,
Matthias Kaehlcke <mka@chromium.org>,
geert@linux-m68k.org, David Rientjes <rientjes@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
thomas.lendacky@amd.com, Arnd Bergmann <arnd@arndb.de>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Kees Cook <keescook@google.com>,
rostedt@goodmis.org, Cao jin <caoj.fnst@cn.fujitsu.com>,
Michal Marek <michal.lkml@markovi.net>,
Josh Poimboeuf <jpoimboe@redhat.com>,
sedat.di
Subject: Re: [PATCH v2 2/2] x86: paravirt: make native_save_fl extern inline
Date: Tue, 5 Jun 2018 11:06:22 -0700 [thread overview]
Message-ID: <a40b7e04-8d7c-b26f-4cb9-457bf0fd4a6a@zytor.com> (raw)
In-Reply-To: <CAKwvOdk0v4gY04_pbMeUT7Ly5oRHetKorQXnjp_UVBabK74Ekw@mail.gmail.com>
On 06/05/18 10:52, Nick Desaulniers wrote:
>
> Does the kernel have a different calling convention for 32b x86? How
> does that work? regparm=3? Does that need to be added to the
> declaration?
>
Yes, -mregparm=3. No, doesn't need to be added to the declaration.
>> Something like this added to <asm/asm.h> might be useful; then you can
>> simply:
>>
>> push %_ASM_ARG1
>>
>> Version with fixed typo...
>
> Oh, nice, thanks! I'll pick this up and add it to my patch set for v3
> (or did you want me to review/sign-off now?) I can pick up Sedat's
> suggestion.
>
Add it to your patchset and add your own signoff underneath mine.
-hpa
next prev parent reply other threads:[~2018-06-05 18:08 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 17:05 [PATCH v2 0/2] extern inline native_save_fl for paravirt Nick Desaulniers
2018-06-05 17:05 ` [PATCH v2 1/2] compiler-gcc.h: add gnu_inline to all inline declarations Nick Desaulniers
2018-06-05 17:23 ` Joe Perches
2018-06-05 17:55 ` Nick Desaulniers
2018-06-05 17:55 ` Nick Desaulniers
2018-06-05 19:13 ` Joe Perches
2018-06-05 19:50 ` Nick Desaulniers
2018-06-05 19:50 ` Nick Desaulniers
2018-06-05 21:59 ` Joe Perches
2018-06-05 21:59 ` Joe Perches
2018-06-05 21:59 ` Joe Perches
2018-06-06 8:05 ` Sedat Dilek
2018-06-06 8:05 ` Sedat Dilek
2018-06-06 16:39 ` hpa
2018-06-06 16:39 ` hpa
2018-06-06 16:39 ` hpa
2018-06-08 14:34 ` Sedat Dilek
2018-06-08 14:34 ` Sedat Dilek
2018-06-05 19:13 ` Joe Perches
2018-06-07 17:26 ` Nick Desaulniers
2018-06-07 17:26 ` Nick Desaulniers
2018-06-07 17:29 ` Nick Desaulniers
2018-06-07 17:29 ` Nick Desaulniers
2018-06-07 18:31 ` Joe Perches
2018-06-07 18:31 ` Joe Perches
2018-06-07 18:51 ` Nick Desaulniers
2018-06-07 18:51 ` Nick Desaulniers
2018-06-07 18:31 ` Joe Perches
2018-06-07 17:33 ` Nick Desaulniers
2018-06-07 17:33 ` Nick Desaulniers
2018-06-05 17:23 ` Joe Perches
2018-06-05 17:05 ` [PATCH v2 2/2] x86: paravirt: make native_save_fl extern inline Nick Desaulniers
2018-06-05 17:28 ` H. Peter Anvin
2018-06-05 17:28 ` H. Peter Anvin
2018-06-05 17:28 ` H. Peter Anvin
2018-06-05 17:28 ` H. Peter Anvin
2018-06-05 17:31 ` H. Peter Anvin
2018-06-05 17:31 ` H. Peter Anvin
2018-06-05 17:31 ` H. Peter Anvin
2018-06-05 17:31 ` H. Peter Anvin
2018-06-05 17:46 ` Sedat Dilek
2018-06-05 17:46 ` Sedat Dilek
2018-06-05 17:52 ` Nick Desaulniers
2018-06-05 17:52 ` Nick Desaulniers
2018-06-05 18:06 ` H. Peter Anvin [this message]
2018-06-05 18:06 ` H. Peter Anvin
2018-06-05 21:28 ` Arnd Bergmann
2018-06-05 21:28 ` Arnd Bergmann
2018-06-05 21:31 ` Arnd Bergmann
2018-06-05 21:31 ` Arnd Bergmann
2018-06-05 21:51 ` Nick Desaulniers
2018-06-05 21:51 ` Nick Desaulniers
2018-06-05 21:31 ` Arnd Bergmann
2018-06-05 21:28 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a40b7e04-8d7c-b26f-4cb9-457bf0fd4a6a@zytor.com \
--to=hpa@zytor.com \
--cc=akataria@vmware.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=astrachan@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=brijesh.singh@amd.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=geert@linux-m68k.org \
--cc=ghackmann@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jan.kiszka@siemens.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgross@suse.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manojgupta@google.com \
--cc=mawilcox@microsoft.com \
--cc=michal.lkml@markovi.net \
--cc=mingo@redhat.com \
--cc=mjg59@google.com \
--cc=mka@chromium.org \
--cc=ndesaulniers@google.com \
--cc=pombredanne@nexb.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sedat.dilek@gmail.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tstellar@redhat.com \
--cc=tweek@google.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.