All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sedat Dilek <sedat.dilek@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
	akpm@linux-foundation.org, ard.biesheuvel@linaro.org,
	aryabinin@virtuozzo.com, akataria@vmware.com,
	boris.ostrovsky@oracle.com, brijesh.singh@amd.com,
	caoj.fnst@cn.fujitsu.com, gregkh@linuxfoundation.org,
	jan.kiszka@siemens.com, jarkko.sakkinen@linux.intel.com,
	jgross@suse.com, jpoimboe@redhat.com,
	kirill.shutemov@linux.intel.com, mingo@redhat.com,
	mjg59@google.com, mka@chromium.org, pombredanne@nexb.com,
	rostedt@goodmis.org, tglx@linutronix.de, thomas.lendacky@amd.com,
	tweek@google.com, linux-efi@vger.kernel.org,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	virtualization@lists.linux-foundation.org, astrachan@google.com,
	manojgupta@google.com, ghackmann@google.com, tstellar@redhat.com,
	keescook@google.com, yamada.masahiro@socionext.com,
	michal.lkml@markovi.net, linux-kbuild@vger.kernel.org,
	geert@linux-m68k.org, will.deacon@arm.com,
	mawilcox@microsoft.com, Arnd Bergmann <arnd@arndb.de>,
	rientjes@google.com
Subject: Re: [PATCH v2 2/2] x86: paravirt: make native_save_fl extern inline
Date: Tue, 5 Jun 2018 19:46:19 +0200	[thread overview]
Message-ID: <CA+icZUXecX5s+ZD9Nfp3uXCWRyD7zbBg5WgxCintR9Baco6smA@mail.gmail.com> (raw)
In-Reply-To: <0dd024cd-e05a-0d67-c1bf-1a532714bb1a@zytor.com>

On Tue, Jun 5, 2018 at 7:31 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> On 06/05/18 10:28, H. Peter Anvin wrote:
>> On 06/05/18 10:05, Nick Desaulniers wrote:
>>> +
>>> +/*
>>> + * void native_restore_fl(unsigned long flags)
>>> + * %rdi: flags
>>> + */
>>> +ENTRY(native_restore_fl)
>>> +    push %_ASM_DI
>>> +    popf
>>> +    ret
>>> +ENDPROC(native_restore_fl)
>>> +EXPORT_SYMBOL(native_restore_fl)
>>>
>>
>> To work on i386, this would have to be %_ASM_AX in that case.
>>
>> Something like this added to <asm/asm.h> might be useful; then you can
>> simply:
>>
>>       push %_ASM_ARG1
>>
>
> Version with fixed typo...

Small typo in the commit-subject... s/argument registes/argument registers

- sed@ -

WARNING: multiple messages have this Message-ID (diff)
From: Sedat Dilek <sedat.dilek@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
	akpm@linux-foundation.org, ard.biesheuvel@linaro.org,
	aryabinin@virtuozzo.com, akataria@vmware.com,
	boris.ostrovsky@oracle.com, brijesh.singh@amd.com,
	caoj.fnst@cn.fujitsu.com, gregkh@linuxfoundation.org,
	jan.kiszka@siemens.com, jarkko.sakkinen@linux.intel.com,
	jgross@suse.com, jpoimboe@redhat.com,
	kirill.shutemov@linux.intel.com, mingo@redhat.com,
	mjg59@google.com, mka@chromium.org, pombredanne@nexb.com,
	rostedt@goodmis.org, tglx@linutronix.de, thomas.lendacky@amd.com,
	tweek@google.com, linux-efi@vger.kernel.org,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	virtualization@lists.linux-foundation.org, astrachan@google.com,
	manojgupta@google.com, ghackmann@google.com, tstellar@redhat.com,
	keescook@google.com, yamada.masahiro@socion
Subject: Re: [PATCH v2 2/2] x86: paravirt: make native_save_fl extern inline
Date: Tue, 5 Jun 2018 19:46:19 +0200	[thread overview]
Message-ID: <CA+icZUXecX5s+ZD9Nfp3uXCWRyD7zbBg5WgxCintR9Baco6smA@mail.gmail.com> (raw)
In-Reply-To: <0dd024cd-e05a-0d67-c1bf-1a532714bb1a@zytor.com>

On Tue, Jun 5, 2018 at 7:31 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> On 06/05/18 10:28, H. Peter Anvin wrote:
>> On 06/05/18 10:05, Nick Desaulniers wrote:
>>> +
>>> +/*
>>> + * void native_restore_fl(unsigned long flags)
>>> + * %rdi: flags
>>> + */
>>> +ENTRY(native_restore_fl)
>>> +    push %_ASM_DI
>>> +    popf
>>> +    ret
>>> +ENDPROC(native_restore_fl)
>>> +EXPORT_SYMBOL(native_restore_fl)
>>>
>>
>> To work on i386, this would have to be %_ASM_AX in that case.
>>
>> Something like this added to <asm/asm.h> might be useful; then you can
>> simply:
>>
>>       push %_ASM_ARG1
>>
>
> Version with fixed typo...

Small typo in the commit-subject... s/argument registes/argument registers

- sed@ -

  reply	other threads:[~2018-06-05 17:46 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-05 17:05 [PATCH v2 0/2] extern inline native_save_fl for paravirt Nick Desaulniers
2018-06-05 17:05 ` [PATCH v2 1/2] compiler-gcc.h: add gnu_inline to all inline declarations Nick Desaulniers
2018-06-05 17:23   ` Joe Perches
2018-06-05 17:55     ` Nick Desaulniers
2018-06-05 17:55       ` Nick Desaulniers
2018-06-05 19:13     ` Joe Perches
2018-06-05 19:50       ` Nick Desaulniers
2018-06-05 19:50         ` Nick Desaulniers
2018-06-05 21:59         ` Joe Perches
2018-06-05 21:59         ` Joe Perches
2018-06-05 21:59           ` Joe Perches
2018-06-06  8:05       ` Sedat Dilek
2018-06-06  8:05         ` Sedat Dilek
2018-06-06 16:39         ` hpa
2018-06-06 16:39           ` hpa
2018-06-06 16:39           ` hpa
2018-06-08 14:34           ` Sedat Dilek
2018-06-08 14:34             ` Sedat Dilek
2018-06-05 19:13     ` Joe Perches
2018-06-07 17:26     ` Nick Desaulniers
2018-06-07 17:26       ` Nick Desaulniers
2018-06-07 17:29       ` Nick Desaulniers
2018-06-07 17:29         ` Nick Desaulniers
2018-06-07 18:31       ` Joe Perches
2018-06-07 18:31         ` Joe Perches
2018-06-07 18:51         ` Nick Desaulniers
2018-06-07 18:51           ` Nick Desaulniers
2018-06-07 18:31       ` Joe Perches
2018-06-07 17:33     ` Nick Desaulniers
2018-06-07 17:33       ` Nick Desaulniers
2018-06-05 17:23   ` Joe Perches
2018-06-05 17:05 ` [PATCH v2 2/2] x86: paravirt: make native_save_fl extern inline Nick Desaulniers
2018-06-05 17:28   ` H. Peter Anvin
2018-06-05 17:28     ` H. Peter Anvin
2018-06-05 17:28     ` H. Peter Anvin
2018-06-05 17:28     ` H. Peter Anvin
2018-06-05 17:31     ` H. Peter Anvin
2018-06-05 17:31       ` H. Peter Anvin
2018-06-05 17:31       ` H. Peter Anvin
2018-06-05 17:31       ` H. Peter Anvin
2018-06-05 17:46       ` Sedat Dilek [this message]
2018-06-05 17:46         ` Sedat Dilek
2018-06-05 17:52       ` Nick Desaulniers
2018-06-05 17:52         ` Nick Desaulniers
2018-06-05 18:06         ` H. Peter Anvin
2018-06-05 18:06           ` H. Peter Anvin
2018-06-05 21:28   ` Arnd Bergmann
2018-06-05 21:28     ` Arnd Bergmann
2018-06-05 21:31     ` Arnd Bergmann
2018-06-05 21:31       ` Arnd Bergmann
2018-06-05 21:51       ` Nick Desaulniers
2018-06-05 21:51         ` Nick Desaulniers
2018-06-05 21:31     ` Arnd Bergmann
2018-06-05 21:28   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+icZUXecX5s+ZD9Nfp3uXCWRyD7zbBg5WgxCintR9Baco6smA@mail.gmail.com \
    --to=sedat.dilek@gmail.com \
    --cc=akataria@vmware.com \
    --cc=akpm@linux-foundation.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=arnd@arndb.de \
    --cc=aryabinin@virtuozzo.com \
    --cc=astrachan@google.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=brijesh.singh@amd.com \
    --cc=caoj.fnst@cn.fujitsu.com \
    --cc=geert@linux-m68k.org \
    --cc=ghackmann@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgross@suse.com \
    --cc=jpoimboe@redhat.com \
    --cc=keescook@google.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manojgupta@google.com \
    --cc=mawilcox@microsoft.com \
    --cc=michal.lkml@markovi.net \
    --cc=mingo@redhat.com \
    --cc=mjg59@google.com \
    --cc=mka@chromium.org \
    --cc=ndesaulniers@google.com \
    --cc=pombredanne@nexb.com \
    --cc=rientjes@google.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=tstellar@redhat.com \
    --cc=tweek@google.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=will.deacon@arm.com \
    --cc=x86@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.