From: Philippe Schenker <philippe.schenker@toradex.com> To: "festevam@gmail.com" <festevam@gmail.com> Cc: "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "stefan@agner.ch" <stefan@agner.ch>, Marcel Ziswiler <marcel.ziswiler@toradex.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, Max Krummenacher <max.krummenacher@toradex.com>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "michal.vokac@ysoft.com" <michal.vokac@ysoft.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, Stefan Agner <stefan.agner@toradex.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "linux-imx@nxp.com" <linux-imx@nxp.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v3 07/21] ARM: dts: imx7-colibri: fix 1.8V/UHS support Date: Wed, 7 Aug 2019 13:41:12 +0000 [thread overview] Message-ID: <9f05bcbad4b56d0b7c4f90b53b99c07833f68bb2.camel@toradex.com> (raw) In-Reply-To: <CAOMZO5CdWmVKXmNSLdbsmnU6_ZKwbeVArtOQzuTg_gtqTUnVag@mail.gmail.com> On Wed, 2019-08-07 at 08:19 -0300, Fabio Estevam wrote: > Hi Philippe, > > On Wed, Aug 7, 2019 at 5:26 AM Philippe Schenker > <philippe.schenker@toradex.com> wrote: > > From: Stefan Agner <stefan.agner@toradex.com> > > > > Add pinmuxing and do not specify voltage restrictions for the usdhc > > instance available on the modules edge connector. This allows to use > > SD-cards with higher transfer modes if supported by the carrier > > board. > > > > Signed-off-by: Stefan Agner <stefan.agner@toradex.com> > > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> > > > > --- > > > > Changes in v3: > > - Add new commit message from Stefan's proposal on ML > > The commit message has been improved, but there is also another point > I mentioned earlier: > > > Changes in v2: None > > > > arch/arm/boot/dts/imx7-colibri.dtsi | 23 ++++++++++++++++++++++- > > 1 file changed, 22 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi > > b/arch/arm/boot/dts/imx7-colibri.dtsi > > index 16d1a1ed1aff..67f5e0c87fdc 100644 > > --- a/arch/arm/boot/dts/imx7-colibri.dtsi > > +++ b/arch/arm/boot/dts/imx7-colibri.dtsi > > @@ -326,7 +326,6 @@ > > &usdhc1 { > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_usdhc1 &pinctrl_cd_usdhc1>; > > - no-1-8-v; > > cd-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>; > > disable-wp; > > vqmmc-supply = <®_LDO2>; > > @@ -671,6 +670,28 @@ > > >; > > }; > > > > + pinctrl_usdhc1_100mhz: usdhc1grp_100mhz { > > This new entry has been added and it is not referenced. Sorry, I probably could have mentioned that in this commit. I want, if possible, to let this commmit as is. That's why I added another on top of this patchset. Please see patch 21/21 that makes use of this change. > > > + fsl,pins = < > > + MX7D_PAD_SD1_CMD__SD1_CMD 0x5a > > + MX7D_PAD_SD1_CLK__SD1_CLK 0x1a > > + MX7D_PAD_SD1_DATA0__SD1_DATA0 0x5a > > + MX7D_PAD_SD1_DATA1__SD1_DATA1 0x5a > > + MX7D_PAD_SD1_DATA2__SD1_DATA2 0x5a > > + MX7D_PAD_SD1_DATA3__SD1_DATA3 0x5a > > + >; > > + }; > > + > > + pinctrl_usdhc1_200mhz: usdhc1grp_200mhz { > > Same here.
WARNING: multiple messages have this Message-ID (diff)
From: Philippe Schenker <philippe.schenker@toradex.com> To: "festevam@gmail.com" <festevam@gmail.com> Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "michal.vokac@ysoft.com" <michal.vokac@ysoft.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, Stefan Agner <stefan.agner@toradex.com>, Marcel Ziswiler <marcel.ziswiler@toradex.com>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "stefan@agner.ch" <stefan@agner.ch>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "linux-imx@nxp.com" <linux-imx@nxp.com>, Max Krummenacher <max.krummenacher@toradex.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v3 07/21] ARM: dts: imx7-colibri: fix 1.8V/UHS support Date: Wed, 7 Aug 2019 13:41:12 +0000 [thread overview] Message-ID: <9f05bcbad4b56d0b7c4f90b53b99c07833f68bb2.camel@toradex.com> (raw) In-Reply-To: <CAOMZO5CdWmVKXmNSLdbsmnU6_ZKwbeVArtOQzuTg_gtqTUnVag@mail.gmail.com> On Wed, 2019-08-07 at 08:19 -0300, Fabio Estevam wrote: > Hi Philippe, > > On Wed, Aug 7, 2019 at 5:26 AM Philippe Schenker > <philippe.schenker@toradex.com> wrote: > > From: Stefan Agner <stefan.agner@toradex.com> > > > > Add pinmuxing and do not specify voltage restrictions for the usdhc > > instance available on the modules edge connector. This allows to use > > SD-cards with higher transfer modes if supported by the carrier > > board. > > > > Signed-off-by: Stefan Agner <stefan.agner@toradex.com> > > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> > > > > --- > > > > Changes in v3: > > - Add new commit message from Stefan's proposal on ML > > The commit message has been improved, but there is also another point > I mentioned earlier: > > > Changes in v2: None > > > > arch/arm/boot/dts/imx7-colibri.dtsi | 23 ++++++++++++++++++++++- > > 1 file changed, 22 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi > > b/arch/arm/boot/dts/imx7-colibri.dtsi > > index 16d1a1ed1aff..67f5e0c87fdc 100644 > > --- a/arch/arm/boot/dts/imx7-colibri.dtsi > > +++ b/arch/arm/boot/dts/imx7-colibri.dtsi > > @@ -326,7 +326,6 @@ > > &usdhc1 { > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_usdhc1 &pinctrl_cd_usdhc1>; > > - no-1-8-v; > > cd-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>; > > disable-wp; > > vqmmc-supply = <®_LDO2>; > > @@ -671,6 +670,28 @@ > > >; > > }; > > > > + pinctrl_usdhc1_100mhz: usdhc1grp_100mhz { > > This new entry has been added and it is not referenced. Sorry, I probably could have mentioned that in this commit. I want, if possible, to let this commmit as is. That's why I added another on top of this patchset. Please see patch 21/21 that makes use of this change. > > > + fsl,pins = < > > + MX7D_PAD_SD1_CMD__SD1_CMD 0x5a > > + MX7D_PAD_SD1_CLK__SD1_CLK 0x1a > > + MX7D_PAD_SD1_DATA0__SD1_DATA0 0x5a > > + MX7D_PAD_SD1_DATA1__SD1_DATA1 0x5a > > + MX7D_PAD_SD1_DATA2__SD1_DATA2 0x5a > > + MX7D_PAD_SD1_DATA3__SD1_DATA3 0x5a > > + >; > > + }; > > + > > + pinctrl_usdhc1_200mhz: usdhc1grp_200mhz { > > Same here. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-07 13:41 UTC|newest] Thread overview: 155+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-07 8:26 [PATCH v3 00/21] Common patches from downstream development Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` [PATCH v3 01/21] ARM: dts: imx7-colibri: make sure module supplies are always on Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` [PATCH v3 02/21] ARM: dts: imx7-colibri: disable HS400 Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-09 14:05 ` Marcel Ziswiler 2019-08-09 14:05 ` Marcel Ziswiler 2019-08-09 14:05 ` Marcel Ziswiler 2019-08-07 8:26 ` [PATCH v3 03/21] ARM: dts: imx7-colibri: prepare module device tree for FlexCAN Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-09 14:07 ` Marcel Ziswiler 2019-08-09 14:07 ` Marcel Ziswiler 2019-08-09 14:07 ` Marcel Ziswiler 2019-08-07 8:26 ` [PATCH v3 04/21] ARM: dts: imx7-colibri: Add sleep mode to ethernet Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-09 14:20 ` Marcel Ziswiler 2019-08-09 14:20 ` Marcel Ziswiler 2019-08-09 14:20 ` Marcel Ziswiler 2019-08-07 8:26 ` [PATCH v3 05/21] ARM: dts: add recovery for I2C for iMX7 Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-09 14:45 ` Marcel Ziswiler 2019-08-09 14:45 ` Marcel Ziswiler 2019-08-09 14:45 ` Marcel Ziswiler 2019-08-10 21:58 ` [PATCH] ARM: dts: imx7d: sbc-iot-imx7: add recovery for i2c3/4 André Draszik 2019-08-10 21:58 ` André Draszik 2019-08-12 8:50 ` Philippe Schenker 2019-08-12 8:50 ` Philippe Schenker 2019-08-12 9:15 ` [PATCH v3 05/21] ARM: dts: add recovery for I2C for iMX7 Michal Vokáč 2019-08-12 9:15 ` Michal Vokáč 2019-08-12 9:15 ` Michal Vokáč 2019-08-12 10:59 ` Philippe Schenker 2019-08-12 10:59 ` Philippe Schenker 2019-08-12 10:59 ` Philippe Schenker 2019-08-07 8:26 ` [PATCH v3 06/21] ARM: dts: imx7-colibri: add GPIO wakeup key Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-09 14:46 ` Marcel Ziswiler 2019-08-09 14:46 ` Marcel Ziswiler 2019-08-09 14:46 ` Marcel Ziswiler 2019-08-07 8:26 ` [PATCH v3 07/21] ARM: dts: imx7-colibri: fix 1.8V/UHS support Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 11:19 ` Fabio Estevam 2019-08-07 11:19 ` Fabio Estevam 2019-08-07 13:41 ` Philippe Schenker [this message] 2019-08-07 13:41 ` Philippe Schenker 2019-08-07 13:41 ` Philippe Schenker 2019-08-09 14:48 ` Marcel Ziswiler 2019-08-09 14:48 ` Marcel Ziswiler 2019-08-09 14:48 ` Marcel Ziswiler 2019-08-07 8:26 ` [PATCH v3 08/21] ARM: dts: imx7-colibri: Add touch controllers Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-09 14:56 ` Marcel Ziswiler 2019-08-09 14:56 ` Marcel Ziswiler 2019-08-09 14:56 ` Marcel Ziswiler 2019-08-07 8:26 ` [PATCH v3 09/21] ARM: dts: imx6qdl-colibri: add phy to fec Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 10:51 ` Uwe Kleine-König 2019-08-07 10:51 ` Uwe Kleine-König 2019-08-08 8:03 ` Philippe Schenker 2019-08-08 8:03 ` Philippe Schenker 2019-08-08 8:03 ` Philippe Schenker 2019-08-09 14:59 ` Marcel Ziswiler 2019-08-09 14:59 ` Marcel Ziswiler 2019-08-09 14:59 ` Marcel Ziswiler 2019-08-07 8:26 ` [PATCH v3 10/21] ARM: dts: imx6qdl-colibri: Add missing pin declaration in iomuxc Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-09 15:00 ` Marcel Ziswiler 2019-08-09 15:00 ` Marcel Ziswiler 2019-08-09 15:00 ` Marcel Ziswiler 2019-08-07 8:26 ` [PATCH v3 11/21] ARM: dts: imx6qdl-apalis: Add sleep state to can interfaces Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-09 15:02 ` Marcel Ziswiler 2019-08-09 15:02 ` Marcel Ziswiler 2019-08-09 15:02 ` Marcel Ziswiler 2019-08-07 8:26 ` [PATCH v3 12/21] ARM: dts: imx6-apalis: Add touchscreens used on Toradex eval boards Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-09 15:35 ` Marcel Ziswiler 2019-08-09 15:35 ` Marcel Ziswiler 2019-08-09 15:35 ` Marcel Ziswiler 2019-08-07 8:26 ` [PATCH v3 13/21] ARM: dts: imx6-colibri: Add missing pinmuxing to Toradex eval board Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-09 15:36 ` Marcel Ziswiler 2019-08-09 15:36 ` Marcel Ziswiler 2019-08-09 15:36 ` Marcel Ziswiler 2019-08-07 8:26 ` [PATCH v3 14/21] ARM: dts: imx6ull-colibri: Add sleep mode to fec Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-09 15:38 ` Marcel Ziswiler 2019-08-09 15:38 ` Marcel Ziswiler 2019-08-09 15:38 ` Marcel Ziswiler 2019-08-07 8:26 ` [PATCH v3 15/21] ARM: dts: imx6ull-colibri: reduce v_batt current in power off Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-09 15:40 ` Marcel Ziswiler 2019-08-09 15:40 ` Marcel Ziswiler 2019-08-09 15:40 ` Marcel Ziswiler 2019-08-07 8:26 ` [PATCH v3 16/21] ARM: dts: imx6ull-colibri: Add watchdog Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-09 15:43 ` Marcel Ziswiler 2019-08-09 15:43 ` Marcel Ziswiler 2019-08-09 15:43 ` Marcel Ziswiler 2019-08-07 8:26 ` [PATCH v3 17/21] ARM: dts: imx6ull: improve can templates Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-09 15:47 ` Marcel Ziswiler 2019-08-09 15:47 ` Marcel Ziswiler 2019-08-09 15:47 ` Marcel Ziswiler 2019-08-12 8:54 ` Philippe Schenker 2019-08-12 8:54 ` Philippe Schenker 2019-08-12 8:54 ` Philippe Schenker 2019-08-07 8:26 ` [PATCH v3 18/21] ARM: dts: imx6ull-colibri: Add general wakeup key used on Colibri Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-09 15:48 ` Marcel Ziswiler 2019-08-09 15:48 ` Marcel Ziswiler 2019-08-09 15:48 ` Marcel Ziswiler 2019-08-07 8:26 ` [PATCH v3 19/21] ARM: dts: imx6/7-colibri: switch dr_mode to otg Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-09 15:50 ` Marcel Ziswiler 2019-08-09 15:50 ` Marcel Ziswiler 2019-08-09 15:50 ` Marcel Ziswiler 2019-08-12 12:53 ` Philippe Schenker 2019-08-12 12:53 ` Philippe Schenker 2019-08-12 12:53 ` Philippe Schenker 2019-08-07 8:26 ` [PATCH v3 20/21] ARM: dts: imx6ull-colibri: Add touchscreen used with Eval Board Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-09 15:54 ` Marcel Ziswiler 2019-08-09 15:54 ` Marcel Ziswiler 2019-08-09 15:54 ` Marcel Ziswiler 2019-08-12 13:14 ` Philippe Schenker 2019-08-12 13:14 ` Philippe Schenker 2019-08-12 13:14 ` Philippe Schenker 2019-08-07 8:26 ` [PATCH v3 21/21] ARM: dts: imx7-colibri: Add UHS support to eval board Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-07 8:26 ` Philippe Schenker 2019-08-09 15:56 ` Marcel Ziswiler 2019-08-09 15:56 ` Marcel Ziswiler 2019-08-09 15:56 ` Marcel Ziswiler
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9f05bcbad4b56d0b7c4f90b53b99c07833f68bb2.camel@toradex.com \ --to=philippe.schenker@toradex.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=marcel.ziswiler@toradex.com \ --cc=mark.rutland@arm.com \ --cc=max.krummenacher@toradex.com \ --cc=michal.vokac@ysoft.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=stefan.agner@toradex.com \ --cc=stefan@agner.ch \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.