From: Krishna Reddy <vdumpa@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Thierry Reding <treding@nvidia.com>,
Yu-Huan Hsu <YHsu@nvidia.com>, Sachin Nikam <Snikam@nvidia.com>,
Pritesh Raithatha <praithatha@nvidia.com>,
Timo Alho <talho@nvidia.com>,
Alexander Van Brunt <avanbrunt@nvidia.com>,
"Thomas Zeng (SW-TEGRA)" <thomasz@nvidia.com>,
"olof@lixom.net" <olof@lixom.net>,
Juha Tukkinen <jtukkinen@nvidia.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
Robin Murphy <robin.murphy@arm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"joro@8bytes.org" <joro@8byte>
Subject: RE: [PATCH 3/7] iommu/arm-smmu: Add tlb_sync implementation hook
Date: Fri, 30 Aug 2019 19:00:05 +0000 [thread overview]
Message-ID: <BYAPR12MB27106B630A0E1A2A0CBC79D9B3BD0@BYAPR12MB2710.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20190830111446.GC23902@ulmo>
>Wouldn't it work if you replaced all calls of __arm_smmu_tlb_sync() by
>smmu->impl->tlb_sync() and assign __arm_smmu_tlb_sync() as default for
>devices that don't need to override it? That makes this patch slightly larger, but it saves us one level of indirection.
The tlb_ops->tlb_sync can be overridden directly in arm-smmu-nvidia.c specific implementation as pointed by Robin. Will be updating in next patch.
>> + void (*tlb_sync)(struct arm_smmu_device *smmu, int page, int sync,
>> + int status);
>Can't page, sync and status all be unsigned?
This is to be uniform with original tlb_sync definition is arm-smmu.c. Anyway, this hook is not necessary as tlb_ops->tlb_sync can be overridden directly.
-KR
WARNING: multiple messages have this Message-ID (diff)
From: Krishna Reddy <vdumpa@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Thierry Reding <treding@nvidia.com>,
"Yu-Huan Hsu" <YHsu@nvidia.com>, Sachin Nikam <Snikam@nvidia.com>,
Pritesh Raithatha <praithatha@nvidia.com>,
Timo Alho <talho@nvidia.com>,
Alexander Van Brunt <avanbrunt@nvidia.com>,
"Thomas Zeng (SW-TEGRA)" <thomasz@nvidia.com>,
"olof@lixom.net" <olof@lixom.net>,
Juha Tukkinen <jtukkinen@nvidia.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
Robin Murphy <robin.murphy@arm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"joro@8bytes.org" <joro@8bytes.org>
Subject: RE: [PATCH 3/7] iommu/arm-smmu: Add tlb_sync implementation hook
Date: Fri, 30 Aug 2019 19:00:05 +0000 [thread overview]
Message-ID: <BYAPR12MB27106B630A0E1A2A0CBC79D9B3BD0@BYAPR12MB2710.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20190830111446.GC23902@ulmo>
>Wouldn't it work if you replaced all calls of __arm_smmu_tlb_sync() by
>smmu->impl->tlb_sync() and assign __arm_smmu_tlb_sync() as default for
>devices that don't need to override it? That makes this patch slightly larger, but it saves us one level of indirection.
The tlb_ops->tlb_sync can be overridden directly in arm-smmu-nvidia.c specific implementation as pointed by Robin. Will be updating in next patch.
>> + void (*tlb_sync)(struct arm_smmu_device *smmu, int page, int sync,
>> + int status);
>Can't page, sync and status all be unsigned?
This is to be uniform with original tlb_sync definition is arm-smmu.c. Anyway, this hook is not necessary as tlb_ops->tlb_sync can be overridden directly.
-KR
WARNING: multiple messages have this Message-ID (diff)
From: Krishna Reddy <vdumpa@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Sachin Nikam <Snikam@nvidia.com>,
"Thomas Zeng \(SW-TEGRA\)" <thomasz@nvidia.com>,
Juha Tukkinen <jtukkinen@nvidia.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
Pritesh Raithatha <praithatha@nvidia.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Timo Alho <talho@nvidia.com>, Yu-Huan Hsu <YHsu@nvidia.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Thierry Reding <treding@nvidia.com>,
Robin Murphy <robin.murphy@arm.com>,
Alexander Van Brunt <avanbrunt@nvidia.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 3/7] iommu/arm-smmu: Add tlb_sync implementation hook
Date: Fri, 30 Aug 2019 19:00:05 +0000 [thread overview]
Message-ID: <BYAPR12MB27106B630A0E1A2A0CBC79D9B3BD0@BYAPR12MB2710.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20190830111446.GC23902@ulmo>
>Wouldn't it work if you replaced all calls of __arm_smmu_tlb_sync() by
>smmu->impl->tlb_sync() and assign __arm_smmu_tlb_sync() as default for
>devices that don't need to override it? That makes this patch slightly larger, but it saves us one level of indirection.
The tlb_ops->tlb_sync can be overridden directly in arm-smmu-nvidia.c specific implementation as pointed by Robin. Will be updating in next patch.
>> + void (*tlb_sync)(struct arm_smmu_device *smmu, int page, int sync,
>> + int status);
>Can't page, sync and status all be unsigned?
This is to be uniform with original tlb_sync definition is arm-smmu.c. Anyway, this hook is not necessary as tlb_ops->tlb_sync can be overridden directly.
-KR
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Krishna Reddy <vdumpa@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Sachin Nikam <Snikam@nvidia.com>,
"Thomas Zeng \(SW-TEGRA\)" <thomasz@nvidia.com>,
Juha Tukkinen <jtukkinen@nvidia.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
Pritesh Raithatha <praithatha@nvidia.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Timo Alho <talho@nvidia.com>, "olof@lixom.net" <olof@lixom.net>,
Yu-Huan Hsu <YHsu@nvidia.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Thierry Reding <treding@nvidia.com>,
Robin Murphy <robin.murphy@arm.com>,
Alexander Van Brunt <avanbrunt@nvidia.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 3/7] iommu/arm-smmu: Add tlb_sync implementation hook
Date: Fri, 30 Aug 2019 19:00:05 +0000 [thread overview]
Message-ID: <BYAPR12MB27106B630A0E1A2A0CBC79D9B3BD0@BYAPR12MB2710.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20190830111446.GC23902@ulmo>
>Wouldn't it work if you replaced all calls of __arm_smmu_tlb_sync() by
>smmu->impl->tlb_sync() and assign __arm_smmu_tlb_sync() as default for
>devices that don't need to override it? That makes this patch slightly larger, but it saves us one level of indirection.
The tlb_ops->tlb_sync can be overridden directly in arm-smmu-nvidia.c specific implementation as pointed by Robin. Will be updating in next patch.
>> + void (*tlb_sync)(struct arm_smmu_device *smmu, int page, int sync,
>> + int status);
>Can't page, sync and status all be unsigned?
This is to be uniform with original tlb_sync definition is arm-smmu.c. Anyway, this hook is not necessary as tlb_ops->tlb_sync can be overridden directly.
-KR
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-30 19:00 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 22:47 [PATCH 0/7] Nvidia Arm SMMUv2 Implementation Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-29 22:47 ` [PATCH 1/7] iommu/arm-smmu: add Nvidia SMMUv2 implementation Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-30 15:02 ` Robin Murphy
2019-08-30 15:02 ` Robin Murphy
2019-08-30 15:02 ` Robin Murphy
2019-08-30 18:16 ` Krishna Reddy
2019-08-30 18:16 ` Krishna Reddy
2019-08-30 18:16 ` Krishna Reddy
2019-08-30 18:16 ` Krishna Reddy
[not found] ` <BYAPR12MB2710D045303BE89A7D3FF2C1B3BD0-ZGDeBxoHBPnlX2Hc6Vgn3wdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-09-02 13:39 ` Robin Murphy
2019-09-02 13:39 ` Robin Murphy
2019-09-02 13:39 ` Robin Murphy
2019-09-02 13:39 ` Robin Murphy
2019-09-03 1:07 ` Krishna Reddy
2019-09-03 1:07 ` Krishna Reddy
2019-09-03 1:07 ` Krishna Reddy
2019-09-03 1:07 ` Krishna Reddy
2019-08-29 22:47 ` [PATCH 2/7] dt-bindings: arm-smmu: Add binding for nvidia,smmu-v2 Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-30 12:07 ` Mikko Perttunen
2019-08-30 12:07 ` [PATCH 2/7] dt-bindings: arm-smmu: Add binding for nvidia, smmu-v2 Mikko Perttunen
2019-08-30 12:07 ` Mikko Perttunen
2019-08-30 15:13 ` [PATCH 2/7] dt-bindings: arm-smmu: Add binding for nvidia,smmu-v2 Robin Murphy
2019-08-30 15:13 ` [PATCH 2/7] dt-bindings: arm-smmu: Add binding for nvidia, smmu-v2 Robin Murphy
2019-08-30 15:13 ` Robin Murphy
2019-08-30 18:12 ` [PATCH 2/7] dt-bindings: arm-smmu: Add binding for nvidia,smmu-v2 Krishna Reddy
2019-08-30 18:12 ` [PATCH 2/7] dt-bindings: arm-smmu: Add binding for nvidia, smmu-v2 Krishna Reddy
2019-08-30 18:12 ` Krishna Reddy
2019-08-30 18:12 ` [PATCH 2/7] dt-bindings: arm-smmu: Add binding for nvidia,smmu-v2 Krishna Reddy
2019-09-02 7:38 ` Thierry Reding
2019-09-02 7:38 ` [PATCH 2/7] dt-bindings: arm-smmu: Add binding for nvidia, smmu-v2 Thierry Reding
2019-09-02 7:38 ` Thierry Reding
2019-09-02 7:38 ` [PATCH 2/7] dt-bindings: arm-smmu: Add binding for nvidia,smmu-v2 Thierry Reding
2019-08-29 22:47 ` [PATCH 3/7] iommu/arm-smmu: Add tlb_sync implementation hook Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-30 11:14 ` Thierry Reding
2019-08-30 11:14 ` Thierry Reding
2019-08-30 11:14 ` Thierry Reding
2019-08-30 19:00 ` Krishna Reddy [this message]
2019-08-30 19:00 ` Krishna Reddy
2019-08-30 19:00 ` Krishna Reddy
2019-08-30 19:00 ` Krishna Reddy
2019-08-30 15:23 ` Robin Murphy
2019-08-30 15:23 ` Robin Murphy
2019-08-30 15:23 ` Robin Murphy
2019-08-30 18:05 ` Krishna Reddy
2019-08-30 18:05 ` Krishna Reddy
2019-08-30 18:05 ` Krishna Reddy
2019-08-30 18:05 ` Krishna Reddy
2019-08-30 22:49 ` Krishna Reddy
2019-08-30 22:49 ` Krishna Reddy
2019-08-30 22:49 ` Krishna Reddy
2019-08-30 22:49 ` Krishna Reddy
2019-09-02 13:00 ` Robin Murphy
2019-09-02 13:00 ` Robin Murphy
2019-09-02 13:00 ` Robin Murphy
2019-09-02 13:00 ` Robin Murphy
2019-08-29 22:47 ` [PATCH 4/7] iommu/arm-smmu: Add global/context fault implementation hooks Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-30 11:17 ` Thierry Reding
2019-08-30 11:17 ` Thierry Reding
2019-08-30 11:17 ` Thierry Reding
2019-08-30 19:16 ` Krishna Reddy
2019-08-30 19:16 ` Krishna Reddy
2019-08-30 19:16 ` Krishna Reddy
2019-08-30 19:16 ` Krishna Reddy
2019-08-30 15:43 ` Robin Murphy
2019-08-30 15:43 ` Robin Murphy
2019-08-30 15:43 ` Robin Murphy
2019-08-30 17:43 ` Krishna Reddy
2019-08-30 17:43 ` Krishna Reddy
2019-08-30 17:43 ` Krishna Reddy
2019-08-30 17:43 ` Krishna Reddy
2019-08-29 22:47 ` [PATCH 5/7] arm64: tegra: Add Memory controller DT node on T194 Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-30 11:18 ` Thierry Reding
2019-08-30 11:18 ` Thierry Reding
2019-08-30 11:18 ` Thierry Reding
2019-08-29 22:47 ` [PATCH 6/7] arm64: tegra: Add DT node for T194 SMMU Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-30 12:09 ` Mikko Perttunen
2019-08-30 12:09 ` Mikko Perttunen
2019-08-30 12:09 ` Mikko Perttunen
2019-08-30 18:39 ` Krishna Reddy
2019-08-30 18:39 ` Krishna Reddy
2019-08-30 18:39 ` Krishna Reddy
2019-08-30 18:39 ` Krishna Reddy
2019-08-30 15:44 ` Robin Murphy
2019-08-30 15:44 ` Robin Murphy
2019-08-30 15:44 ` Robin Murphy
2019-08-30 17:25 ` Krishna Reddy
2019-08-30 17:25 ` Krishna Reddy
2019-08-30 17:25 ` Krishna Reddy
2019-08-30 17:25 ` Krishna Reddy
2019-08-30 17:45 ` Robin Murphy
2019-08-30 17:45 ` Robin Murphy
2019-08-30 17:45 ` Robin Murphy
2019-08-30 17:45 ` Robin Murphy
2019-08-30 18:35 ` Krishna Reddy
2019-08-30 18:35 ` Krishna Reddy
2019-08-30 18:35 ` Krishna Reddy
2019-08-30 18:35 ` Krishna Reddy
2019-08-29 22:47 ` [PATCH 7/7] arm64: tegra: enable SMMU for SDHCI and EQOS Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
2019-08-29 22:47 ` Krishna Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR12MB27106B630A0E1A2A0CBC79D9B3BD0@BYAPR12MB2710.namprd12.prod.outlook.com \
--to=vdumpa@nvidia.com \
--cc=Snikam@nvidia.com \
--cc=YHsu@nvidia.com \
--cc=avanbrunt@nvidia.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8byte \
--cc=jtukkinen@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=olof@lixom.net \
--cc=praithatha@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=thomasz@nvidia.com \
--cc=treding@nvidia.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.