From: Linus Walleij <linus.walleij@linaro.org>
To: Timur Tabi <timur@codeaurora.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
anjiandi@codeaurora.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 0/2] [v5] pinctrl: qcom: add support for sparse GPIOs
Date: Thu, 21 Sep 2017 14:08:33 +0200 [thread overview]
Message-ID: <CACRpkdYfAcKrgbgybccurUKTyR0E+tHDyzp7sbXxXxKuyMOGhQ@mail.gmail.com> (raw)
In-Reply-To: <d53e67a2-4f69-752f-ba35-53872d9b9760@codeaurora.org>
On Wed, Sep 20, 2017 at 3:04 PM, Timur Tabi <timur@codeaurora.org> wrote:
> On 9/20/17 6:43 AM, Linus Walleij wrote:
>>
>> Doesn't that mean we need something like irq_valid_mask but rather
>> gpio_valid_mask that just block all usage of certain GPIOs?
>
>
> That raises a lot of questions. In the meantime, my current patches for
> 4.14 work fine.
>
> Do we replace irq_valid_mask with gpio_valid_mask? That would break drivers
> where the GPIO is valid but the interrupt is not. If we keep both, what
> happens if gpio_valid_mask is false but irq_valid_mask is true? And then we
> would need to audit all gpio drivers to see which ones should be updated for
> the new infrastructure.
I guess gpio_valid_mask would take precedence over irq_valid_mask.
I.e if the GPIO is not valid then the IRQ is per definition not valid either.
Since it is a new thing, we can simply define a semantic like that
and document it.
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] [v5] pinctrl: qcom: add support for sparse GPIOs
Date: Thu, 21 Sep 2017 14:08:33 +0200 [thread overview]
Message-ID: <CACRpkdYfAcKrgbgybccurUKTyR0E+tHDyzp7sbXxXxKuyMOGhQ@mail.gmail.com> (raw)
In-Reply-To: <d53e67a2-4f69-752f-ba35-53872d9b9760@codeaurora.org>
On Wed, Sep 20, 2017 at 3:04 PM, Timur Tabi <timur@codeaurora.org> wrote:
> On 9/20/17 6:43 AM, Linus Walleij wrote:
>>
>> Doesn't that mean we need something like irq_valid_mask but rather
>> gpio_valid_mask that just block all usage of certain GPIOs?
>
>
> That raises a lot of questions. In the meantime, my current patches for
> 4.14 work fine.
>
> Do we replace irq_valid_mask with gpio_valid_mask? That would break drivers
> where the GPIO is valid but the interrupt is not. If we keep both, what
> happens if gpio_valid_mask is false but irq_valid_mask is true? And then we
> would need to audit all gpio drivers to see which ones should be updated for
> the new infrastructure.
I guess gpio_valid_mask would take precedence over irq_valid_mask.
I.e if the GPIO is not valid then the IRQ is per definition not valid either.
Since it is a new thing, we can simply define a semantic like that
and document it.
Yours,
Linus Walleij
next prev parent reply other threads:[~2017-09-21 12:08 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 15:33 [PATCH 0/2] [v5] pinctrl: qcom: add support for sparse GPIOs Timur Tabi
2017-09-07 15:33 ` Timur Tabi
2017-09-07 15:33 ` [PATCH 1/2] [v5] pinctrl: qcom: disable GPIO groups with no pins Timur Tabi
2017-09-07 15:33 ` Timur Tabi
2017-10-02 17:44 ` Bjorn Andersson
2017-10-02 17:44 ` Bjorn Andersson
2017-10-02 20:47 ` Timur Tabi
2017-10-02 20:47 ` Timur Tabi
2017-10-07 11:07 ` Linus Walleij
2017-10-07 11:07 ` Linus Walleij
2017-10-13 23:35 ` Timur Tabi
2017-10-13 23:35 ` Timur Tabi
2017-10-19 22:44 ` Timur Tabi
2017-10-19 22:44 ` Timur Tabi
2017-10-16 8:01 ` Thierry Reding
2017-10-16 8:01 ` Thierry Reding
2017-10-16 13:52 ` Timur Tabi
2017-10-16 13:52 ` Timur Tabi
2017-09-07 15:33 ` [PATCH 2/2] [v3] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002 Timur Tabi
2017-09-07 15:33 ` Timur Tabi
2017-09-08 12:50 ` [PATCH 0/2] [v5] pinctrl: qcom: add support for sparse GPIOs Linus Walleij
2017-09-08 12:50 ` Linus Walleij
2017-09-13 17:09 ` Timur Tabi
2017-09-13 17:09 ` Timur Tabi
2017-09-19 7:04 ` Stephen Boyd
2017-09-19 7:04 ` Stephen Boyd
2017-09-19 8:15 ` Linus Walleij
2017-09-19 8:15 ` Linus Walleij
2017-09-19 12:32 ` Timur Tabi
2017-09-19 12:32 ` Timur Tabi
2017-09-20 11:43 ` Linus Walleij
2017-09-20 11:43 ` Linus Walleij
2017-09-20 13:04 ` Timur Tabi
2017-09-20 13:04 ` Timur Tabi
2017-09-21 12:08 ` Linus Walleij [this message]
2017-09-21 12:08 ` Linus Walleij
2017-09-21 12:12 ` Timur Tabi
2017-09-21 12:12 ` Timur Tabi
2017-09-22 13:29 ` Linus Walleij
2017-09-22 13:29 ` Linus Walleij
2017-09-22 13:37 ` Timur Tabi
2017-09-22 13:37 ` Timur Tabi
2017-10-03 22:03 ` Stephen Boyd
2017-10-03 22:03 ` Stephen Boyd
2017-10-03 22:12 ` Timur Tabi
2017-10-03 22:12 ` Timur Tabi
2017-10-04 21:50 ` Stephen Boyd
2017-10-04 21:50 ` Stephen Boyd
2017-10-04 22:41 ` Timur Tabi
2017-10-04 22:41 ` Timur Tabi
2017-10-05 21:30 ` Stephen Boyd
2017-10-05 21:30 ` Stephen Boyd
2017-10-11 7:51 ` Linus Walleij
2017-10-11 7:51 ` Linus Walleij
2017-10-12 7:39 ` Stephen Boyd
2017-10-12 7:39 ` Stephen Boyd
2017-10-14 22:43 ` Linus Walleij
2017-10-14 22:43 ` Linus Walleij
2017-10-16 13:42 ` Timur Tabi
2017-10-16 13:42 ` Timur Tabi
2017-10-13 23:26 ` Timur Tabi
2017-10-13 23:26 ` Timur Tabi
2017-10-15 20:18 ` Thierry Reding
2017-10-15 20:18 ` Thierry Reding
2017-10-15 21:09 ` Timur Tabi
2017-10-15 21:09 ` Timur Tabi
2017-10-02 16:02 ` Timur Tabi
2017-10-02 16:02 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYfAcKrgbgybccurUKTyR0E+tHDyzp7sbXxXxKuyMOGhQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.gross@linaro.org \
--cc=anjiandi@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=sboyd@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.