From: Linus Walleij <linus.walleij@linaro.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
James Hogan <james.hogan@imgtec.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 5/5] pinctrl: rockchip: correctly handle arguments of pinconf options
Date: Sun, 16 Jun 2013 14:35:58 +0200 [thread overview]
Message-ID: <CACRpkdZxO-8rQPBRPsxAx8OBfwvh_BQuts7NAi379gMZG+1ocg@mail.gmail.com> (raw)
In-Reply-To: <201306161302.32156.heiko@sntech.de>
On Sun, Jun 16, 2013 at 1:02 PM, Heiko Stübner <heiko@sntech.de> wrote:
>> > - *config = 0;
>> > + pull = rockchip_get_pull(bank, pin - bank->pin_base);
>> > + *config = (pull == param) ? 1 : 0;
>>
>> And then I guess you should emit PIN_CONFIG_BIAS_DISABLE
>> here as well.
>
> rockchip_get_pull does emit PIN_CONFIG_BIAS_DISABLE when the pull is disabled,
> only wrongly does add the argument here.
Ah, right.
> But I'm actually not quite sure what the expected behaviour is here at all :-)
>
> Say the pin is in the "pin-default" pull state and the query in config_get is
> for "bias-disable", what would be the expected bahviour/return value in this
> case?
return -EINVAL; ?
Hm it was some time since I designed this...
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: James Hogan <james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>,
"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 5/5] pinctrl: rockchip: correctly handle arguments of pinconf options
Date: Sun, 16 Jun 2013 14:35:58 +0200 [thread overview]
Message-ID: <CACRpkdZxO-8rQPBRPsxAx8OBfwvh_BQuts7NAi379gMZG+1ocg@mail.gmail.com> (raw)
In-Reply-To: <201306161302.32156.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
On Sun, Jun 16, 2013 at 1:02 PM, Heiko Stübner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> wrote:
>> > - *config = 0;
>> > + pull = rockchip_get_pull(bank, pin - bank->pin_base);
>> > + *config = (pull == param) ? 1 : 0;
>>
>> And then I guess you should emit PIN_CONFIG_BIAS_DISABLE
>> here as well.
>
> rockchip_get_pull does emit PIN_CONFIG_BIAS_DISABLE when the pull is disabled,
> only wrongly does add the argument here.
Ah, right.
> But I'm actually not quite sure what the expected behaviour is here at all :-)
>
> Say the pin is in the "pin-default" pull state and the query in config_get is
> for "bias-disable", what would be the expected bahviour/return value in this
> case?
return -EINVAL; ?
Hm it was some time since I designed this...
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] pinctrl: rockchip: correctly handle arguments of pinconf options
Date: Sun, 16 Jun 2013 14:35:58 +0200 [thread overview]
Message-ID: <CACRpkdZxO-8rQPBRPsxAx8OBfwvh_BQuts7NAi379gMZG+1ocg@mail.gmail.com> (raw)
In-Reply-To: <201306161302.32156.heiko@sntech.de>
On Sun, Jun 16, 2013 at 1:02 PM, Heiko St?bner <heiko@sntech.de> wrote:
>> > - *config = 0;
>> > + pull = rockchip_get_pull(bank, pin - bank->pin_base);
>> > + *config = (pull == param) ? 1 : 0;
>>
>> And then I guess you should emit PIN_CONFIG_BIAS_DISABLE
>> here as well.
>
> rockchip_get_pull does emit PIN_CONFIG_BIAS_DISABLE when the pull is disabled,
> only wrongly does add the argument here.
Ah, right.
> But I'm actually not quite sure what the expected behaviour is here at all :-)
>
> Say the pin is in the "pin-default" pull state and the query in config_get is
> for "bias-disable", what would be the expected bahviour/return value in this
> case?
return -EINVAL; ?
Hm it was some time since I designed this...
Yours,
Linus Walleij
next prev parent reply other threads:[~2013-06-16 12:36 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 15:41 [PATCH 0/5] pinctrl: fix some issues with new pinconfig dt parsing Heiko Stübner
2013-06-14 15:41 ` Heiko Stübner
2013-06-14 15:41 ` Heiko Stübner
2013-06-14 15:42 ` [PATCH 1/5] pinctrl: update the documentation for some pinconfig params Heiko Stübner
2013-06-14 15:42 ` Heiko Stübner
2013-06-14 15:42 ` Heiko Stübner
2013-06-16 10:26 ` Linus Walleij
2013-06-16 10:26 ` Linus Walleij
2013-06-16 10:26 ` Linus Walleij
2013-06-16 10:45 ` Heiko Stübner
2013-06-16 10:45 ` Heiko Stübner
2013-06-16 10:45 ` Heiko Stübner
2013-06-16 12:26 ` Linus Walleij
2013-06-16 12:26 ` Linus Walleij
2013-06-16 12:26 ` Linus Walleij
2013-06-14 15:42 ` [PATCH 2/5] pinctrl: clarify some dt pinconfig options Heiko Stübner
2013-06-14 15:42 ` Heiko Stübner
2013-06-14 15:42 ` Heiko Stübner
2013-06-16 10:28 ` Linus Walleij
2013-06-16 10:28 ` Linus Walleij
2013-06-16 10:28 ` Linus Walleij
2013-06-19 22:10 ` Stephen Warren
2013-06-19 22:10 ` Stephen Warren
2013-06-19 22:10 ` Stephen Warren
2013-06-24 9:51 ` Linus Walleij
2013-06-24 9:51 ` Linus Walleij
2013-06-14 15:43 ` [PATCH 3/5] pinctrl: handle zero found dt pinconfig properties better Heiko Stübner
2013-06-14 15:43 ` Heiko Stübner
2013-06-14 15:43 ` Heiko Stübner
2013-06-16 10:29 ` Linus Walleij
2013-06-16 10:29 ` Linus Walleij
2013-06-16 10:29 ` Linus Walleij
2013-06-14 15:43 ` [PATCH 4/5] pinctrl: dynamically alloc temp array when parsing dt pinconf options Heiko Stübner
2013-06-14 15:43 ` Heiko Stübner
2013-06-14 15:43 ` Heiko Stübner
2013-06-16 10:31 ` Linus Walleij
2013-06-16 10:31 ` Linus Walleij
2013-06-16 10:31 ` Linus Walleij
2013-06-14 15:44 ` [PATCH 5/5] pinctrl: rockchip: correctly handle arguments of " Heiko Stübner
2013-06-14 15:44 ` Heiko Stübner
2013-06-14 15:44 ` Heiko Stübner
2013-06-16 10:35 ` Linus Walleij
2013-06-16 10:35 ` Linus Walleij
2013-06-16 10:35 ` Linus Walleij
2013-06-16 11:02 ` Heiko Stübner
2013-06-16 11:02 ` Heiko Stübner
2013-06-16 11:02 ` Heiko Stübner
2013-06-16 12:35 ` Linus Walleij [this message]
2013-06-16 12:35 ` Linus Walleij
2013-06-16 12:35 ` Linus Walleij
2013-06-16 15:41 ` [PATCH v2] " Heiko Stübner
2013-06-16 15:41 ` Heiko Stübner
2013-06-16 15:41 ` Heiko Stübner
2013-06-17 15:48 ` Linus Walleij
2013-06-17 15:48 ` Linus Walleij
2013-06-17 15:48 ` Linus Walleij
2013-06-14 15:53 ` [PATCH 0/5] pinctrl: fix some issues with new pinconfig dt parsing James Hogan
2013-06-14 15:53 ` James Hogan
2013-06-14 15:53 ` James Hogan
2013-06-17 3:03 ` Laurent Pinchart
2013-06-17 3:03 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZxO-8rQPBRPsxAx8OBfwvh_BQuts7NAi379gMZG+1ocg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=james.hogan@imgtec.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.