From: Fu Wei <fu.wei@linaro.org>
To: Hanjun Guo <hanjun.guo@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Linaro ACPI Mailman List <linaro-acpi@lists.linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
rruigrok@codeaurora.org, Wim Van Sebroeck <wim@iguana.be>,
Wei Huang <wei@redhat.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Al Stone <al.stone@linaro.org>, Tomasz Nowicki <tn@semihalf.com>,
Timur Tabi <timur@codeaurora.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Guenter Roeck <linux@roeck-us.net>, Len Brown <lenb@kernel.org>,
"Abdulhamid, Harb" <harba@codeaurora.org>,
Julien Grall <julien.grall@arm.com>,
linux-watchdog@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Marc Zyngier <marc.zyngier@arm.com>, Jon Masters <jcm@redhat.com>,
Christopher Covington <cov@codeaurora.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists
Subject: Re: [PATCH v20 11/17] clocksource/drivers/arm_arch_timer: Introduce some new structs to prepare for GTDT
Date: Thu, 19 Jan 2017 17:47:14 +0800 [thread overview]
Message-ID: <CADyBb7uhwU_ACGQRvw8zPg-VCdxyO2L1MEoeZWS1zYdveLK6PA@mail.gmail.com> (raw)
In-Reply-To: <a47f2474-fb29-9217-3de1-6e2a6a36f21f@linaro.org>
Hi Hanjun,
On 19 January 2017 at 16:28, Hanjun Guo <hanjun.guo@linaro.org> wrote:
> On 2017/1/18 21:25, fu.wei@linaro.org wrote:
>>
>> From: Fu Wei <fu.wei@linaro.org>
>>
>> The patch introduce two new structs: arch_timer_mem, arch_timer_mem_frame.
>> And also introduce a new define: ARCH_TIMER_MEM_MAX_FRAMES
>>
>> These will be used for refactoring the memory-mapped timer init code to
>> prepare for GTDT
>>
>> Signed-off-by: Fu Wei <fu.wei@linaro.org>
>> ---
>> include/clocksource/arm_arch_timer.h | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/include/clocksource/arm_arch_timer.h
>> b/include/clocksource/arm_arch_timer.h
>> index 4a98c06..b7dd185 100644
>> --- a/include/clocksource/arm_arch_timer.h
>> +++ b/include/clocksource/arm_arch_timer.h
>> @@ -57,6 +57,8 @@ enum arch_timer_spi_nr {
>> #define ARCH_TIMER_MEM_PHYS_ACCESS 2
>> #define ARCH_TIMER_MEM_VIRT_ACCESS 3
>>
>> +#define ARCH_TIMER_MEM_MAX_FRAMES 8
>> +
>> #define ARCH_TIMER_USR_PCT_ACCESS_EN (1 << 0) /* physical counter */
>> #define ARCH_TIMER_USR_VCT_ACCESS_EN (1 << 1) /* virtual counter */
>> #define ARCH_TIMER_VIRT_EVT_EN (1 << 2)
>> @@ -72,6 +74,21 @@ struct arch_timer_kvm_info {
>> int virtual_irq;
>> };
>>
>> +struct arch_timer_mem_frame {
>> + int frame_nr;
>> + phys_addr_t cntbase;
>> + size_t size;
>> + int phys_irq;
>> + int virt_irq;
>> +};
>> +
>> +struct arch_timer_mem {
>> + phys_addr_t cntctlbase;
>> + size_t size;
>> + int num_frames;
>> + struct arch_timer_mem_frame frame[ARCH_TIMER_MEM_MAX_FRAMES];
>> +};
>
>
> Since struct is introduced but not used in this patch, how about
> squash it with patch 12/17?
In the previous patchset, I have been suggested that I should split it out.
>
> Thanks
> Hanjun
--
Best regards,
Fu Wei
Software Engineer
Red Hat
WARNING: multiple messages have this Message-ID (diff)
From: Fu Wei <fu.wei@linaro.org>
To: Hanjun Guo <hanjun.guo@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org,
Linaro ACPI Mailman List <linaro-acpi@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
rruigrok@codeaurora.org, "Abdulhamid,
Harb" <harba@codeaurora.org>,
Christopher Covington <cov@codeaurora.org>,
Timur Tabi <timur@codeaurora.org>,
G Gregory <graeme.gregory@linaro.org>,
Al Stone <al.stone@linaro.org>, Jon Masters <jcm@redhat.com>,
Wei Huang <wei@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
Leo Duran <leo.duran@amd.com>, Wim Van Sebroeck <wim@iguana.be>,
Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org, Tomasz Nowicki <tn@semihalf.com>,
Christoffer Dall <christoffer.dall@linaro.org>,
Julien Grall <julien.grall@arm.com>
Subject: Re: [PATCH v20 11/17] clocksource/drivers/arm_arch_timer: Introduce some new structs to prepare for GTDT
Date: Thu, 19 Jan 2017 17:47:14 +0800 [thread overview]
Message-ID: <CADyBb7uhwU_ACGQRvw8zPg-VCdxyO2L1MEoeZWS1zYdveLK6PA@mail.gmail.com> (raw)
In-Reply-To: <a47f2474-fb29-9217-3de1-6e2a6a36f21f@linaro.org>
Hi Hanjun,
On 19 January 2017 at 16:28, Hanjun Guo <hanjun.guo@linaro.org> wrote:
> On 2017/1/18 21:25, fu.wei@linaro.org wrote:
>>
>> From: Fu Wei <fu.wei@linaro.org>
>>
>> The patch introduce two new structs: arch_timer_mem, arch_timer_mem_frame.
>> And also introduce a new define: ARCH_TIMER_MEM_MAX_FRAMES
>>
>> These will be used for refactoring the memory-mapped timer init code to
>> prepare for GTDT
>>
>> Signed-off-by: Fu Wei <fu.wei@linaro.org>
>> ---
>> include/clocksource/arm_arch_timer.h | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/include/clocksource/arm_arch_timer.h
>> b/include/clocksource/arm_arch_timer.h
>> index 4a98c06..b7dd185 100644
>> --- a/include/clocksource/arm_arch_timer.h
>> +++ b/include/clocksource/arm_arch_timer.h
>> @@ -57,6 +57,8 @@ enum arch_timer_spi_nr {
>> #define ARCH_TIMER_MEM_PHYS_ACCESS 2
>> #define ARCH_TIMER_MEM_VIRT_ACCESS 3
>>
>> +#define ARCH_TIMER_MEM_MAX_FRAMES 8
>> +
>> #define ARCH_TIMER_USR_PCT_ACCESS_EN (1 << 0) /* physical counter */
>> #define ARCH_TIMER_USR_VCT_ACCESS_EN (1 << 1) /* virtual counter */
>> #define ARCH_TIMER_VIRT_EVT_EN (1 << 2)
>> @@ -72,6 +74,21 @@ struct arch_timer_kvm_info {
>> int virtual_irq;
>> };
>>
>> +struct arch_timer_mem_frame {
>> + int frame_nr;
>> + phys_addr_t cntbase;
>> + size_t size;
>> + int phys_irq;
>> + int virt_irq;
>> +};
>> +
>> +struct arch_timer_mem {
>> + phys_addr_t cntctlbase;
>> + size_t size;
>> + int num_frames;
>> + struct arch_timer_mem_frame frame[ARCH_TIMER_MEM_MAX_FRAMES];
>> +};
>
>
> Since struct is introduced but not used in this patch, how about
> squash it with patch 12/17?
In the previous patchset, I have been suggested that I should split it out.
>
> Thanks
> Hanjun
--
Best regards,
Fu Wei
Software Engineer
Red Hat
WARNING: multiple messages have this Message-ID (diff)
From: fu.wei@linaro.org (Fu Wei)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v20 11/17] clocksource/drivers/arm_arch_timer: Introduce some new structs to prepare for GTDT
Date: Thu, 19 Jan 2017 17:47:14 +0800 [thread overview]
Message-ID: <CADyBb7uhwU_ACGQRvw8zPg-VCdxyO2L1MEoeZWS1zYdveLK6PA@mail.gmail.com> (raw)
In-Reply-To: <a47f2474-fb29-9217-3de1-6e2a6a36f21f@linaro.org>
Hi Hanjun,
On 19 January 2017 at 16:28, Hanjun Guo <hanjun.guo@linaro.org> wrote:
> On 2017/1/18 21:25, fu.wei at linaro.org wrote:
>>
>> From: Fu Wei <fu.wei@linaro.org>
>>
>> The patch introduce two new structs: arch_timer_mem, arch_timer_mem_frame.
>> And also introduce a new define: ARCH_TIMER_MEM_MAX_FRAMES
>>
>> These will be used for refactoring the memory-mapped timer init code to
>> prepare for GTDT
>>
>> Signed-off-by: Fu Wei <fu.wei@linaro.org>
>> ---
>> include/clocksource/arm_arch_timer.h | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/include/clocksource/arm_arch_timer.h
>> b/include/clocksource/arm_arch_timer.h
>> index 4a98c06..b7dd185 100644
>> --- a/include/clocksource/arm_arch_timer.h
>> +++ b/include/clocksource/arm_arch_timer.h
>> @@ -57,6 +57,8 @@ enum arch_timer_spi_nr {
>> #define ARCH_TIMER_MEM_PHYS_ACCESS 2
>> #define ARCH_TIMER_MEM_VIRT_ACCESS 3
>>
>> +#define ARCH_TIMER_MEM_MAX_FRAMES 8
>> +
>> #define ARCH_TIMER_USR_PCT_ACCESS_EN (1 << 0) /* physical counter */
>> #define ARCH_TIMER_USR_VCT_ACCESS_EN (1 << 1) /* virtual counter */
>> #define ARCH_TIMER_VIRT_EVT_EN (1 << 2)
>> @@ -72,6 +74,21 @@ struct arch_timer_kvm_info {
>> int virtual_irq;
>> };
>>
>> +struct arch_timer_mem_frame {
>> + int frame_nr;
>> + phys_addr_t cntbase;
>> + size_t size;
>> + int phys_irq;
>> + int virt_irq;
>> +};
>> +
>> +struct arch_timer_mem {
>> + phys_addr_t cntctlbase;
>> + size_t size;
>> + int num_frames;
>> + struct arch_timer_mem_frame frame[ARCH_TIMER_MEM_MAX_FRAMES];
>> +};
>
>
> Since struct is introduced but not used in this patch, how about
> squash it with patch 12/17?
In the previous patchset, I have been suggested that I should split it out.
>
> Thanks
> Hanjun
--
Best regards,
Fu Wei
Software Engineer
Red Hat
next prev parent reply other threads:[~2017-01-19 9:47 UTC|newest]
Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 13:25 [PATCH v20 00/17] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` [PATCH v20 01/17] clocksource/drivers/arm_arch_timer: Improve printk relevant code fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` [PATCH v20 02/17] clocksource/drivers/arm_arch_timer: Rename the timer type macros fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 03/17] clocksource/drivers/arm_arch_timer: Rename the PPI enum and its values fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` [PATCH v20 04/17] clocksource/drivers/arm_arch_timer: Move enums and defines to header file fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 05/17] clocksource/drivers/arm_arch_timer: Add a new enum for spi type fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 06/17] clocksource/drivers/arm_arch_timer: rework PPI determination fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 07/17] clocksource/drivers/arm_arch_timer: Separate out device-tree code from arch_timer_detect_rate fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 08/17] clocksource/drivers/arm_arch_timer: Rework counter frequency detection fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
[not found] ` <20170118132541.8989-9-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-01-19 8:02 ` Hanjun Guo
2017-01-19 8:02 ` Hanjun Guo
2017-01-19 8:02 ` Hanjun Guo
[not found] ` <cafa8c7a-9c7c-51ba-5566-0cfe1fe6f764-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-01-19 9:44 ` Fu Wei
2017-01-19 9:44 ` Fu Wei
2017-01-19 9:44 ` Fu Wei
2017-01-19 12:41 ` Hanjun Guo
2017-01-19 12:41 ` Hanjun Guo
2017-01-19 12:41 ` Hanjun Guo
2017-01-19 12:41 ` Hanjun Guo
2017-01-24 17:24 ` Mark Rutland
2017-01-24 17:24 ` Mark Rutland
2017-01-25 6:46 ` Fu Wei
2017-01-25 6:46 ` Fu Wei
2017-01-25 6:46 ` Fu Wei
2017-01-25 7:23 ` Fu Wei
2017-01-25 7:23 ` Fu Wei
2017-01-25 7:23 ` Fu Wei
2017-01-25 15:38 ` Christopher Covington
2017-01-25 15:38 ` Christopher Covington
2017-01-25 15:38 ` Christopher Covington
2017-01-25 17:36 ` Mark Rutland
2017-01-25 17:36 ` Mark Rutland
2017-01-25 17:36 ` Mark Rutland
2017-01-26 5:55 ` Fu Wei
2017-01-26 5:55 ` Fu Wei
2017-01-26 5:55 ` Fu Wei
2017-01-25 17:25 ` Mark Rutland
2017-01-25 17:25 ` Mark Rutland
2017-01-25 17:25 ` Mark Rutland
2017-01-26 5:49 ` Fu Wei
2017-01-26 5:49 ` Fu Wei
2017-01-26 5:49 ` Fu Wei
2017-01-30 17:49 ` Mark Rutland
2017-01-30 17:49 ` Mark Rutland
2017-01-30 17:49 ` Mark Rutland
2017-01-31 11:42 ` Mark Rutland
2017-01-31 11:42 ` Mark Rutland
2017-01-31 11:42 ` Mark Rutland
2017-01-31 18:43 ` Fu Wei
2017-01-31 18:43 ` Fu Wei
2017-01-31 18:43 ` Fu Wei
2017-01-31 18:49 ` Mark Rutland
2017-01-31 18:49 ` Mark Rutland
2017-01-31 18:49 ` Mark Rutland
2017-01-31 19:07 ` Fu Wei
2017-01-31 19:07 ` Fu Wei
2017-01-31 19:07 ` Fu Wei
2017-01-18 13:25 ` [PATCH v20 09/17] clocksource/drivers/arm_arch_timer: Refactor arch_timer_needs_probing fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 10/17] clocksource/drivers/arm_arch_timer: Move arch_timer_needs_of_probing into DT init call fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 11/17] clocksource/drivers/arm_arch_timer: Introduce some new structs to prepare for GTDT fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-19 8:28 ` Hanjun Guo
2017-01-19 8:28 ` Hanjun Guo
2017-01-19 9:47 ` Fu Wei [this message]
2017-01-19 9:47 ` Fu Wei
2017-01-19 9:47 ` Fu Wei
2017-01-18 13:25 ` [PATCH v20 12/17] clocksource/drivers/arm_arch_timer: Refactor MMIO timer probing fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 13/17] acpi/arm64: Add GTDT table parse driver fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-19 9:11 ` Hanjun Guo
2017-01-19 9:11 ` Hanjun Guo
[not found] ` <e69d80d1-0954-b1be-817e-c0be6fc24b77-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-01-19 10:32 ` Fu Wei
2017-01-19 10:32 ` Fu Wei
2017-01-19 10:32 ` Fu Wei
2017-01-19 11:16 ` Mark Rutland
2017-01-19 11:16 ` Mark Rutland
2017-01-19 11:16 ` Mark Rutland
2017-01-19 12:28 ` Fu Wei
2017-01-19 12:28 ` Fu Wei
2017-01-19 12:28 ` Fu Wei
2017-01-18 13:25 ` [PATCH v20 14/17] clocksource/drivers/arm_arch_timer: Simplify ACPI support code fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 15/17] acpi/arm64: Add memory-mapped timer support in GTDT driver fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 16/17] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
[not found] ` <20170118132541.8989-17-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-01-19 9:16 ` Hanjun Guo
2017-01-19 9:16 ` Hanjun Guo
2017-01-19 9:16 ` Hanjun Guo
2017-01-19 10:02 ` Fu Wei
2017-01-19 10:02 ` Fu Wei
2017-01-19 10:02 ` Fu Wei
2017-01-19 12:42 ` Hanjun Guo
2017-01-19 12:42 ` Hanjun Guo
2017-01-19 12:42 ` Hanjun Guo
2017-01-18 13:25 ` [PATCH v20 17/17] acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` fu.wei
2017-01-19 9:20 ` [PATCH v20 00/17] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Hanjun Guo
2017-01-19 9:20 ` Hanjun Guo
2017-01-19 9:20 ` Hanjun Guo
2017-01-19 11:06 ` Fu Wei
2017-01-19 11:06 ` Fu Wei
2017-01-19 11:06 ` Fu Wei
2017-01-23 18:54 ` Mark Rutland
2017-01-23 18:54 ` Mark Rutland
2017-01-24 5:11 ` Fu Wei
2017-01-24 5:11 ` Fu Wei
2017-01-24 5:11 ` Fu Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADyBb7uhwU_ACGQRvw8zPg-VCdxyO2L1MEoeZWS1zYdveLK6PA@mail.gmail.com \
--to=fu.wei@linaro.org \
--cc=al.stone@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=cov@codeaurora.org \
--cc=daniel.lezcano@linaro.org \
--cc=hanjun.guo@linaro.org \
--cc=harba@codeaurora.org \
--cc=jcm@redhat.com \
--cc=julien.grall@arm.com \
--cc=lenb@kernel.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=rruigrok@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
--cc=tn@semihalf.com \
--cc=wei@redhat.com \
--cc=will.deacon@arm.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.