From: Hanjun Guo <hanjun.guo@linaro.org>
To: fu.wei@linaro.org, rjw@rjwysocki.net, lenb@kernel.org,
daniel.lezcano@linaro.org, tglx@linutronix.de,
marc.zyngier@arm.com, mark.rutland@arm.com,
lorenzo.pieralisi@arm.com, sudeep.holla@arm.com
Cc: linaro-acpi@lists.linaro.org, catalin.marinas@arm.com,
will.deacon@arm.com, linux-kernel@vger.kernel.org, wim@iguana.be,
wei@redhat.com, al.stone@linaro.org, tn@semihalf.com,
timur@codeaurora.org, linux-acpi@vger.kernel.org,
linux@roeck-us.net, harba@codeaurora.org, julien.grall@arm.com,
linux-watchdog@vger.kernel.org, arnd@arndb.de, jcm@redhat.com,
cov@codeaurora.org, linux-arm-kernel@lists.infradead.org,
graeme.gregory@linaro.org, rruigrok@codeaurora.org,
leo.duran@amd.com, Suravee.Suthikulpanit@amd.com,
christoffer.dall@linaro.org
Subject: Re: [PATCH v20 00/17] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer
Date: Thu, 19 Jan 2017 17:20:07 +0800 [thread overview]
Message-ID: <bddc52ed-d1c9-c3c9-cb79-2c15d97450cc@linaro.org> (raw)
In-Reply-To: <20170118132541.8989-1-fu.wei@linaro.org>
Hi Fuwei,
On 2017/1/18 21:25, fu.wei@linaro.org wrote:
> From: Fu Wei <fu.wei@linaro.org>
>
> This patchset:
> (1)Preparation for adding GTDT support in arm_arch_timer:
> 1. Clean up printk() usage
> 2. Rename the type macros
> 3. Rename the PPI enum & enum values
> 4. Move the type macro and PPI enum into the header file
> 5. Add new enum for SPIs
> 6. Rework PPI determination;
> 7. Rework counter frequency detection;
> 8. Refactor arch_timer_needs_probing, move it into DT init call
> 9. Introduce some new structs and refactor the MMIO timer init code
> for reusing some common code.
>
> (2)Introduce ACPI GTDT parser: drivers/acpi/arm64/acpi_gtdt.c
> Parse all kinds of timer in GTDT table of ACPI:arch timer,
> memory-mapped timer and SBSA Generic Watchdog timer.
> This driver can help to simplify all the relevant timer drivers,
> and separate all the ACPI GTDT knowledge from them.
>
> (3)Simplify ACPI code for arm_arch_timer
>
> (4)Add GTDT support for ARM memory-mapped timer.
>
> This patchset has been tested on the following platforms with ACPI enabled:
> (1)ARM Foundation v8 model
>
> Changelog:
> v20: https://lkml.org/lkml/2017/1/18/
> Reorder the first 4 patches and split the 4th patches.
> Leave CNTHCTL_* as they originally were.
> Fix the bug in arch_timer_select_ppi.
> Split "Rework counter frequency detection" patch.
> Rework the arch_timer_detect_rate function.
> Improve the commit message of "Refactor MMIO timer probing".
> Rebase to 4.10.0-rc4
Other than some minor comments I raised, the patch set
looks fine to me, and I tested this patch set on D03,
the percpu arch timer works fine as before.
With the comments fixed,
Reviewed-by: Hanjun Guo <hanjun.gu@linaro.org>
Tested-by: Hanjun Guo <hanjun.gu@linaro.org>
Thanks
Hanjun
WARNING: multiple messages have this Message-ID (diff)
From: Hanjun Guo <hanjun.guo@linaro.org>
To: fu.wei@linaro.org, rjw@rjwysocki.net, lenb@kernel.org,
daniel.lezcano@linaro.org, tglx@linutronix.de,
marc.zyngier@arm.com, mark.rutland@arm.com,
lorenzo.pieralisi@arm.com, sudeep.holla@arm.com
Cc: linux-arm-kernel@lists.infradead.org,
linaro-acpi@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, rruigrok@codeaurora.org,
harba@codeaurora.org, cov@codeaurora.org, timur@codeaurora.org,
graeme.gregory@linaro.org, al.stone@linaro.org, jcm@redhat.com,
wei@redhat.com, arnd@arndb.de, catalin.marinas@arm.com,
will.deacon@arm.com, Suravee.Suthikulpanit@amd.com,
leo.duran@amd.com, wim@iguana.be, linux@roeck-us.net,
linux-watchdog@vger.kernel.org, tn@semihalf.com,
christoffer.dall@linaro.org, julien.grall@arm.com
Subject: Re: [PATCH v20 00/17] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer
Date: Thu, 19 Jan 2017 17:20:07 +0800 [thread overview]
Message-ID: <bddc52ed-d1c9-c3c9-cb79-2c15d97450cc@linaro.org> (raw)
In-Reply-To: <20170118132541.8989-1-fu.wei@linaro.org>
Hi Fuwei,
On 2017/1/18 21:25, fu.wei@linaro.org wrote:
> From: Fu Wei <fu.wei@linaro.org>
>
> This patchset:
> (1)Preparation for adding GTDT support in arm_arch_timer:
> 1. Clean up printk() usage
> 2. Rename the type macros
> 3. Rename the PPI enum & enum values
> 4. Move the type macro and PPI enum into the header file
> 5. Add new enum for SPIs
> 6. Rework PPI determination;
> 7. Rework counter frequency detection;
> 8. Refactor arch_timer_needs_probing, move it into DT init call
> 9. Introduce some new structs and refactor the MMIO timer init code
> for reusing some common code.
>
> (2)Introduce ACPI GTDT parser: drivers/acpi/arm64/acpi_gtdt.c
> Parse all kinds of timer in GTDT table of ACPI:arch timer,
> memory-mapped timer and SBSA Generic Watchdog timer.
> This driver can help to simplify all the relevant timer drivers,
> and separate all the ACPI GTDT knowledge from them.
>
> (3)Simplify ACPI code for arm_arch_timer
>
> (4)Add GTDT support for ARM memory-mapped timer.
>
> This patchset has been tested on the following platforms with ACPI enabled:
> (1)ARM Foundation v8 model
>
> Changelog:
> v20: https://lkml.org/lkml/2017/1/18/
> Reorder the first 4 patches and split the 4th patches.
> Leave CNTHCTL_* as they originally were.
> Fix the bug in arch_timer_select_ppi.
> Split "Rework counter frequency detection" patch.
> Rework the arch_timer_detect_rate function.
> Improve the commit message of "Refactor MMIO timer probing".
> Rebase to 4.10.0-rc4
Other than some minor comments I raised, the patch set
looks fine to me, and I tested this patch set on D03,
the percpu arch timer works fine as before.
With the comments fixed,
Reviewed-by: Hanjun Guo <hanjun.gu@linaro.org>
Tested-by: Hanjun Guo <hanjun.gu@linaro.org>
Thanks
Hanjun
WARNING: multiple messages have this Message-ID (diff)
From: hanjun.guo@linaro.org (Hanjun Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v20 00/17] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer
Date: Thu, 19 Jan 2017 17:20:07 +0800 [thread overview]
Message-ID: <bddc52ed-d1c9-c3c9-cb79-2c15d97450cc@linaro.org> (raw)
In-Reply-To: <20170118132541.8989-1-fu.wei@linaro.org>
Hi Fuwei,
On 2017/1/18 21:25, fu.wei at linaro.org wrote:
> From: Fu Wei <fu.wei@linaro.org>
>
> This patchset:
> (1)Preparation for adding GTDT support in arm_arch_timer:
> 1. Clean up printk() usage
> 2. Rename the type macros
> 3. Rename the PPI enum & enum values
> 4. Move the type macro and PPI enum into the header file
> 5. Add new enum for SPIs
> 6. Rework PPI determination;
> 7. Rework counter frequency detection;
> 8. Refactor arch_timer_needs_probing, move it into DT init call
> 9. Introduce some new structs and refactor the MMIO timer init code
> for reusing some common code.
>
> (2)Introduce ACPI GTDT parser: drivers/acpi/arm64/acpi_gtdt.c
> Parse all kinds of timer in GTDT table of ACPI:arch timer,
> memory-mapped timer and SBSA Generic Watchdog timer.
> This driver can help to simplify all the relevant timer drivers,
> and separate all the ACPI GTDT knowledge from them.
>
> (3)Simplify ACPI code for arm_arch_timer
>
> (4)Add GTDT support for ARM memory-mapped timer.
>
> This patchset has been tested on the following platforms with ACPI enabled:
> (1)ARM Foundation v8 model
>
> Changelog:
> v20: https://lkml.org/lkml/2017/1/18/
> Reorder the first 4 patches and split the 4th patches.
> Leave CNTHCTL_* as they originally were.
> Fix the bug in arch_timer_select_ppi.
> Split "Rework counter frequency detection" patch.
> Rework the arch_timer_detect_rate function.
> Improve the commit message of "Refactor MMIO timer probing".
> Rebase to 4.10.0-rc4
Other than some minor comments I raised, the patch set
looks fine to me, and I tested this patch set on D03,
the percpu arch timer works fine as before.
With the comments fixed,
Reviewed-by: Hanjun Guo <hanjun.gu@linaro.org>
Tested-by: Hanjun Guo <hanjun.gu@linaro.org>
Thanks
Hanjun
next prev parent reply other threads:[~2017-01-19 9:20 UTC|newest]
Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 13:25 [PATCH v20 00/17] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` [PATCH v20 01/17] clocksource/drivers/arm_arch_timer: Improve printk relevant code fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` [PATCH v20 02/17] clocksource/drivers/arm_arch_timer: Rename the timer type macros fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 03/17] clocksource/drivers/arm_arch_timer: Rename the PPI enum and its values fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` [PATCH v20 04/17] clocksource/drivers/arm_arch_timer: Move enums and defines to header file fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 05/17] clocksource/drivers/arm_arch_timer: Add a new enum for spi type fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 06/17] clocksource/drivers/arm_arch_timer: rework PPI determination fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 07/17] clocksource/drivers/arm_arch_timer: Separate out device-tree code from arch_timer_detect_rate fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 08/17] clocksource/drivers/arm_arch_timer: Rework counter frequency detection fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
[not found] ` <20170118132541.8989-9-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-01-19 8:02 ` Hanjun Guo
2017-01-19 8:02 ` Hanjun Guo
2017-01-19 8:02 ` Hanjun Guo
[not found] ` <cafa8c7a-9c7c-51ba-5566-0cfe1fe6f764-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-01-19 9:44 ` Fu Wei
2017-01-19 9:44 ` Fu Wei
2017-01-19 9:44 ` Fu Wei
2017-01-19 12:41 ` Hanjun Guo
2017-01-19 12:41 ` Hanjun Guo
2017-01-19 12:41 ` Hanjun Guo
2017-01-19 12:41 ` Hanjun Guo
2017-01-24 17:24 ` Mark Rutland
2017-01-24 17:24 ` Mark Rutland
2017-01-25 6:46 ` Fu Wei
2017-01-25 6:46 ` Fu Wei
2017-01-25 6:46 ` Fu Wei
2017-01-25 7:23 ` Fu Wei
2017-01-25 7:23 ` Fu Wei
2017-01-25 7:23 ` Fu Wei
2017-01-25 15:38 ` Christopher Covington
2017-01-25 15:38 ` Christopher Covington
2017-01-25 15:38 ` Christopher Covington
2017-01-25 17:36 ` Mark Rutland
2017-01-25 17:36 ` Mark Rutland
2017-01-25 17:36 ` Mark Rutland
2017-01-26 5:55 ` Fu Wei
2017-01-26 5:55 ` Fu Wei
2017-01-26 5:55 ` Fu Wei
2017-01-25 17:25 ` Mark Rutland
2017-01-25 17:25 ` Mark Rutland
2017-01-25 17:25 ` Mark Rutland
2017-01-26 5:49 ` Fu Wei
2017-01-26 5:49 ` Fu Wei
2017-01-26 5:49 ` Fu Wei
2017-01-30 17:49 ` Mark Rutland
2017-01-30 17:49 ` Mark Rutland
2017-01-30 17:49 ` Mark Rutland
2017-01-31 11:42 ` Mark Rutland
2017-01-31 11:42 ` Mark Rutland
2017-01-31 11:42 ` Mark Rutland
2017-01-31 18:43 ` Fu Wei
2017-01-31 18:43 ` Fu Wei
2017-01-31 18:43 ` Fu Wei
2017-01-31 18:49 ` Mark Rutland
2017-01-31 18:49 ` Mark Rutland
2017-01-31 18:49 ` Mark Rutland
2017-01-31 19:07 ` Fu Wei
2017-01-31 19:07 ` Fu Wei
2017-01-31 19:07 ` Fu Wei
2017-01-18 13:25 ` [PATCH v20 09/17] clocksource/drivers/arm_arch_timer: Refactor arch_timer_needs_probing fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 10/17] clocksource/drivers/arm_arch_timer: Move arch_timer_needs_of_probing into DT init call fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 11/17] clocksource/drivers/arm_arch_timer: Introduce some new structs to prepare for GTDT fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-19 8:28 ` Hanjun Guo
2017-01-19 8:28 ` Hanjun Guo
2017-01-19 9:47 ` Fu Wei
2017-01-19 9:47 ` Fu Wei
2017-01-19 9:47 ` Fu Wei
2017-01-18 13:25 ` [PATCH v20 12/17] clocksource/drivers/arm_arch_timer: Refactor MMIO timer probing fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 13/17] acpi/arm64: Add GTDT table parse driver fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-19 9:11 ` Hanjun Guo
2017-01-19 9:11 ` Hanjun Guo
[not found] ` <e69d80d1-0954-b1be-817e-c0be6fc24b77-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-01-19 10:32 ` Fu Wei
2017-01-19 10:32 ` Fu Wei
2017-01-19 10:32 ` Fu Wei
2017-01-19 11:16 ` Mark Rutland
2017-01-19 11:16 ` Mark Rutland
2017-01-19 11:16 ` Mark Rutland
2017-01-19 12:28 ` Fu Wei
2017-01-19 12:28 ` Fu Wei
2017-01-19 12:28 ` Fu Wei
2017-01-18 13:25 ` [PATCH v20 14/17] clocksource/drivers/arm_arch_timer: Simplify ACPI support code fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 15/17] acpi/arm64: Add memory-mapped timer support in GTDT driver fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` [PATCH v20 16/17] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
[not found] ` <20170118132541.8989-17-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-01-19 9:16 ` Hanjun Guo
2017-01-19 9:16 ` Hanjun Guo
2017-01-19 9:16 ` Hanjun Guo
2017-01-19 10:02 ` Fu Wei
2017-01-19 10:02 ` Fu Wei
2017-01-19 10:02 ` Fu Wei
2017-01-19 12:42 ` Hanjun Guo
2017-01-19 12:42 ` Hanjun Guo
2017-01-19 12:42 ` Hanjun Guo
2017-01-18 13:25 ` [PATCH v20 17/17] acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver fu.wei
2017-01-18 13:25 ` fu.wei at linaro.org
2017-01-18 13:25 ` fu.wei
2017-01-18 13:25 ` fu.wei
2017-01-19 9:20 ` Hanjun Guo [this message]
2017-01-19 9:20 ` [PATCH v20 00/17] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Hanjun Guo
2017-01-19 9:20 ` Hanjun Guo
2017-01-19 11:06 ` Fu Wei
2017-01-19 11:06 ` Fu Wei
2017-01-19 11:06 ` Fu Wei
2017-01-23 18:54 ` Mark Rutland
2017-01-23 18:54 ` Mark Rutland
2017-01-24 5:11 ` Fu Wei
2017-01-24 5:11 ` Fu Wei
2017-01-24 5:11 ` Fu Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bddc52ed-d1c9-c3c9-cb79-2c15d97450cc@linaro.org \
--to=hanjun.guo@linaro.org \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=al.stone@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=cov@codeaurora.org \
--cc=daniel.lezcano@linaro.org \
--cc=fu.wei@linaro.org \
--cc=graeme.gregory@linaro.org \
--cc=harba@codeaurora.org \
--cc=jcm@redhat.com \
--cc=julien.grall@arm.com \
--cc=lenb@kernel.org \
--cc=leo.duran@amd.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=rjw@rjwysocki.net \
--cc=rruigrok@codeaurora.org \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
--cc=tn@semihalf.com \
--cc=wei@redhat.com \
--cc=will.deacon@arm.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.