From: Linus Torvalds <torvalds@linux-foundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Kees Cook <keescook@chromium.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-hardening@vger.kernel.org,
Segher Boessenkool <segher@kernel.crashing.org>
Subject: Re: mainline build failure of powerpc allmodconfig for prom_init_check
Date: Sun, 17 Jul 2022 13:29:07 -0700 [thread overview]
Message-ID: <CAHk-=whjWyoognKy4QUUwf95L6qvPg7MGdp0CxqD2fpvZo7DLw@mail.gmail.com> (raw)
In-Reply-To: <CADVatmO1V8DiAgWMW9EFHwt+ghwfHhueigXh214tUa_=tVxiug@mail.gmail.com>
On Sun, Jul 17, 2022 at 1:25 PM Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
>
> And the generated assembly still has the memset for "struct prom_args".
Strange. That smells like a compiler bug to me.
But I can't read powerpc assembly code - it's been too many years, and
even back when I did read it I hated how the register "names" worked.
Maybe it was never the args array, and it was about the other fields.
Not that that makes any sense either, but it makes more sense than the
compiler turning a series of volatile accesses into a memset.
Linus
WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Kees Cook <keescook@chromium.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
linux-hardening@vger.kernel.org,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: mainline build failure of powerpc allmodconfig for prom_init_check
Date: Sun, 17 Jul 2022 13:29:07 -0700 [thread overview]
Message-ID: <CAHk-=whjWyoognKy4QUUwf95L6qvPg7MGdp0CxqD2fpvZo7DLw@mail.gmail.com> (raw)
In-Reply-To: <CADVatmO1V8DiAgWMW9EFHwt+ghwfHhueigXh214tUa_=tVxiug@mail.gmail.com>
On Sun, Jul 17, 2022 at 1:25 PM Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
>
> And the generated assembly still has the memset for "struct prom_args".
Strange. That smells like a compiler bug to me.
But I can't read powerpc assembly code - it's been too many years, and
even back when I did read it I hated how the register "names" worked.
Maybe it was never the args array, and it was about the other fields.
Not that that makes any sense either, but it makes more sense than the
compiler turning a series of volatile accesses into a memset.
Linus
next prev parent reply other threads:[~2022-07-17 20:29 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 8:55 mainline build failure of powerpc allmodconfig for prom_init_check Sudip Mukherjee (Codethink)
2022-07-14 8:55 ` Sudip Mukherjee (Codethink)
2022-07-17 9:12 ` Sudip Mukherjee
2022-07-17 9:12 ` Sudip Mukherjee
2022-07-17 14:44 ` Linus Torvalds
2022-07-17 14:44 ` Linus Torvalds
2022-07-17 19:54 ` Segher Boessenkool
2022-07-17 19:54 ` Segher Boessenkool
2022-07-18 3:52 ` Michael Ellerman
2022-07-18 3:52 ` Michael Ellerman
2022-07-18 14:56 ` Segher Boessenkool
2022-07-18 14:56 ` Segher Boessenkool
2022-07-17 20:25 ` Sudip Mukherjee
2022-07-17 20:25 ` Sudip Mukherjee
2022-07-17 20:29 ` Linus Torvalds [this message]
2022-07-17 20:29 ` Linus Torvalds
2022-07-17 20:38 ` Sudip Mukherjee
2022-07-17 20:38 ` Sudip Mukherjee
2022-07-17 20:56 ` Linus Torvalds
2022-07-17 20:56 ` Linus Torvalds
2022-07-17 20:56 ` Segher Boessenkool
2022-07-17 20:56 ` Segher Boessenkool
2022-07-17 21:11 ` Linus Torvalds
2022-07-17 21:11 ` Linus Torvalds
2022-07-17 21:45 ` Segher Boessenkool
2022-07-17 21:45 ` Segher Boessenkool
2022-07-18 1:38 ` Linus Torvalds
2022-07-18 1:38 ` Linus Torvalds
2022-07-18 4:41 ` Michael Ellerman
2022-07-18 4:41 ` Michael Ellerman
2022-07-18 7:51 ` David Laight
2022-07-18 7:51 ` David Laight
2022-07-18 13:44 ` [PATCH] powerpc/64s: Disable stack variable initialisation for prom_init Michael Ellerman
2022-07-18 13:44 ` Michael Ellerman
2022-07-18 15:03 ` Sudip Mukherjee
2022-07-18 15:03 ` Sudip Mukherjee
2022-07-18 18:34 ` Linus Torvalds
2022-07-18 18:34 ` Linus Torvalds
2022-07-27 12:02 ` Michael Ellerman
2022-07-18 19:06 ` mainline build failure of powerpc allmodconfig for prom_init_check Linus Torvalds
2022-07-18 19:06 ` Linus Torvalds
2022-07-18 22:08 ` Segher Boessenkool
2022-07-18 22:08 ` Segher Boessenkool
2022-07-18 22:55 ` Linus Torvalds
2022-07-18 22:55 ` Linus Torvalds
2022-07-19 13:35 ` Michael Ellerman
2022-07-19 13:35 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whjWyoognKy4QUUwf95L6qvPg7MGdp0CxqD2fpvZo7DLw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.