From: Linus Torvalds <torvalds@linux-foundation.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Kees Cook <keescook@chromium.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] powerpc/64s: Disable stack variable initialisation for prom_init
Date: Mon, 18 Jul 2022 11:34:50 -0700 [thread overview]
Message-ID: <CAHk-=wihbCSydApZcH21hev5pcKu=-CrQgwp6qmPwuv5kMpwxQ@mail.gmail.com> (raw)
In-Reply-To: <20220718134418.354114-1-mpe@ellerman.id.au>
On Mon, Jul 18, 2022 at 6:44 AM Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> With GCC 12, allmodconfig enables CONFIG_INIT_STACK_ALL_PATTERN, which
> causes the compiler to emit memset calls to initialise on-stack
> variables with a pattern.
Ahh, and that explains why "volatile" made no difference. That did
seem very odd.
Thanks for figuring it out,
Linus
WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-hardening@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] powerpc/64s: Disable stack variable initialisation for prom_init
Date: Mon, 18 Jul 2022 11:34:50 -0700 [thread overview]
Message-ID: <CAHk-=wihbCSydApZcH21hev5pcKu=-CrQgwp6qmPwuv5kMpwxQ@mail.gmail.com> (raw)
In-Reply-To: <20220718134418.354114-1-mpe@ellerman.id.au>
On Mon, Jul 18, 2022 at 6:44 AM Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> With GCC 12, allmodconfig enables CONFIG_INIT_STACK_ALL_PATTERN, which
> causes the compiler to emit memset calls to initialise on-stack
> variables with a pattern.
Ahh, and that explains why "volatile" made no difference. That did
seem very odd.
Thanks for figuring it out,
Linus
next prev parent reply other threads:[~2022-07-18 18:35 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 8:55 mainline build failure of powerpc allmodconfig for prom_init_check Sudip Mukherjee (Codethink)
2022-07-14 8:55 ` Sudip Mukherjee (Codethink)
2022-07-17 9:12 ` Sudip Mukherjee
2022-07-17 9:12 ` Sudip Mukherjee
2022-07-17 14:44 ` Linus Torvalds
2022-07-17 14:44 ` Linus Torvalds
2022-07-17 19:54 ` Segher Boessenkool
2022-07-17 19:54 ` Segher Boessenkool
2022-07-18 3:52 ` Michael Ellerman
2022-07-18 3:52 ` Michael Ellerman
2022-07-18 14:56 ` Segher Boessenkool
2022-07-18 14:56 ` Segher Boessenkool
2022-07-17 20:25 ` Sudip Mukherjee
2022-07-17 20:25 ` Sudip Mukherjee
2022-07-17 20:29 ` Linus Torvalds
2022-07-17 20:29 ` Linus Torvalds
2022-07-17 20:38 ` Sudip Mukherjee
2022-07-17 20:38 ` Sudip Mukherjee
2022-07-17 20:56 ` Linus Torvalds
2022-07-17 20:56 ` Linus Torvalds
2022-07-17 20:56 ` Segher Boessenkool
2022-07-17 20:56 ` Segher Boessenkool
2022-07-17 21:11 ` Linus Torvalds
2022-07-17 21:11 ` Linus Torvalds
2022-07-17 21:45 ` Segher Boessenkool
2022-07-17 21:45 ` Segher Boessenkool
2022-07-18 1:38 ` Linus Torvalds
2022-07-18 1:38 ` Linus Torvalds
2022-07-18 4:41 ` Michael Ellerman
2022-07-18 4:41 ` Michael Ellerman
2022-07-18 7:51 ` David Laight
2022-07-18 7:51 ` David Laight
2022-07-18 13:44 ` [PATCH] powerpc/64s: Disable stack variable initialisation for prom_init Michael Ellerman
2022-07-18 13:44 ` Michael Ellerman
2022-07-18 15:03 ` Sudip Mukherjee
2022-07-18 15:03 ` Sudip Mukherjee
2022-07-18 18:34 ` Linus Torvalds [this message]
2022-07-18 18:34 ` Linus Torvalds
2022-07-27 12:02 ` Michael Ellerman
2022-07-18 19:06 ` mainline build failure of powerpc allmodconfig for prom_init_check Linus Torvalds
2022-07-18 19:06 ` Linus Torvalds
2022-07-18 22:08 ` Segher Boessenkool
2022-07-18 22:08 ` Segher Boessenkool
2022-07-18 22:55 ` Linus Torvalds
2022-07-18 22:55 ` Linus Torvalds
2022-07-19 13:35 ` Michael Ellerman
2022-07-19 13:35 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wihbCSydApZcH21hev5pcKu=-CrQgwp6qmPwuv5kMpwxQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.