From: "Rafael J. Wysocki" <rafael@kernel.org> To: Stephen Boyd <swboyd@chromium.org> Cc: Rob Herring <robh@kernel.org>, Andrzej Hajda <a.hajda@samsung.com>, Andy Shevchenko <andy.shevchenko@gmail.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Mark Brown <broonie@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, javierm@redhat.com, Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Russell King - ARM Linux <linux@armlinux.org.uk>, Marek Szyprowski <m.szyprowski@samsung.com>, "Rafael J. Wysocki" <rafael@kernel.org> Subject: Re: [PATCH v3] driver core: platform: Add an error message to platform_get_irq*() Date: Thu, 3 Jan 2019 10:40:26 +0100 [thread overview] Message-ID: <CAJZ5v0iL_Fq0RUbLjMj9WBitDw2amNV_ybirkiPbuYb0zroGAg@mail.gmail.com> (raw) In-Reply-To: <20190102185106.56913-1-swboyd@chromium.org> On Wed, Jan 2, 2019 at 7:51 PM Stephen Boyd <swboyd@chromium.org> wrote: > > A grep of the kernel shows that many drivers print an error message if > they fail to get the irq they're looking for. Furthermore, those drivers > all decide to print the device name, or not, and the irq they were > requesting, or not, etc. Let's consolidate all these error messages into > the API itself, allowing us to get rid of the error messages in each > driver. > > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > > Changes from v2: > * Don't refactor platform_get_irq(), just wrap it > > Changes from v1: > * Update error text to indicate irq index instead of IRQn, use %u > > drivers/base/platform.c | 31 +++++++++++++++++++++++-------- > 1 file changed, 23 insertions(+), 8 deletions(-) > > diff --git a/drivers/base/platform.c b/drivers/base/platform.c > index 1c958eb33ef4..388461306dd4 100644 > --- a/drivers/base/platform.c > +++ b/drivers/base/platform.c > @@ -79,12 +79,7 @@ struct resource *platform_get_resource(struct platform_device *dev, > } > EXPORT_SYMBOL_GPL(platform_get_resource); > > -/** > - * platform_get_irq - get an IRQ for a device > - * @dev: platform device > - * @num: IRQ number index > - */ > -int platform_get_irq(struct platform_device *dev, unsigned int num) > +static int __platform_get_irq(struct platform_device *dev, unsigned int num) > { > #ifdef CONFIG_SPARC > /* sparc does not have irqs represented as IORESOURCE_IRQ resources */ > @@ -130,6 +125,22 @@ int platform_get_irq(struct platform_device *dev, unsigned int num) > return r ? r->start : -ENXIO; > #endif > } > + > +/** > + * platform_get_irq - get an IRQ for a device > + * @dev: platform device > + * @num: IRQ number index > + */ > +int platform_get_irq(struct platform_device *dev, unsigned int num) > +{ > + int ret; > + > + ret = __platform_get_irq(dev, num); > + if (ret < 0 && ret != -EPROBE_DEFER) > + dev_err(&dev->dev, "IRQ index %u not found\n", num); Why don't you log the error code too? > + > + return ret; > +} > EXPORT_SYMBOL_GPL(platform_get_irq); > > /** > @@ -142,7 +153,7 @@ int platform_irq_count(struct platform_device *dev) > { > int ret, nr = 0; > > - while ((ret = platform_get_irq(dev, nr)) >= 0) > + while ((ret = __platform_get_irq(dev, nr)) >= 0) > nr++; > > if (ret == -EPROBE_DEFER) > @@ -195,7 +206,11 @@ int platform_get_irq_byname(struct platform_device *dev, const char *name) > } > > r = platform_get_resource_byname(dev, IORESOURCE_IRQ, name); > - return r ? r->start : -ENXIO; > + if (r) > + return r->start; > + > + dev_err(&dev->dev, "IRQ %s not found\n", name); > + return -ENXIO; > } > EXPORT_SYMBOL_GPL(platform_get_irq_byname); > > -- > Sent by a computer through tubes >
WARNING: multiple messages have this Message-ID (diff)
From: "Rafael J. Wysocki" <rafael@kernel.org> To: Stephen Boyd <swboyd@chromium.org> Cc: Rob Herring <robh@kernel.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rafael@kernel.org>, javierm@redhat.com, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Andrzej Hajda <a.hajda@samsung.com>, Andy Shevchenko <andy.shevchenko@gmail.com>, Mark Brown <broonie@kernel.org>, Russell King - ARM Linux <linux@armlinux.org.uk>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Marek Szyprowski <m.szyprowski@samsung.com> Subject: Re: [PATCH v3] driver core: platform: Add an error message to platform_get_irq*() Date: Thu, 3 Jan 2019 10:40:26 +0100 [thread overview] Message-ID: <CAJZ5v0iL_Fq0RUbLjMj9WBitDw2amNV_ybirkiPbuYb0zroGAg@mail.gmail.com> (raw) In-Reply-To: <20190102185106.56913-1-swboyd@chromium.org> On Wed, Jan 2, 2019 at 7:51 PM Stephen Boyd <swboyd@chromium.org> wrote: > > A grep of the kernel shows that many drivers print an error message if > they fail to get the irq they're looking for. Furthermore, those drivers > all decide to print the device name, or not, and the irq they were > requesting, or not, etc. Let's consolidate all these error messages into > the API itself, allowing us to get rid of the error messages in each > driver. > > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > > Changes from v2: > * Don't refactor platform_get_irq(), just wrap it > > Changes from v1: > * Update error text to indicate irq index instead of IRQn, use %u > > drivers/base/platform.c | 31 +++++++++++++++++++++++-------- > 1 file changed, 23 insertions(+), 8 deletions(-) > > diff --git a/drivers/base/platform.c b/drivers/base/platform.c > index 1c958eb33ef4..388461306dd4 100644 > --- a/drivers/base/platform.c > +++ b/drivers/base/platform.c > @@ -79,12 +79,7 @@ struct resource *platform_get_resource(struct platform_device *dev, > } > EXPORT_SYMBOL_GPL(platform_get_resource); > > -/** > - * platform_get_irq - get an IRQ for a device > - * @dev: platform device > - * @num: IRQ number index > - */ > -int platform_get_irq(struct platform_device *dev, unsigned int num) > +static int __platform_get_irq(struct platform_device *dev, unsigned int num) > { > #ifdef CONFIG_SPARC > /* sparc does not have irqs represented as IORESOURCE_IRQ resources */ > @@ -130,6 +125,22 @@ int platform_get_irq(struct platform_device *dev, unsigned int num) > return r ? r->start : -ENXIO; > #endif > } > + > +/** > + * platform_get_irq - get an IRQ for a device > + * @dev: platform device > + * @num: IRQ number index > + */ > +int platform_get_irq(struct platform_device *dev, unsigned int num) > +{ > + int ret; > + > + ret = __platform_get_irq(dev, num); > + if (ret < 0 && ret != -EPROBE_DEFER) > + dev_err(&dev->dev, "IRQ index %u not found\n", num); Why don't you log the error code too? > + > + return ret; > +} > EXPORT_SYMBOL_GPL(platform_get_irq); > > /** > @@ -142,7 +153,7 @@ int platform_irq_count(struct platform_device *dev) > { > int ret, nr = 0; > > - while ((ret = platform_get_irq(dev, nr)) >= 0) > + while ((ret = __platform_get_irq(dev, nr)) >= 0) > nr++; > > if (ret == -EPROBE_DEFER) > @@ -195,7 +206,11 @@ int platform_get_irq_byname(struct platform_device *dev, const char *name) > } > > r = platform_get_resource_byname(dev, IORESOURCE_IRQ, name); > - return r ? r->start : -ENXIO; > + if (r) > + return r->start; > + > + dev_err(&dev->dev, "IRQ %s not found\n", name); > + return -ENXIO; > } > EXPORT_SYMBOL_GPL(platform_get_irq_byname); > > -- > Sent by a computer through tubes > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-03 9:40 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20181220102258eucas1p1ca5abb0b48d1f13d9234a4a7702a13da@eucas1p1.samsung.com> 2018-12-20 10:22 ` [PATCH v4 0/3] driver core: add probe error check helper Andrzej Hajda 2018-12-20 10:22 ` Andrzej Hajda [not found] ` <CGME20181220102259eucas1p2f748c68e01cd4e09a266da879722e218@eucas1p2.samsung.com> 2018-12-20 10:22 ` [PATCH v4 1/3] driver core: add probe_err log helper Andrzej Hajda 2018-12-20 10:22 ` Andrzej Hajda 2018-12-20 10:35 ` Rafael J. Wysocki 2018-12-20 10:35 ` Rafael J. Wysocki 2018-12-20 11:14 ` Greg Kroah-Hartman 2018-12-20 11:14 ` Greg Kroah-Hartman 2018-12-20 11:37 ` Andrzej Hajda 2018-12-20 11:37 ` Andrzej Hajda 2018-12-21 22:47 ` Rob Herring 2018-12-21 22:47 ` Rob Herring 2018-12-22 7:24 ` [PATCH] driver core: platform: Add an error message to platform_get_irq*() Stephen Boyd 2018-12-22 7:24 ` Stephen Boyd 2018-12-22 10:33 ` Russell King - ARM Linux 2018-12-22 10:33 ` Russell King - ARM Linux 2018-12-28 21:53 ` Stephen Boyd 2018-12-28 21:53 ` Stephen Boyd 2018-12-24 9:29 ` [PATCH v4 1/3] driver core: add probe_err log helper Andrzej Hajda 2018-12-24 9:29 ` Andrzej Hajda 2018-12-28 21:56 ` [PATCH v2] driver core: platform: Add an error message to platform_get_irq*() Stephen Boyd 2018-12-28 21:56 ` Stephen Boyd 2018-12-30 10:42 ` Andy Shevchenko 2018-12-30 10:42 ` Andy Shevchenko 2019-01-02 18:17 ` Stephen Boyd 2019-01-02 18:17 ` Stephen Boyd 2019-01-02 18:51 ` [PATCH v3] " Stephen Boyd 2019-01-02 18:51 ` Stephen Boyd 2019-01-03 9:40 ` Rafael J. Wysocki [this message] 2019-01-03 9:40 ` Rafael J. Wysocki 2019-01-03 16:11 ` Stephen Boyd 2019-01-03 16:11 ` Stephen Boyd 2019-01-03 17:22 ` Rafael J. Wysocki 2019-01-03 17:22 ` Rafael J. Wysocki 2019-01-03 17:25 ` Stephen Boyd 2019-01-03 17:25 ` Stephen Boyd 2019-01-03 17:38 ` Rafael J. Wysocki 2019-01-03 17:38 ` Rafael J. Wysocki 2019-01-03 17:51 ` Andy Shevchenko 2019-01-03 17:51 ` Andy Shevchenko [not found] ` <CGME20181220102259eucas1p1884a0b68ce342239c2a43a74cc50725a@eucas1p1.samsung.com> 2018-12-20 10:22 ` [PATCH v4 2/3] driver core: add deferring probe reason to devices_deferred property Andrzej Hajda 2018-12-20 10:22 ` Andrzej Hajda 2018-12-20 11:04 ` Rafael J. Wysocki 2018-12-20 11:04 ` Rafael J. Wysocki 2018-12-20 12:27 ` Andrzej Hajda 2018-12-20 12:27 ` Andrzej Hajda 2018-12-20 11:12 ` Greg Kroah-Hartman 2018-12-20 11:12 ` Greg Kroah-Hartman 2018-12-20 11:51 ` Andrzej Hajda 2018-12-20 11:51 ` Andrzej Hajda [not found] ` <CGME20181220102300eucas1p210735c7753688a52a73ccf026884dd11@eucas1p2.samsung.com> 2018-12-20 10:22 ` [PATCH v4 3/3] driver core: add probe_err_ptr helper Andrzej Hajda 2018-12-20 10:22 ` Andrzej Hajda 2018-12-20 11:05 ` Rafael J. Wysocki 2018-12-20 11:05 ` Rafael J. Wysocki 2018-12-20 11:14 ` Greg Kroah-Hartman 2018-12-20 11:14 ` Greg Kroah-Hartman [not found] ` <CGME20181221083246eucas1p22cade911a455344d351db6060d39ddce@eucas1p2.samsung.com> 2018-12-21 8:32 ` [PATCH] PCI: pcie-rockchip: use probe_err helpers instead of open coding Andrzej Hajda 2018-12-21 8:32 ` Andrzej Hajda 2018-12-22 5:42 ` kbuild test robot 2018-12-22 5:42 ` kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAJZ5v0iL_Fq0RUbLjMj9WBitDw2amNV_ybirkiPbuYb0zroGAg@mail.gmail.com \ --to=rafael@kernel.org \ --cc=a.hajda@samsung.com \ --cc=andy.shevchenko@gmail.com \ --cc=b.zolnierkie@samsung.com \ --cc=broonie@kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=javierm@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=m.szyprowski@samsung.com \ --cc=robh@kernel.org \ --cc=swboyd@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.