From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Rob Herring <robh@kernel.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
javierm@redhat.com,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v3] driver core: platform: Add an error message to platform_get_irq*()
Date: Thu, 3 Jan 2019 18:38:55 +0100 [thread overview]
Message-ID: <CAJZ5v0jj13UgkM+7ad8-17W_4cdOJw61FMyvshBAcybzaiea5A@mail.gmail.com> (raw)
In-Reply-To: <154653631992.15366.980047163353936345@swboyd.mtv.corp.google.com>
On Thu, Jan 3, 2019 at 6:25 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Rafael J. Wysocki (2019-01-03 09:22:56)
> > On Thu, Jan 3, 2019 at 5:12 PM Stephen Boyd <swboyd@chromium.org> wrote:
> > >
> > > I don't see much benefit to seeing -ENXIO or -EINVAL printed here, so I
> > > left out the error code.
> >
> > OK, so the value of the message is to tell the user that some driver
> > asked for an invalid IRQ, right?
>
> Yes.
OK
This can help to reduce code duplication a bit, so
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
for the v3.
WARNING: multiple messages have this Message-ID (diff)
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Rob Herring <robh@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
javierm@redhat.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Mark Brown <broonie@kernel.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v3] driver core: platform: Add an error message to platform_get_irq*()
Date: Thu, 3 Jan 2019 18:38:55 +0100 [thread overview]
Message-ID: <CAJZ5v0jj13UgkM+7ad8-17W_4cdOJw61FMyvshBAcybzaiea5A@mail.gmail.com> (raw)
In-Reply-To: <154653631992.15366.980047163353936345@swboyd.mtv.corp.google.com>
On Thu, Jan 3, 2019 at 6:25 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Rafael J. Wysocki (2019-01-03 09:22:56)
> > On Thu, Jan 3, 2019 at 5:12 PM Stephen Boyd <swboyd@chromium.org> wrote:
> > >
> > > I don't see much benefit to seeing -ENXIO or -EINVAL printed here, so I
> > > left out the error code.
> >
> > OK, so the value of the message is to tell the user that some driver
> > asked for an invalid IRQ, right?
>
> Yes.
OK
This can help to reduce code duplication a bit, so
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
for the v3.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-03 17:39 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181220102258eucas1p1ca5abb0b48d1f13d9234a4a7702a13da@eucas1p1.samsung.com>
2018-12-20 10:22 ` [PATCH v4 0/3] driver core: add probe error check helper Andrzej Hajda
2018-12-20 10:22 ` Andrzej Hajda
[not found] ` <CGME20181220102259eucas1p2f748c68e01cd4e09a266da879722e218@eucas1p2.samsung.com>
2018-12-20 10:22 ` [PATCH v4 1/3] driver core: add probe_err log helper Andrzej Hajda
2018-12-20 10:22 ` Andrzej Hajda
2018-12-20 10:35 ` Rafael J. Wysocki
2018-12-20 10:35 ` Rafael J. Wysocki
2018-12-20 11:14 ` Greg Kroah-Hartman
2018-12-20 11:14 ` Greg Kroah-Hartman
2018-12-20 11:37 ` Andrzej Hajda
2018-12-20 11:37 ` Andrzej Hajda
2018-12-21 22:47 ` Rob Herring
2018-12-21 22:47 ` Rob Herring
2018-12-22 7:24 ` [PATCH] driver core: platform: Add an error message to platform_get_irq*() Stephen Boyd
2018-12-22 7:24 ` Stephen Boyd
2018-12-22 10:33 ` Russell King - ARM Linux
2018-12-22 10:33 ` Russell King - ARM Linux
2018-12-28 21:53 ` Stephen Boyd
2018-12-28 21:53 ` Stephen Boyd
2018-12-24 9:29 ` [PATCH v4 1/3] driver core: add probe_err log helper Andrzej Hajda
2018-12-24 9:29 ` Andrzej Hajda
2018-12-28 21:56 ` [PATCH v2] driver core: platform: Add an error message to platform_get_irq*() Stephen Boyd
2018-12-28 21:56 ` Stephen Boyd
2018-12-30 10:42 ` Andy Shevchenko
2018-12-30 10:42 ` Andy Shevchenko
2019-01-02 18:17 ` Stephen Boyd
2019-01-02 18:17 ` Stephen Boyd
2019-01-02 18:51 ` [PATCH v3] " Stephen Boyd
2019-01-02 18:51 ` Stephen Boyd
2019-01-03 9:40 ` Rafael J. Wysocki
2019-01-03 9:40 ` Rafael J. Wysocki
2019-01-03 16:11 ` Stephen Boyd
2019-01-03 16:11 ` Stephen Boyd
2019-01-03 17:22 ` Rafael J. Wysocki
2019-01-03 17:22 ` Rafael J. Wysocki
2019-01-03 17:25 ` Stephen Boyd
2019-01-03 17:25 ` Stephen Boyd
2019-01-03 17:38 ` Rafael J. Wysocki [this message]
2019-01-03 17:38 ` Rafael J. Wysocki
2019-01-03 17:51 ` Andy Shevchenko
2019-01-03 17:51 ` Andy Shevchenko
[not found] ` <CGME20181220102259eucas1p1884a0b68ce342239c2a43a74cc50725a@eucas1p1.samsung.com>
2018-12-20 10:22 ` [PATCH v4 2/3] driver core: add deferring probe reason to devices_deferred property Andrzej Hajda
2018-12-20 10:22 ` Andrzej Hajda
2018-12-20 11:04 ` Rafael J. Wysocki
2018-12-20 11:04 ` Rafael J. Wysocki
2018-12-20 12:27 ` Andrzej Hajda
2018-12-20 12:27 ` Andrzej Hajda
2018-12-20 11:12 ` Greg Kroah-Hartman
2018-12-20 11:12 ` Greg Kroah-Hartman
2018-12-20 11:51 ` Andrzej Hajda
2018-12-20 11:51 ` Andrzej Hajda
[not found] ` <CGME20181220102300eucas1p210735c7753688a52a73ccf026884dd11@eucas1p2.samsung.com>
2018-12-20 10:22 ` [PATCH v4 3/3] driver core: add probe_err_ptr helper Andrzej Hajda
2018-12-20 10:22 ` Andrzej Hajda
2018-12-20 11:05 ` Rafael J. Wysocki
2018-12-20 11:05 ` Rafael J. Wysocki
2018-12-20 11:14 ` Greg Kroah-Hartman
2018-12-20 11:14 ` Greg Kroah-Hartman
[not found] ` <CGME20181221083246eucas1p22cade911a455344d351db6060d39ddce@eucas1p2.samsung.com>
2018-12-21 8:32 ` [PATCH] PCI: pcie-rockchip: use probe_err helpers instead of open coding Andrzej Hajda
2018-12-21 8:32 ` Andrzej Hajda
2018-12-22 5:42 ` kbuild test robot
2018-12-22 5:42 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0jj13UgkM+7ad8-17W_4cdOJw61FMyvshBAcybzaiea5A@mail.gmail.com \
--to=rafael@kernel.org \
--cc=a.hajda@samsung.com \
--cc=andy.shevchenko@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=javierm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=robh@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.