From: Miklos Szeredi <miklos@szeredi.hu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Bernd Schubert <bernd.schubert@fastmail.fm>,
Daniel Rosenberg <drosen@google.com>,
Paul Lawrence <paullawrence@google.com>,
Alessio Balsini <balsini@android.com>,
Christian Brauner <brauner@kernel.org>,
fuse-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org,
Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH v14 00/12] FUSE passthrough for file io
Date: Wed, 29 Nov 2023 15:13:50 +0100 [thread overview]
Message-ID: <CAJfpegsoz12HRBeXzjX+x37fSdzedshOMYbcWS1QtG4add6Nfg@mail.gmail.com> (raw)
In-Reply-To: <CAOQ4uxh6sd0Eeu8z-CpCD1KEiydvQO6AagU93RQv67pAzWXFvQ@mail.gmail.com>
On Wed, 29 Nov 2023 at 08:25, Amir Goldstein <amir73il@gmail.com> wrote:
> My proposed solution is to change the semantics with the init flag
> FUSE_PASSTHROUGH to disallow mmap on FOPEN_DIRECT_IO
> files.
Why? FOPEN_DIRECT_IO and FUSE_PASSTHROUGH should mix much more
readily than FOPEN_DIRECT_IO with page cache.
> So with a filesystem that supports FUSE_PASSTHROUGH,
> FOPEN_DIRECT_IO files can only be used for direct read/write io and
> mmap maps either the fuse inode pages or the backing inode pages.
>
> This also means that FUSE_DIRECT_IO_RELAX conflicts with
> FUSE_PASSTHROUGH.
>
> Should we also deny mixing FUSE_HAS_INODE_DAX with
> FUSE_PASSTHROUGH? Anything else from virtiofs?
Virtiofs/DAX and passthrough are similar features in totally different
environments. We just need to make sure the code paths don't
collide.
> While I have your attention, I am trying to consolidate the validation
> of FOPEN_ mode vs inode state into fuse_finish_open().
>
> What do you think about this partial patch that also moves
> fuse_finish_open() to after fuse_release_nowrite().
> Is it legit?
I suspect it won't work due to the i_size reset being in
fuse_finish_open(). But I feel there's not enough context to
understand why this is needed.
Thanks,
Miklos
next prev parent reply other threads:[~2023-11-29 14:14 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 16:08 [PATCH v14 00/12] FUSE passthrough for file io Amir Goldstein
2023-10-16 16:08 ` [PATCH v14 01/12] fs: prepare for stackable filesystems backing file helpers Amir Goldstein
2023-10-16 16:08 ` [PATCH v14 02/12] fs: factor out backing_file_{read,write}_iter() helpers Amir Goldstein
2023-10-16 16:08 ` [PATCH v14 03/12] fs: factor out backing_file_splice_{read,write}() helpers Amir Goldstein
2023-10-16 16:08 ` [PATCH v14 04/12] fs: factor out backing_file_mmap() helper Amir Goldstein
2023-10-16 16:08 ` [PATCH v14 05/12] fuse: factor out helper for FUSE_DEV_IOC_CLONE Amir Goldstein
2023-10-16 16:08 ` [PATCH v14 06/12] fuse: introduce FUSE_PASSTHROUGH capability Amir Goldstein
2023-10-16 16:08 ` [PATCH v14 07/12] fuse: pass optional backing_id in struct fuse_open_out Amir Goldstein
2023-10-16 16:08 ` [PATCH v14 08/12] fuse: implement ioctls to manage backing files Amir Goldstein
2023-10-17 9:45 ` Amir Goldstein
2023-10-16 16:08 ` [PATCH v14 09/12] fuse: implement read/write passthrough Amir Goldstein
2023-10-16 16:09 ` [PATCH v14 10/12] fuse: implement splice_{read/write} passthrough Amir Goldstein
2023-10-16 16:09 ` [PATCH v14 11/12] fuse: implement passthrough for mmap Amir Goldstein
2023-10-16 16:09 ` [PATCH v14 12/12] fuse: implement passthrough for readdir Amir Goldstein
2023-10-19 14:33 ` [PATCH v14 00/12] FUSE passthrough for file io Amir Goldstein
2023-10-30 10:16 ` Miklos Szeredi
2023-10-31 10:28 ` Amir Goldstein
2023-10-31 11:16 ` Miklos Szeredi
2023-10-31 12:31 ` Amir Goldstein
2023-10-31 15:01 ` Miklos Szeredi
2023-10-31 17:44 ` Amir Goldstein
2023-11-01 11:32 ` Miklos Szeredi
2023-11-01 13:23 ` Amir Goldstein
2023-11-01 14:42 ` Miklos Szeredi
2023-11-01 15:06 ` Amir Goldstein
2023-11-01 15:25 ` Miklos Szeredi
2023-11-01 18:32 ` Amir Goldstein
2023-11-02 10:46 ` Miklos Szeredi
2023-11-02 13:07 ` Amir Goldstein
2023-11-02 13:13 ` Miklos Szeredi
2024-01-26 12:13 ` Amir Goldstein
2023-11-29 7:25 ` Amir Goldstein
2023-11-29 14:13 ` Miklos Szeredi [this message]
2023-11-29 15:06 ` Amir Goldstein
2023-11-29 15:21 ` Miklos Szeredi
2023-11-29 15:52 ` Amir Goldstein
2023-11-29 16:55 ` Miklos Szeredi
2023-11-29 17:39 ` Amir Goldstein
2023-11-29 20:46 ` Bernd Schubert
2023-11-29 21:39 ` Antonio SJ Musumeci
2023-11-29 22:01 ` Bernd Schubert
2023-11-30 7:29 ` Amir Goldstein
2023-11-30 7:12 ` Amir Goldstein
2023-11-30 8:17 ` Miklos Szeredi
2023-12-06 9:59 ` Amir Goldstein
2023-12-06 23:11 ` Bernd Schubert
2023-12-07 7:23 ` Amir Goldstein
2023-12-07 8:56 ` Bernd Schubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJfpegsoz12HRBeXzjX+x37fSdzedshOMYbcWS1QtG4add6Nfg@mail.gmail.com \
--to=miklos@szeredi.hu \
--cc=amir73il@gmail.com \
--cc=balsini@android.com \
--cc=bernd.schubert@fastmail.fm \
--cc=brauner@kernel.org \
--cc=david@fromorbit.com \
--cc=drosen@google.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=paullawrence@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.