From: Masahiro Yamada <yamada.masahiro@socionext.com> To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> Cc: rui.zhang@intel.com, Eduardo Valentin <edubezval@gmail.com>, linux-pm@vger.kernel.org, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Masami Hiramatsu <masami.hiramatsu@linaro.org>, Jassi Brar <jaswinder.singh@linaro.org> Subject: Re: [PATCH 2/4] dt-bindings: thermal: add binding documentation for UniPhier thermal monitor Date: Tue, 6 Jun 2017 11:46:26 +0900 [thread overview] Message-ID: <CAK7LNAS-1+p7u4RMuF5FVNyuSHvX+SfAYk4+YbQSdEaAVma=zg@mail.gmail.com> (raw) In-Reply-To: <1496049345-14649-3-git-send-email-hayashi.kunihiko@socionext.com> 2017-05-29 18:15 GMT+09:00 Kunihiko Hayashi <hayashi.kunihiko@socionext.com>: > Add devicetree binding documentation for thermal monitor implemented on > Socionext UniPhier SoCs. > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > --- > .../bindings/thermal/uniphier-thermal.txt | 54 ++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/uniphier-thermal.txt > > diff --git a/Documentation/devicetree/bindings/thermal/uniphier-thermal.txt b/Documentation/devicetree/bindings/thermal/uniphier-thermal.txt > new file mode 100644 > index 0000000..72834e1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/uniphier-thermal.txt > @@ -0,0 +1,54 @@ > +* UniPhier Thermal bindings > + > +This describes the devicetree bindings for thermal monitor supported by > +PVT(Process, Voltage and Temperature) monitoring unit implemented on Socionext > +UniPhier SoCs. This paragraph implies this might be a HWMON driver if more features are implemented, but I assume you use only the Temperature part for a thermal driver at the moment. (I do not know if other sensors are useful or not, so I do not mind it much.) > +Required properties: > +- compatible : > + - "socionext,uniphier-pxs2-thermal" : For UniPhier PXs2 SoC > + - "socionext,uniphier-ld20-thermal" : For UniPhier LD20 SoC > +- reg : Offset address of the thermal registers from sysctrl This "reg" does not exist in the example. Your driver code uses regmap for register access. > +- interrupts : IRQ for the temperature alarm > +- #thermal-sensor-cells : Should be 0. See ./thermal.txt for details. > + > +Optional properties: > +- socionext,tmod-calibration: A pair of calibrated values referred from PVT, > + in case that the values aren't set on SoC, > + like a reference board. > + > +Example: > + > + sysctrl@61840000 { > + compatible = "socionext,uniphier-ld20-sysctrl", > + "simple-mfd", "syscon"; > + reg = <0x61840000 0x10000>; > + ... > + pvtctl: pvtctl { > + compatible = "socionext,uniphier-ld20-thermal"; > + interrupts = <0 3 1>; > + #thermal-sensor-cells = <0>; > + }; > + ... > + }; > + > + thermal-zones { > + cpu_thermal { > + polling-delay-passive = <250>; /* 250ms */ > + polling-delay = <1000>; /* 1000ms */ > + thermal-sensors = <&pvtctl>; > + > + trips { > + cpu_crit: cpu_crit { > + temperature = <95000>; /* 95C */ > + hysteresis = <2000>; > + type = "critical"; > + }; > + cpu_alert: cpu_alert { > + temperature = <85000>; /* 85C */ > + hysteresis = <2000>; > + type = "passive"; > + }; > + }; > + }; > + }; > -- > 2.7.4 > -- Best Regards Masahiro Yamada
WARNING: multiple messages have this Message-ID (diff)
From: yamada.masahiro@socionext.com (Masahiro Yamada) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/4] dt-bindings: thermal: add binding documentation for UniPhier thermal monitor Date: Tue, 6 Jun 2017 11:46:26 +0900 [thread overview] Message-ID: <CAK7LNAS-1+p7u4RMuF5FVNyuSHvX+SfAYk4+YbQSdEaAVma=zg@mail.gmail.com> (raw) In-Reply-To: <1496049345-14649-3-git-send-email-hayashi.kunihiko@socionext.com> 2017-05-29 18:15 GMT+09:00 Kunihiko Hayashi <hayashi.kunihiko@socionext.com>: > Add devicetree binding documentation for thermal monitor implemented on > Socionext UniPhier SoCs. > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > --- > .../bindings/thermal/uniphier-thermal.txt | 54 ++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/uniphier-thermal.txt > > diff --git a/Documentation/devicetree/bindings/thermal/uniphier-thermal.txt b/Documentation/devicetree/bindings/thermal/uniphier-thermal.txt > new file mode 100644 > index 0000000..72834e1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/uniphier-thermal.txt > @@ -0,0 +1,54 @@ > +* UniPhier Thermal bindings > + > +This describes the devicetree bindings for thermal monitor supported by > +PVT(Process, Voltage and Temperature) monitoring unit implemented on Socionext > +UniPhier SoCs. This paragraph implies this might be a HWMON driver if more features are implemented, but I assume you use only the Temperature part for a thermal driver at the moment. (I do not know if other sensors are useful or not, so I do not mind it much.) > +Required properties: > +- compatible : > + - "socionext,uniphier-pxs2-thermal" : For UniPhier PXs2 SoC > + - "socionext,uniphier-ld20-thermal" : For UniPhier LD20 SoC > +- reg : Offset address of the thermal registers from sysctrl This "reg" does not exist in the example. Your driver code uses regmap for register access. > +- interrupts : IRQ for the temperature alarm > +- #thermal-sensor-cells : Should be 0. See ./thermal.txt for details. > + > +Optional properties: > +- socionext,tmod-calibration: A pair of calibrated values referred from PVT, > + in case that the values aren't set on SoC, > + like a reference board. > + > +Example: > + > + sysctrl at 61840000 { > + compatible = "socionext,uniphier-ld20-sysctrl", > + "simple-mfd", "syscon"; > + reg = <0x61840000 0x10000>; > + ... > + pvtctl: pvtctl { > + compatible = "socionext,uniphier-ld20-thermal"; > + interrupts = <0 3 1>; > + #thermal-sensor-cells = <0>; > + }; > + ... > + }; > + > + thermal-zones { > + cpu_thermal { > + polling-delay-passive = <250>; /* 250ms */ > + polling-delay = <1000>; /* 1000ms */ > + thermal-sensors = <&pvtctl>; > + > + trips { > + cpu_crit: cpu_crit { > + temperature = <95000>; /* 95C */ > + hysteresis = <2000>; > + type = "critical"; > + }; > + cpu_alert: cpu_alert { > + temperature = <85000>; /* 85C */ > + hysteresis = <2000>; > + type = "passive"; > + }; > + }; > + }; > + }; > -- > 2.7.4 > -- Best Regards Masahiro Yamada
next prev parent reply other threads:[~2017-06-06 2:46 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-29 9:15 [PATCH 0/4] add UniPhier thermal support Kunihiko Hayashi 2017-05-29 9:15 ` Kunihiko Hayashi 2017-05-29 9:15 ` [PATCH 1/4] thermal: uniphier: add UniPhier thermal driver Kunihiko Hayashi 2017-05-29 9:15 ` Kunihiko Hayashi 2017-05-29 9:15 ` Kunihiko Hayashi 2017-05-29 10:23 ` Keerthy 2017-05-29 10:23 ` Keerthy 2017-05-29 10:23 ` Keerthy 2017-05-30 2:47 ` Kunihiko Hayashi 2017-05-30 2:47 ` Kunihiko Hayashi 2017-05-30 2:47 ` Kunihiko Hayashi 2017-05-30 3:21 ` Keerthy 2017-05-30 3:21 ` Keerthy 2017-05-30 3:21 ` Keerthy 2017-05-30 4:09 ` Kunihiko Hayashi 2017-05-30 4:09 ` Kunihiko Hayashi 2017-05-30 4:09 ` Kunihiko Hayashi 2017-05-29 16:48 ` Eduardo Valentin 2017-05-29 16:48 ` Eduardo Valentin 2017-05-30 9:21 ` Kunihiko Hayashi 2017-05-30 9:21 ` Kunihiko Hayashi 2017-06-05 8:42 ` Masahiro Yamada 2017-06-05 8:42 ` Masahiro Yamada 2017-06-05 8:42 ` Masahiro Yamada 2017-05-29 9:15 ` [PATCH 2/4] dt-bindings: thermal: add binding documentation for UniPhier thermal monitor Kunihiko Hayashi 2017-05-29 9:15 ` Kunihiko Hayashi 2017-06-05 17:28 ` Rob Herring 2017-06-05 17:28 ` Rob Herring 2017-06-06 2:46 ` Masahiro Yamada [this message] 2017-06-06 2:46 ` Masahiro Yamada 2017-05-29 9:15 ` [PATCH 3/4] ARM: dts: uniphier: add nodes of thermal monitor and thermal zone for PXs2 Kunihiko Hayashi 2017-05-29 9:15 ` Kunihiko Hayashi 2017-05-29 16:30 ` Eduardo Valentin 2017-05-29 16:30 ` Eduardo Valentin 2017-05-30 9:25 ` Kunihiko Hayashi 2017-05-30 9:25 ` Kunihiko Hayashi 2017-05-30 9:25 ` Kunihiko Hayashi 2017-05-29 9:15 ` [PATCH 4/4] arm64: dts: uniphier: add nodes of thermal monitor and thermal zone for LD20 Kunihiko Hayashi 2017-05-29 9:15 ` Kunihiko Hayashi 2017-06-06 3:04 ` Masahiro Yamada 2017-06-06 3:04 ` Masahiro Yamada
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAK7LNAS-1+p7u4RMuF5FVNyuSHvX+SfAYk4+YbQSdEaAVma=zg@mail.gmail.com' \ --to=yamada.masahiro@socionext.com \ --cc=devicetree@vger.kernel.org \ --cc=edubezval@gmail.com \ --cc=hayashi.kunihiko@socionext.com \ --cc=jaswinder.singh@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=masami.hiramatsu@linaro.org \ --cc=robh+dt@kernel.org \ --cc=rui.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.