From: Arnd Bergmann <arnd@arndb.de>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Nicolas Pitre <nico@fluxnic.net>,
Jani Nikula <jani.nikula@linux.intel.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Leon Romanovsky <leon@kernel.org>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Jernej Skrabec <jernej.skrabec@siol.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>
Subject: Re: [RFC PATCH 2/2] net/mlx5: Kconfig: Use "uses" instead of "imply"
Date: Fri, 17 Apr 2020 10:08:26 +0200 [thread overview]
Message-ID: <CAK8P3a22OtR5x01iNaSpJ3kM0MBd+dJshKOe6Cp42zukme2A+A@mail.gmail.com> (raw)
In-Reply-To: <20200417011146.83973-2-saeedm@mellanox.com>
On Fri, Apr 17, 2020 at 3:12 AM Saeed Mahameed <saeedm@mellanox.com> wrote:
> @@ -7,10 +7,10 @@ config MLX5_CORE
> tristate "Mellanox 5th generation network adapters (ConnectX series) core driver"
> depends on PCI
> select NET_DEVLINK
> - imply PTP_1588_CLOCK
> - imply VXLAN
> - imply MLXFW
> - imply PCI_HYPERV_INTERFACE
> + uses PTP_1588_CLOCK
> + uses VXLAN
> + uses MLXFW
> + uses PCI_HYPERV_INTERFACE
I have confirmed in the meantime that changing the PCI_HYPERV_INTERFACE
dependency is indeed required, in addition to PTP_1588_CLOCK and VXLAN
that the randconfig tests found earlier:
x86_64-linux-ld: drivers/net/ethernet/mellanox/mlx5/core/main.o: in
function `mlx5_unload':
main.c:(.text+0x325): undefined reference to `mlx5_hv_vhca_cleanup'
I also checked that there is no link failure with MLX5_CORE=y and MLXFW=m,
but only because of an IS_REACHABLE() check in mlxfw/mlxfw.h.
I suppose that should be changed back to IS_ENABLED() now along with
the Kconfig check.
Arnd
next prev parent reply other threads:[~2020-04-17 8:08 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 1:11 [RFC PATCH 1/2] Kconfig: Introduce "uses" keyword Saeed Mahameed
2020-04-17 1:11 ` [RFC PATCH 2/2] net/mlx5: Kconfig: Use "uses" instead of "imply" Saeed Mahameed
2020-04-17 8:08 ` Arnd Bergmann [this message]
2020-04-17 6:23 ` [RFC PATCH 1/2] Kconfig: Introduce "uses" keyword Jani Nikula
2020-04-17 6:23 ` Jani Nikula
2020-04-17 12:28 ` Jason Gunthorpe
2020-04-17 14:01 ` Jani Nikula
2020-04-17 14:07 ` Jason Gunthorpe
2020-04-17 10:24 ` Arnd Bergmann
2020-04-17 11:35 ` Saeed Mahameed
2020-04-17 11:35 ` Saeed Mahameed
2020-04-18 19:00 ` Masahiro Yamada
2020-04-18 19:11 ` Nicolas Pitre
2020-04-18 20:07 ` Masahiro Yamada
2020-04-20 8:43 ` Jani Nikula
2020-04-20 18:42 ` Jakub Kicinski
2020-04-21 4:24 ` Saeed Mahameed
2020-04-21 4:24 ` Saeed Mahameed
2020-04-21 13:58 ` Nicolas Pitre
2020-04-21 13:58 ` Nicolas Pitre
2020-04-21 16:30 ` Saeed Mahameed
2020-04-21 16:30 ` Saeed Mahameed
2020-04-21 18:23 ` Nicolas Pitre
2020-04-21 18:23 ` Nicolas Pitre
2020-04-22 8:51 ` Jani Nikula
2020-04-22 8:51 ` Jani Nikula
2020-04-22 21:13 ` Nicolas Pitre
2020-04-22 21:13 ` Nicolas Pitre
2020-04-22 22:37 ` Randy Dunlap
2020-04-22 22:37 ` Randy Dunlap
2020-04-23 15:01 ` Nicolas Pitre
2020-04-23 15:01 ` Nicolas Pitre
2020-04-23 15:05 ` Jason Gunthorpe
2020-04-23 15:05 ` Jason Gunthorpe
2020-04-23 15:11 ` Nicolas Pitre
2020-04-23 15:11 ` Nicolas Pitre
2020-04-23 15:16 ` Jason Gunthorpe
2020-04-23 15:16 ` Jason Gunthorpe
2020-04-23 15:28 ` Arnd Bergmann
2020-04-23 15:28 ` Arnd Bergmann
2020-04-23 15:33 ` Nicolas Pitre
2020-04-23 15:33 ` Nicolas Pitre
2020-04-23 18:30 ` Jason Gunthorpe
2020-04-23 18:30 ` Jason Gunthorpe
2020-04-23 18:52 ` Nicolas Pitre
2020-04-23 18:52 ` Nicolas Pitre
2020-04-20 13:53 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a22OtR5x01iNaSpJ3kM0MBd+dJshKOe6Cp42zukme2A+A@mail.gmail.com \
--to=arnd@arndb.de \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=jani.nikula@linux.intel.com \
--cc=jernej.skrabec@siol.net \
--cc=jgg@ziepe.ca \
--cc=jonas@kwiboo.se \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=leon@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.