From: Viresh Kumar <viresh.kumar@linaro.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: "cpufreq: fix serialization issues with freq change notifiers" breaks cpufreq too
Date: Tue, 10 Sep 2013 15:38:31 +0000 [thread overview]
Message-ID: <CAKohpomBBKLhNemVUpUHAftGhPJJe+ZB7T_9UYLD7LwpR1nK0g@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1309101656150.16010@axis700.grange>
On 10 September 2013 20:42, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> 4. reverted that commit, resolving a trivial conflict. Added a debug
> output in __cpufreq_driver_target() of
>
>
> if (cpufreq_disabled())
> return -ENODEV;
> + pr_info("%s() %d\n", __func__, policy->transition_ongoing);
> if (policy->transition_ongoing)
> return -EBUSY;
Are you sure this diff is on linux-next and not after the revert that
you mentioned later in the mail? There is some locking introduced
by my patch which I can't see in you diff..
> Built and booted, got
>
> cpufreq: __cpufreq_driver_target(): 1
>
> printed out 4 times from the beginning.
>
> 5. tried
>
> echo powersave > /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
>
> the above output appeared 2 more times - no frequency change resulted.
>
> 6. reverted commit dceff5ce18801dddc220d6238628619c93bc3cb6, built booted
> - cpufreq works again.
>
>> I am afraid you need to give us some more information on how it broke
>> your stuff.. :)
>
> Hope the above is enough.
A bit more would be helpful.. Can you add these debug prints to all the places
where transition_ongoing is getting modified? with %s, __func__ to distinguish
them better? That will make it a bit easy for me...
Also, what's the configuration of your system? How many CPUs? And are all
of them sharing clock? (I believe yes, as you are using cpufreq-cpu0)..
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Greg KH <greg@kroah.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
SH-Linux <linux-sh@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: "cpufreq: fix serialization issues with freq change notifiers" breaks cpufreq too
Date: Tue, 10 Sep 2013 20:56:31 +0530 [thread overview]
Message-ID: <CAKohpomBBKLhNemVUpUHAftGhPJJe+ZB7T_9UYLD7LwpR1nK0g@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1309101656150.16010@axis700.grange>
On 10 September 2013 20:42, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> 4. reverted that commit, resolving a trivial conflict. Added a debug
> output in __cpufreq_driver_target() of
>
>
> if (cpufreq_disabled())
> return -ENODEV;
> + pr_info("%s() %d\n", __func__, policy->transition_ongoing);
> if (policy->transition_ongoing)
> return -EBUSY;
Are you sure this diff is on linux-next and not after the revert that
you mentioned later in the mail? There is some locking introduced
by my patch which I can't see in you diff..
> Built and booted, got
>
> cpufreq: __cpufreq_driver_target(): 1
>
> printed out 4 times from the beginning.
>
> 5. tried
>
> echo powersave > /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
>
> the above output appeared 2 more times - no frequency change resulted.
>
> 6. reverted commit dceff5ce18801dddc220d6238628619c93bc3cb6, built booted
> - cpufreq works again.
>
>> I am afraid you need to give us some more information on how it broke
>> your stuff.. :)
>
> Hope the above is enough.
A bit more would be helpful.. Can you add these debug prints to all the places
where transition_ongoing is getting modified? with %s, __func__ to distinguish
them better? That will make it a bit easy for me...
Also, what's the configuration of your system? How many CPUs? And are all
of them sharing clock? (I believe yes, as you are using cpufreq-cpu0)..
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Greg KH <greg@kroah.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
SH-Linux <linux-sh@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: "cpufreq: fix serialization issues with freq change notifiers" breaks cpufreq too
Date: Tue, 10 Sep 2013 20:56:31 +0530 [thread overview]
Message-ID: <CAKohpomBBKLhNemVUpUHAftGhPJJe+ZB7T_9UYLD7LwpR1nK0g@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1309101656150.16010@axis700.grange>
On 10 September 2013 20:42, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> 4. reverted that commit, resolving a trivial conflict. Added a debug
> output in __cpufreq_driver_target() of
>
>
> if (cpufreq_disabled())
> return -ENODEV;
> + pr_info("%s() %d\n", __func__, policy->transition_ongoing);
> if (policy->transition_ongoing)
> return -EBUSY;
Are you sure this diff is on linux-next and not after the revert that
you mentioned later in the mail? There is some locking introduced
by my patch which I can't see in you diff..
> Built and booted, got
>
> cpufreq: __cpufreq_driver_target(): 1
>
> printed out 4 times from the beginning.
>
> 5. tried
>
> echo powersave > /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
>
> the above output appeared 2 more times - no frequency change resulted.
>
> 6. reverted commit dceff5ce18801dddc220d6238628619c93bc3cb6, built booted
> - cpufreq works again.
>
>> I am afraid you need to give us some more information on how it broke
>> your stuff.. :)
>
> Hope the above is enough.
A bit more would be helpful.. Can you add these debug prints to all the places
where transition_ongoing is getting modified? with %s, __func__ to distinguish
them better? That will make it a bit easy for me...
Also, what's the configuration of your system? How many CPUs? And are all
of them sharing clock? (I believe yes, as you are using cpufreq-cpu0)..
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: "cpufreq: fix serialization issues with freq change notifiers" breaks cpufreq too
Date: Tue, 10 Sep 2013 20:56:31 +0530 [thread overview]
Message-ID: <CAKohpomBBKLhNemVUpUHAftGhPJJe+ZB7T_9UYLD7LwpR1nK0g@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1309101656150.16010@axis700.grange>
On 10 September 2013 20:42, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> 4. reverted that commit, resolving a trivial conflict. Added a debug
> output in __cpufreq_driver_target() of
>
>
> if (cpufreq_disabled())
> return -ENODEV;
> + pr_info("%s() %d\n", __func__, policy->transition_ongoing);
> if (policy->transition_ongoing)
> return -EBUSY;
Are you sure this diff is on linux-next and not after the revert that
you mentioned later in the mail? There is some locking introduced
by my patch which I can't see in you diff..
> Built and booted, got
>
> cpufreq: __cpufreq_driver_target(): 1
>
> printed out 4 times from the beginning.
>
> 5. tried
>
> echo powersave > /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
>
> the above output appeared 2 more times - no frequency change resulted.
>
> 6. reverted commit dceff5ce18801dddc220d6238628619c93bc3cb6, built booted
> - cpufreq works again.
>
>> I am afraid you need to give us some more information on how it broke
>> your stuff.. :)
>
> Hope the above is enough.
A bit more would be helpful.. Can you add these debug prints to all the places
where transition_ongoing is getting modified? with %s, __func__ to distinguish
them better? That will make it a bit easy for me...
Also, what's the configuration of your system? How many CPUs? And are all
of them sharing clock? (I believe yes, as you are using cpufreq-cpu0)..
next prev parent reply other threads:[~2013-09-10 15:38 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 15:11 "cpufreq: fix serialization issues with freq change notifiers" breaks cpufreq too Guennadi Liakhovetski
2013-09-09 15:11 ` Guennadi Liakhovetski
2013-09-09 15:11 ` Guennadi Liakhovetski
2013-09-09 15:11 ` Guennadi Liakhovetski
2013-09-09 20:57 ` Rafael J. Wysocki
2013-09-09 21:08 ` Rafael J. Wysocki
2013-09-09 21:08 ` Rafael J. Wysocki
2013-09-09 21:42 ` Guennadi Liakhovetski
2013-09-09 21:42 ` Guennadi Liakhovetski
2013-09-09 21:42 ` Guennadi Liakhovetski
2013-09-09 23:12 ` Rafael J. Wysocki
2013-09-09 23:12 ` Rafael J. Wysocki
2013-09-09 23:12 ` Rafael J. Wysocki
2013-09-10 1:46 ` Rafael J. Wysocki
2013-09-10 1:46 ` Rafael J. Wysocki
2013-09-10 11:29 ` Viresh Kumar
2013-09-10 11:41 ` Viresh Kumar
2013-09-10 11:29 ` Viresh Kumar
2013-09-10 11:29 ` Viresh Kumar
2013-09-10 11:49 ` Rafael J. Wysocki
2013-09-10 11:49 ` Rafael J. Wysocki
2013-09-10 11:49 ` Rafael J. Wysocki
2013-09-10 11:49 ` Rafael J. Wysocki
2013-09-10 15:14 ` Viresh Kumar
2013-09-10 15:26 ` Viresh Kumar
2013-09-10 15:14 ` Viresh Kumar
2013-09-10 15:14 ` Viresh Kumar
2013-09-10 19:46 ` Rafael J. Wysocki
2013-09-10 19:46 ` Rafael J. Wysocki
2013-09-10 19:46 ` Rafael J. Wysocki
2013-09-10 19:46 ` Rafael J. Wysocki
2013-09-11 8:38 ` Viresh Kumar
2013-09-11 8:50 ` Viresh Kumar
2013-09-11 8:38 ` Viresh Kumar
2013-09-11 8:38 ` Viresh Kumar
2013-09-11 13:18 ` Rafael J. Wysocki
2013-09-11 13:18 ` Rafael J. Wysocki
2013-09-11 13:18 ` Rafael J. Wysocki
2013-09-11 13:18 ` Rafael J. Wysocki
2013-09-12 0:39 ` Viresh Kumar
2013-09-12 0:51 ` Viresh Kumar
2013-09-12 0:39 ` Viresh Kumar
2013-09-12 0:39 ` Viresh Kumar
2013-09-12 0:43 ` Rafael J. Wysocki
2013-09-12 0:43 ` Rafael J. Wysocki
2013-09-12 0:43 ` Rafael J. Wysocki
2013-09-12 0:43 ` Rafael J. Wysocki
2013-09-12 5:36 ` Viresh Kumar
2013-09-12 5:48 ` Viresh Kumar
2013-09-12 5:36 ` Viresh Kumar
2013-09-12 5:36 ` Viresh Kumar
2013-09-12 10:50 ` Rafael J. Wysocki
2013-09-12 11:01 ` Rafael J. Wysocki
2013-09-12 11:01 ` Rafael J. Wysocki
2013-09-12 11:01 ` Rafael J. Wysocki
2013-09-12 10:52 ` Viresh Kumar
2013-09-12 10:52 ` Viresh Kumar
2013-09-12 10:52 ` Viresh Kumar
2013-09-12 10:52 ` Viresh Kumar
2013-09-10 15:12 ` Guennadi Liakhovetski
2013-09-10 15:12 ` Guennadi Liakhovetski
2013-09-10 15:12 ` Guennadi Liakhovetski
2013-09-10 15:12 ` Guennadi Liakhovetski
2013-09-10 15:26 ` Viresh Kumar [this message]
2013-09-10 15:38 ` Viresh Kumar
2013-09-10 15:26 ` Viresh Kumar
2013-09-10 15:26 ` Viresh Kumar
2013-09-10 16:22 ` Guennadi Liakhovetski
2013-09-10 16:22 ` Guennadi Liakhovetski
2013-09-10 16:22 ` Guennadi Liakhovetski
2013-09-10 16:22 ` Guennadi Liakhovetski
2013-09-10 16:34 ` Viresh Kumar
2013-09-10 16:46 ` Viresh Kumar
2013-09-10 16:34 ` Viresh Kumar
2013-09-10 16:34 ` Viresh Kumar
2013-09-10 17:07 ` Guennadi Liakhovetski
2013-09-10 17:07 ` Guennadi Liakhovetski
2013-09-10 17:07 ` Guennadi Liakhovetski
2013-09-10 17:07 ` Guennadi Liakhovetski
2013-09-11 8:06 ` Viresh Kumar
2013-09-11 8:18 ` Viresh Kumar
2013-09-11 8:06 ` Viresh Kumar
2013-09-11 8:06 ` Viresh Kumar
2013-09-11 8:15 ` Guennadi Liakhovetski
2013-09-11 8:15 ` Guennadi Liakhovetski
2013-09-11 8:15 ` Guennadi Liakhovetski
2013-09-11 8:15 ` Guennadi Liakhovetski
2013-09-11 8:39 ` Viresh Kumar
2013-09-11 8:51 ` Viresh Kumar
2013-09-11 8:39 ` Viresh Kumar
2013-09-11 8:39 ` Viresh Kumar
2013-09-11 13:28 ` Rafael J. Wysocki
2013-09-11 13:28 ` Rafael J. Wysocki
2013-09-11 13:28 ` Rafael J. Wysocki
2013-09-11 13:28 ` Rafael J. Wysocki
2013-09-12 7:47 ` Guennadi Liakhovetski
2013-09-12 7:47 ` Guennadi Liakhovetski
2013-09-12 7:47 ` Guennadi Liakhovetski
2013-09-12 7:47 ` Guennadi Liakhovetski
2013-09-12 7:51 ` Viresh Kumar
2013-09-12 7:51 ` Viresh Kumar
2013-09-12 7:51 ` Viresh Kumar
2013-09-12 7:51 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKohpomBBKLhNemVUpUHAftGhPJJe+ZB7T_9UYLD7LwpR1nK0g@mail.gmail.com \
--to=viresh.kumar@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.