From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: "cpufreq: fix serialization issues with freq change notifiers" breaks cpufreq too
Date: Tue, 10 Sep 2013 15:12:14 +0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1309101656150.16010@axis700.grange> (raw)
In-Reply-To: <CAKohponZ+FnzqXYMbBzbun0-1iQMi2fS4syrEBC_MdF41vLCeA@mail.gmail.com>
On Tue, 10 Sep 2013, Viresh Kumar wrote:
> On 9 September 2013 20:41, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> > Sorry guys, I'm trying my best to stop this patch from propagating to
> > stable and to get it fixed asap, so, the CC list might be a bit excessive.
> > Also trying to fix the originally spare cc list, which makes it impossible
> > for me to reply to the original thread, instead have to start a new one.
> >
> > Commit
> >
> > commit dceff5ce18801dddc220d6238628619c93bc3cb6
> > Author: Viresh Kumar <viresh.kumar@linaro.org>
> > Date: Sun Sep 1 22:19:37 2013 +0530
> >
> > cpufreq: fix serialization issues with freq change notifiers
> >
> > breaks .transition_ongoing counting. This leads to cpufreq-cpu0 not
> > working any more. In particular switching the governor from performance to
> > powersave directly after boot doesn't result in a frequency switch any
> > more. Reverting this patch fixes the problem again. Tested with today's
> > -next.
>
> I have tested it again on my exynos and intel machines and couldn't see
> a single problem with this patch..
Ok, here's what I've just done.
1. checkout -next tag next-20130909
commit 98926a8004b453089368fda456b8c869240e9953
Author: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon Sep 9 16:05:53 2013 +1000
Add linux-next specific files for 20130909
2. built and booted a kernel for kzm9g (.config available on request)
3. cpufreq failed to initialise:
cpufreq_cpu0: failed to find cpu0 node
cpufreq-cpu0: probe of cpufreq-cpu0 failed with error -2
due to commit f837a9b5ab05c52a07108c6f09ca66f2e0aee757 - as reported in
another thread.
4. reverted that commit, resolving a trivial conflict. Added a debug
output in __cpufreq_driver_target() of
if (cpufreq_disabled())
return -ENODEV;
+ pr_info("%s() %d\n", __func__, policy->transition_ongoing);
if (policy->transition_ongoing)
return -EBUSY;
Built and booted, got
cpufreq: __cpufreq_driver_target(): 1
printed out 4 times from the beginning.
5. tried
echo powersave > /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
the above output appeared 2 more times - no frequency change resulted.
6. reverted commit dceff5ce18801dddc220d6238628619c93bc3cb6, built booted
- cpufreq works again.
> I am afraid you need to give us some more information on how it broke
> your stuff.. :)
Hope the above is enough.
Thanks
Guennadi
> And I am also not sure cpufreq-cpu0 is different then any other driver..
>
> --
> viresh
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
WARNING: multiple messages have this Message-ID (diff)
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Greg KH <greg@kroah.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
SH-Linux <linux-sh@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: "cpufreq: fix serialization issues with freq change notifiers" breaks cpufreq too
Date: Tue, 10 Sep 2013 17:12:14 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1309101656150.16010@axis700.grange> (raw)
In-Reply-To: <CAKohponZ+FnzqXYMbBzbun0-1iQMi2fS4syrEBC_MdF41vLCeA@mail.gmail.com>
On Tue, 10 Sep 2013, Viresh Kumar wrote:
> On 9 September 2013 20:41, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> > Sorry guys, I'm trying my best to stop this patch from propagating to
> > stable and to get it fixed asap, so, the CC list might be a bit excessive.
> > Also trying to fix the originally spare cc list, which makes it impossible
> > for me to reply to the original thread, instead have to start a new one.
> >
> > Commit
> >
> > commit dceff5ce18801dddc220d6238628619c93bc3cb6
> > Author: Viresh Kumar <viresh.kumar@linaro.org>
> > Date: Sun Sep 1 22:19:37 2013 +0530
> >
> > cpufreq: fix serialization issues with freq change notifiers
> >
> > breaks .transition_ongoing counting. This leads to cpufreq-cpu0 not
> > working any more. In particular switching the governor from performance to
> > powersave directly after boot doesn't result in a frequency switch any
> > more. Reverting this patch fixes the problem again. Tested with today's
> > -next.
>
> I have tested it again on my exynos and intel machines and couldn't see
> a single problem with this patch..
Ok, here's what I've just done.
1. checkout -next tag next-20130909
commit 98926a8004b453089368fda456b8c869240e9953
Author: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon Sep 9 16:05:53 2013 +1000
Add linux-next specific files for 20130909
2. built and booted a kernel for kzm9g (.config available on request)
3. cpufreq failed to initialise:
cpufreq_cpu0: failed to find cpu0 node
cpufreq-cpu0: probe of cpufreq-cpu0 failed with error -2
due to commit f837a9b5ab05c52a07108c6f09ca66f2e0aee757 - as reported in
another thread.
4. reverted that commit, resolving a trivial conflict. Added a debug
output in __cpufreq_driver_target() of
if (cpufreq_disabled())
return -ENODEV;
+ pr_info("%s() %d\n", __func__, policy->transition_ongoing);
if (policy->transition_ongoing)
return -EBUSY;
Built and booted, got
cpufreq: __cpufreq_driver_target(): 1
printed out 4 times from the beginning.
5. tried
echo powersave > /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
the above output appeared 2 more times - no frequency change resulted.
6. reverted commit dceff5ce18801dddc220d6238628619c93bc3cb6, built booted
- cpufreq works again.
> I am afraid you need to give us some more information on how it broke
> your stuff.. :)
Hope the above is enough.
Thanks
Guennadi
> And I am also not sure cpufreq-cpu0 is different then any other driver..
>
> --
> viresh
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
WARNING: multiple messages have this Message-ID (diff)
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Greg KH <greg@kroah.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
SH-Linux <linux-sh@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: "cpufreq: fix serialization issues with freq change notifiers" breaks cpufreq too
Date: Tue, 10 Sep 2013 17:12:14 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1309101656150.16010@axis700.grange> (raw)
In-Reply-To: <CAKohponZ+FnzqXYMbBzbun0-1iQMi2fS4syrEBC_MdF41vLCeA@mail.gmail.com>
On Tue, 10 Sep 2013, Viresh Kumar wrote:
> On 9 September 2013 20:41, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> > Sorry guys, I'm trying my best to stop this patch from propagating to
> > stable and to get it fixed asap, so, the CC list might be a bit excessive.
> > Also trying to fix the originally spare cc list, which makes it impossible
> > for me to reply to the original thread, instead have to start a new one.
> >
> > Commit
> >
> > commit dceff5ce18801dddc220d6238628619c93bc3cb6
> > Author: Viresh Kumar <viresh.kumar@linaro.org>
> > Date: Sun Sep 1 22:19:37 2013 +0530
> >
> > cpufreq: fix serialization issues with freq change notifiers
> >
> > breaks .transition_ongoing counting. This leads to cpufreq-cpu0 not
> > working any more. In particular switching the governor from performance to
> > powersave directly after boot doesn't result in a frequency switch any
> > more. Reverting this patch fixes the problem again. Tested with today's
> > -next.
>
> I have tested it again on my exynos and intel machines and couldn't see
> a single problem with this patch..
Ok, here's what I've just done.
1. checkout -next tag next-20130909
commit 98926a8004b453089368fda456b8c869240e9953
Author: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon Sep 9 16:05:53 2013 +1000
Add linux-next specific files for 20130909
2. built and booted a kernel for kzm9g (.config available on request)
3. cpufreq failed to initialise:
cpufreq_cpu0: failed to find cpu0 node
cpufreq-cpu0: probe of cpufreq-cpu0 failed with error -2
due to commit f837a9b5ab05c52a07108c6f09ca66f2e0aee757 - as reported in
another thread.
4. reverted that commit, resolving a trivial conflict. Added a debug
output in __cpufreq_driver_target() of
if (cpufreq_disabled())
return -ENODEV;
+ pr_info("%s() %d\n", __func__, policy->transition_ongoing);
if (policy->transition_ongoing)
return -EBUSY;
Built and booted, got
cpufreq: __cpufreq_driver_target(): 1
printed out 4 times from the beginning.
5. tried
echo powersave > /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
the above output appeared 2 more times - no frequency change resulted.
6. reverted commit dceff5ce18801dddc220d6238628619c93bc3cb6, built booted
- cpufreq works again.
> I am afraid you need to give us some more information on how it broke
> your stuff.. :)
Hope the above is enough.
Thanks
Guennadi
> And I am also not sure cpufreq-cpu0 is different then any other driver..
>
> --
> viresh
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
WARNING: multiple messages have this Message-ID (diff)
From: g.liakhovetski@gmx.de (Guennadi Liakhovetski)
To: linux-arm-kernel@lists.infradead.org
Subject: "cpufreq: fix serialization issues with freq change notifiers" breaks cpufreq too
Date: Tue, 10 Sep 2013 17:12:14 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1309101656150.16010@axis700.grange> (raw)
In-Reply-To: <CAKohponZ+FnzqXYMbBzbun0-1iQMi2fS4syrEBC_MdF41vLCeA@mail.gmail.com>
On Tue, 10 Sep 2013, Viresh Kumar wrote:
> On 9 September 2013 20:41, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> > Sorry guys, I'm trying my best to stop this patch from propagating to
> > stable and to get it fixed asap, so, the CC list might be a bit excessive.
> > Also trying to fix the originally spare cc list, which makes it impossible
> > for me to reply to the original thread, instead have to start a new one.
> >
> > Commit
> >
> > commit dceff5ce18801dddc220d6238628619c93bc3cb6
> > Author: Viresh Kumar <viresh.kumar@linaro.org>
> > Date: Sun Sep 1 22:19:37 2013 +0530
> >
> > cpufreq: fix serialization issues with freq change notifiers
> >
> > breaks .transition_ongoing counting. This leads to cpufreq-cpu0 not
> > working any more. In particular switching the governor from performance to
> > powersave directly after boot doesn't result in a frequency switch any
> > more. Reverting this patch fixes the problem again. Tested with today's
> > -next.
>
> I have tested it again on my exynos and intel machines and couldn't see
> a single problem with this patch..
Ok, here's what I've just done.
1. checkout -next tag next-20130909
commit 98926a8004b453089368fda456b8c869240e9953
Author: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon Sep 9 16:05:53 2013 +1000
Add linux-next specific files for 20130909
2. built and booted a kernel for kzm9g (.config available on request)
3. cpufreq failed to initialise:
cpufreq_cpu0: failed to find cpu0 node
cpufreq-cpu0: probe of cpufreq-cpu0 failed with error -2
due to commit f837a9b5ab05c52a07108c6f09ca66f2e0aee757 - as reported in
another thread.
4. reverted that commit, resolving a trivial conflict. Added a debug
output in __cpufreq_driver_target() of
if (cpufreq_disabled())
return -ENODEV;
+ pr_info("%s() %d\n", __func__, policy->transition_ongoing);
if (policy->transition_ongoing)
return -EBUSY;
Built and booted, got
cpufreq: __cpufreq_driver_target(): 1
printed out 4 times from the beginning.
5. tried
echo powersave > /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
the above output appeared 2 more times - no frequency change resulted.
6. reverted commit dceff5ce18801dddc220d6238628619c93bc3cb6, built booted
- cpufreq works again.
> I am afraid you need to give us some more information on how it broke
> your stuff.. :)
Hope the above is enough.
Thanks
Guennadi
> And I am also not sure cpufreq-cpu0 is different then any other driver..
>
> --
> viresh
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
next prev parent reply other threads:[~2013-09-10 15:12 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 15:11 "cpufreq: fix serialization issues with freq change notifiers" breaks cpufreq too Guennadi Liakhovetski
2013-09-09 15:11 ` Guennadi Liakhovetski
2013-09-09 15:11 ` Guennadi Liakhovetski
2013-09-09 15:11 ` Guennadi Liakhovetski
2013-09-09 20:57 ` Rafael J. Wysocki
2013-09-09 21:08 ` Rafael J. Wysocki
2013-09-09 21:08 ` Rafael J. Wysocki
2013-09-09 21:42 ` Guennadi Liakhovetski
2013-09-09 21:42 ` Guennadi Liakhovetski
2013-09-09 21:42 ` Guennadi Liakhovetski
2013-09-09 23:12 ` Rafael J. Wysocki
2013-09-09 23:12 ` Rafael J. Wysocki
2013-09-09 23:12 ` Rafael J. Wysocki
2013-09-10 1:46 ` Rafael J. Wysocki
2013-09-10 1:46 ` Rafael J. Wysocki
2013-09-10 11:29 ` Viresh Kumar
2013-09-10 11:41 ` Viresh Kumar
2013-09-10 11:29 ` Viresh Kumar
2013-09-10 11:29 ` Viresh Kumar
2013-09-10 11:49 ` Rafael J. Wysocki
2013-09-10 11:49 ` Rafael J. Wysocki
2013-09-10 11:49 ` Rafael J. Wysocki
2013-09-10 11:49 ` Rafael J. Wysocki
2013-09-10 15:14 ` Viresh Kumar
2013-09-10 15:26 ` Viresh Kumar
2013-09-10 15:14 ` Viresh Kumar
2013-09-10 15:14 ` Viresh Kumar
2013-09-10 19:46 ` Rafael J. Wysocki
2013-09-10 19:46 ` Rafael J. Wysocki
2013-09-10 19:46 ` Rafael J. Wysocki
2013-09-10 19:46 ` Rafael J. Wysocki
2013-09-11 8:38 ` Viresh Kumar
2013-09-11 8:50 ` Viresh Kumar
2013-09-11 8:38 ` Viresh Kumar
2013-09-11 8:38 ` Viresh Kumar
2013-09-11 13:18 ` Rafael J. Wysocki
2013-09-11 13:18 ` Rafael J. Wysocki
2013-09-11 13:18 ` Rafael J. Wysocki
2013-09-11 13:18 ` Rafael J. Wysocki
2013-09-12 0:39 ` Viresh Kumar
2013-09-12 0:51 ` Viresh Kumar
2013-09-12 0:39 ` Viresh Kumar
2013-09-12 0:39 ` Viresh Kumar
2013-09-12 0:43 ` Rafael J. Wysocki
2013-09-12 0:43 ` Rafael J. Wysocki
2013-09-12 0:43 ` Rafael J. Wysocki
2013-09-12 0:43 ` Rafael J. Wysocki
2013-09-12 5:36 ` Viresh Kumar
2013-09-12 5:48 ` Viresh Kumar
2013-09-12 5:36 ` Viresh Kumar
2013-09-12 5:36 ` Viresh Kumar
2013-09-12 10:50 ` Rafael J. Wysocki
2013-09-12 11:01 ` Rafael J. Wysocki
2013-09-12 11:01 ` Rafael J. Wysocki
2013-09-12 11:01 ` Rafael J. Wysocki
2013-09-12 10:52 ` Viresh Kumar
2013-09-12 10:52 ` Viresh Kumar
2013-09-12 10:52 ` Viresh Kumar
2013-09-12 10:52 ` Viresh Kumar
2013-09-10 15:12 ` Guennadi Liakhovetski [this message]
2013-09-10 15:12 ` Guennadi Liakhovetski
2013-09-10 15:12 ` Guennadi Liakhovetski
2013-09-10 15:12 ` Guennadi Liakhovetski
2013-09-10 15:26 ` Viresh Kumar
2013-09-10 15:38 ` Viresh Kumar
2013-09-10 15:26 ` Viresh Kumar
2013-09-10 15:26 ` Viresh Kumar
2013-09-10 16:22 ` Guennadi Liakhovetski
2013-09-10 16:22 ` Guennadi Liakhovetski
2013-09-10 16:22 ` Guennadi Liakhovetski
2013-09-10 16:22 ` Guennadi Liakhovetski
2013-09-10 16:34 ` Viresh Kumar
2013-09-10 16:46 ` Viresh Kumar
2013-09-10 16:34 ` Viresh Kumar
2013-09-10 16:34 ` Viresh Kumar
2013-09-10 17:07 ` Guennadi Liakhovetski
2013-09-10 17:07 ` Guennadi Liakhovetski
2013-09-10 17:07 ` Guennadi Liakhovetski
2013-09-10 17:07 ` Guennadi Liakhovetski
2013-09-11 8:06 ` Viresh Kumar
2013-09-11 8:18 ` Viresh Kumar
2013-09-11 8:06 ` Viresh Kumar
2013-09-11 8:06 ` Viresh Kumar
2013-09-11 8:15 ` Guennadi Liakhovetski
2013-09-11 8:15 ` Guennadi Liakhovetski
2013-09-11 8:15 ` Guennadi Liakhovetski
2013-09-11 8:15 ` Guennadi Liakhovetski
2013-09-11 8:39 ` Viresh Kumar
2013-09-11 8:51 ` Viresh Kumar
2013-09-11 8:39 ` Viresh Kumar
2013-09-11 8:39 ` Viresh Kumar
2013-09-11 13:28 ` Rafael J. Wysocki
2013-09-11 13:28 ` Rafael J. Wysocki
2013-09-11 13:28 ` Rafael J. Wysocki
2013-09-11 13:28 ` Rafael J. Wysocki
2013-09-12 7:47 ` Guennadi Liakhovetski
2013-09-12 7:47 ` Guennadi Liakhovetski
2013-09-12 7:47 ` Guennadi Liakhovetski
2013-09-12 7:47 ` Guennadi Liakhovetski
2013-09-12 7:51 ` Viresh Kumar
2013-09-12 7:51 ` Viresh Kumar
2013-09-12 7:51 ` Viresh Kumar
2013-09-12 7:51 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1309101656150.16010@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.