From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Dirk Behme <dirk.behme@de.bosch.com>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Ryo Kataoka <ryo.kataoka.wt@renesas.com>,
Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
Subject: Re: [PATCH 3/8] spi: sh-msiof: Fix MSIOF address for DMAC
Date: Wed, 6 Sep 2017 13:01:51 +0200 [thread overview]
Message-ID: <CAMuHMdWYwe-cxVVk6Vema9J0EFEeioMB0V9rNwg+O9f7Y35C0Q@mail.gmail.com> (raw)
In-Reply-To: <b408d4a1-2ccf-a1dc-d4f0-d5908d8cf731@de.bosch.com>
Hi Dirk,
On Wed, Sep 6, 2017 at 12:59 PM, Dirk Behme <dirk.behme@de.bosch.com> wrote:
> On 06.09.2017 12:42, Geert Uytterhoeven wrote:
>> On Wed, Sep 6, 2017 at 12:09 PM, Dirk Behme <dirk.behme@de.bosch.com>
>> wrote:
>>> On 06.09.2017 11:22, Geert Uytterhoeven wrote:
>>>> On Wed, Sep 6, 2017 at 9:05 AM, Dirk Behme <dirk.behme@de.bosch.com>
>>>> wrote:
>>>>> From: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
>>>>>
>>>>> MSIOF Base Address H'E6xx can be accessed by CPU and DMAC.
>>>>> MSIOF Base Address H'E7xx for DMAC was removed from H/W manual.
>>>>>
>>>>> Signed-off-by: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
>>>>> Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
>>>>> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
>>>>
>>>> NAKed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>>>
>>>> The MSIOF Base Address for DMAC was removed only from the R-Car
>>>> Gen2/Gen3
>>>> manuals. It still affects e.g. R-Mobile APE6.
>>>
>>> Do we have a nice run time detection for that?
>>
>> The current driver code just looks at the DTS, cfr. the comment:
>>
>> /* The DMA engine uses the second register set, if present */
>
> Ok, yes, thanks.
>
> So this patch is completely superfluous, even in the BSP, correct?
Correct. But it keeps on popping up, I think this is the third time someone
tried to submit it upstream :-(
> Will drop it for the next round, hoping that it doesn't result in too much
> rebase hassle ;)
OK, thx!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2017-09-06 11:01 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 7:04 [PATCH 0/8] spi: sh-msiof: Import some BSP patches Dirk Behme
2017-09-06 7:05 ` [PATCH 1/8] spi: sh-msiof: Add sleep before master transfer for test Dirk Behme
2017-09-07 7:04 ` Vladimir Zapolskiy
2017-09-07 7:04 ` Vladimir Zapolskiy
2017-09-07 7:16 ` Dirk Behme
2017-09-07 7:16 ` Dirk Behme
2017-09-07 8:11 ` Geert Uytterhoeven
2017-09-07 8:26 ` Dirk Behme
2017-09-07 8:26 ` Dirk Behme
2017-09-06 7:05 ` [PATCH 2/8] spi: sh-msiof: Fix DMA transfer size check Dirk Behme
2017-09-07 8:31 ` Geert Uytterhoeven
2017-09-07 8:33 ` Dirk Behme
2017-09-07 8:39 ` Geert Uytterhoeven
2017-09-07 8:39 ` Geert Uytterhoeven
2017-09-07 8:42 ` Dirk Behme
2017-09-07 8:59 ` Geert Uytterhoeven
2017-09-07 9:05 ` Dirk Behme
2017-09-07 9:05 ` Dirk Behme
2017-09-07 9:12 ` Geert Uytterhoeven
2017-09-07 9:12 ` Geert Uytterhoeven
2018-01-03 17:25 ` Geert Uytterhoeven
2018-01-03 17:25 ` Geert Uytterhoeven
2018-01-04 7:19 ` Dirk Behme
2018-01-04 8:24 ` Geert Uytterhoeven
2017-09-06 7:05 ` [PATCH 3/8] spi: sh-msiof: Fix MSIOF address for DMAC Dirk Behme
2017-09-06 7:05 ` Dirk Behme
2017-09-06 9:22 ` Geert Uytterhoeven
2017-09-06 10:09 ` Dirk Behme
2017-09-06 10:09 ` Dirk Behme
2017-09-06 10:42 ` Geert Uytterhoeven
2017-09-06 10:59 ` Dirk Behme
2017-09-06 10:59 ` Dirk Behme
2017-09-06 11:01 ` Geert Uytterhoeven [this message]
2017-09-06 7:05 ` [PATCH 4/8] spi: sh-msiof: Fix DMA completion Dirk Behme
2017-09-07 8:33 ` Geert Uytterhoeven
2017-09-07 8:33 ` Geert Uytterhoeven
2017-09-07 8:41 ` Dirk Behme
2017-09-07 8:41 ` Dirk Behme
2017-09-06 7:05 ` [PATCH 5/8] spi: sh-msiof: Wait for Tx FIFO empty after DMA Dirk Behme
2017-09-06 17:57 ` Sergei Shtylyov
2017-09-07 8:34 ` Geert Uytterhoeven
2017-09-07 8:34 ` Geert Uytterhoeven
2017-09-06 7:05 ` [PATCH 6/8] spi: sh-msiof: Add MSIOF parent clock changing function for R-Car Gen3 Dirk Behme
2017-09-07 8:38 ` Geert Uytterhoeven
2017-09-06 7:05 ` [PATCH 7/8] spi: sh-msiof: Fix gpio function Dirk Behme
2017-09-06 7:05 ` Dirk Behme
2017-09-07 8:24 ` Geert Uytterhoeven
2017-09-06 7:05 ` [PATCH 8/8] spi: sh-msiof: Add registers reset Dirk Behme
2017-09-06 7:05 ` Dirk Behme
2017-09-06 18:11 ` Sergei Shtylyov
2017-09-07 8:11 ` Geert Uytterhoeven
2017-09-07 8:11 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWYwe-cxVVk6Vema9J0EFEeioMB0V9rNwg+O9f7Y35C0Q@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=dirk.behme@de.bosch.com \
--cc=geert+renesas@glider.be \
--cc=hiromitsu.yamasaki.ym@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ryo.kataoka.wt@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.