From: Ulf Hansson <ulf.hansson@linaro.org>
To: Ludovic Barre <ludovic.Barre@st.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Gerald Baeza <gerald.baeza@st.com>,
Loic Pallardy <loic.pallardy@st.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH V2 26/27] mmc: mmci: add DT bindings for STM32 sdmmc
Date: Mon, 1 Oct 2018 11:30:58 +0200 [thread overview]
Message-ID: <CAPDyKFoiZMnYqtp_FofYEV=xKD+Azb2qKf=R=LdRsE+doxqW+A@mail.gmail.com> (raw)
In-Reply-To: <1537523181-14578-27-git-send-email-ludovic.Barre@st.com>
On 21 September 2018 at 11:46, Ludovic Barre <ludovic.Barre@st.com> wrote:
> From: Ludovic Barre <ludovic.barre@st.com>
>
> STM32 sdmmc variant has support to:
> -Indicate signal directions (only one property
> for d0dir, d123dir, cmd_dir)
> -Select command and data phase relation.
> -Select "clock in" from an external driver.
>
> Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
> ---
> change v3:
> -remove space at end of "st,use-ckin "
>
> Documentation/devicetree/bindings/mmc/mmci.txt | 9 +++++++++
Please split this. DT doc changes should be separate patches.
> drivers/mmc/host/mmci.c | 6 ++++++
> drivers/mmc/host/mmci.h | 1 +
> 3 files changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmci.txt b/Documentation/devicetree/bindings/mmc/mmci.txt
> index e952707..d678933 100644
> --- a/Documentation/devicetree/bindings/mmc/mmci.txt
> +++ b/Documentation/devicetree/bindings/mmc/mmci.txt
> @@ -19,6 +19,7 @@ Optional properties:
> the ID provided by the HW
> - vqmmc-supply : phandle to the regulator device tree node, mentioned
> as the VCCQ/VDD_IO supply in the eMMC/SD specs.
> +specific for ux500 variant:
> - st,sig-dir-dat0 : bus signal direction pin used for DAT[0].
> - st,sig-dir-dat2 : bus signal direction pin used for DAT[2].
> - st,sig-dir-dat31 : bus signal direction pin used for DAT[3] and DAT[1].
> @@ -26,6 +27,14 @@ Optional properties:
> - st,sig-dir-cmd : cmd signal direction pin used for CMD.
> - st,sig-pin-fbclk : feedback clock signal pin used.
>
> +specific for sdmmc variant:
> +- st,sig-dir : signal direction polarity used for cmd, dat0 dat123.
> +- st,neg-edge : data & command phase relation, generated on
> + sd clock falling edge.
> +- st,use-ckin : use ckin pin from an external driver to sample
> + the receive data (example: with voltage
> + switch transceiver).
[...]
Kind regards
Uffe
WARNING: multiple messages have this Message-ID (diff)
From: ulf.hansson@linaro.org (Ulf Hansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 26/27] mmc: mmci: add DT bindings for STM32 sdmmc
Date: Mon, 1 Oct 2018 11:30:58 +0200 [thread overview]
Message-ID: <CAPDyKFoiZMnYqtp_FofYEV=xKD+Azb2qKf=R=LdRsE+doxqW+A@mail.gmail.com> (raw)
In-Reply-To: <1537523181-14578-27-git-send-email-ludovic.Barre@st.com>
On 21 September 2018 at 11:46, Ludovic Barre <ludovic.Barre@st.com> wrote:
> From: Ludovic Barre <ludovic.barre@st.com>
>
> STM32 sdmmc variant has support to:
> -Indicate signal directions (only one property
> for d0dir, d123dir, cmd_dir)
> -Select command and data phase relation.
> -Select "clock in" from an external driver.
>
> Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
> ---
> change v3:
> -remove space at end of "st,use-ckin "
>
> Documentation/devicetree/bindings/mmc/mmci.txt | 9 +++++++++
Please split this. DT doc changes should be separate patches.
> drivers/mmc/host/mmci.c | 6 ++++++
> drivers/mmc/host/mmci.h | 1 +
> 3 files changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmci.txt b/Documentation/devicetree/bindings/mmc/mmci.txt
> index e952707..d678933 100644
> --- a/Documentation/devicetree/bindings/mmc/mmci.txt
> +++ b/Documentation/devicetree/bindings/mmc/mmci.txt
> @@ -19,6 +19,7 @@ Optional properties:
> the ID provided by the HW
> - vqmmc-supply : phandle to the regulator device tree node, mentioned
> as the VCCQ/VDD_IO supply in the eMMC/SD specs.
> +specific for ux500 variant:
> - st,sig-dir-dat0 : bus signal direction pin used for DAT[0].
> - st,sig-dir-dat2 : bus signal direction pin used for DAT[2].
> - st,sig-dir-dat31 : bus signal direction pin used for DAT[3] and DAT[1].
> @@ -26,6 +27,14 @@ Optional properties:
> - st,sig-dir-cmd : cmd signal direction pin used for CMD.
> - st,sig-pin-fbclk : feedback clock signal pin used.
>
> +specific for sdmmc variant:
> +- st,sig-dir : signal direction polarity used for cmd, dat0 dat123.
> +- st,neg-edge : data & command phase relation, generated on
> + sd clock falling edge.
> +- st,use-ckin : use ckin pin from an external driver to sample
> + the receive data (example: with voltage
> + switch transceiver).
[...]
Kind regards
Uffe
next prev parent reply other threads:[~2018-10-01 9:31 UTC|newest]
Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 9:45 [PATCH V2 00/27] mmc: mmci: add sdmmc variant for stm32 Ludovic Barre
2018-09-21 9:45 ` Ludovic Barre
2018-09-21 9:45 ` Ludovic Barre
2018-09-21 9:45 ` [PATCH V2 01/27] mmc: mmci: internalize dma map/unmap into mmci dma functions Ludovic Barre
2018-09-21 9:45 ` Ludovic Barre
2018-09-21 9:45 ` Ludovic Barre
2018-09-26 23:49 ` Ulf Hansson
2018-09-26 23:49 ` Ulf Hansson
2018-09-21 9:45 ` [PATCH V2 02/27] mmc: mmci: internalize dma_inprogress " Ludovic Barre
2018-09-21 9:45 ` Ludovic Barre
2018-09-21 9:45 ` Ludovic Barre
2018-09-26 23:49 ` Ulf Hansson
2018-09-26 23:49 ` Ulf Hansson
2018-09-21 9:45 ` [PATCH V2 03/27] mmc: mmci: convert dma_setup callback to return an int Ludovic Barre
2018-09-21 9:45 ` Ludovic Barre
2018-09-21 9:45 ` Ludovic Barre
2018-09-24 14:28 ` Ulf Hansson
2018-09-24 14:28 ` Ulf Hansson
2018-09-24 16:12 ` Ludovic BARRE
2018-09-24 16:12 ` Ludovic BARRE
2018-09-24 16:12 ` Ludovic BARRE
2018-09-26 23:49 ` Ulf Hansson
2018-09-26 23:49 ` Ulf Hansson
2018-09-27 8:55 ` Srinivas Kandagatla
2018-09-27 8:55 ` Srinivas Kandagatla
2018-09-21 9:45 ` [PATCH V2 04/27] mmc: mmci: introduce dma_priv pointer to mmci_host Ludovic Barre
2018-09-21 9:45 ` Ludovic Barre
2018-09-21 9:45 ` Ludovic Barre
2018-09-24 18:52 ` Ulf Hansson
2018-09-24 18:52 ` Ulf Hansson
2018-09-25 7:19 ` Ludovic BARRE
2018-09-25 7:19 ` Ludovic BARRE
2018-09-25 7:19 ` Ludovic BARRE
2018-09-21 9:45 ` [PATCH V2 05/27] mmc: mmci: move mmci next cookie to mci host Ludovic Barre
2018-09-21 9:45 ` Ludovic Barre
2018-09-21 9:45 ` Ludovic Barre
2018-09-24 18:46 ` Ulf Hansson
2018-09-24 18:46 ` Ulf Hansson
2018-09-25 7:08 ` Ludovic BARRE
2018-09-25 7:08 ` Ludovic BARRE
2018-09-25 7:08 ` Ludovic BARRE
2018-09-21 9:46 ` [PATCH V2 06/27] mmc: mmci: merge prepare data functions Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` [PATCH V2 07/27] mmc: mmci: add prepare/unprepare_data callbacks Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` [PATCH V2 08/27] mmc: mmci: add get_next_data callback Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` [PATCH V2 09/27] mmc: mmci: modify dma_setup callback Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-10-01 9:30 ` Ulf Hansson
2018-10-01 9:30 ` Ulf Hansson
2018-10-01 9:43 ` Ludovic BARRE
2018-10-01 9:43 ` Ludovic BARRE
2018-10-01 9:43 ` Ludovic BARRE
2018-09-21 9:46 ` [PATCH V2 10/27] mmc: mmci: add dma_release callback Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` [PATCH V2 11/27] mmc: mmci: add dma_start callback Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` [PATCH V2 12/27] mmc: mmci: add dma_finalize callback Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` [PATCH V2 13/27] mmc: mmci: add dma_error callback Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` [PATCH V2 14/27] mmc: mmci: add validate_data callback Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` [PATCH V2 15/27] mmc: mmci: add set_clk/pwrreg callbacks Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` [PATCH V2 16/27] mmc: mmci: add datactrl block size variant property Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` [PATCH V2 17/27] mmc: mmci: expand startbiterr to irqmask and error check Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` [PATCH V2 18/27] mmc: mmci: add variant properties to define cpsm & cmdresp bits Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` [PATCH V2 19/27] mmc: mmci: add variant property to define dpsm bit Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` [PATCH V2 20/27] mmc: mmci: add variant property to define irq pio mask Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` [PATCH V2 21/27] mmc: mmci: add variant property to write datactrl before command Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` [PATCH V2 22/27] mmc: mmci: add variant property to not read datacnt Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` [PATCH V2 23/27] mmc: mmci: add variant property to request a reset Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-10-01 9:30 ` Ulf Hansson
2018-10-01 9:30 ` Ulf Hansson
2018-10-01 12:16 ` Ludovic BARRE
2018-10-01 12:16 ` Ludovic BARRE
2018-10-01 12:16 ` Ludovic BARRE
2018-10-01 13:43 ` Ulf Hansson
2018-10-01 13:43 ` Ulf Hansson
2018-09-21 9:46 ` [PATCH V2 24/27] mmc: mmci: add clock divider for stm32 sdmmc Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` [PATCH V2 25/27] mmc: mmci: add stm32 sdmmc registers Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` [PATCH V2 26/27] mmc: mmci: add DT bindings for STM32 sdmmc Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-25 15:27 ` Rob Herring
2018-09-25 15:27 ` Rob Herring
2018-10-01 9:30 ` Ulf Hansson [this message]
2018-10-01 9:30 ` Ulf Hansson
2018-09-21 9:46 ` [PATCH V2 27/27] mmc: mmci: add stm32 sdmmc variant Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-09-21 9:46 ` Ludovic Barre
2018-10-01 9:31 ` Ulf Hansson
2018-10-01 9:31 ` Ulf Hansson
2018-10-01 12:56 ` Ludovic BARRE
2018-10-01 12:56 ` Ludovic BARRE
2018-10-01 12:56 ` Ludovic BARRE
2018-10-01 13:39 ` Ulf Hansson
2018-10-01 13:39 ` Ulf Hansson
2018-10-01 13:53 ` Ludovic BARRE
2018-10-01 13:53 ` Ludovic BARRE
2018-10-01 13:53 ` Ludovic BARRE
-- strict thread matches above, loose matches on Subject: below --
2018-09-18 10:55 [PATCH V2 00/27] mmc: mmci: add sdmmc variant for stm32 Ludovic Barre
2018-09-18 10:55 ` [PATCH V2 26/27] mmc: mmci: add DT bindings for STM32 sdmmc Ludovic Barre
2018-09-18 10:55 ` Ludovic Barre
2018-09-18 10:55 ` Ludovic Barre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFoiZMnYqtp_FofYEV=xKD+Azb2qKf=R=LdRsE+doxqW+A@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gerald.baeza@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=loic.pallardy@st.com \
--cc=ludovic.Barre@st.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.