From: "Gupta, Nipun" <Nipun.Gupta@amd.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"maz@kernel.org" <maz@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"okaya@kernel.org" <okaya@kernel.org>,
"Anand, Harpreet" <harpreet.anand@amd.com>,
"Simek, Michal" <michal.simek@amd.com>,
"Agarwal, Nikhil" <nikhil.agarwal@amd.com>
Subject: RE: [RFC PATCH 2/2] driver core: add compatible string in sysfs for platform devices
Date: Wed, 3 Aug 2022 12:46:32 +0000 [thread overview]
Message-ID: <DM6PR12MB30827E57AA6000BDC5AE6FEDE89C9@DM6PR12MB3082.namprd12.prod.outlook.com> (raw)
In-Reply-To: <YupquKhvLR7zAwa/@kroah.com>
[AMD Official Use Only - General]
> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Wednesday, August 3, 2022 6:02 PM
> To: Gupta, Nipun <Nipun.Gupta@amd.com>
> Cc: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> rafael@kernel.org; maz@kernel.org; tglx@linutronix.de; okaya@kernel.org;
> Anand, Harpreet <harpreet.anand@amd.com>; Simek, Michal
> <michal.simek@amd.com>; Agarwal, Nikhil <nikhil.agarwal@amd.com>
> Subject: Re: [RFC PATCH 2/2] driver core: add compatible string in sysfs for
> platform devices
>
> [CAUTION: External Email]
>
> On Wed, Aug 03, 2022 at 05:56:55PM +0530, Nipun Gupta wrote:
> > For devices registered dynamically using platform_device_register
> > API, this patch exposes the sysfs entry for the compatible string.
> >
> > Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
> > ---
> > drivers/base/platform.c | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> > index 51bb2289865c..89949f88a0a1 100644
> > --- a/drivers/base/platform.c
> > +++ b/drivers/base/platform.c
> > @@ -1289,10 +1289,25 @@ static ssize_t driver_override_store(struct device
> *dev,
> > }
> > static DEVICE_ATTR_RW(driver_override);
> >
> > +static ssize_t compatible_show(struct device *dev, struct device_attribute
> *attr,
> > + char *buf)
> > +{
> > + const char *compat;
> > + int ret;
> > +
> > + ret = device_property_read_string(dev, "compatible", &compat);
> > + if (ret != 0)
> > + return 0;
> > +
> > + return sysfs_emit(buf, "%s", compat);
> > +}
> > +static DEVICE_ATTR_RO(compatible);
>
> You forgot the Documentation/ABI/ update :(
Thanks for pointing. Will be adding the new sysfs entry as part
of the documentation.
>
> Also, what happens if there is no such string to read? Why are you
> returning 0? You should not create the attribute at all then, right?
Will be updating platform_dev_attrs_visible() API to have it visible
depending on if the attribute is available. Yes, then we may not need
this check here and would be part of the platform_dev_attrs_visible() API.
Thanks,
Nipun
>
> thanks,
>
> greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: "Gupta, Nipun" <Nipun.Gupta@amd.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"maz@kernel.org" <maz@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"okaya@kernel.org" <okaya@kernel.org>,
"Anand, Harpreet" <harpreet.anand@amd.com>,
"Simek, Michal" <michal.simek@amd.com>,
"Agarwal, Nikhil" <nikhil.agarwal@amd.com>
Subject: RE: [RFC PATCH 2/2] driver core: add compatible string in sysfs for platform devices
Date: Wed, 3 Aug 2022 12:46:32 +0000 [thread overview]
Message-ID: <DM6PR12MB30827E57AA6000BDC5AE6FEDE89C9@DM6PR12MB3082.namprd12.prod.outlook.com> (raw)
In-Reply-To: <YupquKhvLR7zAwa/@kroah.com>
[AMD Official Use Only - General]
> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Wednesday, August 3, 2022 6:02 PM
> To: Gupta, Nipun <Nipun.Gupta@amd.com>
> Cc: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> rafael@kernel.org; maz@kernel.org; tglx@linutronix.de; okaya@kernel.org;
> Anand, Harpreet <harpreet.anand@amd.com>; Simek, Michal
> <michal.simek@amd.com>; Agarwal, Nikhil <nikhil.agarwal@amd.com>
> Subject: Re: [RFC PATCH 2/2] driver core: add compatible string in sysfs for
> platform devices
>
> [CAUTION: External Email]
>
> On Wed, Aug 03, 2022 at 05:56:55PM +0530, Nipun Gupta wrote:
> > For devices registered dynamically using platform_device_register
> > API, this patch exposes the sysfs entry for the compatible string.
> >
> > Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
> > ---
> > drivers/base/platform.c | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> > index 51bb2289865c..89949f88a0a1 100644
> > --- a/drivers/base/platform.c
> > +++ b/drivers/base/platform.c
> > @@ -1289,10 +1289,25 @@ static ssize_t driver_override_store(struct device
> *dev,
> > }
> > static DEVICE_ATTR_RW(driver_override);
> >
> > +static ssize_t compatible_show(struct device *dev, struct device_attribute
> *attr,
> > + char *buf)
> > +{
> > + const char *compat;
> > + int ret;
> > +
> > + ret = device_property_read_string(dev, "compatible", &compat);
> > + if (ret != 0)
> > + return 0;
> > +
> > + return sysfs_emit(buf, "%s", compat);
> > +}
> > +static DEVICE_ATTR_RO(compatible);
>
> You forgot the Documentation/ABI/ update :(
Thanks for pointing. Will be adding the new sysfs entry as part
of the documentation.
>
> Also, what happens if there is no such string to read? Why are you
> returning 0? You should not create the attribute at all then, right?
Will be updating platform_dev_attrs_visible() API to have it visible
depending on if the attribute is available. Yes, then we may not need
this check here and would be part of the platform_dev_attrs_visible() API.
Thanks,
Nipun
>
> thanks,
>
> greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-03 12:46 UTC|newest]
Thread overview: 198+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 12:26 [RFC PATCH 0/2] add support for CDX bus MSI domain Nipun Gupta
2022-08-03 12:26 ` Nipun Gupta
2022-08-03 12:26 ` [RFC PATCH 1/2] irqchip: cdx-bus: add cdx-MSI domain with gic-its domain as parent Nipun Gupta
2022-08-03 12:26 ` Nipun Gupta
2022-08-03 12:33 ` Greg KH
2022-08-03 12:33 ` Greg KH
2022-08-03 12:37 ` Gupta, Nipun
2022-08-03 12:37 ` Gupta, Nipun
2022-08-04 8:49 ` Marc Zyngier
2022-08-04 8:49 ` Marc Zyngier
2022-08-04 9:18 ` Gupta, Nipun
2022-08-04 9:18 ` Gupta, Nipun
2022-08-04 10:38 ` Marc Zyngier
2022-08-04 12:11 ` Gupta, Nipun
2022-08-04 12:11 ` Gupta, Nipun
2022-08-03 12:26 ` [RFC PATCH 2/2] driver core: add compatible string in sysfs for platform devices Nipun Gupta
2022-08-03 12:26 ` Nipun Gupta
2022-08-03 12:31 ` Greg KH
2022-08-03 12:31 ` Greg KH
2022-08-03 12:46 ` Gupta, Nipun [this message]
2022-08-03 12:46 ` Gupta, Nipun
2022-08-03 14:16 ` [RFC PATCH 0/2] add support for CDX bus MSI domain Robin Murphy
2022-08-03 14:16 ` Robin Murphy
2022-08-04 4:23 ` Gupta, Nipun
2022-08-04 4:23 ` Gupta, Nipun
2022-08-17 16:00 ` Jason Gunthorpe
2022-08-17 16:00 ` Jason Gunthorpe
2022-08-17 15:05 ` [RFC PATCH v2 0/6] add support for CDX bus controller Nipun Gupta
2022-08-17 15:05 ` [RFC PATCH v2 1/6] Documentation: DT: Add entry for CDX controller Nipun Gupta
2022-08-18 9:54 ` Krzysztof Kozlowski
2022-08-18 9:59 ` Krzysztof Kozlowski
2022-09-05 14:05 ` Gupta, Nipun
2022-09-06 6:55 ` Krzysztof Kozlowski
2022-09-06 7:03 ` Gupta, Nipun
2022-09-06 7:20 ` Krzysztof Kozlowski
2022-08-17 15:05 ` [RFC PATCH v2 2/6] bus/cdx: add the cdx bus driver Nipun Gupta
2022-08-17 15:32 ` Greg KH
2022-08-17 15:46 ` Marc Zyngier
2022-08-22 13:21 ` Gupta, Nipun
2022-08-22 13:29 ` Greg KH
2022-08-24 8:50 ` Gupta, Nipun
2022-08-24 12:11 ` Greg KH
2022-08-24 23:31 ` Jason Gunthorpe
2022-08-25 18:38 ` Saravana Kannan
2022-08-25 19:57 ` Robin Murphy
2022-08-26 0:08 ` Jason Gunthorpe
2022-08-29 4:49 ` Gupta, Nipun
2022-08-29 4:49 ` Gupta, Nipun
2022-08-29 15:31 ` Jason Gunthorpe
2022-08-30 7:06 ` Gupta, Nipun
2022-08-30 11:25 ` Robin Murphy
2022-08-30 13:01 ` Jason Gunthorpe
2022-08-30 13:12 ` Gupta, Nipun
2022-08-17 15:05 ` [RFC PATCH v2 3/6] bus/cdx: add cdx-MSI domain with gic-its domain as parent Nipun Gupta
2022-08-17 15:33 ` Greg KH
2022-08-17 15:05 ` [RFC PATCH v2 4/6] bus/cdx: add rescan and reset support Nipun Gupta
2022-08-17 15:05 ` [RFC PATCH v2 5/6] vfio: platform: reset: add reset for cdx devices Nipun Gupta
2022-08-17 15:05 ` [RFC PATCH v2 6/6] driver core: add compatible string in sysfs for platform devices Nipun Gupta
2022-08-17 15:30 ` Greg KH
2022-08-17 16:04 ` Saravana Kannan
2022-09-05 13:54 ` Gupta, Nipun
2022-09-06 13:47 ` [RFC PATCH v3 0/7] add support for CDX bus Nipun Gupta
2022-09-06 13:47 ` Nipun Gupta
2022-09-06 13:47 ` [RFC PATCH v3 1/7] dt-bindings: bus: add CDX bus device tree bindings Nipun Gupta
2022-09-06 13:47 ` Nipun Gupta
2022-09-06 17:46 ` Rob Herring
2022-09-06 17:46 ` Rob Herring
2022-09-07 3:13 ` Gupta, Nipun
2022-09-07 3:13 ` Gupta, Nipun
2022-09-08 10:51 ` Krzysztof Kozlowski
2022-09-08 10:51 ` Krzysztof Kozlowski
2022-09-06 13:47 ` [RFC PATCH v3 2/7] bus/cdx: add the cdx bus driver Nipun Gupta
2022-09-06 13:47 ` Nipun Gupta
2022-09-07 0:32 ` Saravana Kannan
2022-09-07 0:32 ` Saravana Kannan
2022-09-07 3:21 ` Gupta, Nipun
2022-09-07 3:21 ` Gupta, Nipun
2022-09-07 18:06 ` Saravana Kannan
2022-09-07 18:06 ` Saravana Kannan
2022-09-07 12:32 ` Greg KH
2022-09-07 12:32 ` Greg KH
2022-09-08 13:29 ` Gupta, Nipun
2022-09-08 13:29 ` Gupta, Nipun
2022-09-06 13:47 ` [RFC PATCH v3 3/7] iommu/arm-smmu-v3: support ops registration for CDX bus Nipun Gupta
2022-09-06 13:47 ` Nipun Gupta
2022-09-07 0:10 ` Saravana Kannan
2022-09-07 0:10 ` Saravana Kannan
2022-09-07 3:17 ` Gupta, Nipun
2022-09-07 3:17 ` Gupta, Nipun
2022-09-07 8:27 ` Robin Murphy
2022-09-07 8:27 ` Robin Murphy
2022-09-07 18:24 ` Saravana Kannan
2022-09-07 18:24 ` Saravana Kannan
2022-09-07 20:40 ` Robin Murphy
2022-09-07 20:40 ` Robin Murphy
2022-09-08 0:14 ` Saravana Kannan
2022-09-08 0:14 ` Saravana Kannan
2022-09-06 13:47 ` [RFC PATCH v3 4/7] bus/cdx: add cdx-MSI domain with gic-its domain as parent Nipun Gupta
2022-09-06 13:47 ` Nipun Gupta
2022-09-06 17:19 ` Jason Gunthorpe
2022-09-06 17:19 ` Jason Gunthorpe
2022-09-07 11:17 ` Marc Zyngier
2022-09-07 11:17 ` Marc Zyngier
2022-09-07 11:33 ` Robin Murphy
2022-09-07 11:33 ` Robin Murphy
2022-09-07 12:14 ` Marc Zyngier
2022-09-07 12:14 ` Marc Zyngier
2022-09-07 11:35 ` Radovanovic, Aleksandar
2022-09-07 11:35 ` Radovanovic, Aleksandar
2022-09-07 12:32 ` Marc Zyngier
2022-09-07 13:18 ` Radovanovic, Aleksandar
2022-09-07 13:18 ` Radovanovic, Aleksandar
2022-09-08 8:08 ` Marc Zyngier
2022-09-08 9:51 ` Radovanovic, Aleksandar
2022-09-08 9:51 ` Radovanovic, Aleksandar
2022-09-08 11:49 ` Robin Murphy
2022-09-08 11:49 ` Robin Murphy
2022-09-08 14:18 ` Marc Zyngier
2022-09-07 13:18 ` Marc Zyngier
2022-09-07 13:18 ` Marc Zyngier
2022-09-08 14:13 ` Gupta, Nipun
2022-09-08 14:13 ` Gupta, Nipun
2022-09-08 14:29 ` Marc Zyngier
2022-09-09 6:32 ` Gupta, Nipun
2022-09-09 6:32 ` Gupta, Nipun
2022-10-12 10:04 ` Gupta, Nipun
2022-10-12 10:04 ` Gupta, Nipun
2022-10-12 10:34 ` Radovanovic, Aleksandar
2022-10-12 10:34 ` Radovanovic, Aleksandar
2022-10-12 13:02 ` Jason Gunthorpe
2022-10-12 13:02 ` Jason Gunthorpe
2022-10-12 13:37 ` Radovanovic, Aleksandar
2022-10-12 13:37 ` Radovanovic, Aleksandar
2022-10-12 14:38 ` Jason Gunthorpe
2022-10-12 14:38 ` Jason Gunthorpe
2022-10-12 15:09 ` Radovanovic, Aleksandar
2022-10-12 15:09 ` Radovanovic, Aleksandar
2022-10-13 12:43 ` Jason Gunthorpe
2022-10-13 12:43 ` Jason Gunthorpe
2022-10-14 11:18 ` Radovanovic, Aleksandar
2022-10-14 11:18 ` Radovanovic, Aleksandar
2022-10-14 11:54 ` gregkh
2022-10-14 11:54 ` gregkh
2022-10-14 12:13 ` Radovanovic, Aleksandar
2022-10-14 12:13 ` Radovanovic, Aleksandar
2022-10-14 13:46 ` gregkh
2022-10-14 13:46 ` gregkh
2022-10-14 13:58 ` Jason Gunthorpe
2022-10-14 13:58 ` Jason Gunthorpe
2022-09-06 13:47 ` [RFC PATCH v3 5/7] bus/cdx: add bus and device attributes Nipun Gupta
2022-09-06 13:47 ` Nipun Gupta
2022-09-06 13:48 ` [RFC PATCH v3 6/7] vfio/cdx: add support for CDX bus Nipun Gupta
2022-09-06 13:48 ` Nipun Gupta
2022-09-06 17:20 ` Jason Gunthorpe
2022-09-06 17:20 ` Jason Gunthorpe
2022-09-06 17:23 ` Gupta, Nipun
2022-09-06 17:23 ` Gupta, Nipun
2022-09-06 13:48 ` [RFC PATCH v3 7/7] vfio/cdx: add interrupt support Nipun Gupta
2022-09-06 13:48 ` Nipun Gupta
2022-10-14 4:40 ` [RFC PATCH v4 0/8] add support for CDX bus Nipun Gupta
2022-10-14 4:40 ` Nipun Gupta
2022-10-14 4:40 ` [RFC PATCH v4 1/8] dt-bindings: bus: add CDX bus device tree bindings Nipun Gupta
2022-10-14 4:40 ` Nipun Gupta
2022-10-14 14:17 ` Rob Herring
2022-10-14 14:17 ` Rob Herring
2022-10-17 10:18 ` Gupta, Nipun
2022-10-17 10:18 ` Gupta, Nipun
2022-10-14 4:40 ` [RFC PATCH v4 2/8] bus/cdx: add the cdx bus driver Nipun Gupta
2022-10-14 4:40 ` Nipun Gupta
2022-10-14 7:15 ` Greg KH
2022-10-14 7:15 ` Greg KH
2022-10-14 8:12 ` Gupta, Nipun
2022-10-14 8:12 ` Gupta, Nipun
2022-10-14 7:18 ` Greg KH
2022-10-14 7:18 ` Greg KH
2022-10-14 8:20 ` Gupta, Nipun
2022-10-14 8:20 ` Gupta, Nipun
2022-10-14 4:40 ` [RFC PATCH v4 3/8] iommu/arm-smmu-v3: support ops registration for CDX bus Nipun Gupta
2022-10-14 4:40 ` Nipun Gupta
2022-10-14 4:51 ` Gupta, Nipun
2022-10-14 4:51 ` Gupta, Nipun
2022-10-14 4:40 ` [RFC PATCH v4 4/8] bux/cdx: support dma configuration for CDX devices Nipun Gupta
2022-10-14 4:40 ` Nipun Gupta
2022-10-14 4:40 ` [RFC PATCH v4 5/8] bus/cdx: add bus and device attributes Nipun Gupta
2022-10-14 4:40 ` Nipun Gupta
2022-10-14 4:40 ` [RFC PATCH v4 6/8] irq/msi: use implicit msi domain for alloc and free Nipun Gupta
2022-10-14 4:40 ` Nipun Gupta
2022-10-14 4:40 ` [RFC PATCH v4 7/8] bus/cdx: add cdx-MSI domain with gic-its domain as parent Nipun Gupta
2022-10-14 4:40 ` Nipun Gupta
2022-10-17 13:08 ` kernel test robot
2022-11-17 19:10 ` Thomas Gleixner
2022-11-17 19:10 ` Thomas Gleixner
2022-10-14 4:40 ` [RFC PATCH v4 8/8] bus/cdx: add cdx controller Nipun Gupta
2022-10-14 4:40 ` Nipun Gupta
2022-10-14 14:10 ` [RFC PATCH v4 0/8] add support for CDX bus Rob Herring
2022-10-14 14:10 ` Rob Herring
2022-10-17 10:08 ` Gupta, Nipun
2022-10-17 10:08 ` Gupta, Nipun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB30827E57AA6000BDC5AE6FEDE89C9@DM6PR12MB3082.namprd12.prod.outlook.com \
--to=nipun.gupta@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=harpreet.anand@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=michal.simek@amd.com \
--cc=nikhil.agarwal@amd.com \
--cc=okaya@kernel.org \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.