From: "Yang, Fei" <fei.yang@intel.com> To: "Hajda, Andrzej" <andrzej.hajda@intel.com>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org> Cc: "Roper, Matthew D" <matthew.d.roper@intel.com>, "De Marchi, Lucas" <lucas.demarchi@intel.com>, Madhumitha Tolakanahalli Pradeep <madhumitha.tolakanahalli.pradeep@intel.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org> Subject: RE: [Intel-gfx] [PATCH 2/8] drm/i915/mtl: Define MOCS and PAT tables for MTL Date: Wed, 19 Apr 2023 16:03:50 +0000 [thread overview] Message-ID: <SN6PR11MB25744F6D7DE1AF772278D0B09A629@SN6PR11MB2574.namprd11.prod.outlook.com> (raw) In-Reply-To: <95df8360-99ef-2184-401b-f10873de0fe5@intel.com> >> void setup_private_pat(struct intel_gt *gt) >> >> GEM_BUG_ON(GRAPHICS_VER(i915) < 8); >> >> - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) >> - xehp_setup_private_ppat(gt); >> - else if (GRAPHICS_VER(i915) >= 12) >> - tgl_setup_private_ppat(uncore); >> - else if (GRAPHICS_VER(i915) >= 11) >> - icl_setup_private_ppat(uncore); >> - else if (IS_CHERRYVIEW(i915) || IS_GEN9_LP(i915)) >> - chv_setup_private_ppat(uncore); >> - else >> - bdw_setup_private_ppat(uncore); >> + if (gt->type == GT_MEDIA) { >> + xelpmp_setup_private_ppat(gt->uncore); >> + } else { >> + if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 70)) > > You could just use "else if" here to avoid indendation, for now it would work, up to you. Will update. >> + xelpg_setup_private_ppat(gt); >> + else if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) >> + xehp_setup_private_ppat(gt); >> + else if (GRAPHICS_VER(i915) >= 12) >> + tgl_setup_private_ppat(uncore); >> + else if (GRAPHICS_VER(i915) >= 11) >> + icl_setup_private_ppat(uncore); >> + else if (IS_CHERRYVIEW(i915) || IS_GEN9_LP(i915)) >> + chv_setup_private_ppat(uncore); >> + else >> + bdw_setup_private_ppat(uncore); >> + } >> } ......
WARNING: multiple messages have this Message-ID (diff)
From: "Yang, Fei" <fei.yang@intel.com> To: "Hajda, Andrzej" <andrzej.hajda@intel.com>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org> Cc: "Roper, Matthew D" <matthew.d.roper@intel.com>, "De Marchi, Lucas" <lucas.demarchi@intel.com>, Madhumitha Tolakanahalli Pradeep <madhumitha.tolakanahalli.pradeep@intel.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org> Subject: Re: [Intel-gfx] [PATCH 2/8] drm/i915/mtl: Define MOCS and PAT tables for MTL Date: Wed, 19 Apr 2023 16:03:50 +0000 [thread overview] Message-ID: <SN6PR11MB25744F6D7DE1AF772278D0B09A629@SN6PR11MB2574.namprd11.prod.outlook.com> (raw) In-Reply-To: <95df8360-99ef-2184-401b-f10873de0fe5@intel.com> >> void setup_private_pat(struct intel_gt *gt) >> >> GEM_BUG_ON(GRAPHICS_VER(i915) < 8); >> >> - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) >> - xehp_setup_private_ppat(gt); >> - else if (GRAPHICS_VER(i915) >= 12) >> - tgl_setup_private_ppat(uncore); >> - else if (GRAPHICS_VER(i915) >= 11) >> - icl_setup_private_ppat(uncore); >> - else if (IS_CHERRYVIEW(i915) || IS_GEN9_LP(i915)) >> - chv_setup_private_ppat(uncore); >> - else >> - bdw_setup_private_ppat(uncore); >> + if (gt->type == GT_MEDIA) { >> + xelpmp_setup_private_ppat(gt->uncore); >> + } else { >> + if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 70)) > > You could just use "else if" here to avoid indendation, for now it would work, up to you. Will update. >> + xelpg_setup_private_ppat(gt); >> + else if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) >> + xehp_setup_private_ppat(gt); >> + else if (GRAPHICS_VER(i915) >= 12) >> + tgl_setup_private_ppat(uncore); >> + else if (GRAPHICS_VER(i915) >= 11) >> + icl_setup_private_ppat(uncore); >> + else if (IS_CHERRYVIEW(i915) || IS_GEN9_LP(i915)) >> + chv_setup_private_ppat(uncore); >> + else >> + bdw_setup_private_ppat(uncore); >> + } >> } ......
next prev parent reply other threads:[~2023-04-19 16:04 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-04-17 6:24 [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL fei.yang 2023-04-17 6:24 ` [Intel-gfx] " fei.yang 2023-04-17 6:24 ` [PATCH 1/8] drm/i915/mtl: Set has_llc=0 fei.yang 2023-04-17 6:24 ` [Intel-gfx] " fei.yang 2023-04-19 10:59 ` Andi Shyti 2023-04-19 12:50 ` Andrzej Hajda 2023-04-19 14:10 ` Das, Nirmoy 2023-04-17 6:24 ` [PATCH 2/8] drm/i915/mtl: Define MOCS and PAT tables for MTL fei.yang 2023-04-17 6:24 ` [Intel-gfx] " fei.yang 2023-04-19 11:01 ` Andi Shyti 2023-04-19 16:00 ` Yang, Fei 2023-04-19 16:00 ` Yang, Fei 2023-04-19 13:59 ` Andrzej Hajda 2023-04-19 16:03 ` Yang, Fei [this message] 2023-04-19 16:03 ` Yang, Fei 2023-04-19 14:36 ` Das, Nirmoy 2023-04-19 16:05 ` Yang, Fei 2023-04-19 16:05 ` Yang, Fei 2023-04-17 6:24 ` [PATCH 3/8] drm/i915/mtl: Add PTE encode function fei.yang 2023-04-17 6:24 ` [Intel-gfx] " fei.yang 2023-04-19 11:02 ` Andi Shyti 2023-04-19 12:51 ` Andrzej Hajda 2023-04-19 15:11 ` Das, Nirmoy 2023-04-19 15:11 ` [Intel-gfx] " Das, Nirmoy 2023-04-17 6:24 ` [PATCH 4/8] drm/i915/mtl: workaround coherency issue for Media fei.yang 2023-04-17 6:24 ` [Intel-gfx] " fei.yang 2023-04-19 10:59 ` Andi Shyti 2023-04-19 12:38 ` Andi Shyti 2023-04-19 15:14 ` Das, Nirmoy 2023-04-19 15:14 ` [Intel-gfx] " Das, Nirmoy 2023-04-19 15:40 ` Andrzej Hajda 2023-04-19 16:37 ` Yang, Fei 2023-04-19 16:37 ` Yang, Fei 2023-04-19 18:49 ` Yang, Fei 2023-04-19 18:49 ` Yang, Fei 2023-04-17 6:25 ` [PATCH 5/8] drm/i915/mtl: end support for set caching ioctl fei.yang 2023-04-17 6:25 ` [Intel-gfx] " fei.yang 2023-04-19 11:08 ` Andi Shyti 2023-04-19 13:05 ` Andrzej Hajda 2023-04-19 16:56 ` Yang, Fei 2023-04-19 16:56 ` Yang, Fei 2023-04-17 6:25 ` [PATCH 6/8] drm/i915: preparation for using PAT index fei.yang 2023-04-17 6:25 ` [Intel-gfx] " fei.yang 2023-04-19 11:17 ` Andi Shyti 2023-04-19 11:17 ` [Intel-gfx] " Andi Shyti 2023-04-17 6:25 ` [PATCH 7/8] drm/i915: use pat_index instead of cache_level fei.yang 2023-04-17 6:25 ` [Intel-gfx] " fei.yang 2023-04-19 12:16 ` Andi Shyti 2023-04-17 6:25 ` [PATCH 8/8] drm/i915: Allow user to set cache at BO creation fei.yang 2023-04-17 6:25 ` [Intel-gfx] " fei.yang 2023-04-19 12:23 ` Andi Shyti 2023-04-19 12:23 ` [Intel-gfx] " Andi Shyti 2023-04-17 6:32 ` [Intel-gfx] [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL Timo Aaltonen 2023-04-17 6:43 ` Yang, Fei 2023-04-17 6:43 ` Yang, Fei 2023-04-24 20:00 ` Jordan Justen 2023-04-24 20:00 ` Jordan Justen 2023-04-17 11:59 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: Define MOCS and PAT tables for MTL (rev5) Patchwork 2023-04-17 11:59 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2023-04-17 12:15 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork 2023-04-19 18:09 [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL fei.yang 2023-04-19 18:09 ` [Intel-gfx] [PATCH 2/8] " fei.yang 2023-04-19 21:12 [PATCH 0/8] " fei.yang 2023-04-19 21:12 ` [Intel-gfx] [PATCH 2/8] " fei.yang 2023-04-19 21:48 ` Andi Shyti 2023-04-19 23:00 ` Yang, Fei 2023-04-19 23:00 ` Yang, Fei 2023-04-19 21:59 ` Andi Shyti 2023-04-19 23:00 [PATCH 0/8] " fei.yang 2023-04-19 23:00 ` [Intel-gfx] [PATCH 2/8] " fei.yang 2023-04-20 20:29 ` Matt Roper
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=SN6PR11MB25744F6D7DE1AF772278D0B09A629@SN6PR11MB2574.namprd11.prod.outlook.com \ --to=fei.yang@intel.com \ --cc=andrzej.hajda@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=lucas.demarchi@intel.com \ --cc=madhumitha.tolakanahalli.pradeep@intel.com \ --cc=matthew.d.roper@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.