All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: fei.yang@intel.com
Cc: Matt Roper <matthew.d.roper@intel.com>,
	intel-gfx@lists.freedesktop.org,
	Chris Wilson <chris.p.wilson@linux.intel.com>,
	Andi Shyti <andi.shyti@linux.intel.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 8/8] drm/i915: Allow user to set cache at BO creation
Date: Wed, 19 Apr 2023 14:23:59 +0200	[thread overview]
Message-ID: <ZD/dX1Xsb9D3zLqK@ashyti-mobl2.lan> (raw)
In-Reply-To: <20230417062503.1884465-9-fei.yang@intel.com>

On Sun, Apr 16, 2023 at 11:25:03PM -0700, fei.yang@intel.com wrote:
> From: Fei Yang <fei.yang@intel.com>
> 
> To comply with the design that buffer objects shall have immutable
> cache setting through out its life cycle, {set, get}_caching ioctl's

/its/their/

> are no longer supported from MTL onward. With that change caching
> policy can only be set at object creation time. The current code
> applies a default (platform dependent) cache setting for all objects.
> However this is not optimal for performance tuning. The patch extends
> the existing gem_create uAPI to let user set PAT index for the object
> at creation time.
> The new extension is platform independent, so UMD's can switch to using
> this extension for older platforms as well, while {set, get}_caching are
> still supported on these legacy paltforms for compatibility reason.
> 
> Cc: Chris Wilson <chris.p.wilson@linux.intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Signed-off-by: Fei Yang <fei.yang@intel.com>

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> 

Andi

WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@linux.intel.com>
To: fei.yang@intel.com
Cc: Matt Roper <matthew.d.roper@intel.com>,
	intel-gfx@lists.freedesktop.org,
	Chris Wilson <chris.p.wilson@linux.intel.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 8/8] drm/i915: Allow user to set cache at BO creation
Date: Wed, 19 Apr 2023 14:23:59 +0200	[thread overview]
Message-ID: <ZD/dX1Xsb9D3zLqK@ashyti-mobl2.lan> (raw)
In-Reply-To: <20230417062503.1884465-9-fei.yang@intel.com>

On Sun, Apr 16, 2023 at 11:25:03PM -0700, fei.yang@intel.com wrote:
> From: Fei Yang <fei.yang@intel.com>
> 
> To comply with the design that buffer objects shall have immutable
> cache setting through out its life cycle, {set, get}_caching ioctl's

/its/their/

> are no longer supported from MTL onward. With that change caching
> policy can only be set at object creation time. The current code
> applies a default (platform dependent) cache setting for all objects.
> However this is not optimal for performance tuning. The patch extends
> the existing gem_create uAPI to let user set PAT index for the object
> at creation time.
> The new extension is platform independent, so UMD's can switch to using
> this extension for older platforms as well, while {set, get}_caching are
> still supported on these legacy paltforms for compatibility reason.
> 
> Cc: Chris Wilson <chris.p.wilson@linux.intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Signed-off-by: Fei Yang <fei.yang@intel.com>

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> 

Andi

  reply	other threads:[~2023-04-19 12:24 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17  6:24 [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL fei.yang
2023-04-17  6:24 ` [Intel-gfx] " fei.yang
2023-04-17  6:24 ` [PATCH 1/8] drm/i915/mtl: Set has_llc=0 fei.yang
2023-04-17  6:24   ` [Intel-gfx] " fei.yang
2023-04-19 10:59   ` Andi Shyti
2023-04-19 12:50   ` Andrzej Hajda
2023-04-19 14:10   ` Das, Nirmoy
2023-04-17  6:24 ` [PATCH 2/8] drm/i915/mtl: Define MOCS and PAT tables for MTL fei.yang
2023-04-17  6:24   ` [Intel-gfx] " fei.yang
2023-04-19 11:01   ` Andi Shyti
2023-04-19 16:00     ` Yang, Fei
2023-04-19 16:00       ` Yang, Fei
2023-04-19 13:59   ` Andrzej Hajda
2023-04-19 16:03     ` Yang, Fei
2023-04-19 16:03       ` Yang, Fei
2023-04-19 14:36   ` Das, Nirmoy
2023-04-19 16:05     ` Yang, Fei
2023-04-19 16:05       ` Yang, Fei
2023-04-17  6:24 ` [PATCH 3/8] drm/i915/mtl: Add PTE encode function fei.yang
2023-04-17  6:24   ` [Intel-gfx] " fei.yang
2023-04-19 11:02   ` Andi Shyti
2023-04-19 12:51   ` Andrzej Hajda
2023-04-19 15:11   ` Das, Nirmoy
2023-04-19 15:11     ` [Intel-gfx] " Das, Nirmoy
2023-04-17  6:24 ` [PATCH 4/8] drm/i915/mtl: workaround coherency issue for Media fei.yang
2023-04-17  6:24   ` [Intel-gfx] " fei.yang
2023-04-19 10:59   ` Andi Shyti
2023-04-19 12:38     ` Andi Shyti
2023-04-19 15:14   ` Das, Nirmoy
2023-04-19 15:14     ` [Intel-gfx] " Das, Nirmoy
2023-04-19 15:40   ` Andrzej Hajda
2023-04-19 16:37     ` Yang, Fei
2023-04-19 16:37       ` Yang, Fei
2023-04-19 18:49       ` Yang, Fei
2023-04-19 18:49         ` Yang, Fei
2023-04-17  6:25 ` [PATCH 5/8] drm/i915/mtl: end support for set caching ioctl fei.yang
2023-04-17  6:25   ` [Intel-gfx] " fei.yang
2023-04-19 11:08   ` Andi Shyti
2023-04-19 13:05   ` Andrzej Hajda
2023-04-19 16:56     ` Yang, Fei
2023-04-19 16:56       ` Yang, Fei
2023-04-17  6:25 ` [PATCH 6/8] drm/i915: preparation for using PAT index fei.yang
2023-04-17  6:25   ` [Intel-gfx] " fei.yang
2023-04-19 11:17   ` Andi Shyti
2023-04-19 11:17     ` [Intel-gfx] " Andi Shyti
2023-04-17  6:25 ` [PATCH 7/8] drm/i915: use pat_index instead of cache_level fei.yang
2023-04-17  6:25   ` [Intel-gfx] " fei.yang
2023-04-19 12:16   ` Andi Shyti
2023-04-17  6:25 ` [PATCH 8/8] drm/i915: Allow user to set cache at BO creation fei.yang
2023-04-17  6:25   ` [Intel-gfx] " fei.yang
2023-04-19 12:23   ` Andi Shyti [this message]
2023-04-19 12:23     ` Andi Shyti
2023-04-17  6:32 ` [Intel-gfx] [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL Timo Aaltonen
2023-04-17  6:43   ` Yang, Fei
2023-04-17  6:43     ` Yang, Fei
2023-04-24 20:00     ` Jordan Justen
2023-04-24 20:00       ` Jordan Justen
2023-04-17 11:59 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: Define MOCS and PAT tables for MTL (rev5) Patchwork
2023-04-17 11:59 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-04-17 12:15 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2023-04-19 23:00 [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL fei.yang
2023-04-19 23:00 ` [PATCH 8/8] drm/i915: Allow user to set cache at BO creation fei.yang
2023-04-20 11:39   ` Andi Shyti
2023-04-19 21:12 [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL fei.yang
2023-04-19 21:12 ` [PATCH 8/8] drm/i915: Allow user to set cache at BO creation fei.yang
2023-04-19 22:14   ` Andi Shyti
2023-04-19 18:09 [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL fei.yang
2023-04-19 18:09 ` [PATCH 8/8] drm/i915: Allow user to set cache at BO creation fei.yang
2023-04-07  7:12 [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL fei.yang
2023-04-07  7:12 ` [PATCH 8/8] drm/i915: Allow user to set cache at BO creation fei.yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZD/dX1Xsb9D3zLqK@ashyti-mobl2.lan \
    --to=andi.shyti@linux.intel.com \
    --cc=chris.p.wilson@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fei.yang@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.