From: Conor Dooley <conor@kernel.org>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Andy Chiu <andy.chiu@sifive.com>,
linux-riscv@lists.infradead.org, palmer@dabbelt.com,
anup@brainfault.org, atishp@atishpatra.org,
kvm-riscv@lists.infradead.org, kvm@vger.kernel.org,
vineetg@rivosinc.com, greentime.hu@sifive.com,
guoren@linux.alibaba.com,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>
Subject: Re: [PATCH -next v13 19/19] riscv: Enable Vector code to be built
Date: Wed, 8 Feb 2023 18:19:14 +0000 [thread overview]
Message-ID: <Y+PnorGskAAIsODw@spud> (raw)
In-Reply-To: <Y9d8IBqXyep+PJTq@wendy>
[-- Attachment #1: Type: text/plain, Size: 1685 bytes --]
Hey Andy,
On Mon, Jan 30, 2023 at 08:13:20AM +0000, Conor Dooley wrote:
> On Mon, Jan 30, 2023 at 03:46:32PM +0800, Andy Chiu wrote:
> > On Thu, Jan 26, 2023 at 5:04 AM Conor Dooley <conor@kernel.org> wrote:
> > > Firstly, no-implicit-float is a CFLAG, so why add it to march?
> > I placed it in march because I thought we need the flag in vdso. And,
> > KBUILD_CFLAGS is not enough for vdso. However, I think we don't need
> > this flag in vdso since it is run in user space anyway.
> > > There is an existing patch on the list for enabling this flag, but I
> > > recall Palmer saying that it was not actually needed?
> > The flag is needed for clang builds to prevent auto-vectorization from
> > using V in the kernel code [1].
> >
> > > Palmer, do you remember why that was?
> > The discussion[2] suggested that we need this flag, IIUC. But somehow
> > the patch did make it into the tree.
>
> I know, in [1] I left an R-b as the patch seemed reasonable to me.
> Palmer mentioned some reason for not thinking it was actually needed but
> not on-list, so I was hoping he'd comment!
Palmer replied there today with his rationale & an expectation that we
do the same thing for vector as we did for float:
https://lore.kernel.org/linux-riscv/mhng-4c71ada6-003c-414f-9a74-efa3ccd2856b@palmer-ri-x1c9/T/#m366779709bbcf7672b5277b3bb27a7d6ce6c6115
>
> And I suppose, it never got any further attention as it isn't needed by
> any in-tree code?
>
> > [1]https://lore.kernel.org/all/CAOnJCULtT-y9vo6YhW7bW9XyKRdod-hvFfr02jHVamR_LcsKdA@mail.gmail.com/
> > [2]https://lore.kernel.org/all/20221216185012.2342675-1-abdulras@google.com/
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Andy Chiu <andy.chiu@sifive.com>,
linux-riscv@lists.infradead.org, palmer@dabbelt.com,
anup@brainfault.org, atishp@atishpatra.org,
kvm-riscv@lists.infradead.org, kvm@vger.kernel.org,
vineetg@rivosinc.com, greentime.hu@sifive.com,
guoren@linux.alibaba.com,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>
Subject: Re: [PATCH -next v13 19/19] riscv: Enable Vector code to be built
Date: Wed, 8 Feb 2023 18:19:14 +0000 [thread overview]
Message-ID: <Y+PnorGskAAIsODw@spud> (raw)
In-Reply-To: <Y9d8IBqXyep+PJTq@wendy>
[-- Attachment #1.1: Type: text/plain, Size: 1685 bytes --]
Hey Andy,
On Mon, Jan 30, 2023 at 08:13:20AM +0000, Conor Dooley wrote:
> On Mon, Jan 30, 2023 at 03:46:32PM +0800, Andy Chiu wrote:
> > On Thu, Jan 26, 2023 at 5:04 AM Conor Dooley <conor@kernel.org> wrote:
> > > Firstly, no-implicit-float is a CFLAG, so why add it to march?
> > I placed it in march because I thought we need the flag in vdso. And,
> > KBUILD_CFLAGS is not enough for vdso. However, I think we don't need
> > this flag in vdso since it is run in user space anyway.
> > > There is an existing patch on the list for enabling this flag, but I
> > > recall Palmer saying that it was not actually needed?
> > The flag is needed for clang builds to prevent auto-vectorization from
> > using V in the kernel code [1].
> >
> > > Palmer, do you remember why that was?
> > The discussion[2] suggested that we need this flag, IIUC. But somehow
> > the patch did make it into the tree.
>
> I know, in [1] I left an R-b as the patch seemed reasonable to me.
> Palmer mentioned some reason for not thinking it was actually needed but
> not on-list, so I was hoping he'd comment!
Palmer replied there today with his rationale & an expectation that we
do the same thing for vector as we did for float:
https://lore.kernel.org/linux-riscv/mhng-4c71ada6-003c-414f-9a74-efa3ccd2856b@palmer-ri-x1c9/T/#m366779709bbcf7672b5277b3bb27a7d6ce6c6115
>
> And I suppose, it never got any further attention as it isn't needed by
> any in-tree code?
>
> > [1]https://lore.kernel.org/all/CAOnJCULtT-y9vo6YhW7bW9XyKRdod-hvFfr02jHVamR_LcsKdA@mail.gmail.com/
> > [2]https://lore.kernel.org/all/20221216185012.2342675-1-abdulras@google.com/
Cheers,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-02-08 18:19 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 14:20 [PATCH -next v13 00/19] riscv: Add vector ISA support Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-25 14:20 ` [PATCH -next v13 01/19] riscv: Rename __switch_to_aux -> fpu Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-25 21:15 ` Conor Dooley
2023-01-25 21:15 ` Conor Dooley
2023-01-25 14:20 ` [PATCH -next v13 02/19] riscv: Extending cpufeature.c to detect V-extension Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-25 21:33 ` Conor Dooley
2023-01-25 21:33 ` Conor Dooley
2023-01-28 7:09 ` Guo Ren
2023-01-28 7:09 ` Guo Ren
2023-01-28 10:28 ` Conor Dooley
2023-01-28 10:28 ` Conor Dooley
2023-01-25 14:20 ` [PATCH -next v13 03/19] riscv: Add new csr defines related to vector extension Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-25 22:16 ` Conor Dooley
2023-01-25 22:16 ` Conor Dooley
2023-01-25 14:20 ` [PATCH -next v13 04/19] riscv: Clear vector regfile on bootup Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-25 21:54 ` Conor Dooley
2023-01-25 21:54 ` Conor Dooley
2023-01-25 21:57 ` Vineet Gupta
2023-01-25 21:57 ` Vineet Gupta
2023-01-25 22:18 ` Conor Dooley
2023-01-25 22:18 ` Conor Dooley
2023-01-25 14:20 ` [PATCH -next v13 05/19] riscv: Disable Vector Instructions for kernel itself Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-25 21:51 ` Conor Dooley
2023-01-25 21:51 ` Conor Dooley
2023-01-25 14:20 ` [PATCH -next v13 06/19] riscv: Introduce Vector enable/disable helpers Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-26 21:06 ` Conor Dooley
2023-01-26 21:06 ` Conor Dooley
2023-01-25 14:20 ` [PATCH -next v13 07/19] riscv: Introduce riscv_vsize to record size of Vector context Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-26 21:24 ` Conor Dooley
2023-01-26 21:24 ` Conor Dooley
2023-01-25 14:20 ` [PATCH -next v13 08/19] riscv: Introduce struct/helpers to save/restore per-task Vector state Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-26 21:32 ` Conor Dooley
2023-01-26 21:32 ` Conor Dooley
2023-01-25 14:20 ` [PATCH -next v13 09/19] riscv: Add task switch support for vector Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-26 21:44 ` Conor Dooley
2023-01-26 21:44 ` Conor Dooley
2023-01-31 2:55 ` Vineet Gupta
2023-01-31 2:55 ` Vineet Gupta
2023-01-25 14:20 ` [PATCH -next v13 10/19] riscv: Allocate user's vector context in the first-use trap Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-26 23:11 ` Conor Dooley
2023-01-26 23:11 ` Conor Dooley
2023-02-06 12:00 ` Andy Chiu
2023-02-06 12:00 ` Andy Chiu
2023-02-06 13:40 ` Conor Dooley
2023-02-06 13:40 ` Conor Dooley
2023-02-10 12:00 ` Andy Chiu
2023-02-10 12:00 ` Andy Chiu
2023-02-07 14:36 ` Björn Töpel
2023-02-07 14:36 ` Björn Töpel
2023-02-13 22:54 ` Vineet Gupta
2023-02-13 22:54 ` Vineet Gupta
2023-02-14 6:43 ` Björn Töpel
2023-02-14 6:43 ` Björn Töpel
2023-02-14 15:36 ` Andy Chiu
2023-02-14 15:36 ` Andy Chiu
2023-02-14 16:50 ` Björn Töpel
2023-02-14 16:50 ` Björn Töpel
2023-02-14 17:24 ` Vineet Gupta
2023-02-14 17:24 ` Vineet Gupta
2023-02-15 7:14 ` Björn Töpel
2023-02-15 7:14 ` Björn Töpel
2023-02-15 14:39 ` Andy Chiu
2023-02-15 14:39 ` Andy Chiu
2023-02-07 21:18 ` Vineet Gupta
2023-02-07 21:18 ` Vineet Gupta
2023-02-08 9:20 ` Björn Töpel
2023-02-08 9:20 ` Björn Töpel
2023-01-25 14:20 ` [PATCH -next v13 11/19] riscv: Add ptrace vector support Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-25 14:20 ` [PATCH -next v13 12/19] riscv: signal: check fp-reserved words unconditionally Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-25 14:20 ` [PATCH -next v13 13/19] riscv: signal: Add sigcontext save/restore for vector Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-25 14:20 ` [PATCH -next v13 14/19] riscv: signal: Report signal frame size to userspace via auxv Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-26 23:19 ` Conor Dooley
2023-01-26 23:19 ` Conor Dooley
2023-01-31 12:34 ` Andy Chiu
2023-01-31 12:34 ` Andy Chiu
2023-01-25 14:20 ` [PATCH -next v13 15/19] riscv: Fix a kernel panic issue if $s2 is set to a specific value before entering Linux Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-27 20:31 ` Conor Dooley
2023-01-27 20:31 ` Conor Dooley
2023-01-31 12:34 ` Andy Chiu
2023-01-31 12:34 ` Andy Chiu
2023-01-25 14:20 ` [PATCH -next v13 16/19] riscv: Add V extension to KVM ISA Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-27 20:43 ` Conor Dooley
2023-01-27 20:43 ` Conor Dooley
2023-01-30 9:58 ` Andy Chiu
2023-01-30 9:58 ` Andy Chiu
2023-01-25 14:20 ` [PATCH -next v13 17/19] riscv: KVM: Add vector lazy save/restore support Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-25 14:20 ` [PATCH -next v13 18/19] riscv: kvm: redirect illegal instruction traps to guests Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-27 11:28 ` Anup Patel
2023-01-27 11:28 ` Anup Patel
2023-01-30 8:18 ` Andy Chiu
2023-01-30 8:18 ` Andy Chiu
2023-01-25 14:20 ` [PATCH -next v13 19/19] riscv: Enable Vector code to be built Andy Chiu
2023-01-25 14:20 ` Andy Chiu
2023-01-25 21:04 ` Conor Dooley
2023-01-25 21:04 ` Conor Dooley
2023-01-25 21:38 ` Jessica Clarke
2023-01-25 21:38 ` Jessica Clarke
2023-01-25 22:24 ` Conor Dooley
2023-01-25 22:24 ` Conor Dooley
2023-01-30 6:38 ` Andy Chiu
2023-01-30 6:38 ` Andy Chiu
2023-01-30 18:38 ` Vineet Gupta
2023-01-30 18:38 ` Vineet Gupta
2023-01-30 7:46 ` Andy Chiu
2023-01-30 7:46 ` Andy Chiu
2023-01-30 8:13 ` Conor Dooley
2023-01-30 8:13 ` Conor Dooley
2023-02-08 18:19 ` Conor Dooley [this message]
2023-02-08 18:19 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+PnorGskAAIsODw@spud \
--to=conor@kernel.org \
--cc=andy.chiu@sifive.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@atishpatra.org \
--cc=conor.dooley@microchip.com \
--cc=greentime.hu@sifive.com \
--cc=guoren@linux.alibaba.com \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=vineetg@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.