From: Conor Dooley <conor@kernel.org> To: Guenter Roeck <linux@roeck-us.net> Cc: Jisheng Zhang <jszhang@kernel.org>, Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley <paul.walmsley@sifive.com>, Albert Ou <aou@eecs.berkeley.edu>, Anup Patel <anup@brainfault.org>, Atish Patra <atishp@atishpatra.org>, Heiko Stuebner <heiko@sntech.de>, Andrew Jones <ajones@ventanamicro.com>, Conor Dooley <conor.dooley@microchip.com>, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org Subject: Re: [PATCH v5 00/13] riscv: improve boot time isa extensions handling Date: Sun, 12 Feb 2023 18:45:31 +0000 [thread overview] Message-ID: <Y+kzy1y3Z3j3Ohs9@spud> (raw) In-Reply-To: <48d2ac96-abdd-23bc-b167-08dc2c1a1dbe@roeck-us.net> [-- Attachment #1: Type: text/plain, Size: 2777 bytes --] On Sun, Feb 12, 2023 at 10:38:26AM -0800, Guenter Roeck wrote: > On 2/12/23 10:20, Conor Dooley wrote: > > On Sun, Feb 12, 2023 at 10:14:13AM -0800, Guenter Roeck wrote: > > > On 2/12/23 10:06, Conor Dooley wrote: > > > > On Sun, Feb 12, 2023 at 05:06:09PM +0000, Conor Dooley wrote: > > > > > On Sun, Feb 12, 2023 at 04:33:58PM +0000, Conor Dooley wrote: > > > > > > On Sun, Feb 12, 2023 at 03:59:59PM +0000, Conor Dooley wrote: > > > > > > > > > > So as not to lead anyone up the garden path, let me correct myself: > > > > > > > > > > > Hmm, so this appears to be us attempting to patch in alternatives where > > > > > > none actually exists - seemingly F & D. > > > > > > > > > > And of course that's not true, riscv_has_extension_likely() now uses > > > > > alternatives as of: > > > > > bdda5d554e43 ("riscv: introduce riscv_has_extension_[un]likely()") > > > > > > > > > > From a quick look, it just happens that the only users are F & D. > > > > > > > > > > > > > Samuel pointed out that this is a lockdep splat on irc. > > > > There's a patch on the list that removes the lockdep annotation > > > > entirely: > > > > https://patchwork.kernel.org/project/linux-riscv/patch/20230202114116.3695793-1-changbin.du@huawei.com/ > > > > > > > > So ye, no surprises that it was config based! > > > > > > > > Palmer posted a "better" fix for that lockdep warning a while ago: > > > > https://lore.kernel.org/all/20220322022331.32136-1-palmer@rivosinc.com/ > > > > > > > > So we'd have to duplicate/reuse that for cpufeature/errata patching. > > > > > > > > > > > > > > This does not (only) happen in stop_machine(). > > > > Yah, sorry I meant that it's the same lockdep splat as is being > > addressed there. > > The first patch deletes the lockdep stuff entirely, so removes the > > splat. I was thinking that we'd need to take Palmer's (IMO better) > > patch and do the same thing for patching alternatives, but I figure we > > can just take the text_mutex itself for alternatives & not have to > > dance around the lock. > > > > I'll go do that I suppose! > > Thanks a lot for the clarification. That sounds like the backtrace > can be largely ignored. Yeah, sorry that I phrased that confusingly in the first place. > However, I still see that the patch series > results in boot hangs with the sifive_u qemu emulation, where > the log ends with "Oops - illegal instruction". Is that problem > being addressed as well ? Hmm, if it died on the last commit in this series, then I am not sure. If you meant with riscv/for-next or linux-next that's fixed by a patch from Samuel: https://patchwork.kernel.org/project/linux-riscv/patch/20230212021534.59121-3-samuel@sholland.org/ Cheers, Conor. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org> To: Guenter Roeck <linux@roeck-us.net> Cc: Jisheng Zhang <jszhang@kernel.org>, Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley <paul.walmsley@sifive.com>, Albert Ou <aou@eecs.berkeley.edu>, Anup Patel <anup@brainfault.org>, Atish Patra <atishp@atishpatra.org>, Heiko Stuebner <heiko@sntech.de>, Andrew Jones <ajones@ventanamicro.com>, Conor Dooley <conor.dooley@microchip.com>, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org Subject: Re: [PATCH v5 00/13] riscv: improve boot time isa extensions handling Date: Sun, 12 Feb 2023 18:45:31 +0000 [thread overview] Message-ID: <Y+kzy1y3Z3j3Ohs9@spud> (raw) In-Reply-To: <48d2ac96-abdd-23bc-b167-08dc2c1a1dbe@roeck-us.net> [-- Attachment #1.1: Type: text/plain, Size: 2777 bytes --] On Sun, Feb 12, 2023 at 10:38:26AM -0800, Guenter Roeck wrote: > On 2/12/23 10:20, Conor Dooley wrote: > > On Sun, Feb 12, 2023 at 10:14:13AM -0800, Guenter Roeck wrote: > > > On 2/12/23 10:06, Conor Dooley wrote: > > > > On Sun, Feb 12, 2023 at 05:06:09PM +0000, Conor Dooley wrote: > > > > > On Sun, Feb 12, 2023 at 04:33:58PM +0000, Conor Dooley wrote: > > > > > > On Sun, Feb 12, 2023 at 03:59:59PM +0000, Conor Dooley wrote: > > > > > > > > > > So as not to lead anyone up the garden path, let me correct myself: > > > > > > > > > > > Hmm, so this appears to be us attempting to patch in alternatives where > > > > > > none actually exists - seemingly F & D. > > > > > > > > > > And of course that's not true, riscv_has_extension_likely() now uses > > > > > alternatives as of: > > > > > bdda5d554e43 ("riscv: introduce riscv_has_extension_[un]likely()") > > > > > > > > > > From a quick look, it just happens that the only users are F & D. > > > > > > > > > > > > > Samuel pointed out that this is a lockdep splat on irc. > > > > There's a patch on the list that removes the lockdep annotation > > > > entirely: > > > > https://patchwork.kernel.org/project/linux-riscv/patch/20230202114116.3695793-1-changbin.du@huawei.com/ > > > > > > > > So ye, no surprises that it was config based! > > > > > > > > Palmer posted a "better" fix for that lockdep warning a while ago: > > > > https://lore.kernel.org/all/20220322022331.32136-1-palmer@rivosinc.com/ > > > > > > > > So we'd have to duplicate/reuse that for cpufeature/errata patching. > > > > > > > > > > > > > > This does not (only) happen in stop_machine(). > > > > Yah, sorry I meant that it's the same lockdep splat as is being > > addressed there. > > The first patch deletes the lockdep stuff entirely, so removes the > > splat. I was thinking that we'd need to take Palmer's (IMO better) > > patch and do the same thing for patching alternatives, but I figure we > > can just take the text_mutex itself for alternatives & not have to > > dance around the lock. > > > > I'll go do that I suppose! > > Thanks a lot for the clarification. That sounds like the backtrace > can be largely ignored. Yeah, sorry that I phrased that confusingly in the first place. > However, I still see that the patch series > results in boot hangs with the sifive_u qemu emulation, where > the log ends with "Oops - illegal instruction". Is that problem > being addressed as well ? Hmm, if it died on the last commit in this series, then I am not sure. If you meant with riscv/for-next or linux-next that's fixed by a patch from Samuel: https://patchwork.kernel.org/project/linux-riscv/patch/20230212021534.59121-3-samuel@sholland.org/ Cheers, Conor. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 161 bytes --] _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-02-12 18:45 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-28 17:28 [PATCH v5 00/13] riscv: improve boot time isa extensions handling Jisheng Zhang 2023-01-28 17:28 ` Jisheng Zhang 2023-01-28 17:28 ` [PATCH v5 01/13] riscv: move riscv_noncoherent_supported() out of ZICBOM probe Jisheng Zhang 2023-01-28 17:28 ` Jisheng Zhang 2023-01-28 17:28 ` [PATCH v5 02/13] riscv: cpufeature: detect RISCV_ALTERNATIVES_EARLY_BOOT earlier Jisheng Zhang 2023-01-28 17:28 ` Jisheng Zhang 2023-01-28 17:28 ` [PATCH v5 03/13] riscv: hwcap: make ISA extension ids can be used in asm Jisheng Zhang 2023-01-28 17:28 ` Jisheng Zhang 2023-01-28 17:28 ` [PATCH v5 04/13] riscv: cpufeature: extend riscv_cpufeature_patch_func to all ISA extensions Jisheng Zhang 2023-01-28 17:28 ` Jisheng Zhang 2023-01-28 17:28 ` [PATCH v5 05/13] riscv: introduce riscv_has_extension_[un]likely() Jisheng Zhang 2023-01-28 17:28 ` Jisheng Zhang 2023-01-28 17:28 ` [PATCH v5 06/13] riscv: fpu: switch has_fpu() to riscv_has_extension_likely() Jisheng Zhang 2023-01-28 17:28 ` Jisheng Zhang 2023-03-22 12:01 ` Jason A. Donenfeld 2023-03-22 12:01 ` Jason A. Donenfeld 2023-03-22 12:09 ` [PATCH] riscv: require alternatives framework when selecting FPU support Jason A. Donenfeld 2023-03-22 12:09 ` Jason A. Donenfeld 2023-03-22 12:46 ` Andrew Jones 2023-03-22 12:46 ` Andrew Jones 2023-03-22 15:17 ` Conor Dooley 2023-03-22 15:17 ` Conor Dooley 2023-03-22 19:26 ` Andrew Jones 2023-03-22 19:26 ` Andrew Jones 2023-03-22 19:44 ` Conor Dooley 2023-03-22 19:44 ` Conor Dooley 2023-03-22 20:05 ` Conor Dooley 2023-03-22 20:05 ` Conor Dooley 2023-03-22 20:19 ` Jason A. Donenfeld 2023-03-22 20:19 ` Jason A. Donenfeld 2023-03-23 14:49 ` Conor Dooley 2023-03-23 14:49 ` Conor Dooley 2023-03-23 15:56 ` Jason A. Donenfeld 2023-03-23 15:56 ` Jason A. Donenfeld 2023-03-23 22:19 ` Conor Dooley 2023-03-23 22:19 ` Conor Dooley 2023-01-28 17:28 ` [PATCH v5 07/13] riscv: module: move find_section to module.h Jisheng Zhang 2023-01-28 17:28 ` Jisheng Zhang 2023-01-28 17:28 ` [PATCH v5 08/13] riscv: module: Add ADD16 and SUB16 rela types Jisheng Zhang 2023-01-28 17:28 ` Jisheng Zhang 2023-01-28 17:28 ` [PATCH v5 09/13] riscv: switch to relative alternative entries Jisheng Zhang 2023-01-28 17:28 ` Jisheng Zhang 2023-01-28 17:28 ` [PATCH v5 10/13] riscv: alternative: patch alternatives in the vDSO Jisheng Zhang 2023-01-28 17:28 ` Jisheng Zhang 2023-01-28 17:28 ` [PATCH v5 11/13] riscv: cpu_relax: switch to riscv_has_extension_likely() Jisheng Zhang 2023-01-28 17:28 ` Jisheng Zhang 2023-01-28 17:28 ` [PATCH v5 12/13] riscv: KVM: Switch has_svinval() to riscv_has_extension_unlikely() Jisheng Zhang 2023-01-28 17:28 ` Jisheng Zhang 2023-01-28 17:28 ` [PATCH v5 13/13] riscv: remove riscv_isa_ext_keys[] array and related usage Jisheng Zhang 2023-01-28 17:28 ` Jisheng Zhang 2023-02-02 23:39 ` [PATCH v5 00/13] riscv: improve boot time isa extensions handling Palmer Dabbelt 2023-02-02 23:39 ` Palmer Dabbelt 2023-02-02 23:40 ` patchwork-bot+linux-riscv 2023-02-02 23:40 ` patchwork-bot+linux-riscv 2023-02-12 15:43 ` Guenter Roeck 2023-02-12 15:43 ` Guenter Roeck 2023-02-12 15:59 ` Conor Dooley 2023-02-12 15:59 ` Conor Dooley 2023-02-12 16:33 ` Conor Dooley 2023-02-12 16:33 ` Conor Dooley 2023-02-12 17:06 ` Conor Dooley 2023-02-12 17:06 ` Conor Dooley 2023-02-12 18:06 ` Conor Dooley 2023-02-12 18:06 ` Conor Dooley 2023-02-12 18:14 ` Guenter Roeck 2023-02-12 18:14 ` Guenter Roeck 2023-02-12 18:20 ` Conor Dooley 2023-02-12 18:20 ` Conor Dooley 2023-02-12 18:38 ` Guenter Roeck 2023-02-12 18:38 ` Guenter Roeck 2023-02-12 18:45 ` Conor Dooley [this message] 2023-02-12 18:45 ` Conor Dooley 2023-02-12 20:27 ` Guenter Roeck 2023-02-12 20:27 ` Guenter Roeck 2023-02-12 20:39 ` Conor Dooley 2023-02-12 20:39 ` Conor Dooley 2023-02-12 22:21 ` Guenter Roeck 2023-02-12 22:21 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Y+kzy1y3Z3j3Ohs9@spud \ --to=conor@kernel.org \ --cc=ajones@ventanamicro.com \ --cc=anup@brainfault.org \ --cc=aou@eecs.berkeley.edu \ --cc=atishp@atishpatra.org \ --cc=conor.dooley@microchip.com \ --cc=heiko@sntech.de \ --cc=jszhang@kernel.org \ --cc=kvm-riscv@lists.infradead.org \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=linux@roeck-us.net \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.