From: Simon Horman <simon.horman@corigine.com> To: Jerome Brunet <jbrunet@baylibre.com> Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>, linux-amlogic@lists.infradead.org, Kevin Hilman <khilman@baylibre.com>, Neil Armstrong <neil.armstrong@linaro.org>, Da Xue <da@lessconfused.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/2] net: mdio: add amlogic gxl mdio mux support Date: Mon, 16 Jan 2023 14:51:20 +0100 [thread overview] Message-ID: <Y8VWWP53ZysENI7/@corigine.com> (raw) In-Reply-To: <1jk01mhaeg.fsf@starbuckisacylon.baylibre.com> On Mon, Jan 16, 2023 at 02:27:57PM +0100, Jerome Brunet wrote: > > On Mon 16 Jan 2023 at 13:11, Simon Horman <simon.horman@corigine.com> wrote: > > > On Mon, Jan 16, 2023 at 10:16:36AM +0100, Jerome Brunet wrote: > >> Add support for the mdio mux and internal phy glue of the GXL SoC > >> family > >> > >> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > >> --- > >> drivers/net/mdio/Kconfig | 11 ++ > >> drivers/net/mdio/Makefile | 1 + > >> drivers/net/mdio/mdio-mux-meson-gxl.c | 160 ++++++++++++++++++++++++++ > >> 3 files changed, 172 insertions(+) > >> create mode 100644 drivers/net/mdio/mdio-mux-meson-gxl.c > > > > Hi Jerome, > > > > please run this patch through checkpatch. > > Shame ... I really thought I did, but I forgot indeed. > I am really sorry for this. I'll fix everything. No problem, it happens. > > ... > > > >> diff --git a/drivers/net/mdio/mdio-mux-meson-gxl.c b/drivers/net/mdio/mdio-mux-meson-gxl.c > >> new file mode 100644 > >> index 000000000000..205095d845ea > >> --- /dev/null > >> +++ b/drivers/net/mdio/mdio-mux-meson-gxl.c > > > > ... > > > >> +static int gxl_enable_internal_mdio(struct gxl_mdio_mux *priv) > >> +{ > > > > nit: I think void would be a more appropriate return type for this > > function. Likewise gxl_enable_external_mdio() > > > > ... > > > >> +static int gxl_mdio_mux_probe(struct platform_device *pdev){ > > > > nit: '{' should be at the beginning of a new line > > > >> + struct device *dev = &pdev->dev; > >> + struct clk *rclk; > >> + struct gxl_mdio_mux *priv; > > > > nit: reverse xmas tree for local variable declarations. > > > >> + int ret; > >> + > >> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > >> + if (!priv) > >> + return -ENOMEM; > > > > nit: may be it is nicer to use dev_err_probe() here for consistency. > > That was on purpose. I only use the `dev_err_probe()` when the probe may > defer, which I don't expect here. > > I don't mind changing if you prefer it this way. I have no strong opinion on this :) > >> + platform_set_drvdata(pdev, priv); > >> + > >> + priv->regs = devm_platform_ioremap_resource(pdev, 0); > >> + if (IS_ERR(priv->regs)) > >> + return PTR_ERR(priv->regs); > > > > And here. > > > > ... >
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <simon.horman@corigine.com> To: Jerome Brunet <jbrunet@baylibre.com> Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>, linux-amlogic@lists.infradead.org, Kevin Hilman <khilman@baylibre.com>, Neil Armstrong <neil.armstrong@linaro.org>, Da Xue <da@lessconfused.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/2] net: mdio: add amlogic gxl mdio mux support Date: Mon, 16 Jan 2023 14:51:20 +0100 [thread overview] Message-ID: <Y8VWWP53ZysENI7/@corigine.com> (raw) In-Reply-To: <1jk01mhaeg.fsf@starbuckisacylon.baylibre.com> On Mon, Jan 16, 2023 at 02:27:57PM +0100, Jerome Brunet wrote: > > On Mon 16 Jan 2023 at 13:11, Simon Horman <simon.horman@corigine.com> wrote: > > > On Mon, Jan 16, 2023 at 10:16:36AM +0100, Jerome Brunet wrote: > >> Add support for the mdio mux and internal phy glue of the GXL SoC > >> family > >> > >> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > >> --- > >> drivers/net/mdio/Kconfig | 11 ++ > >> drivers/net/mdio/Makefile | 1 + > >> drivers/net/mdio/mdio-mux-meson-gxl.c | 160 ++++++++++++++++++++++++++ > >> 3 files changed, 172 insertions(+) > >> create mode 100644 drivers/net/mdio/mdio-mux-meson-gxl.c > > > > Hi Jerome, > > > > please run this patch through checkpatch. > > Shame ... I really thought I did, but I forgot indeed. > I am really sorry for this. I'll fix everything. No problem, it happens. > > ... > > > >> diff --git a/drivers/net/mdio/mdio-mux-meson-gxl.c b/drivers/net/mdio/mdio-mux-meson-gxl.c > >> new file mode 100644 > >> index 000000000000..205095d845ea > >> --- /dev/null > >> +++ b/drivers/net/mdio/mdio-mux-meson-gxl.c > > > > ... > > > >> +static int gxl_enable_internal_mdio(struct gxl_mdio_mux *priv) > >> +{ > > > > nit: I think void would be a more appropriate return type for this > > function. Likewise gxl_enable_external_mdio() > > > > ... > > > >> +static int gxl_mdio_mux_probe(struct platform_device *pdev){ > > > > nit: '{' should be at the beginning of a new line > > > >> + struct device *dev = &pdev->dev; > >> + struct clk *rclk; > >> + struct gxl_mdio_mux *priv; > > > > nit: reverse xmas tree for local variable declarations. > > > >> + int ret; > >> + > >> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > >> + if (!priv) > >> + return -ENOMEM; > > > > nit: may be it is nicer to use dev_err_probe() here for consistency. > > That was on purpose. I only use the `dev_err_probe()` when the probe may > defer, which I don't expect here. > > I don't mind changing if you prefer it this way. I have no strong opinion on this :) > >> + platform_set_drvdata(pdev, priv); > >> + > >> + priv->regs = devm_platform_ioremap_resource(pdev, 0); > >> + if (IS_ERR(priv->regs)) > >> + return PTR_ERR(priv->regs); > > > > And here. > > > > ... > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-01-16 13:54 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-16 9:16 [PATCH net-next 0/2] net: mdio: add amlogic gxl mdio mux support Jerome Brunet 2023-01-16 9:16 ` Jerome Brunet 2023-01-16 9:16 ` [PATCH net-next 1/2] dt-bindings: net: add amlogic gxl mdio multiplexer Jerome Brunet 2023-01-16 9:16 ` Jerome Brunet 2023-01-17 8:31 ` Krzysztof Kozlowski 2023-01-17 8:31 ` Krzysztof Kozlowski 2023-01-17 9:05 ` Jerome Brunet 2023-01-17 9:05 ` Jerome Brunet 2023-01-17 10:39 ` Krzysztof Kozlowski 2023-01-17 10:39 ` Krzysztof Kozlowski 2023-01-16 9:16 ` [PATCH net-next 2/2] net: mdio: add amlogic gxl mdio mux support Jerome Brunet 2023-01-16 9:16 ` Jerome Brunet 2023-01-16 12:11 ` Simon Horman 2023-01-16 12:11 ` Simon Horman 2023-01-16 13:27 ` Jerome Brunet 2023-01-16 13:27 ` Jerome Brunet 2023-01-16 13:51 ` Simon Horman [this message] 2023-01-16 13:51 ` Simon Horman 2023-01-18 2:56 ` Andrew Lunn 2023-01-18 2:56 ` Andrew Lunn 2023-01-18 12:41 ` Simon Horman 2023-01-18 12:41 ` Simon Horman 2023-01-18 3:02 ` Andrew Lunn 2023-01-18 3:02 ` Andrew Lunn 2023-01-19 10:55 ` Jerome Brunet 2023-01-19 10:55 ` Jerome Brunet 2023-01-19 17:17 ` Andrew Lunn 2023-01-19 17:17 ` Andrew Lunn 2023-01-20 10:16 ` Jerome Brunet 2023-01-20 10:16 ` Jerome Brunet 2023-01-18 3:08 ` [PATCH net-next 0/2] " Andrew Lunn 2023-01-18 3:08 ` Andrew Lunn 2023-01-19 10:42 ` Jerome Brunet 2023-01-19 10:42 ` Jerome Brunet 2023-01-19 17:21 ` Andrew Lunn 2023-01-19 17:21 ` Andrew Lunn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Y8VWWP53ZysENI7/@corigine.com \ --to=simon.horman@corigine.com \ --cc=da@lessconfused.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=jbrunet@baylibre.com \ --cc=khilman@baylibre.com \ --cc=linux-amlogic@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=neil.armstrong@linaro.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.