From: Simon Horman <simon.horman@corigine.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
linux-amlogic@lists.infradead.org,
Kevin Hilman <khilman@baylibre.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Da Xue <da@lessconfused.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: mdio: add amlogic gxl mdio mux support
Date: Wed, 18 Jan 2023 13:41:14 +0100 [thread overview]
Message-ID: <Y8fo6qx7LnXsJN4o@corigine.com> (raw)
In-Reply-To: <Y8df4LRfPN34lvP8@lunn.ch>
On Wed, Jan 18, 2023 at 03:56:32AM +0100, Andrew Lunn wrote:
> > > >> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> > > >> + if (!priv)
> > > >> + return -ENOMEM;
> > > >
> > > > nit: may be it is nicer to use dev_err_probe() here for consistency.
> > >
> > > That was on purpose. I only use the `dev_err_probe()` when the probe may
> > > defer, which I don't expect here.
> > >
> > > I don't mind changing if you prefer it this way.
> >
> > I have no strong opinion on this :)
>
> dev_err_probe() does not apply here, because devm_kzalloc does not
> return an error code. Hence it cannot be EPROBE_DEFFER, which is what
> dev_err_probe() is looking for.
Sure, there is no EPROBE_DEFFER.
But, FWIIW, my reading of the documentation for dev_err_probe()
is that it's use in such cases is acceptable.
Anyway, let's pass on my suggestion.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <simon.horman@corigine.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
linux-amlogic@lists.infradead.org,
Kevin Hilman <khilman@baylibre.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Da Xue <da@lessconfused.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: mdio: add amlogic gxl mdio mux support
Date: Wed, 18 Jan 2023 13:41:14 +0100 [thread overview]
Message-ID: <Y8fo6qx7LnXsJN4o@corigine.com> (raw)
In-Reply-To: <Y8df4LRfPN34lvP8@lunn.ch>
On Wed, Jan 18, 2023 at 03:56:32AM +0100, Andrew Lunn wrote:
> > > >> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> > > >> + if (!priv)
> > > >> + return -ENOMEM;
> > > >
> > > > nit: may be it is nicer to use dev_err_probe() here for consistency.
> > >
> > > That was on purpose. I only use the `dev_err_probe()` when the probe may
> > > defer, which I don't expect here.
> > >
> > > I don't mind changing if you prefer it this way.
> >
> > I have no strong opinion on this :)
>
> dev_err_probe() does not apply here, because devm_kzalloc does not
> return an error code. Hence it cannot be EPROBE_DEFFER, which is what
> dev_err_probe() is looking for.
Sure, there is no EPROBE_DEFFER.
But, FWIIW, my reading of the documentation for dev_err_probe()
is that it's use in such cases is acceptable.
Anyway, let's pass on my suggestion.
next prev parent reply other threads:[~2023-01-18 12:45 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 9:16 [PATCH net-next 0/2] net: mdio: add amlogic gxl mdio mux support Jerome Brunet
2023-01-16 9:16 ` Jerome Brunet
2023-01-16 9:16 ` [PATCH net-next 1/2] dt-bindings: net: add amlogic gxl mdio multiplexer Jerome Brunet
2023-01-16 9:16 ` Jerome Brunet
2023-01-17 8:31 ` Krzysztof Kozlowski
2023-01-17 8:31 ` Krzysztof Kozlowski
2023-01-17 9:05 ` Jerome Brunet
2023-01-17 9:05 ` Jerome Brunet
2023-01-17 10:39 ` Krzysztof Kozlowski
2023-01-17 10:39 ` Krzysztof Kozlowski
2023-01-16 9:16 ` [PATCH net-next 2/2] net: mdio: add amlogic gxl mdio mux support Jerome Brunet
2023-01-16 9:16 ` Jerome Brunet
2023-01-16 12:11 ` Simon Horman
2023-01-16 12:11 ` Simon Horman
2023-01-16 13:27 ` Jerome Brunet
2023-01-16 13:27 ` Jerome Brunet
2023-01-16 13:51 ` Simon Horman
2023-01-16 13:51 ` Simon Horman
2023-01-18 2:56 ` Andrew Lunn
2023-01-18 2:56 ` Andrew Lunn
2023-01-18 12:41 ` Simon Horman [this message]
2023-01-18 12:41 ` Simon Horman
2023-01-18 3:02 ` Andrew Lunn
2023-01-18 3:02 ` Andrew Lunn
2023-01-19 10:55 ` Jerome Brunet
2023-01-19 10:55 ` Jerome Brunet
2023-01-19 17:17 ` Andrew Lunn
2023-01-19 17:17 ` Andrew Lunn
2023-01-20 10:16 ` Jerome Brunet
2023-01-20 10:16 ` Jerome Brunet
2023-01-18 3:08 ` [PATCH net-next 0/2] " Andrew Lunn
2023-01-18 3:08 ` Andrew Lunn
2023-01-19 10:42 ` Jerome Brunet
2023-01-19 10:42 ` Jerome Brunet
2023-01-19 17:21 ` Andrew Lunn
2023-01-19 17:21 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8fo6qx7LnXsJN4o@corigine.com \
--to=simon.horman@corigine.com \
--cc=andrew@lunn.ch \
--cc=da@lessconfused.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.