From: Andrew Lunn <andrew@lunn.ch> To: Jerome Brunet <jbrunet@baylibre.com> Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>, linux-amlogic@lists.infradead.org, Kevin Hilman <khilman@baylibre.com>, Neil Armstrong <neil.armstrong@linaro.org>, Da Xue <da@lessconfused.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/2] net: mdio: add amlogic gxl mdio mux support Date: Wed, 18 Jan 2023 04:02:43 +0100 [thread overview] Message-ID: <Y8dhUwIMb4tTeqWN@lunn.ch> (raw) In-Reply-To: <20230116091637.272923-3-jbrunet@baylibre.com> > +static int gxl_enable_internal_mdio(struct gxl_mdio_mux *priv) > +{ > + u32 val; > + > + /* Setup the internal phy */ > + val = (REG3_ENH | > + FIELD_PREP(REG3_CFGMODE, 0x7) | > + REG3_AUTOMDIX | > + FIELD_PREP(REG3_PHYADDR, 8) | > + REG3_LEDPOL | > + REG3_PHYMDI | > + REG3_CLKINEN | > + REG3_PHYIP); > + > + writel_relaxed(REG4_PWRUPRSTSIG, priv->regs + ETH_REG4); > + writel_relaxed(val, priv->regs + ETH_REG3); > + mdelay(10); Probably the second _relaxed() should not be. You want it guaranteed to be written out before you do the mdelay(). > + > + /* Set the internal phy id */ > + writel_relaxed(FIELD_PREP(REG2_PHYID, 0x110181), > + priv->regs + ETH_REG2); So how does this play with what Heiner has been reporting recently? What is the reset default? Who determined this value? > + /* Enable the internal phy */ > + val |= REG3_PHYEN; > + writel_relaxed(val, priv->regs + ETH_REG3); > + writel_relaxed(0, priv->regs + ETH_REG4); > + > + /* The phy needs a bit of time to come up */ > + mdelay(10); What do you mean by 'come up'? Not link up i assume. But maybe it will not respond to MDIO requests? Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch> To: Jerome Brunet <jbrunet@baylibre.com> Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>, linux-amlogic@lists.infradead.org, Kevin Hilman <khilman@baylibre.com>, Neil Armstrong <neil.armstrong@linaro.org>, Da Xue <da@lessconfused.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/2] net: mdio: add amlogic gxl mdio mux support Date: Wed, 18 Jan 2023 04:02:43 +0100 [thread overview] Message-ID: <Y8dhUwIMb4tTeqWN@lunn.ch> (raw) In-Reply-To: <20230116091637.272923-3-jbrunet@baylibre.com> > +static int gxl_enable_internal_mdio(struct gxl_mdio_mux *priv) > +{ > + u32 val; > + > + /* Setup the internal phy */ > + val = (REG3_ENH | > + FIELD_PREP(REG3_CFGMODE, 0x7) | > + REG3_AUTOMDIX | > + FIELD_PREP(REG3_PHYADDR, 8) | > + REG3_LEDPOL | > + REG3_PHYMDI | > + REG3_CLKINEN | > + REG3_PHYIP); > + > + writel_relaxed(REG4_PWRUPRSTSIG, priv->regs + ETH_REG4); > + writel_relaxed(val, priv->regs + ETH_REG3); > + mdelay(10); Probably the second _relaxed() should not be. You want it guaranteed to be written out before you do the mdelay(). > + > + /* Set the internal phy id */ > + writel_relaxed(FIELD_PREP(REG2_PHYID, 0x110181), > + priv->regs + ETH_REG2); So how does this play with what Heiner has been reporting recently? What is the reset default? Who determined this value? > + /* Enable the internal phy */ > + val |= REG3_PHYEN; > + writel_relaxed(val, priv->regs + ETH_REG3); > + writel_relaxed(0, priv->regs + ETH_REG4); > + > + /* The phy needs a bit of time to come up */ > + mdelay(10); What do you mean by 'come up'? Not link up i assume. But maybe it will not respond to MDIO requests? Andrew _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-01-18 3:02 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-16 9:16 [PATCH net-next 0/2] net: mdio: add amlogic gxl mdio mux support Jerome Brunet 2023-01-16 9:16 ` Jerome Brunet 2023-01-16 9:16 ` [PATCH net-next 1/2] dt-bindings: net: add amlogic gxl mdio multiplexer Jerome Brunet 2023-01-16 9:16 ` Jerome Brunet 2023-01-17 8:31 ` Krzysztof Kozlowski 2023-01-17 8:31 ` Krzysztof Kozlowski 2023-01-17 9:05 ` Jerome Brunet 2023-01-17 9:05 ` Jerome Brunet 2023-01-17 10:39 ` Krzysztof Kozlowski 2023-01-17 10:39 ` Krzysztof Kozlowski 2023-01-16 9:16 ` [PATCH net-next 2/2] net: mdio: add amlogic gxl mdio mux support Jerome Brunet 2023-01-16 9:16 ` Jerome Brunet 2023-01-16 12:11 ` Simon Horman 2023-01-16 12:11 ` Simon Horman 2023-01-16 13:27 ` Jerome Brunet 2023-01-16 13:27 ` Jerome Brunet 2023-01-16 13:51 ` Simon Horman 2023-01-16 13:51 ` Simon Horman 2023-01-18 2:56 ` Andrew Lunn 2023-01-18 2:56 ` Andrew Lunn 2023-01-18 12:41 ` Simon Horman 2023-01-18 12:41 ` Simon Horman 2023-01-18 3:02 ` Andrew Lunn [this message] 2023-01-18 3:02 ` Andrew Lunn 2023-01-19 10:55 ` Jerome Brunet 2023-01-19 10:55 ` Jerome Brunet 2023-01-19 17:17 ` Andrew Lunn 2023-01-19 17:17 ` Andrew Lunn 2023-01-20 10:16 ` Jerome Brunet 2023-01-20 10:16 ` Jerome Brunet 2023-01-18 3:08 ` [PATCH net-next 0/2] " Andrew Lunn 2023-01-18 3:08 ` Andrew Lunn 2023-01-19 10:42 ` Jerome Brunet 2023-01-19 10:42 ` Jerome Brunet 2023-01-19 17:21 ` Andrew Lunn 2023-01-19 17:21 ` Andrew Lunn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Y8dhUwIMb4tTeqWN@lunn.ch \ --to=andrew@lunn.ch \ --cc=da@lessconfused.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=jbrunet@baylibre.com \ --cc=khilman@baylibre.com \ --cc=linux-amlogic@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=neil.armstrong@linaro.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.