From: Christoph Hellwig <hch@infradead.org> To: Jane Chu <jane.chu@oracle.com> Cc: david@fromorbit.com, djwong@kernel.org, dan.j.williams@intel.com, hch@infradead.org, vishal.l.verma@intel.com, dave.jiang@intel.com, agk@redhat.com, snitzer@redhat.com, dm-devel@redhat.com, ira.weiny@intel.com, willy@infradead.org, vgoyal@redhat.com, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v7 6/6] pmem: implement pmem_recovery_write() Date: Tue, 5 Apr 2022 22:21:44 -0700 [thread overview] Message-ID: <Yk0jaC9rHwwoEV11@infradead.org> (raw) In-Reply-To: <20220405194747.2386619-7-jane.chu@oracle.com> On Tue, Apr 05, 2022 at 01:47:47PM -0600, Jane Chu wrote: > + off = (unsigned long)addr & ~PAGE_MASK; offset_inpage() > + if (off || !(PAGE_ALIGNED(bytes))) { No need for the inner braces. > + mutex_lock(&pmem->recovery_lock); > + pmem_off = PFN_PHYS(pgoff) + pmem->data_offset; > + cleared = __pmem_clear_poison(pmem, pmem_off, len); > + if (cleared > 0 && cleared < len) { > + dev_warn(dev, "poison cleared only %ld out of %lu\n", > + cleared, len); > + mutex_unlock(&pmem->recovery_lock); > + return 0; > + } else if (cleared < 0) { No need for an else after a return.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org> To: Jane Chu <jane.chu@oracle.com> Cc: nvdimm@lists.linux.dev, dave.jiang@intel.com, snitzer@redhat.com, djwong@kernel.org, x86@kernel.org, david@fromorbit.com, linux-kernel@vger.kernel.org, willy@infradead.org, hch@infradead.org, dm-devel@redhat.com, vgoyal@redhat.com, vishal.l.verma@intel.com, linux-fsdevel@vger.kernel.org, dan.j.williams@intel.com, ira.weiny@intel.com, linux-xfs@vger.kernel.org, agk@redhat.com Subject: Re: [dm-devel] [PATCH v7 6/6] pmem: implement pmem_recovery_write() Date: Tue, 5 Apr 2022 22:21:44 -0700 [thread overview] Message-ID: <Yk0jaC9rHwwoEV11@infradead.org> (raw) In-Reply-To: <20220405194747.2386619-7-jane.chu@oracle.com> On Tue, Apr 05, 2022 at 01:47:47PM -0600, Jane Chu wrote: > + off = (unsigned long)addr & ~PAGE_MASK; offset_inpage() > + if (off || !(PAGE_ALIGNED(bytes))) { No need for the inner braces. > + mutex_lock(&pmem->recovery_lock); > + pmem_off = PFN_PHYS(pgoff) + pmem->data_offset; > + cleared = __pmem_clear_poison(pmem, pmem_off, len); > + if (cleared > 0 && cleared < len) { > + dev_warn(dev, "poison cleared only %ld out of %lu\n", > + cleared, len); > + mutex_unlock(&pmem->recovery_lock); > + return 0; > + } else if (cleared < 0) { No need for an else after a return. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2022-04-06 5:21 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-05 19:47 [PATCH v7 0/6] DAX poison recovery Jane Chu 2022-04-05 19:47 ` [dm-devel] " Jane Chu 2022-04-05 19:47 ` [PATCH v7 1/6] x86/mm: fix comment Jane Chu 2022-04-05 19:47 ` [dm-devel] " Jane Chu 2022-04-11 22:07 ` Dan Williams 2022-04-11 22:07 ` [dm-devel] " Dan Williams 2022-04-12 9:53 ` Borislav Petkov 2022-04-12 9:53 ` [dm-devel] " Borislav Petkov 2022-04-14 1:00 ` Jane Chu 2022-04-14 1:00 ` [dm-devel] " Jane Chu 2022-04-14 8:44 ` Borislav Petkov 2022-04-14 8:44 ` [dm-devel] " Borislav Petkov 2022-04-14 21:54 ` Jane Chu 2022-04-14 21:54 ` [dm-devel] " Jane Chu 2022-04-05 19:47 ` [PATCH v7 2/6] x86/mce: relocate set{clear}_mce_nospec() functions Jane Chu 2022-04-05 19:47 ` [dm-devel] " Jane Chu 2022-04-06 5:01 ` Christoph Hellwig 2022-04-06 5:01 ` [dm-devel] " Christoph Hellwig 2022-04-11 22:20 ` Dan Williams 2022-04-11 22:20 ` [dm-devel] " Dan Williams 2022-04-14 0:56 ` Jane Chu 2022-04-14 0:56 ` [dm-devel] " Jane Chu 2022-04-05 19:47 ` [PATCH v7 3/6] mce: fix set_mce_nospec to always unmap the whole page Jane Chu 2022-04-05 19:47 ` [dm-devel] " Jane Chu 2022-04-06 5:02 ` Christoph Hellwig 2022-04-06 5:02 ` [dm-devel] " Christoph Hellwig 2022-04-11 23:27 ` Dan Williams 2022-04-11 23:27 ` [dm-devel] " Dan Williams 2022-04-13 23:36 ` Jane Chu 2022-04-13 23:36 ` [dm-devel] " Jane Chu 2022-04-14 2:32 ` Dan Williams 2022-04-14 2:32 ` [dm-devel] " Dan Williams 2022-04-15 16:18 ` Jane Chu 2022-04-15 16:18 ` [dm-devel] " Jane Chu 2022-04-12 10:07 ` Borislav Petkov 2022-04-12 10:07 ` [dm-devel] " Borislav Petkov 2022-04-13 23:41 ` Jane Chu 2022-04-13 23:41 ` [dm-devel] " Jane Chu 2022-04-05 19:47 ` [PATCH v7 4/6] dax: add DAX_RECOVERY flag and .recovery_write dev_pgmap_ops Jane Chu 2022-04-05 19:47 ` [dm-devel] " Jane Chu 2022-04-06 5:19 ` Christoph Hellwig 2022-04-06 5:19 ` Christoph Hellwig 2022-04-06 17:32 ` [dm-devel] " Jane Chu 2022-04-06 17:32 ` Jane Chu 2022-04-06 17:45 ` Jane Chu 2022-04-06 17:45 ` [dm-devel] " Jane Chu 2022-04-07 5:30 ` Christoph Hellwig 2022-04-07 5:30 ` [dm-devel] " Christoph Hellwig 2022-04-11 23:55 ` Dan Williams 2022-04-11 23:55 ` [dm-devel] " Dan Williams 2022-04-14 0:48 ` Jane Chu 2022-04-14 0:48 ` [dm-devel] " Jane Chu 2022-04-14 0:47 ` Jane Chu 2022-04-14 0:47 ` [dm-devel] " Jane Chu 2022-04-12 0:08 ` Dan Williams 2022-04-12 0:08 ` [dm-devel] " Dan Williams 2022-04-14 0:50 ` Jane Chu 2022-04-14 0:50 ` [dm-devel] " Jane Chu 2022-04-12 4:57 ` Dan Williams 2022-04-12 4:57 ` [dm-devel] " Dan Williams 2022-04-12 5:02 ` Christoph Hellwig 2022-04-12 5:02 ` [dm-devel] " Christoph Hellwig 2022-04-14 0:51 ` Jane Chu 2022-04-14 0:51 ` [dm-devel] " Jane Chu 2022-04-05 19:47 ` [PATCH v7 5/6] pmem: refactor pmem_clear_poison() Jane Chu 2022-04-05 19:47 ` [dm-devel] " Jane Chu 2022-04-06 5:04 ` Christoph Hellwig 2022-04-06 5:04 ` [dm-devel] " Christoph Hellwig 2022-04-06 17:34 ` Jane Chu 2022-04-06 17:34 ` Jane Chu 2022-04-12 4:26 ` Dan Williams 2022-04-12 4:26 ` [dm-devel] " Dan Williams 2022-04-14 0:55 ` Jane Chu 2022-04-14 0:55 ` [dm-devel] " Jane Chu 2022-04-14 2:02 ` Dan Williams 2022-04-14 2:02 ` [dm-devel] " Dan Williams 2022-04-05 19:47 ` [PATCH v7 6/6] pmem: implement pmem_recovery_write() Jane Chu 2022-04-05 19:47 ` [dm-devel] " Jane Chu 2022-04-06 5:21 ` Christoph Hellwig [this message] 2022-04-06 5:21 ` Christoph Hellwig 2022-04-06 17:33 ` Jane Chu 2022-04-06 17:33 ` Jane Chu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Yk0jaC9rHwwoEV11@infradead.org \ --to=hch@infradead.org \ --cc=agk@redhat.com \ --cc=dan.j.williams@intel.com \ --cc=dave.jiang@intel.com \ --cc=david@fromorbit.com \ --cc=djwong@kernel.org \ --cc=dm-devel@redhat.com \ --cc=ira.weiny@intel.com \ --cc=jane.chu@oracle.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-xfs@vger.kernel.org \ --cc=nvdimm@lists.linux.dev \ --cc=snitzer@redhat.com \ --cc=vgoyal@redhat.com \ --cc=vishal.l.verma@intel.com \ --cc=willy@infradead.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.