From: Andi Shyti <andi.shyti@linux.intel.com>
To: fei.yang@intel.com
Cc: Chris Wilson <chris.p.wilson@linux.intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
Andi Shyti <andi.shyti@linux.intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Matt Roper <matthew.d.roper@intel.com>,
Nirmoy Das <nirmoy.das@intel.com>
Subject: Re: [PATCH 8/8] drm/i915: Allow user to set cache at BO creation
Date: Thu, 20 Apr 2023 13:39:03 +0200 [thread overview]
Message-ID: <ZEEkV3XOdmtYWnMv@ashyti-mobl2.lan> (raw)
In-Reply-To: <20230419230058.2659455-9-fei.yang@intel.com>
Hi Fei,
> To comply with the design that buffer objects shall have immutable
> cache setting through out their life cycle, {set, get}_caching ioctl's
> are no longer supported from MTL onward. With that change caching
> policy can only be set at object creation time. The current code
> applies a default (platform dependent) cache setting for all objects.
> However this is not optimal for performance tuning. The patch extends
> the existing gem_create uAPI to let user set PAT index for the object
> at creation time.
> The new extension is platform independent, so UMD's can switch to using
> this extension for older platforms as well, while {set, get}_caching are
> still supported on these legacy paltforms for compatibility reason.
>
> Cc: Chris Wilson <chris.p.wilson@linux.intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Signed-off-by: Fei Yang <fei.yang@intel.com>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
because this is an API change, we need some more information
here.
First of all you need to CC the userspace guys that have been
working on top of your series and get their ack's.
I also believe that this series has also been tested on a
separate repository, would you link it in the commit message?
Thanks,
Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@linux.intel.com>
To: fei.yang@intel.com
Cc: Chris Wilson <chris.p.wilson@linux.intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Matt Roper <matthew.d.roper@intel.com>,
Nirmoy Das <nirmoy.das@intel.com>
Subject: Re: [Intel-gfx] [PATCH 8/8] drm/i915: Allow user to set cache at BO creation
Date: Thu, 20 Apr 2023 13:39:03 +0200 [thread overview]
Message-ID: <ZEEkV3XOdmtYWnMv@ashyti-mobl2.lan> (raw)
In-Reply-To: <20230419230058.2659455-9-fei.yang@intel.com>
Hi Fei,
> To comply with the design that buffer objects shall have immutable
> cache setting through out their life cycle, {set, get}_caching ioctl's
> are no longer supported from MTL onward. With that change caching
> policy can only be set at object creation time. The current code
> applies a default (platform dependent) cache setting for all objects.
> However this is not optimal for performance tuning. The patch extends
> the existing gem_create uAPI to let user set PAT index for the object
> at creation time.
> The new extension is platform independent, so UMD's can switch to using
> this extension for older platforms as well, while {set, get}_caching are
> still supported on these legacy paltforms for compatibility reason.
>
> Cc: Chris Wilson <chris.p.wilson@linux.intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Signed-off-by: Fei Yang <fei.yang@intel.com>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
because this is an API change, we need some more information
here.
First of all you need to CC the userspace guys that have been
working on top of your series and get their ack's.
I also believe that this series has also been tested on a
separate repository, would you link it in the commit message?
Thanks,
Andi
next prev parent reply other threads:[~2023-04-20 11:39 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 23:00 [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL fei.yang
2023-04-19 23:00 ` [Intel-gfx] " fei.yang
2023-04-19 23:00 ` [PATCH 1/8] drm/i915/mtl: Set has_llc=0 fei.yang
2023-04-19 23:00 ` [Intel-gfx] " fei.yang
2023-04-20 10:20 ` Das, Nirmoy
2023-04-20 10:20 ` Das, Nirmoy
2023-04-19 23:00 ` [PATCH 2/8] drm/i915/mtl: Define MOCS and PAT tables for MTL fei.yang
2023-04-19 23:00 ` [Intel-gfx] " fei.yang
2023-04-20 20:29 ` Matt Roper
2023-04-19 23:00 ` [PATCH 3/8] drm/i915/mtl: Add PTE encode function fei.yang
2023-04-19 23:00 ` [Intel-gfx] " fei.yang
2023-04-20 20:40 ` Matt Roper
2023-04-21 17:27 ` Yang, Fei
2023-04-21 17:42 ` Matt Roper
2023-04-23 7:37 ` Yang, Fei
2023-04-23 7:37 ` Yang, Fei
2023-04-24 17:20 ` Matt Roper
2023-04-24 18:41 ` Yang, Fei
2023-04-19 23:00 ` [PATCH 4/8] drm/i915/mtl: workaround coherency issue for Media fei.yang
2023-04-19 23:00 ` [Intel-gfx] " fei.yang
2023-04-20 8:26 ` Andrzej Hajda
2023-04-20 11:36 ` Das, Nirmoy
2023-04-20 11:36 ` Das, Nirmoy
2023-04-20 20:52 ` Matt Roper
2023-04-19 23:00 ` [PATCH 5/8] drm/i915/mtl: end support for set caching ioctl fei.yang
2023-04-19 23:00 ` [Intel-gfx] " fei.yang
2023-04-20 21:05 ` Matt Roper
2023-04-19 23:00 ` [PATCH 6/8] drm/i915: preparation for using PAT index fei.yang
2023-04-19 23:00 ` [Intel-gfx] " fei.yang
2023-04-20 8:45 ` Andrzej Hajda
2023-04-20 21:14 ` Matt Roper
2023-04-19 23:00 ` [PATCH 7/8] drm/i915: use pat_index instead of cache_level fei.yang
2023-04-19 23:00 ` [Intel-gfx] " fei.yang
2023-04-20 10:13 ` Andrzej Hajda
2023-04-20 12:39 ` Tvrtko Ursulin
2023-04-20 20:34 ` Yang, Fei
2023-04-21 8:43 ` Tvrtko Ursulin
2023-04-21 10:17 ` Tvrtko Ursulin
2023-04-23 6:12 ` Yang, Fei
2023-04-23 6:12 ` Yang, Fei
2023-04-24 8:41 ` Tvrtko Ursulin
2023-04-21 11:39 ` Tvrtko Ursulin
2023-04-23 6:52 ` Yang, Fei
2023-04-23 6:52 ` Yang, Fei
2023-04-24 9:22 ` Tvrtko Ursulin
2023-04-19 23:00 ` [PATCH 8/8] drm/i915: Allow user to set cache at BO creation fei.yang
2023-04-19 23:00 ` [Intel-gfx] " fei.yang
2023-04-20 11:39 ` Andi Shyti [this message]
2023-04-20 11:39 ` Andi Shyti
2023-04-20 13:06 ` Tvrtko Ursulin
2023-04-20 16:11 ` Yang, Fei
2023-04-20 16:29 ` Andi Shyti
2023-04-20 16:29 ` Andi Shyti
2023-04-21 20:48 ` Jordan Justen
2023-04-21 20:48 ` Jordan Justen
[not found] ` <BYAPR11MB2567F03AD43D7E2DE2628D5D9A669@BYAPR11MB2567.namprd11.prod.outlook.com>
[not found] ` <168232538771.392286.3227368099155268955@jljusten-skl>
2023-04-24 9:08 ` Tvrtko Ursulin
2023-04-24 9:08 ` Tvrtko Ursulin
2023-04-24 17:13 ` Jordan Justen
2023-04-24 17:13 ` Jordan Justen
2023-04-25 13:41 ` IOCTL feature detection (Was: Re: [Intel-gfx] [PATCH 8/8] drm/i915: Allow user to set cache at BO creation) Joonas Lahtinen
2023-04-25 13:41 ` [Intel-gfx] IOCTL feature detection (Was: " Joonas Lahtinen
2023-04-25 17:21 ` IOCTL feature detection (Was: Re: [Intel-gfx] " Teres Alexis, Alan Previn
2023-04-25 17:21 ` [Intel-gfx] IOCTL feature detection (Was: " Teres Alexis, Alan Previn
2023-04-25 18:19 ` IOCTL feature detection (Was: Re: [Intel-gfx] " Jordan Justen
2023-04-25 18:19 ` [Intel-gfx] IOCTL feature detection (Was: " Jordan Justen
2023-04-26 11:52 ` IOCTL feature detection (Was: Re: [Intel-gfx] " Daniel Vetter
2023-04-26 11:52 ` [Intel-gfx] IOCTL feature detection (Was: " Daniel Vetter
2023-04-26 16:48 ` IOCTL feature detection (Was: Re: [Intel-gfx] " Teres Alexis, Alan Previn
2023-04-26 16:48 ` [Intel-gfx] IOCTL feature detection (Was: " Teres Alexis, Alan Previn
2023-04-26 18:10 ` IOCTL feature detection (Was: Re: [Intel-gfx] " Ceraolo Spurio, Daniele
2023-04-26 18:10 ` [Intel-gfx] IOCTL feature detection (Was: " Ceraolo Spurio, Daniele
2023-04-26 20:04 ` IOCTL feature detection (Was: Re: [Intel-gfx] " Jordan Justen
2023-04-26 20:04 ` [Intel-gfx] IOCTL feature detection (Was: " Jordan Justen
2023-04-19 23:29 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/mtl: Define MOCS and PAT tables for MTL (rev8) Patchwork
2023-04-19 23:51 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-04-20 11:30 ` [Intel-gfx] [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL Andi Shyti
-- strict thread matches above, loose matches on Subject: below --
2023-04-19 21:12 fei.yang
2023-04-19 21:12 ` [PATCH 8/8] drm/i915: Allow user to set cache at BO creation fei.yang
2023-04-19 22:14 ` Andi Shyti
2023-04-19 18:09 [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL fei.yang
2023-04-19 18:09 ` [PATCH 8/8] drm/i915: Allow user to set cache at BO creation fei.yang
2023-04-17 6:24 [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL fei.yang
2023-04-17 6:25 ` [PATCH 8/8] drm/i915: Allow user to set cache at BO creation fei.yang
2023-04-19 12:23 ` Andi Shyti
2023-04-07 7:12 [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL fei.yang
2023-04-07 7:12 ` [PATCH 8/8] drm/i915: Allow user to set cache at BO creation fei.yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEEkV3XOdmtYWnMv@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=chris.p.wilson@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fei.yang@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jordan.l.justen@intel.com \
--cc=lionel.g.landwerlin@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=nirmoy.das@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.