From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Tony Lindgren <tony@atomide.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 01/22] ARM: omap1: innovator: pass lcd control address as pdata
Date: Fri, 9 Aug 2019 13:29:59 +0200 [thread overview]
Message-ID: <af560012-053e-b439-8c6a-8d3f05ff1ef7@samsung.com> (raw)
In-Reply-To: <20190808212234.2213262-2-arnd@arndb.de>
On 8/8/19 11:22 PM, Arnd Bergmann wrote:
> To avoid using the mach/omap1510.h header file, pass the correct
> address as platform data.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
For fbdev part:
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> arch/arm/mach-omap1/board-innovator.c | 3 +++
> drivers/video/fbdev/omap/lcd_inn1510.c | 7 +++++--
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/board-innovator.c b/arch/arm/mach-omap1/board-innovator.c
> index cbe093f969d5..2425f1bacb33 100644
> --- a/arch/arm/mach-omap1/board-innovator.c
> +++ b/arch/arm/mach-omap1/board-innovator.c
> @@ -194,6 +194,9 @@ static struct platform_device innovator1510_smc91x_device = {
> static struct platform_device innovator1510_lcd_device = {
> .name = "lcd_inn1510",
> .id = -1,
> + .dev = {
> + .platform_data = (void __force *)OMAP1510_FPGA_LCD_PANEL_CONTROL,
> + }
> };
>
> static struct platform_device innovator1510_spi_device = {
> diff --git a/drivers/video/fbdev/omap/lcd_inn1510.c b/drivers/video/fbdev/omap/lcd_inn1510.c
> index 776e7f8d656e..37ed0c14aa5a 100644
> --- a/drivers/video/fbdev/omap/lcd_inn1510.c
> +++ b/drivers/video/fbdev/omap/lcd_inn1510.c
> @@ -14,15 +14,17 @@
>
> #include "omapfb.h"
>
> +static void __iomem *omap1510_fpga_lcd_panel_control;
> +
> static int innovator1510_panel_enable(struct lcd_panel *panel)
> {
> - __raw_writeb(0x7, OMAP1510_FPGA_LCD_PANEL_CONTROL);
> + __raw_writeb(0x7, omap1510_fpga_lcd_panel_control);
> return 0;
> }
>
> static void innovator1510_panel_disable(struct lcd_panel *panel)
> {
> - __raw_writeb(0x0, OMAP1510_FPGA_LCD_PANEL_CONTROL);
> + __raw_writeb(0x0, omap1510_fpga_lcd_panel_control);
> }
>
> static struct lcd_panel innovator1510_panel = {
> @@ -48,6 +50,7 @@ static struct lcd_panel innovator1510_panel = {
>
> static int innovator1510_panel_probe(struct platform_device *pdev)
> {
> + omap1510_fpga_lcd_panel_control = (void __iomem *)pdev->dev.platform_data;
> omapfb_register_panel(&innovator1510_panel);
> return 0;
> }
WARNING: multiple messages have this Message-ID (diff)
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Tony Lindgren <tony@atomide.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 01/22] ARM: omap1: innovator: pass lcd control address as pdata
Date: Fri, 09 Aug 2019 11:29:59 +0000 [thread overview]
Message-ID: <af560012-053e-b439-8c6a-8d3f05ff1ef7@samsung.com> (raw)
In-Reply-To: <20190808212234.2213262-2-arnd@arndb.de>
On 8/8/19 11:22 PM, Arnd Bergmann wrote:
> To avoid using the mach/omap1510.h header file, pass the correct
> address as platform data.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
For fbdev part:
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> arch/arm/mach-omap1/board-innovator.c | 3 +++
> drivers/video/fbdev/omap/lcd_inn1510.c | 7 +++++--
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/board-innovator.c b/arch/arm/mach-omap1/board-innovator.c
> index cbe093f969d5..2425f1bacb33 100644
> --- a/arch/arm/mach-omap1/board-innovator.c
> +++ b/arch/arm/mach-omap1/board-innovator.c
> @@ -194,6 +194,9 @@ static struct platform_device innovator1510_smc91x_device = {
> static struct platform_device innovator1510_lcd_device = {
> .name = "lcd_inn1510",
> .id = -1,
> + .dev = {
> + .platform_data = (void __force *)OMAP1510_FPGA_LCD_PANEL_CONTROL,
> + }
> };
>
> static struct platform_device innovator1510_spi_device = {
> diff --git a/drivers/video/fbdev/omap/lcd_inn1510.c b/drivers/video/fbdev/omap/lcd_inn1510.c
> index 776e7f8d656e..37ed0c14aa5a 100644
> --- a/drivers/video/fbdev/omap/lcd_inn1510.c
> +++ b/drivers/video/fbdev/omap/lcd_inn1510.c
> @@ -14,15 +14,17 @@
>
> #include "omapfb.h"
>
> +static void __iomem *omap1510_fpga_lcd_panel_control;
> +
> static int innovator1510_panel_enable(struct lcd_panel *panel)
> {
> - __raw_writeb(0x7, OMAP1510_FPGA_LCD_PANEL_CONTROL);
> + __raw_writeb(0x7, omap1510_fpga_lcd_panel_control);
> return 0;
> }
>
> static void innovator1510_panel_disable(struct lcd_panel *panel)
> {
> - __raw_writeb(0x0, OMAP1510_FPGA_LCD_PANEL_CONTROL);
> + __raw_writeb(0x0, omap1510_fpga_lcd_panel_control);
> }
>
> static struct lcd_panel innovator1510_panel = {
> @@ -48,6 +50,7 @@ static struct lcd_panel innovator1510_panel = {
>
> static int innovator1510_panel_probe(struct platform_device *pdev)
> {
> + omap1510_fpga_lcd_panel_control = (void __iomem *)pdev->dev.platform_data;
> omapfb_register_panel(&innovator1510_panel);
> return 0;
> }
WARNING: multiple messages have this Message-ID (diff)
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-fbdev@vger.kernel.org, Aaro Koskinen <aaro.koskinen@iki.fi>,
Tony Lindgren <tony@atomide.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/22] ARM: omap1: innovator: pass lcd control address as pdata
Date: Fri, 9 Aug 2019 13:29:59 +0200 [thread overview]
Message-ID: <af560012-053e-b439-8c6a-8d3f05ff1ef7@samsung.com> (raw)
In-Reply-To: <20190808212234.2213262-2-arnd@arndb.de>
On 8/8/19 11:22 PM, Arnd Bergmann wrote:
> To avoid using the mach/omap1510.h header file, pass the correct
> address as platform data.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
For fbdev part:
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> arch/arm/mach-omap1/board-innovator.c | 3 +++
> drivers/video/fbdev/omap/lcd_inn1510.c | 7 +++++--
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/board-innovator.c b/arch/arm/mach-omap1/board-innovator.c
> index cbe093f969d5..2425f1bacb33 100644
> --- a/arch/arm/mach-omap1/board-innovator.c
> +++ b/arch/arm/mach-omap1/board-innovator.c
> @@ -194,6 +194,9 @@ static struct platform_device innovator1510_smc91x_device = {
> static struct platform_device innovator1510_lcd_device = {
> .name = "lcd_inn1510",
> .id = -1,
> + .dev = {
> + .platform_data = (void __force *)OMAP1510_FPGA_LCD_PANEL_CONTROL,
> + }
> };
>
> static struct platform_device innovator1510_spi_device = {
> diff --git a/drivers/video/fbdev/omap/lcd_inn1510.c b/drivers/video/fbdev/omap/lcd_inn1510.c
> index 776e7f8d656e..37ed0c14aa5a 100644
> --- a/drivers/video/fbdev/omap/lcd_inn1510.c
> +++ b/drivers/video/fbdev/omap/lcd_inn1510.c
> @@ -14,15 +14,17 @@
>
> #include "omapfb.h"
>
> +static void __iomem *omap1510_fpga_lcd_panel_control;
> +
> static int innovator1510_panel_enable(struct lcd_panel *panel)
> {
> - __raw_writeb(0x7, OMAP1510_FPGA_LCD_PANEL_CONTROL);
> + __raw_writeb(0x7, omap1510_fpga_lcd_panel_control);
> return 0;
> }
>
> static void innovator1510_panel_disable(struct lcd_panel *panel)
> {
> - __raw_writeb(0x0, OMAP1510_FPGA_LCD_PANEL_CONTROL);
> + __raw_writeb(0x0, omap1510_fpga_lcd_panel_control);
> }
>
> static struct lcd_panel innovator1510_panel = {
> @@ -48,6 +50,7 @@ static struct lcd_panel innovator1510_panel = {
>
> static int innovator1510_panel_probe(struct platform_device *pdev)
> {
> + omap1510_fpga_lcd_panel_control = (void __iomem *)pdev->dev.platform_data;
> omapfb_register_panel(&innovator1510_panel);
> return 0;
> }
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-09 11:30 UTC|newest]
Thread overview: 138+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 21:22 [PATCH 00/22] ARM: omap1 multiplatform support Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-08 21:22 ` [PATCH 01/22] ARM: omap1: innovator: pass lcd control address as pdata Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-09 11:29 ` Bartlomiej Zolnierkiewicz [this message]
2019-08-09 11:29 ` Bartlomiej Zolnierkiewicz
2019-08-09 11:29 ` Bartlomiej Zolnierkiewicz
2019-08-08 21:22 ` [PATCH 02/22] ARM: omap1: make omapfb standalone compilable Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-09 11:32 ` Bartlomiej Zolnierkiewicz
2019-08-09 11:32 ` Bartlomiej Zolnierkiewicz
2019-08-09 11:43 ` Arnd Bergmann
2019-08-09 11:43 ` Arnd Bergmann
2019-08-09 14:36 ` Bartlomiej Zolnierkiewicz
2019-08-09 14:36 ` Bartlomiej Zolnierkiewicz
2019-08-09 19:55 ` Arnd Bergmann
2019-08-09 19:55 ` Arnd Bergmann
2019-08-12 9:21 ` Bartlomiej Zolnierkiewicz
2019-08-12 9:21 ` Bartlomiej Zolnierkiewicz
2019-08-08 21:22 ` [PATCH 03/22] ARM: omap1: move omap15xx local bus handling to usb.c Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-09 5:32 ` Felipe Balbi
2019-08-09 5:32 ` Felipe Balbi
2019-08-09 5:32 ` Felipe Balbi
2019-08-10 10:28 ` Christoph Hellwig
2019-08-10 10:28 ` Christoph Hellwig
2019-08-10 10:28 ` Christoph Hellwig
2019-08-08 21:22 ` [PATCH 04/22] ARM: omap1: move ohci phy power handling to board files Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-08 21:22 ` [PATCH 05/22] ARM: omap1: move mach/usb.h to include/linux/soc Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-08 21:22 ` [PATCH 06/22] ARM: omap1: move some headers " Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-08 21:22 ` [PATCH 07/22] ARM: omap1: move perseus spi pinconf to board file Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-08 22:24 ` Mark Brown
2019-08-08 22:24 ` Mark Brown
2019-08-09 11:29 ` Arnd Bergmann
2019-08-09 11:29 ` Arnd Bergmann
2019-08-09 12:01 ` Mark Brown
2019-08-09 12:01 ` Mark Brown
2019-08-08 21:22 ` [PATCH 08/22] ARM: omap1: move CF chipselect setup " Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-08 21:22 ` [PATCH 09/22] fbdev: omap: avoid using mach/*.h files Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-09 11:34 ` Bartlomiej Zolnierkiewicz
2019-08-09 11:34 ` Bartlomiej Zolnierkiewicz
2019-08-09 11:34 ` Bartlomiej Zolnierkiewicz
2019-08-08 21:22 ` [PATCH 10/22] usb: omap: avoid mach/*.h headers Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-09 5:38 ` Greg Kroah-Hartman
2019-08-09 5:38 ` Greg Kroah-Hartman
2019-08-08 21:22 ` [PATCH 11/22] clocksource: ti-dmtimer: avoid using mach/hardware.h Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-09 7:01 ` Daniel Lezcano
2019-08-09 7:01 ` Daniel Lezcano
2019-08-09 7:33 ` Arnd Bergmann
2019-08-09 7:33 ` Arnd Bergmann
2019-08-09 7:57 ` Daniel Lezcano
2019-08-09 7:57 ` Daniel Lezcano
2019-08-08 21:22 ` [PATCH 12/22] serial: 8250/omap1: include linux/soc/ti/omap1-soc.h Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-08 21:22 ` [PATCH 13/22] input: omap: void using mach/*.h headers Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-08 21:42 ` Dmitry Torokhov
2019-08-08 21:42 ` Dmitry Torokhov
2019-08-08 21:46 ` Arnd Bergmann
2019-08-08 21:46 ` Arnd Bergmann
2019-08-08 21:46 ` Arnd Bergmann
2019-08-08 22:19 ` Dmitry Torokhov
2019-08-08 22:19 ` Dmitry Torokhov
2019-08-08 23:39 ` Sebastian Reichel
2019-08-08 23:39 ` Sebastian Reichel
2019-08-09 11:23 ` Arnd Bergmann
2019-08-09 11:23 ` Arnd Bergmann
2019-08-08 21:22 ` [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf Arnd Bergmann
2019-08-08 21:22 ` Arnd Bergmann
2019-08-13 10:36 ` Tony Lindgren
2019-08-13 10:36 ` Tony Lindgren
2019-08-13 11:02 ` Arnd Bergmann
2019-08-13 11:02 ` Arnd Bergmann
2019-08-13 18:11 ` Aaro Koskinen
2019-08-13 18:11 ` Aaro Koskinen
2019-08-13 18:11 ` Aaro Koskinen
2019-08-13 19:33 ` Arnd Bergmann
2019-08-13 19:33 ` Arnd Bergmann
2019-08-14 7:49 ` Tony Lindgren
2019-08-14 7:49 ` Tony Lindgren
2019-08-14 10:36 ` Arnd Bergmann
2019-08-14 10:36 ` Arnd Bergmann
2019-08-14 13:40 ` Tony Lindgren
2019-08-14 13:40 ` Tony Lindgren
2019-08-16 8:34 ` Aaro Koskinen
2019-08-16 8:34 ` Aaro Koskinen
2019-08-27 16:33 ` Arnd Bergmann
2019-08-27 16:33 ` Arnd Bergmann
2019-08-27 19:04 ` Aaro Koskinen
2019-08-27 19:04 ` Aaro Koskinen
2019-08-28 13:02 ` Arnd Bergmann
2019-08-28 13:02 ` Arnd Bergmann
2019-08-28 18:23 ` Aaro Koskinen
2019-08-28 18:23 ` Aaro Koskinen
2019-08-28 18:45 ` Tony Lindgren
2019-08-28 18:45 ` Tony Lindgren
2019-08-08 21:41 ` [PATCH 15/22] ARM: omap1: move mach/*.h into mach directory Arnd Bergmann
2019-08-08 21:41 ` Arnd Bergmann
2019-08-08 21:41 ` Arnd Bergmann
2019-08-08 21:41 ` [PATCH 16/22] ARM: omap1: move clk support into a single file Arnd Bergmann
2019-08-08 21:41 ` Arnd Bergmann
2019-08-08 21:41 ` Arnd Bergmann
2019-08-08 21:41 ` [PATCH 17/22] ARM: omap1: remove some dead clock code Arnd Bergmann
2019-08-08 21:41 ` Arnd Bergmann
2019-08-08 21:41 ` [PATCH 18/22] ARM: omap1: clk: rework 'struct clk' Arnd Bergmann
2019-08-08 21:41 ` Arnd Bergmann
2019-08-08 21:41 ` [PATCH 19/22] ARM: omap1: clk: use common_clk-like callbacks Arnd Bergmann
2019-08-08 21:41 ` Arnd Bergmann
2019-08-08 21:43 ` [PATCH 20/22] ARM: omap1: clk: use clk_init_data Arnd Bergmann
2019-08-08 21:43 ` Arnd Bergmann
2019-08-08 21:43 ` [PATCH 21/22] ARM: omap1: use common clk framework Arnd Bergmann
2019-08-08 21:43 ` Arnd Bergmann
2019-08-14 21:10 ` Aaro Koskinen
2019-08-14 21:10 ` Aaro Koskinen
2019-08-15 7:10 ` Arnd Bergmann
2019-08-15 7:10 ` Arnd Bergmann
2019-08-08 21:47 ` [PATCH 22/22] ARM: omap1: enable multiplatform Arnd Bergmann
2019-08-08 21:47 ` Arnd Bergmann
2019-08-08 21:47 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af560012-053e-b439-8c6a-8d3f05ff1ef7@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=aaro.koskinen@iki.fi \
--cc=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.