All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: 'Kukjin Kim' <kgene.kim@samsung.com>,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: kyungmin.park@samsung.com, ben-linux@fluff.org
Subject: RE: [PATCH 1/6] ARM: S5PC110: update framebuffer setup information for Goni
Date: Tue, 14 Sep 2010 07:38:19 +0200	[thread overview]
Message-ID: <002f01cb53cf$0c682a80$25387f80$%szyprowski@samsung.com> (raw)
In-Reply-To: <000401cb50cd$8b3f72a0$a1be57e0$%kim@samsung.com>

Hello,

On Friday, September 10, 2010 11:50 AM Kukjin Kim wrote:

> Marek Szyprowski wrote:
> >
> > Change the default upper_margin and vsync_len to get rid of repeated last
> > line on the display.
> >
> How about Aquila board? Maybe same in my thinking.

Yes, I will send a similar patch once I do a test. Had no access to Aquila
board that time.

> And it'd better that another stuff like removing pixclock is in different
> patch.

Well, Goni machine was the last one that had pixelclock defined. All other
boards had pixel clock definition already removed, so I thought that it would
be a good opportunity to fix this together with screen definition update.
 
> Anyway, looks ok to me...will apply.

Thx

> 
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> >  arch/arm/mach-s5pv210/mach-goni.c |    5 ++---
> >  1 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/mach-s5pv210/mach-goni.c
> b/arch/arm/mach-s5pv210/mach-
> > goni.c
> > index d9fe739..b0ae208 100644
> > --- a/arch/arm/mach-s5pv210/mach-goni.c
> > +++ b/arch/arm/mach-s5pv210/mach-goni.c
> > @@ -88,13 +88,12 @@ static struct s3c2410_uartcfg goni_uartcfgs[]
> __initdata = {
> >  /* Frame Buffer */
> >  static struct s3c_fb_pd_win goni_fb_win0 = {
> >  	.win_mode = {
> > -		.pixclock = 1000000000000ULL /
> > ((16+16+2+480)*(28+3+2+800)*55),
> >  		.left_margin	= 16,
> >  		.right_margin	= 16,
> > -		.upper_margin	= 3,
> > +		.upper_margin	= 2,
> >  		.lower_margin	= 28,
> >  		.hsync_len	= 2,
> > -		.vsync_len	= 2,
> > +		.vsync_len	= 1,
> >  		.xres		= 480,
> >  		.yres		= 800,
> >  		.refresh	= 55,
> > --
> > 1.7.2.2
> 

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center

WARNING: multiple messages have this Message-ID (diff)
From: m.szyprowski@samsung.com (Marek Szyprowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] ARM: S5PC110: update framebuffer setup information for Goni
Date: Tue, 14 Sep 2010 07:38:19 +0200	[thread overview]
Message-ID: <002f01cb53cf$0c682a80$25387f80$%szyprowski@samsung.com> (raw)
In-Reply-To: <000401cb50cd$8b3f72a0$a1be57e0$%kim@samsung.com>

Hello,

On Friday, September 10, 2010 11:50 AM Kukjin Kim wrote:

> Marek Szyprowski wrote:
> >
> > Change the default upper_margin and vsync_len to get rid of repeated last
> > line on the display.
> >
> How about Aquila board? Maybe same in my thinking.

Yes, I will send a similar patch once I do a test. Had no access to Aquila
board that time.

> And it'd better that another stuff like removing pixclock is in different
> patch.

Well, Goni machine was the last one that had pixelclock defined. All other
boards had pixel clock definition already removed, so I thought that it would
be a good opportunity to fix this together with screen definition update.
 
> Anyway, looks ok to me...will apply.

Thx

> 
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> >  arch/arm/mach-s5pv210/mach-goni.c |    5 ++---
> >  1 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/mach-s5pv210/mach-goni.c
> b/arch/arm/mach-s5pv210/mach-
> > goni.c
> > index d9fe739..b0ae208 100644
> > --- a/arch/arm/mach-s5pv210/mach-goni.c
> > +++ b/arch/arm/mach-s5pv210/mach-goni.c
> > @@ -88,13 +88,12 @@ static struct s3c2410_uartcfg goni_uartcfgs[]
> __initdata = {
> >  /* Frame Buffer */
> >  static struct s3c_fb_pd_win goni_fb_win0 = {
> >  	.win_mode = {
> > -		.pixclock = 1000000000000ULL /
> > ((16+16+2+480)*(28+3+2+800)*55),
> >  		.left_margin	= 16,
> >  		.right_margin	= 16,
> > -		.upper_margin	= 3,
> > +		.upper_margin	= 2,
> >  		.lower_margin	= 28,
> >  		.hsync_len	= 2,
> > -		.vsync_len	= 2,
> > +		.vsync_len	= 1,
> >  		.xres		= 480,
> >  		.yres		= 800,
> >  		.refresh	= 55,
> > --
> > 1.7.2.2
> 

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center

  reply	other threads:[~2010-09-14  5:38 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-10  7:23 [PATCH] ARM: S5PC110: Samsung Goni board update Marek Szyprowski
2010-09-10  7:23 ` Marek Szyprowski
2010-09-10  7:23 ` [PATCH 1/6] ARM: S5PC110: update framebuffer setup information for Goni Marek Szyprowski
2010-09-10  7:23   ` Marek Szyprowski
2010-09-10  9:49   ` Kukjin Kim
2010-09-10  9:49     ` Kukjin Kim
2010-09-14  5:38     ` Marek Szyprowski [this message]
2010-09-14  5:38       ` Marek Szyprowski
2010-09-10  7:23 ` [PATCH 2/6] ARM: S5PC110: add support for S6E63M0 LCD controller on Goni board Marek Szyprowski
2010-09-10  7:23   ` Marek Szyprowski
2010-09-10  7:23 ` [PATCH 3/6] ARM: S5PC110: Add si470x radio device to the GONI board Marek Szyprowski
2010-09-10  7:23   ` Marek Szyprowski
2010-09-10  9:58   ` Kukjin Kim
2010-09-10  9:58     ` Kukjin Kim
2010-09-14  5:43     ` Marek Szyprowski
2010-09-14  5:43       ` Marek Szyprowski
2010-09-10  7:23 ` [PATCH 4/6] ARM: S5PV210: Enable USB HSOTG gadget build Marek Szyprowski
2010-09-10  7:23   ` Marek Szyprowski
2010-09-10 10:33   ` Kukjin Kim
2010-09-10 10:33     ` Kukjin Kim
2010-09-11  6:12     ` Kyungmin Park
2010-09-11  6:12       ` Kyungmin Park
2010-09-10  7:23 ` [PATCH 5/6] ARM: S5PC110: add support for otg usb gadget on Goni board Marek Szyprowski
2010-09-10  7:23   ` Marek Szyprowski
2010-09-10 10:44   ` Kukjin Kim
2010-09-10 10:44     ` Kukjin Kim
2010-09-14  5:46     ` Marek Szyprowski
2010-09-14  5:46       ` Marek Szyprowski
2010-09-10  7:23 ` [PATCH 6/6] ARM: S5PC110: add support for MMC regulators " Marek Szyprowski
2010-09-10  7:23   ` Marek Szyprowski
2010-09-10  9:41   ` Mark Brown
2010-09-10  9:41     ` Mark Brown
2010-09-10  9:55   ` Kukjin Kim
2010-09-10  9:55     ` Kukjin Kim
2010-09-10  9:58     ` Mark Brown
2010-09-10  9:58       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002f01cb53cf$0c682a80$25387f80$%szyprowski@samsung.com' \
    --to=m.szyprowski@samsung.com \
    --cc=ben-linux@fluff.org \
    --cc=kgene.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.