From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kyungmin.park@samsung.com,
kgene.kim@samsung.com, ben-linux@fluff.org
Subject: Re: [PATCH 6/6] ARM: S5PC110: add support for MMC regulators on Goni board
Date: Fri, 10 Sep 2010 10:41:04 +0100 [thread overview]
Message-ID: <20100910094104.GC3068@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1284103403-10696-7-git-send-email-m.szyprowski@samsung.com>
On Fri, Sep 10, 2010 at 09:23:23AM +0200, Marek Szyprowski wrote:
> +static struct regulator_consumer_supply goni_ldo5_consumers[] = {
> + { .supply = "vmmc", .dev = &s3c_device_hsmmc0.dev },
> +};
> +
This is OK but it is better to use dev_name rather than dev - dev may
be removed at some point since given dev you can always use dev_name but
you don't always have dev.
Acked-by: Mark Brown <broonie@opoensource.wolfsonmicro.com>
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] ARM: S5PC110: add support for MMC regulators on Goni board
Date: Fri, 10 Sep 2010 10:41:04 +0100 [thread overview]
Message-ID: <20100910094104.GC3068@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1284103403-10696-7-git-send-email-m.szyprowski@samsung.com>
On Fri, Sep 10, 2010 at 09:23:23AM +0200, Marek Szyprowski wrote:
> +static struct regulator_consumer_supply goni_ldo5_consumers[] = {
> + { .supply = "vmmc", .dev = &s3c_device_hsmmc0.dev },
> +};
> +
This is OK but it is better to use dev_name rather than dev - dev may
be removed at some point since given dev you can always use dev_name but
you don't always have dev.
Acked-by: Mark Brown <broonie@opoensource.wolfsonmicro.com>
next prev parent reply other threads:[~2010-09-10 9:41 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 7:23 [PATCH] ARM: S5PC110: Samsung Goni board update Marek Szyprowski
2010-09-10 7:23 ` Marek Szyprowski
2010-09-10 7:23 ` [PATCH 1/6] ARM: S5PC110: update framebuffer setup information for Goni Marek Szyprowski
2010-09-10 7:23 ` Marek Szyprowski
2010-09-10 9:49 ` Kukjin Kim
2010-09-10 9:49 ` Kukjin Kim
2010-09-14 5:38 ` Marek Szyprowski
2010-09-14 5:38 ` Marek Szyprowski
2010-09-10 7:23 ` [PATCH 2/6] ARM: S5PC110: add support for S6E63M0 LCD controller on Goni board Marek Szyprowski
2010-09-10 7:23 ` Marek Szyprowski
2010-09-10 7:23 ` [PATCH 3/6] ARM: S5PC110: Add si470x radio device to the GONI board Marek Szyprowski
2010-09-10 7:23 ` Marek Szyprowski
2010-09-10 9:58 ` Kukjin Kim
2010-09-10 9:58 ` Kukjin Kim
2010-09-14 5:43 ` Marek Szyprowski
2010-09-14 5:43 ` Marek Szyprowski
2010-09-10 7:23 ` [PATCH 4/6] ARM: S5PV210: Enable USB HSOTG gadget build Marek Szyprowski
2010-09-10 7:23 ` Marek Szyprowski
2010-09-10 10:33 ` Kukjin Kim
2010-09-10 10:33 ` Kukjin Kim
2010-09-11 6:12 ` Kyungmin Park
2010-09-11 6:12 ` Kyungmin Park
2010-09-10 7:23 ` [PATCH 5/6] ARM: S5PC110: add support for otg usb gadget on Goni board Marek Szyprowski
2010-09-10 7:23 ` Marek Szyprowski
2010-09-10 10:44 ` Kukjin Kim
2010-09-10 10:44 ` Kukjin Kim
2010-09-14 5:46 ` Marek Szyprowski
2010-09-14 5:46 ` Marek Szyprowski
2010-09-10 7:23 ` [PATCH 6/6] ARM: S5PC110: add support for MMC regulators " Marek Szyprowski
2010-09-10 7:23 ` Marek Szyprowski
2010-09-10 9:41 ` Mark Brown [this message]
2010-09-10 9:41 ` Mark Brown
2010-09-10 9:55 ` Kukjin Kim
2010-09-10 9:55 ` Kukjin Kim
2010-09-10 9:58 ` Mark Brown
2010-09-10 9:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100910094104.GC3068@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.