From: Mark Brown <broonie@opensource.wolfsonmicro.com> To: Kukjin Kim <kgene.kim@samsung.com> Cc: 'Marek Szyprowski' <m.szyprowski@samsung.com>, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kyungmin.park@samsung.com, ben-linux@fluff.org Subject: Re: [PATCH 6/6] ARM: S5PC110: add support for MMC regulators on Goni board Date: Fri, 10 Sep 2010 10:58:28 +0100 [thread overview] Message-ID: <20100910095828.GE3068@rakim.wolfsonmicro.main> (raw) In-Reply-To: <000501cb50ce$5c606f60$15214e20$%kim@samsung.com> On Fri, Sep 10, 2010 at 06:55:50PM +0900, Kukjin Kim wrote: > > +static struct fixed_voltage_config mmc2_fixed_voltage_config = { > > + .supply_name = "T_FLASH_EN", > > + .microvolts = 2800000, > > + .gpio = S5PV210_MP05(4), /* XM0ADDR_12 */ ... > > static void goni_setup_sdhci(void) > > { > > - gpio_request(GONI_EXT_FLASH_EN, "FLASH_EN"); > > - gpio_direction_output(GONI_EXT_FLASH_EN, 1); > > - > Why need above changes in this patch? > Others, looks ok. It looks like ownership of this GPIO has been transferred to the fixed voltage regulator added in the patch (though using the #define in the fixed voltage regulator platform data might be a good idea).
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 6/6] ARM: S5PC110: add support for MMC regulators on Goni board Date: Fri, 10 Sep 2010 10:58:28 +0100 [thread overview] Message-ID: <20100910095828.GE3068@rakim.wolfsonmicro.main> (raw) In-Reply-To: <000501cb50ce$5c606f60$15214e20$%kim@samsung.com> On Fri, Sep 10, 2010 at 06:55:50PM +0900, Kukjin Kim wrote: > > +static struct fixed_voltage_config mmc2_fixed_voltage_config = { > > + .supply_name = "T_FLASH_EN", > > + .microvolts = 2800000, > > + .gpio = S5PV210_MP05(4), /* XM0ADDR_12 */ ... > > static void goni_setup_sdhci(void) > > { > > - gpio_request(GONI_EXT_FLASH_EN, "FLASH_EN"); > > - gpio_direction_output(GONI_EXT_FLASH_EN, 1); > > - > Why need above changes in this patch? > Others, looks ok. It looks like ownership of this GPIO has been transferred to the fixed voltage regulator added in the patch (though using the #define in the fixed voltage regulator platform data might be a good idea).
next prev parent reply other threads:[~2010-09-10 9:58 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-09-10 7:23 [PATCH] ARM: S5PC110: Samsung Goni board update Marek Szyprowski 2010-09-10 7:23 ` Marek Szyprowski 2010-09-10 7:23 ` [PATCH 1/6] ARM: S5PC110: update framebuffer setup information for Goni Marek Szyprowski 2010-09-10 7:23 ` Marek Szyprowski 2010-09-10 9:49 ` Kukjin Kim 2010-09-10 9:49 ` Kukjin Kim 2010-09-14 5:38 ` Marek Szyprowski 2010-09-14 5:38 ` Marek Szyprowski 2010-09-10 7:23 ` [PATCH 2/6] ARM: S5PC110: add support for S6E63M0 LCD controller on Goni board Marek Szyprowski 2010-09-10 7:23 ` Marek Szyprowski 2010-09-10 7:23 ` [PATCH 3/6] ARM: S5PC110: Add si470x radio device to the GONI board Marek Szyprowski 2010-09-10 7:23 ` Marek Szyprowski 2010-09-10 9:58 ` Kukjin Kim 2010-09-10 9:58 ` Kukjin Kim 2010-09-14 5:43 ` Marek Szyprowski 2010-09-14 5:43 ` Marek Szyprowski 2010-09-10 7:23 ` [PATCH 4/6] ARM: S5PV210: Enable USB HSOTG gadget build Marek Szyprowski 2010-09-10 7:23 ` Marek Szyprowski 2010-09-10 10:33 ` Kukjin Kim 2010-09-10 10:33 ` Kukjin Kim 2010-09-11 6:12 ` Kyungmin Park 2010-09-11 6:12 ` Kyungmin Park 2010-09-10 7:23 ` [PATCH 5/6] ARM: S5PC110: add support for otg usb gadget on Goni board Marek Szyprowski 2010-09-10 7:23 ` Marek Szyprowski 2010-09-10 10:44 ` Kukjin Kim 2010-09-10 10:44 ` Kukjin Kim 2010-09-14 5:46 ` Marek Szyprowski 2010-09-14 5:46 ` Marek Szyprowski 2010-09-10 7:23 ` [PATCH 6/6] ARM: S5PC110: add support for MMC regulators " Marek Szyprowski 2010-09-10 7:23 ` Marek Szyprowski 2010-09-10 9:41 ` Mark Brown 2010-09-10 9:41 ` Mark Brown 2010-09-10 9:55 ` Kukjin Kim 2010-09-10 9:55 ` Kukjin Kim 2010-09-10 9:58 ` Mark Brown [this message] 2010-09-10 9:58 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100910095828.GE3068@rakim.wolfsonmicro.main \ --to=broonie@opensource.wolfsonmicro.com \ --cc=ben-linux@fluff.org \ --cc=kgene.kim@samsung.com \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.