AVCTP and AVRCP packet decoder file structure in btmon

AVCTP and AVRCP packet decoder file structure in btmon

[Vikrampal]

Hi,

I'm working on AVRCP packet decoder for Bluetooth monitor module.
There's a separate file avctp.c/h for AVCTP packet decoder.

The file avctp.c is not a big file as such. So, I'm thinking whether or not
I should
include AVRCP decoder in this file itself.

Shall I create a separate file for AVRCP decoding?

If both AVCTP & AVRCP go in the same file then what should be the 
appropriate name of the file or shall I create a separate file for AVRCP as
well.

Please advise me. Thanks!

Regards,
Vikram

Re: AVCTP and AVRCP packet decoder file structure in btmon

[Luiz Augusto von Dentz]

Hi Vikrampal,

We can start by reusing avctp.c to place AV/C and AVRCP decoders,
later on we can review if it is the case of splitting. Also please
note that android/Android.mk needs updating if we change anything on
the build of btmon.

On Mon, Aug 4, 2014 at 11:48 AM, Vikrampal <vikram.pal@samsung.com> wrote:
> Hi,
>
> I'm working on AVRCP packet decoder for Bluetooth monitor module.
> There's a separate file avctp.c/h for AVCTP packet decoder.
>
> The file avctp.c is not a big file as such. So, I'm thinking whether or not
> I should
> include AVRCP decoder in this file itself.
>
> Shall I create a separate file for AVRCP decoding?
>
> If both AVCTP & AVRCP go in the same file then what should be the
> appropriate name of the file or shall I create a separate file for AVRCP as
> well.
>
> Please advise me. Thanks!
>
> Regards,
> Vikram
>



-- 
Luiz Augusto von Dentz

RE: AVCTP and AVRCP packet decoder file structure in btmon

[Vikrampal]

Sure Luiz!

However, I've one more small doubt. If I'm submitting a series of patches
Such as 1/4, 2/4, 3/4, 4/4... I guess in such scenarios no need to ensure that
the patches separately compiles. What we need to ensure is that all the patches together
gets compiled properly. Am I mistaken?

> -----Original Message-----
> From: Luiz Augusto von Dentz [mailto:luiz.dentz@gmail.com]
> Sent: Monday, August 04, 2014 4:15 PM
> To: Vikrampal
> Cc: linux-bluetooth@vger.kernel.org; Dmitry Kasatkin
> Subject: Re: AVCTP and AVRCP packet decoder file structure in btmon
> 
> Hi Vikrampal,
> 
> We can start by reusing avctp.c to place AV/C and AVRCP decoders, later on
> we can review if it is the case of splitting. Also please note that
> android/Android.mk needs updating if we change anything on the build of
> btmon.
> 
> On Mon, Aug 4, 2014 at 11:48 AM, Vikrampal <vikram.pal@samsung.com>
> wrote:
> > Hi,
> >
> > I'm working on AVRCP packet decoder for Bluetooth monitor module.
> > There's a separate file avctp.c/h for AVCTP packet decoder.
> >
> > The file avctp.c is not a big file as such. So, I'm thinking whether
> > or not I should include AVRCP decoder in this file itself.
> >
> > Shall I create a separate file for AVRCP decoding?
> >
> > If both AVCTP & AVRCP go in the same file then what should be the
> > appropriate name of the file or shall I create a separate file for
> > AVRCP as well.
> >
> > Please advise me. Thanks!
> >
> > Regards,
> > Vikram
> >
> 
> 
> 
> --
> Luiz Augusto von Dentz

Regards,
Vikram

Re: AVCTP and AVRCP packet decoder file structure in btmon

[Luiz Augusto von Dentz]

Hi Vikrampal,

I do like to test patches individually so please make sure they
compile and in general we don't allow commits that do not compile
because they can break bisect.

On Tue, Aug 5, 2014 at 9:54 AM, Vikrampal <vikram.pal@samsung.com> wrote:
> Sure Luiz!
>
> However, I've one more small doubt. If I'm submitting a series of patches
> Such as 1/4, 2/4, 3/4, 4/4... I guess in such scenarios no need to ensure that
> the patches separately compiles. What we need to ensure is that all the patches together
> gets compiled properly. Am I mistaken?
>
>> -----Original Message-----
>> From: Luiz Augusto von Dentz [mailto:luiz.dentz@gmail.com]
>> Sent: Monday, August 04, 2014 4:15 PM
>> To: Vikrampal
>> Cc: linux-bluetooth@vger.kernel.org; Dmitry Kasatkin
>> Subject: Re: AVCTP and AVRCP packet decoder file structure in btmon
>>
>> Hi Vikrampal,
>>
>> We can start by reusing avctp.c to place AV/C and AVRCP decoders, later on
>> we can review if it is the case of splitting. Also please note that
>> android/Android.mk needs updating if we change anything on the build of
>> btmon.
>>
>> On Mon, Aug 4, 2014 at 11:48 AM, Vikrampal <vikram.pal@samsung.com>
>> wrote:
>> > Hi,
>> >
>> > I'm working on AVRCP packet decoder for Bluetooth monitor module.
>> > There's a separate file avctp.c/h for AVCTP packet decoder.
>> >
>> > The file avctp.c is not a big file as such. So, I'm thinking whether
>> > or not I should include AVRCP decoder in this file itself.
>> >
>> > Shall I create a separate file for AVRCP decoding?
>> >
>> > If both AVCTP & AVRCP go in the same file then what should be the
>> > appropriate name of the file or shall I create a separate file for
>> > AVRCP as well.
>> >
>> > Please advise me. Thanks!
>> >
>> > Regards,
>> > Vikram
>> >
>>
>>
>>
>> --
>> Luiz Augusto von Dentz
>
> Regards,
> Vikram
>



-- 
Luiz Augusto von Dentz

RE: AVCTP and AVRCP packet decoder file structure in btmon

[Vikrampal]

Hi Luiz,

If I submit interdependent patches in one go then I guess the patches are taken in order
i.e. 1/4, 2/4, 3/4, 4/4.

That means we can take just 2/4 out and expect it to compile since it depends on 1/4.

Am I correct?

> -----Original Message-----
> From: Luiz Augusto von Dentz [mailto:luiz.dentz@gmail.com]
> Sent: Tuesday, August 05, 2014 1:32 PM
> To: Vikrampal
> Cc: linux-bluetooth@vger.kernel.org; Dmitry Kasatkin
> Subject: Re: AVCTP and AVRCP packet decoder file structure in btmon
> 
> Hi Vikrampal,
> 
> I do like to test patches individually so please make sure they compile and in
> general we don't allow commits that do not compile because they can break
> bisect.
> 
> On Tue, Aug 5, 2014 at 9:54 AM, Vikrampal <vikram.pal@samsung.com>
> wrote:
> > Sure Luiz!
> >
> > However, I've one more small doubt. If I'm submitting a series of
> > patches Such as 1/4, 2/4, 3/4, 4/4... I guess in such scenarios no
> > need to ensure that the patches separately compiles. What we need to
> > ensure is that all the patches together gets compiled properly. Am I
> mistaken?
> >
> >> -----Original Message-----
> >> From: Luiz Augusto von Dentz [mailto:luiz.dentz@gmail.com]
> >> Sent: Monday, August 04, 2014 4:15 PM
> >> To: Vikrampal
> >> Cc: linux-bluetooth@vger.kernel.org; Dmitry Kasatkin
> >> Subject: Re: AVCTP and AVRCP packet decoder file structure in btmon
> >>
> >> Hi Vikrampal,
> >>
> >> We can start by reusing avctp.c to place AV/C and AVRCP decoders,
> >> later on we can review if it is the case of splitting. Also please
> >> note that android/Android.mk needs updating if we change anything on
> >> the build of btmon.
> >>
> >> On Mon, Aug 4, 2014 at 11:48 AM, Vikrampal
> <vikram.pal@samsung.com>
> >> wrote:
> >> > Hi,
> >> >
> >> > I'm working on AVRCP packet decoder for Bluetooth monitor module.
> >> > There's a separate file avctp.c/h for AVCTP packet decoder.
> >> >
> >> > The file avctp.c is not a big file as such. So, I'm thinking
> >> > whether or not I should include AVRCP decoder in this file itself.
> >> >
> >> > Shall I create a separate file for AVRCP decoding?
> >> >
> >> > If both AVCTP & AVRCP go in the same file then what should be the
> >> > appropriate name of the file or shall I create a separate file for
> >> > AVRCP as well.
> >> >
> >> > Please advise me. Thanks!
> >> >
> >> > Regards,
> >> > Vikram
> >> >
> >>
> >>
> >>
> >> --
> >> Luiz Augusto von Dentz
> >
> > Regards,
> > Vikram
> >
> 
> 
> 
> --
> Luiz Augusto von Dentz

Regards,
Vikram

RE: AVCTP and AVRCP packet decoder file structure in btmon

[Vikrampal]

> -----Original Message-----
> From: Vikrampal [mailto:vikram.pal@samsung.com]
> Sent: Tuesday, August 05, 2014 2:43 PM
> To: 'Luiz Augusto von Dentz'
> Cc: 'linux-bluetooth@vger.kernel.org'; 'Dmitry Kasatkin'
> Subject: RE: AVCTP and AVRCP packet decoder file structure in btmon
> 
> Hi Luiz,
> 
> If I submit interdependent patches in one go then I guess the patches are
> taken in order i.e. 1/4, 2/4, 3/4, 4/4.
> 
> That means we can take just 2/4 out and expect it to compile since it depends
* That means we can NOT take just 2/4 out and expect it to compile since it depends
> on 1/4.
> 
> Am I correct?
> 
> > -----Original Message-----
> > From: Luiz Augusto von Dentz [mailto:luiz.dentz@gmail.com]
> > Sent: Tuesday, August 05, 2014 1:32 PM
> > To: Vikrampal
> > Cc: linux-bluetooth@vger.kernel.org; Dmitry Kasatkin
> > Subject: Re: AVCTP and AVRCP packet decoder file structure in btmon
> >
> > Hi Vikrampal,
> >
> > I do like to test patches individually so please make sure they
> > compile and in general we don't allow commits that do not compile
> > because they can break bisect.
> >
> > On Tue, Aug 5, 2014 at 9:54 AM, Vikrampal <vikram.pal@samsung.com>
> > wrote:
> > > Sure Luiz!
> > >
> > > However, I've one more small doubt. If I'm submitting a series of
> > > patches Such as 1/4, 2/4, 3/4, 4/4... I guess in such scenarios no
> > > need to ensure that the patches separately compiles. What we need to
> > > ensure is that all the patches together gets compiled properly. Am I
> > mistaken?
> > >
> > >> -----Original Message-----
> > >> From: Luiz Augusto von Dentz [mailto:luiz.dentz@gmail.com]
> > >> Sent: Monday, August 04, 2014 4:15 PM
> > >> To: Vikrampal
> > >> Cc: linux-bluetooth@vger.kernel.org; Dmitry Kasatkin
> > >> Subject: Re: AVCTP and AVRCP packet decoder file structure in btmon
> > >>
> > >> Hi Vikrampal,
> > >>
> > >> We can start by reusing avctp.c to place AV/C and AVRCP decoders,
> > >> later on we can review if it is the case of splitting. Also please
> > >> note that android/Android.mk needs updating if we change anything
> > >> on the build of btmon.
> > >>
> > >> On Mon, Aug 4, 2014 at 11:48 AM, Vikrampal
> > <vikram.pal@samsung.com>
> > >> wrote:
> > >> > Hi,
> > >> >
> > >> > I'm working on AVRCP packet decoder for Bluetooth monitor module.
> > >> > There's a separate file avctp.c/h for AVCTP packet decoder.
> > >> >
> > >> > The file avctp.c is not a big file as such. So, I'm thinking
> > >> > whether or not I should include AVRCP decoder in this file itself.
> > >> >
> > >> > Shall I create a separate file for AVRCP decoding?
> > >> >
> > >> > If both AVCTP & AVRCP go in the same file then what should be the
> > >> > appropriate name of the file or shall I create a separate file
> > >> > for AVRCP as well.
> > >> >
> > >> > Please advise me. Thanks!
> > >> >
> > >> > Regards,
> > >> > Vikram
> > >> >
> > >>
> > >>
> > >>
> > >> --
> > >> Luiz Augusto von Dentz
> > >
> > > Regards,
> > > Vikram
> > >
> >
> >
> >
> > --
> > Luiz Augusto von Dentz
> 
> Regards,
> Vikram

Re: AVCTP and AVRCP packet decoder file structure in btmon

[Antonio Ospite]

On Tue, 05 Aug 2014 12:24:44 +0530
Vikrampal <vikram.pal@samsung.com> wrote:

> Sure Luiz!
> 
> However, I've one more small doubt. If I'm submitting a series of patches
> Such as 1/4, 2/4, 3/4, 4/4... I guess in such scenarios no need to ensure that
> the patches separately compiles. What we need to ensure is that all the patches together
> gets compiled properly. Am I mistaken?
> 

Make sure that sub-sequences of a series produce sensible code.

The code should $VALIDATE with 1/4 applied.
The code should $VALIDATE with 1/4 and 2/4 applied.
The code should $VALIDATE with 1/4, 2/4 and 3/4 applied.
The code should $VALIDATE with 1/4, 2/4, 3/4 and 4/4 applied.

The definition of VALIDATE can vary project by project or feature by
feature; the minimum requirement should be that compilation always
succeeds.

You can use something like:

	git rebase -i --exec "make" some_parent_branch

to test that compilation passes after each commit.

Ciao,
   Antonio

-- 
Antonio Ospite
http://ao2.it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

RE: AVCTP and AVRCP packet decoder file structure in btmon

[Vikrampal]

Thanks Antonio for useful advice!

> -----Original Message-----
> From: Antonio Ospite [mailto:ao2@ao2.it]
> Sent: Tuesday, August 05, 2014 5:22 PM
> To: Vikrampal
> Cc: 'Luiz Augusto von Dentz'; linux-bluetooth@vger.kernel.org; 'Dmitry
> Kasatkin'
> Subject: Re: AVCTP and AVRCP packet decoder file structure in btmon
> 
> On Tue, 05 Aug 2014 12:24:44 +0530
> Vikrampal <vikram.pal@samsung.com> wrote:
> 
> > Sure Luiz!
> >
> > However, I've one more small doubt. If I'm submitting a series of
> > patches Such as 1/4, 2/4, 3/4, 4/4... I guess in such scenarios no
> > need to ensure that the patches separately compiles. What we need to
> > ensure is that all the patches together gets compiled properly. Am I
> mistaken?
> >
> 
> Make sure that sub-sequences of a series produce sensible code.
> 
> The code should $VALIDATE with 1/4 applied.
> The code should $VALIDATE with 1/4 and 2/4 applied.
> The code should $VALIDATE with 1/4, 2/4 and 3/4 applied.
> The code should $VALIDATE with 1/4, 2/4, 3/4 and 4/4 applied.
> 
> The definition of VALIDATE can vary project by project or feature by
feature;
> the minimum requirement should be that compilation always succeeds.
> 
> You can use something like:
> 
> 	git rebase -i --exec "make" some_parent_branch
> 
> to test that compilation passes after each commit.
> 
> Ciao,
>    Antonio
> 
> --
> Antonio Ospite
> http://ao2.it
> 
> A: Because it messes up the order in which people normally read text.
>    See http://en.wikipedia.org/wiki/Posting_style
> Q: Why is top-posting such a bad thing?

Regards,
Vikram