From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: "Hawkins, Nick" <nick.hawkins@hpe.com>, Rob Herring <robh@kernel.org> Cc: "Verdun, Jean-Marie" <verdun@hpe.com>, "joel@jms.id.au" <joel@jms.id.au>, "arnd@arndb.de" <arnd@arndb.de>, "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>, Wim Van Sebroeck <wim@linux-watchdog.org>, Guenter Roeck <linux@roeck-us.net>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v5 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding Date: Tue, 26 Apr 2022 17:44:14 +0200 [thread overview] Message-ID: <0064f937-1f8d-3d1d-4ea1-bb8d24bd605d@linaro.org> (raw) In-Reply-To: <PH0PR84MB1718D9B549FB0CC6FDDAA19788FB9@PH0PR84MB1718.NAMPRD84.PROD.OUTLOOK.COM> On 26/04/2022 15:52, Hawkins, Nick wrote: > Apologies, I did miss the comment about the double spacing around the label and the label not being necessary. I will not make this mistake again. I became focused about the comment of mapping an entire register space which indirectly lead me on to the path which I am now having the gxp-timer have the gxp-wdt as a child. To be specific the feedback I was speaking of above was about the gxp-timer which is here: https://lore.kernel.org/all/704ffa56-4bae-fc33-fddf-3e3dd8be0db9@linaro.org/ That is the children must be defined for a simple-mfd device. This was comment for this v5, not for previous patches. In this v5, you have a child of timer, so it has to be defined in timer schema. This was not a comment whether a child should exist or should not. It was made under the assumption that you want to have a child node. > Hence the plan I have now is to remove the hpe,gxp-wdt.yaml entirely and include it in the hpe,gxp-timer.yaml. I assume that is the correct thing to do? I would follow here the advice from Rob, so since the blocks are mixed significantly (same address space), then let's assume it's actually one device with two functions. In such case Rob pointed out that child node is not necessary. The implementation might differ, depending how the features are mixed-up with each other. It might be one driver having timer and watchdog, or several drivers (usually bound together with a MFD driver which serves as parents and binds to the OF node). Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: "Hawkins, Nick" <nick.hawkins@hpe.com>, Rob Herring <robh@kernel.org> Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>, "arnd@arndb.de" <arnd@arndb.de>, "Verdun, Jean-Marie" <verdun@hpe.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "joel@jms.id.au" <joel@jms.id.au>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Wim Van Sebroeck <wim@linux-watchdog.org>, "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>, Guenter Roeck <linux@roeck-us.net> Subject: Re: [PATCH v5 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding Date: Tue, 26 Apr 2022 17:44:14 +0200 [thread overview] Message-ID: <0064f937-1f8d-3d1d-4ea1-bb8d24bd605d@linaro.org> (raw) In-Reply-To: <PH0PR84MB1718D9B549FB0CC6FDDAA19788FB9@PH0PR84MB1718.NAMPRD84.PROD.OUTLOOK.COM> On 26/04/2022 15:52, Hawkins, Nick wrote: > Apologies, I did miss the comment about the double spacing around the label and the label not being necessary. I will not make this mistake again. I became focused about the comment of mapping an entire register space which indirectly lead me on to the path which I am now having the gxp-timer have the gxp-wdt as a child. To be specific the feedback I was speaking of above was about the gxp-timer which is here: https://lore.kernel.org/all/704ffa56-4bae-fc33-fddf-3e3dd8be0db9@linaro.org/ That is the children must be defined for a simple-mfd device. This was comment for this v5, not for previous patches. In this v5, you have a child of timer, so it has to be defined in timer schema. This was not a comment whether a child should exist or should not. It was made under the assumption that you want to have a child node. > Hence the plan I have now is to remove the hpe,gxp-wdt.yaml entirely and include it in the hpe,gxp-timer.yaml. I assume that is the correct thing to do? I would follow here the advice from Rob, so since the blocks are mixed significantly (same address space), then let's assume it's actually one device with two functions. In such case Rob pointed out that child node is not necessary. The implementation might differ, depending how the features are mixed-up with each other. It might be one driver having timer and watchdog, or several drivers (usually bound together with a MFD driver which serves as parents and binds to the OF node). Best regards, Krzysztof
next prev parent reply other threads:[~2022-04-26 15:44 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-21 19:21 [PATCH v5 01/11] aach: arm: mach-hpe: Introduce the HPE GXP architecture nick.hawkins 2022-04-21 19:21 ` nick.hawkins 2022-04-21 19:21 ` [PATCH v5 01/11] archh: " nick.hawkins 2022-04-21 19:21 ` nick.hawkins 2022-04-22 13:20 ` Arnd Bergmann 2022-04-22 13:20 ` Arnd Bergmann 2022-04-22 13:20 ` Arnd Bergmann 2022-04-21 19:21 ` [PATCH v5 02/11] arch: arm: configs: multi_v7_defconfig nick.hawkins 2022-04-21 19:21 ` nick.hawkins 2022-04-23 11:06 ` Krzysztof Kozlowski 2022-04-23 11:06 ` Krzysztof Kozlowski 2022-04-29 20:34 ` Hawkins, Nick 2022-04-29 20:34 ` Hawkins, Nick 2022-04-30 11:40 ` Krzysztof Kozlowski 2022-04-30 11:40 ` Krzysztof Kozlowski 2022-04-23 11:08 ` Krzysztof Kozlowski 2022-04-23 11:08 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 03/11] drivers: wdt: Introduce HPE GXP SoC Watchdog nick.hawkins 2022-04-21 19:21 ` [PATCH v5 04/11] clocksource/drivers: Add HPE GXP timer nick.hawkins 2022-04-22 13:16 ` Arnd Bergmann 2022-04-22 13:16 ` Arnd Bergmann 2022-04-25 20:38 ` Linus Walleij 2022-04-25 20:38 ` Linus Walleij 2022-04-25 21:05 ` Jonathan Neuschäfer 2022-04-26 6:00 ` Arnd Bergmann 2022-04-26 6:00 ` Arnd Bergmann 2022-04-26 21:38 ` Rob Herring 2022-04-26 21:38 ` Rob Herring 2022-04-26 21:55 ` Arnd Bergmann 2022-04-26 21:55 ` Arnd Bergmann 2022-04-26 22:04 ` Rob Herring 2022-04-26 22:04 ` Rob Herring 2022-04-26 22:26 ` Arnd Bergmann 2022-04-26 22:26 ` Arnd Bergmann 2022-04-22 14:56 ` Thomas Gleixner 2022-04-21 19:21 ` [PATCH v5 05/11] dt-bindings: timer: Add HPE GXP Timer Binding nick.hawkins 2022-04-23 10:50 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding nick.hawkins 2022-04-23 10:52 ` Krzysztof Kozlowski 2022-04-25 22:04 ` Rob Herring 2022-04-25 22:04 ` Rob Herring 2022-04-26 13:21 ` Hawkins, Nick 2022-04-26 13:34 ` Krzysztof Kozlowski 2022-04-26 13:34 ` Krzysztof Kozlowski 2022-04-26 13:52 ` Hawkins, Nick 2022-04-26 15:44 ` Krzysztof Kozlowski [this message] 2022-04-26 15:44 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 07/11] dt-bindings: arm: Add HPE GXP Binding nick.hawkins 2022-04-23 10:58 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 08/11] dt-bindings: usb: generic-ehci: Add HPE GXP ehci binding nick.hawkins 2022-04-23 10:52 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 09/11] dt-bindings: usb: generic-ohci: Add HPE GXP ohci binding nick.hawkins 2022-04-23 10:53 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 10/11] arch: arm: boot: dts: Introduce HPE GXP Device tree nick.hawkins 2022-04-21 19:21 ` nick.hawkins 2022-04-21 19:21 ` nick.hawkins 2022-04-22 13:06 ` Arnd Bergmann 2022-04-22 13:06 ` Arnd Bergmann 2022-04-22 13:06 ` Arnd Bergmann 2022-04-23 11:01 ` Krzysztof Kozlowski 2022-04-23 11:01 ` Krzysztof Kozlowski 2022-04-26 7:22 ` Krzysztof Kozlowski 2022-04-26 7:22 ` Krzysztof Kozlowski 2022-04-26 7:22 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 11/11] maintainers: Introduce HPE GXP Architecture nick.hawkins 2022-04-23 11:04 ` [PATCH v5 01/11] aach: arm: mach-hpe: Introduce the HPE GXP architecture Krzysztof Kozlowski 2022-04-23 11:04 ` Krzysztof Kozlowski 2022-04-25 15:00 ` Hawkins, Nick 2022-04-25 15:00 ` Hawkins, Nick 2022-04-26 8:25 ` Paul Menzel 2022-04-26 8:25 ` Paul Menzel 2022-04-26 8:25 ` Paul Menzel 2022-04-26 17:28 ` Hawkins, Nick 2022-04-26 17:28 ` Hawkins, Nick 2022-04-26 17:50 ` Paul Menzel 2022-04-26 17:50 ` Paul Menzel 2022-04-26 17:50 ` Paul Menzel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0064f937-1f8d-3d1d-4ea1-bb8d24bd605d@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=arnd@arndb.de \ --cc=devicetree@vger.kernel.org \ --cc=joel@jms.id.au \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=nick.hawkins@hpe.com \ --cc=openbmc@lists.ozlabs.org \ --cc=robh@kernel.org \ --cc=verdun@hpe.com \ --cc=wim@linux-watchdog.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.