From: "Hawkins, Nick" <nick.hawkins@hpe.com> To: Paul Menzel <pmenzel@molgen.mpg.de> Cc: "Verdun, Jean-Marie" <verdun@hpe.com>, "joel@jms.id.au" <joel@jms.id.au>, "arnd@arndb.de" <arnd@arndb.de>, "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>, Russell King <linux@armlinux.org.uk>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH v5 01/11] aach: arm: mach-hpe: Introduce the HPE GXP architecture Date: Tue, 26 Apr 2022 17:28:14 +0000 [thread overview] Message-ID: <PH0PR84MB171823121FD62E90495BCB7288FB9@PH0PR84MB1718.NAMPRD84.PROD.OUTLOOK.COM> (raw) In-Reply-To: <44c145a8-cbfd-c8e4-8391-76abb9562f97@molgen.mpg.de> -----Original Message----- From: Paul Menzel [mailto:pmenzel@molgen.mpg.de] Sent: Tuesday, April 26, 2022 3:26 AM To: Hawkins, Nick <nick.hawkins@hpe.com> Cc: Verdun, Jean-Marie <verdun@hpe.com>; joel@jms.id.au; arnd@arndb.de; openbmc@lists.ozlabs.org; Russell King <linux@armlinux.org.uk>; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 01/11] aach: arm: mach-hpe: Introduce the HPE GXP architecture > Type in the prefix: s/aach/arch/. Looking at `git log --oneline arch/arm`, *ARM* or *arm* seems to be commonly used though. I will correct this, I will also look in all other patches to make sure appropriate titles are being used. > > The GXP is the HPE BMC SoC that is used in the majority of HPE > > Generation 10 servers. Traditionally the asic will last multiple > > generations of server before being replaced. > Please mention what kind of documentation (datasheets, …) are available. Currently there are none available. The only reference I can provide will be arm documentation. > > In gxp.c we reset the EHCI controller early to boot the asic. > Why does the EHCI controller need to be reset? This functionality was moved into the boot loader. This message is stale and needs to be removed. It was necessary for the chip to boot. > > Info about SoC: > > > > HPE GXP is the name of the HPE Soc. This SoC is used to implement many > > BMC features at HPE. It supports ARMv7 architecture based on the > > Cortex A9 core. It is capable of using an AXI bus to which a memory > > controller is attached. It has multiple SPI interfaces to connect boot > > flash and BIOS flash. It uses a 10/100/1000 MAC for network > > connectivity. It has multiple i2c engines to drive connectivity with a > > host infrastructure. The initial patches enable the watchdog and timer > > enabling the host to be able to boot. > Maybe doe that in separate commits? Are you asking for me to have this paragraph in the other commits? Or perhaps not mention the other patches in this paragraph? > Please reflow the commit message for 75 characters per line. I will verify all the lines are under 75 characters. Thanks for the feedback, -Nick Hawkins
WARNING: multiple messages have this Message-ID (diff)
From: "Hawkins, Nick" <nick.hawkins@hpe.com> To: Paul Menzel <pmenzel@molgen.mpg.de> Cc: "Verdun, Jean-Marie" <verdun@hpe.com>, "joel@jms.id.au" <joel@jms.id.au>, "arnd@arndb.de" <arnd@arndb.de>, "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>, Russell King <linux@armlinux.org.uk>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH v5 01/11] aach: arm: mach-hpe: Introduce the HPE GXP architecture Date: Tue, 26 Apr 2022 17:28:14 +0000 [thread overview] Message-ID: <PH0PR84MB171823121FD62E90495BCB7288FB9@PH0PR84MB1718.NAMPRD84.PROD.OUTLOOK.COM> (raw) In-Reply-To: <44c145a8-cbfd-c8e4-8391-76abb9562f97@molgen.mpg.de> -----Original Message----- From: Paul Menzel [mailto:pmenzel@molgen.mpg.de] Sent: Tuesday, April 26, 2022 3:26 AM To: Hawkins, Nick <nick.hawkins@hpe.com> Cc: Verdun, Jean-Marie <verdun@hpe.com>; joel@jms.id.au; arnd@arndb.de; openbmc@lists.ozlabs.org; Russell King <linux@armlinux.org.uk>; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 01/11] aach: arm: mach-hpe: Introduce the HPE GXP architecture > Type in the prefix: s/aach/arch/. Looking at `git log --oneline arch/arm`, *ARM* or *arm* seems to be commonly used though. I will correct this, I will also look in all other patches to make sure appropriate titles are being used. > > The GXP is the HPE BMC SoC that is used in the majority of HPE > > Generation 10 servers. Traditionally the asic will last multiple > > generations of server before being replaced. > Please mention what kind of documentation (datasheets, …) are available. Currently there are none available. The only reference I can provide will be arm documentation. > > In gxp.c we reset the EHCI controller early to boot the asic. > Why does the EHCI controller need to be reset? This functionality was moved into the boot loader. This message is stale and needs to be removed. It was necessary for the chip to boot. > > Info about SoC: > > > > HPE GXP is the name of the HPE Soc. This SoC is used to implement many > > BMC features at HPE. It supports ARMv7 architecture based on the > > Cortex A9 core. It is capable of using an AXI bus to which a memory > > controller is attached. It has multiple SPI interfaces to connect boot > > flash and BIOS flash. It uses a 10/100/1000 MAC for network > > connectivity. It has multiple i2c engines to drive connectivity with a > > host infrastructure. The initial patches enable the watchdog and timer > > enabling the host to be able to boot. > Maybe doe that in separate commits? Are you asking for me to have this paragraph in the other commits? Or perhaps not mention the other patches in this paragraph? > Please reflow the commit message for 75 characters per line. I will verify all the lines are under 75 characters. Thanks for the feedback, -Nick Hawkins _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-26 17:29 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-21 19:21 [PATCH v5 01/11] aach: arm: mach-hpe: Introduce the HPE GXP architecture nick.hawkins 2022-04-21 19:21 ` nick.hawkins 2022-04-21 19:21 ` [PATCH v5 01/11] archh: " nick.hawkins 2022-04-21 19:21 ` nick.hawkins 2022-04-22 13:20 ` Arnd Bergmann 2022-04-22 13:20 ` Arnd Bergmann 2022-04-22 13:20 ` Arnd Bergmann 2022-04-21 19:21 ` [PATCH v5 02/11] arch: arm: configs: multi_v7_defconfig nick.hawkins 2022-04-21 19:21 ` nick.hawkins 2022-04-23 11:06 ` Krzysztof Kozlowski 2022-04-23 11:06 ` Krzysztof Kozlowski 2022-04-29 20:34 ` Hawkins, Nick 2022-04-29 20:34 ` Hawkins, Nick 2022-04-30 11:40 ` Krzysztof Kozlowski 2022-04-30 11:40 ` Krzysztof Kozlowski 2022-04-23 11:08 ` Krzysztof Kozlowski 2022-04-23 11:08 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 03/11] drivers: wdt: Introduce HPE GXP SoC Watchdog nick.hawkins 2022-04-21 19:21 ` [PATCH v5 04/11] clocksource/drivers: Add HPE GXP timer nick.hawkins 2022-04-22 13:16 ` Arnd Bergmann 2022-04-22 13:16 ` Arnd Bergmann 2022-04-25 20:38 ` Linus Walleij 2022-04-25 20:38 ` Linus Walleij 2022-04-25 21:05 ` Jonathan Neuschäfer 2022-04-26 6:00 ` Arnd Bergmann 2022-04-26 6:00 ` Arnd Bergmann 2022-04-26 21:38 ` Rob Herring 2022-04-26 21:38 ` Rob Herring 2022-04-26 21:55 ` Arnd Bergmann 2022-04-26 21:55 ` Arnd Bergmann 2022-04-26 22:04 ` Rob Herring 2022-04-26 22:04 ` Rob Herring 2022-04-26 22:26 ` Arnd Bergmann 2022-04-26 22:26 ` Arnd Bergmann 2022-04-22 14:56 ` Thomas Gleixner 2022-04-21 19:21 ` [PATCH v5 05/11] dt-bindings: timer: Add HPE GXP Timer Binding nick.hawkins 2022-04-23 10:50 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding nick.hawkins 2022-04-23 10:52 ` Krzysztof Kozlowski 2022-04-25 22:04 ` Rob Herring 2022-04-25 22:04 ` Rob Herring 2022-04-26 13:21 ` Hawkins, Nick 2022-04-26 13:34 ` Krzysztof Kozlowski 2022-04-26 13:34 ` Krzysztof Kozlowski 2022-04-26 13:52 ` Hawkins, Nick 2022-04-26 15:44 ` Krzysztof Kozlowski 2022-04-26 15:44 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 07/11] dt-bindings: arm: Add HPE GXP Binding nick.hawkins 2022-04-23 10:58 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 08/11] dt-bindings: usb: generic-ehci: Add HPE GXP ehci binding nick.hawkins 2022-04-23 10:52 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 09/11] dt-bindings: usb: generic-ohci: Add HPE GXP ohci binding nick.hawkins 2022-04-23 10:53 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 10/11] arch: arm: boot: dts: Introduce HPE GXP Device tree nick.hawkins 2022-04-21 19:21 ` nick.hawkins 2022-04-21 19:21 ` nick.hawkins 2022-04-22 13:06 ` Arnd Bergmann 2022-04-22 13:06 ` Arnd Bergmann 2022-04-22 13:06 ` Arnd Bergmann 2022-04-23 11:01 ` Krzysztof Kozlowski 2022-04-23 11:01 ` Krzysztof Kozlowski 2022-04-26 7:22 ` Krzysztof Kozlowski 2022-04-26 7:22 ` Krzysztof Kozlowski 2022-04-26 7:22 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 11/11] maintainers: Introduce HPE GXP Architecture nick.hawkins 2022-04-23 11:04 ` [PATCH v5 01/11] aach: arm: mach-hpe: Introduce the HPE GXP architecture Krzysztof Kozlowski 2022-04-23 11:04 ` Krzysztof Kozlowski 2022-04-25 15:00 ` Hawkins, Nick 2022-04-25 15:00 ` Hawkins, Nick 2022-04-26 8:25 ` Paul Menzel 2022-04-26 8:25 ` Paul Menzel 2022-04-26 8:25 ` Paul Menzel 2022-04-26 17:28 ` Hawkins, Nick [this message] 2022-04-26 17:28 ` Hawkins, Nick 2022-04-26 17:50 ` Paul Menzel 2022-04-26 17:50 ` Paul Menzel 2022-04-26 17:50 ` Paul Menzel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=PH0PR84MB171823121FD62E90495BCB7288FB9@PH0PR84MB1718.NAMPRD84.PROD.OUTLOOK.COM \ --to=nick.hawkins@hpe.com \ --cc=arnd@arndb.de \ --cc=joel@jms.id.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=openbmc@lists.ozlabs.org \ --cc=pmenzel@molgen.mpg.de \ --cc=verdun@hpe.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.