From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: nick.hawkins@hpe.com, verdun@hpe.com, joel@jms.id.au, arnd@arndb.de, openbmc@lists.ozlabs.org Cc: Olof Johansson <olof@lixom.net>, soc@kernel.org, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 10/11] arch: arm: boot: dts: Introduce HPE GXP Device tree Date: Sat, 23 Apr 2022 13:01:41 +0200 [thread overview] Message-ID: <7a4222dc-35ee-4809-9e16-64aadf00081a@linaro.org> (raw) In-Reply-To: <20220421192132.109954-11-nick.hawkins@hpe.com> On 21/04/2022 21:21, nick.hawkins@hpe.com wrote: > From: Nick Hawkins <nick.hawkins@hpe.com> > Thank you for your patch. There is something to discuss/improve. > +/include/ "hpe-gxp.dtsi" > + > +/ { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "hpe,gxp-dl360gen10","hpe,gxp"; Missing space after ','. > + model = "Hewlett Packard Enterprise ProLiant dl360 Gen10"; > +}; > diff --git a/arch/arm/boot/dts/hpe-gxp.dtsi b/arch/arm/boot/dts/hpe-gxp.dtsi > new file mode 100644 > index 000000000000..a3a082d21101 > --- /dev/null > +++ b/arch/arm/boot/dts/hpe-gxp.dtsi > @@ -0,0 +1,128 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Device Tree file for HPE GXP > + */ > + > +/dts-v1/; > +/ { > + model = "Hewlett Packard Enterprise GXP BMC"; > + compatible = "hpe,gxp","hpe,gxp-dl360gen10"; The same. > + #address-cells = <1>; > + #size-cells = <1>; > + > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cpu@0 { > + compatible = "arm,cortex-a9"; > + reg = <0>; > + device_type = "cpu"; > + }; > + }; > + > + clocks { > + No need for blank line. > + pll: pll { Generic node names, so either "clock-0" or "pll-clock" > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <1600000000>; > + }; > + > + iopclk: iopclk { "clock-1" or "iop-clock" > + compatible = "fixed-factor-clock"; > + #clock-cells = <0>; > + clock-div = <4>; > + clock-mult = <1>; > + clocks = <&pll>; > + }; > + }; (...) > + > + usb0: usb@efe0000 { > + compatible = "hpe,gxp-ehci","generic-ehci"; Here and in other places - always missing a space. > + reg = <0xefe0000 0x100>; > + interrupts = <7>; > + interrupt-parent = <&vic0>; > + }; > + > + st: timer@80 { > + compatible = "hpe,gxp-timer","simple-mfd"; > + reg = <0x80 0x16>; > + interrupts = <0>; > + interrupt-parent = <&vic0>; > + clocks = <&iopclk>; > + clock-names = "iopclk"; > + watchdog { > + compatible = "hpe,gxp-wdt"; > + }; > + }; > + > + usb1: usb@efe0100 { > + compatible = "hpe,gxp-ohci","generic-ohci"; > + reg = <0xefe0100 0x110>; > + interrupts = <6>; > + interrupt-parent = <&vic0>; > + }; > + }; > + }; > + No need for blank line. > +}; Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: nick.hawkins@hpe.com, verdun@hpe.com, joel@jms.id.au, arnd@arndb.de, openbmc@lists.ozlabs.org Cc: Olof Johansson <olof@lixom.net>, soc@kernel.org, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 10/11] arch: arm: boot: dts: Introduce HPE GXP Device tree Date: Sat, 23 Apr 2022 13:01:41 +0200 [thread overview] Message-ID: <7a4222dc-35ee-4809-9e16-64aadf00081a@linaro.org> (raw) In-Reply-To: <20220421192132.109954-11-nick.hawkins@hpe.com> On 21/04/2022 21:21, nick.hawkins@hpe.com wrote: > From: Nick Hawkins <nick.hawkins@hpe.com> > Thank you for your patch. There is something to discuss/improve. > +/include/ "hpe-gxp.dtsi" > + > +/ { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "hpe,gxp-dl360gen10","hpe,gxp"; Missing space after ','. > + model = "Hewlett Packard Enterprise ProLiant dl360 Gen10"; > +}; > diff --git a/arch/arm/boot/dts/hpe-gxp.dtsi b/arch/arm/boot/dts/hpe-gxp.dtsi > new file mode 100644 > index 000000000000..a3a082d21101 > --- /dev/null > +++ b/arch/arm/boot/dts/hpe-gxp.dtsi > @@ -0,0 +1,128 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Device Tree file for HPE GXP > + */ > + > +/dts-v1/; > +/ { > + model = "Hewlett Packard Enterprise GXP BMC"; > + compatible = "hpe,gxp","hpe,gxp-dl360gen10"; The same. > + #address-cells = <1>; > + #size-cells = <1>; > + > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cpu@0 { > + compatible = "arm,cortex-a9"; > + reg = <0>; > + device_type = "cpu"; > + }; > + }; > + > + clocks { > + No need for blank line. > + pll: pll { Generic node names, so either "clock-0" or "pll-clock" > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <1600000000>; > + }; > + > + iopclk: iopclk { "clock-1" or "iop-clock" > + compatible = "fixed-factor-clock"; > + #clock-cells = <0>; > + clock-div = <4>; > + clock-mult = <1>; > + clocks = <&pll>; > + }; > + }; (...) > + > + usb0: usb@efe0000 { > + compatible = "hpe,gxp-ehci","generic-ehci"; Here and in other places - always missing a space. > + reg = <0xefe0000 0x100>; > + interrupts = <7>; > + interrupt-parent = <&vic0>; > + }; > + > + st: timer@80 { > + compatible = "hpe,gxp-timer","simple-mfd"; > + reg = <0x80 0x16>; > + interrupts = <0>; > + interrupt-parent = <&vic0>; > + clocks = <&iopclk>; > + clock-names = "iopclk"; > + watchdog { > + compatible = "hpe,gxp-wdt"; > + }; > + }; > + > + usb1: usb@efe0100 { > + compatible = "hpe,gxp-ohci","generic-ohci"; > + reg = <0xefe0100 0x110>; > + interrupts = <6>; > + interrupt-parent = <&vic0>; > + }; > + }; > + }; > + No need for blank line. > +}; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-23 11:01 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-21 19:21 [PATCH v5 01/11] aach: arm: mach-hpe: Introduce the HPE GXP architecture nick.hawkins 2022-04-21 19:21 ` nick.hawkins 2022-04-21 19:21 ` [PATCH v5 01/11] archh: " nick.hawkins 2022-04-21 19:21 ` nick.hawkins 2022-04-22 13:20 ` Arnd Bergmann 2022-04-22 13:20 ` Arnd Bergmann 2022-04-22 13:20 ` Arnd Bergmann 2022-04-21 19:21 ` [PATCH v5 02/11] arch: arm: configs: multi_v7_defconfig nick.hawkins 2022-04-21 19:21 ` nick.hawkins 2022-04-23 11:06 ` Krzysztof Kozlowski 2022-04-23 11:06 ` Krzysztof Kozlowski 2022-04-29 20:34 ` Hawkins, Nick 2022-04-29 20:34 ` Hawkins, Nick 2022-04-30 11:40 ` Krzysztof Kozlowski 2022-04-30 11:40 ` Krzysztof Kozlowski 2022-04-23 11:08 ` Krzysztof Kozlowski 2022-04-23 11:08 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 03/11] drivers: wdt: Introduce HPE GXP SoC Watchdog nick.hawkins 2022-04-21 19:21 ` [PATCH v5 04/11] clocksource/drivers: Add HPE GXP timer nick.hawkins 2022-04-22 13:16 ` Arnd Bergmann 2022-04-22 13:16 ` Arnd Bergmann 2022-04-25 20:38 ` Linus Walleij 2022-04-25 20:38 ` Linus Walleij 2022-04-25 21:05 ` Jonathan Neuschäfer 2022-04-26 6:00 ` Arnd Bergmann 2022-04-26 6:00 ` Arnd Bergmann 2022-04-26 21:38 ` Rob Herring 2022-04-26 21:38 ` Rob Herring 2022-04-26 21:55 ` Arnd Bergmann 2022-04-26 21:55 ` Arnd Bergmann 2022-04-26 22:04 ` Rob Herring 2022-04-26 22:04 ` Rob Herring 2022-04-26 22:26 ` Arnd Bergmann 2022-04-26 22:26 ` Arnd Bergmann 2022-04-22 14:56 ` Thomas Gleixner 2022-04-21 19:21 ` [PATCH v5 05/11] dt-bindings: timer: Add HPE GXP Timer Binding nick.hawkins 2022-04-23 10:50 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding nick.hawkins 2022-04-23 10:52 ` Krzysztof Kozlowski 2022-04-25 22:04 ` Rob Herring 2022-04-25 22:04 ` Rob Herring 2022-04-26 13:21 ` Hawkins, Nick 2022-04-26 13:34 ` Krzysztof Kozlowski 2022-04-26 13:34 ` Krzysztof Kozlowski 2022-04-26 13:52 ` Hawkins, Nick 2022-04-26 15:44 ` Krzysztof Kozlowski 2022-04-26 15:44 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 07/11] dt-bindings: arm: Add HPE GXP Binding nick.hawkins 2022-04-23 10:58 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 08/11] dt-bindings: usb: generic-ehci: Add HPE GXP ehci binding nick.hawkins 2022-04-23 10:52 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 09/11] dt-bindings: usb: generic-ohci: Add HPE GXP ohci binding nick.hawkins 2022-04-23 10:53 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 10/11] arch: arm: boot: dts: Introduce HPE GXP Device tree nick.hawkins 2022-04-21 19:21 ` nick.hawkins 2022-04-21 19:21 ` nick.hawkins 2022-04-22 13:06 ` Arnd Bergmann 2022-04-22 13:06 ` Arnd Bergmann 2022-04-22 13:06 ` Arnd Bergmann 2022-04-23 11:01 ` Krzysztof Kozlowski [this message] 2022-04-23 11:01 ` Krzysztof Kozlowski 2022-04-26 7:22 ` Krzysztof Kozlowski 2022-04-26 7:22 ` Krzysztof Kozlowski 2022-04-26 7:22 ` Krzysztof Kozlowski 2022-04-21 19:21 ` [PATCH v5 11/11] maintainers: Introduce HPE GXP Architecture nick.hawkins 2022-04-23 11:04 ` [PATCH v5 01/11] aach: arm: mach-hpe: Introduce the HPE GXP architecture Krzysztof Kozlowski 2022-04-23 11:04 ` Krzysztof Kozlowski 2022-04-25 15:00 ` Hawkins, Nick 2022-04-25 15:00 ` Hawkins, Nick 2022-04-26 8:25 ` Paul Menzel 2022-04-26 8:25 ` Paul Menzel 2022-04-26 8:25 ` Paul Menzel 2022-04-26 17:28 ` Hawkins, Nick 2022-04-26 17:28 ` Hawkins, Nick 2022-04-26 17:50 ` Paul Menzel 2022-04-26 17:50 ` Paul Menzel 2022-04-26 17:50 ` Paul Menzel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7a4222dc-35ee-4809-9e16-64aadf00081a@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=arnd@arndb.de \ --cc=devicetree@vger.kernel.org \ --cc=joel@jms.id.au \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nick.hawkins@hpe.com \ --cc=olof@lixom.net \ --cc=openbmc@lists.ozlabs.org \ --cc=robh+dt@kernel.org \ --cc=soc@kernel.org \ --cc=verdun@hpe.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.