From: "Hillf Danton" <hillf.zj@alibaba-inc.com> To: "'Shaohua Li'" <shli@fb.com>, <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org> Cc: <Kernel-team@fb.com>, <danielmicay@gmail.com>, <mhocko@suse.com>, <minchan@kernel.org>, <hughd@google.com>, <hannes@cmpxchg.org>, <riel@redhat.com>, <mgorman@techsingularity.net>, <akpm@linux-foundation.org> Subject: Re: [PATCH V2 2/7] mm: move MADV_FREE pages into LRU_INACTIVE_FILE list Date: Sat, 04 Feb 2017 14:38:07 +0800 [thread overview] Message-ID: <007e01d27eb1$3f98dee0$beca9ca0$@alibaba-inc.com> (raw) In-Reply-To: <3914c9f53c343357c39cb891210da31aa30ad3a9.1486163864.git.shli@fb.com> On February 04, 2017 7:33 AM Shaohua Li wrote: > @@ -1404,6 +1401,8 @@ bool madvise_free_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, > set_pmd_at(mm, addr, pmd, orig_pmd); > tlb_remove_pmd_tlb_entry(tlb, pmd, addr); > } > + > + mark_page_lazyfree(page); > ret = true; > out: > spin_unlock(ptl); <snipped> > -void deactivate_page(struct page *page) > -{ > - if (PageLRU(page) && PageActive(page) && !PageUnevictable(page)) { > - struct pagevec *pvec = &get_cpu_var(lru_deactivate_pvecs); > +void mark_page_lazyfree(struct page *page) > + { > + if (PageLRU(page) && PageAnon(page) && PageSwapBacked(page) && > + !PageUnevictable(page)) { > + struct pagevec *pvec = &get_cpu_var(lru_lazyfree_pvecs); > > get_page(page); > if (!pagevec_add(pvec, page) || PageCompound(page)) > - pagevec_lru_move_fn(pvec, lru_deactivate_fn, NULL); > - put_cpu_var(lru_deactivate_pvecs); > + pagevec_lru_move_fn(pvec, lru_lazyfree_fn, NULL); > + put_cpu_var(lru_lazyfree_pvecs); > } > } You are not adding it but would you please try to fix or avoid flipping preempt count with page table lock hold? thanks Hillf
WARNING: multiple messages have this Message-ID (diff)
From: "Hillf Danton" <hillf.zj@alibaba-inc.com> To: 'Shaohua Li' <shli@fb.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Kernel-team@fb.com, danielmicay@gmail.com, mhocko@suse.com, minchan@kernel.org, hughd@google.com, hannes@cmpxchg.org, riel@redhat.com, mgorman@techsingularity.net, akpm@linux-foundation.org Subject: Re: [PATCH V2 2/7] mm: move MADV_FREE pages into LRU_INACTIVE_FILE list Date: Sat, 04 Feb 2017 14:38:07 +0800 [thread overview] Message-ID: <007e01d27eb1$3f98dee0$beca9ca0$@alibaba-inc.com> (raw) In-Reply-To: <3914c9f53c343357c39cb891210da31aa30ad3a9.1486163864.git.shli@fb.com> On February 04, 2017 7:33 AM Shaohua Li wrote: > @@ -1404,6 +1401,8 @@ bool madvise_free_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, > set_pmd_at(mm, addr, pmd, orig_pmd); > tlb_remove_pmd_tlb_entry(tlb, pmd, addr); > } > + > + mark_page_lazyfree(page); > ret = true; > out: > spin_unlock(ptl); <snipped> > -void deactivate_page(struct page *page) > -{ > - if (PageLRU(page) && PageActive(page) && !PageUnevictable(page)) { > - struct pagevec *pvec = &get_cpu_var(lru_deactivate_pvecs); > +void mark_page_lazyfree(struct page *page) > + { > + if (PageLRU(page) && PageAnon(page) && PageSwapBacked(page) && > + !PageUnevictable(page)) { > + struct pagevec *pvec = &get_cpu_var(lru_lazyfree_pvecs); > > get_page(page); > if (!pagevec_add(pvec, page) || PageCompound(page)) > - pagevec_lru_move_fn(pvec, lru_deactivate_fn, NULL); > - put_cpu_var(lru_deactivate_pvecs); > + pagevec_lru_move_fn(pvec, lru_lazyfree_fn, NULL); > + put_cpu_var(lru_lazyfree_pvecs); > } > } You are not adding it but would you please try to fix or avoid flipping preempt count with page table lock hold? thanks Hillf -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-02-04 6:38 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-03 23:33 [PATCH V2 0/7] mm: fix some MADV_FREE issues Shaohua Li 2017-02-03 23:33 ` Shaohua Li 2017-02-03 23:33 ` [PATCH V2 1/7] mm: don't assume anonymous pages have SwapBacked flag Shaohua Li 2017-02-03 23:33 ` Shaohua Li 2017-02-03 23:33 ` [PATCH V2 2/7] mm: move MADV_FREE pages into LRU_INACTIVE_FILE list Shaohua Li 2017-02-03 23:33 ` Shaohua Li 2017-02-04 6:38 ` Hillf Danton [this message] 2017-02-04 6:38 ` Hillf Danton 2017-02-09 6:33 ` Hillf Danton 2017-02-09 6:33 ` Hillf Danton 2017-02-10 6:50 ` Minchan Kim 2017-02-10 6:50 ` Minchan Kim 2017-02-10 17:30 ` Shaohua Li 2017-02-10 17:30 ` Shaohua Li 2017-02-13 4:57 ` Minchan Kim 2017-02-13 4:57 ` Minchan Kim 2017-02-10 13:02 ` Michal Hocko 2017-02-10 13:02 ` Michal Hocko 2017-02-10 17:33 ` Shaohua Li 2017-02-10 17:33 ` Shaohua Li 2017-02-03 23:33 ` [PATCH V2 3/7] mm: reclaim MADV_FREE pages Shaohua Li 2017-02-03 23:33 ` Shaohua Li 2017-02-10 6:58 ` Minchan Kim 2017-02-10 6:58 ` Minchan Kim 2017-02-10 17:43 ` Shaohua Li 2017-02-10 17:43 ` Shaohua Li 2017-02-13 5:06 ` Minchan Kim 2017-02-13 5:06 ` Minchan Kim 2017-02-10 13:23 ` Michal Hocko 2017-02-10 13:23 ` Michal Hocko 2017-02-03 23:33 ` [PATCH V2 4/7] mm: enable MADV_FREE for swapless system Shaohua Li 2017-02-03 23:33 ` Shaohua Li 2017-02-03 23:33 ` [PATCH V2 5/7] mm: add vmstat account for MADV_FREE pages Shaohua Li 2017-02-03 23:33 ` Shaohua Li 2017-02-10 13:27 ` Michal Hocko 2017-02-10 13:27 ` Michal Hocko 2017-02-10 17:50 ` Shaohua Li 2017-02-10 17:50 ` Shaohua Li 2017-02-21 9:43 ` Michal Hocko 2017-02-21 9:43 ` Michal Hocko 2017-02-03 23:33 ` [PATCH V2 6/7] proc: show MADV_FREE pages info in smaps Shaohua Li 2017-02-03 23:33 ` Shaohua Li 2017-02-10 13:30 ` Michal Hocko 2017-02-10 13:30 ` Michal Hocko 2017-02-10 17:52 ` Shaohua Li 2017-02-10 17:52 ` Shaohua Li 2017-02-22 2:47 ` Minchan Kim 2017-02-22 2:47 ` Minchan Kim 2017-02-22 4:11 ` Shaohua Li 2017-02-22 4:11 ` Shaohua Li 2017-02-03 23:33 ` [PATCH V2 7/7] mm: add a separate RSS for MADV_FREE pages Shaohua Li 2017-02-03 23:33 ` Shaohua Li 2017-02-10 13:35 ` Michal Hocko 2017-02-10 13:35 ` Michal Hocko 2017-02-10 18:01 ` Shaohua Li 2017-02-10 18:01 ` Shaohua Li 2017-02-21 9:45 ` Michal Hocko 2017-02-21 9:45 ` Michal Hocko 2017-02-22 0:46 ` Minchan Kim 2017-02-22 0:46 ` Minchan Kim 2017-02-22 1:27 ` Shaohua Li 2017-02-22 1:27 ` Shaohua Li
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='007e01d27eb1$3f98dee0$beca9ca0$@alibaba-inc.com' \ --to=hillf.zj@alibaba-inc.com \ --cc=Kernel-team@fb.com \ --cc=akpm@linux-foundation.org \ --cc=danielmicay@gmail.com \ --cc=hannes@cmpxchg.org \ --cc=hughd@google.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@techsingularity.net \ --cc=mhocko@suse.com \ --cc=minchan@kernel.org \ --cc=riel@redhat.com \ --cc=shli@fb.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.