From: Hans de Goede <hdegoede@redhat.com> To: Paul Cercueil <paul@crapouillou.net>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch> Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 24/26] drm: gm12u320: Remove #ifdef guards for PM related functions Date: Mon, 7 Nov 2022 20:43:35 +0100 [thread overview] Message-ID: <00889f1f-d9e5-9607-6932-f72417953ea7@redhat.com> (raw) In-Reply-To: <20221107175510.361051-1-paul@crapouillou.net> Hi, On 11/7/22 18:55, Paul Cercueil wrote: > Use the pm_ptr() macro to handle the .suspend / .resume / .reset_resume > callbacks. > > This macro allows the suspend and resume functions to be automatically > dropped by the compiler when CONFIG_PM is disabled, without having > to use #ifdef guards. > > This has the advantage of always compiling these functions in, > independently of any Kconfig option. Thanks to that, bugs and other > regressions are subsequently easier to catch. It also allows to drop the > __maybe_unused tags. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > Cc: Hans de Goede <hdegoede@redhat.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/gpu/drm/tiny/gm12u320.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/tiny/gm12u320.c b/drivers/gpu/drm/tiny/gm12u320.c > index 7441d992a5d7..0a901201142e 100644 > --- a/drivers/gpu/drm/tiny/gm12u320.c > +++ b/drivers/gpu/drm/tiny/gm12u320.c > @@ -4,6 +4,7 @@ > */ > > #include <linux/module.h> > +#include <linux/pm.h> > #include <linux/usb.h> > > #include <drm/drm_atomic_helper.h> > @@ -718,15 +719,15 @@ static void gm12u320_usb_disconnect(struct usb_interface *interface) > drm_atomic_helper_shutdown(dev); > } > > -static __maybe_unused int gm12u320_suspend(struct usb_interface *interface, > - pm_message_t message) > +static int gm12u320_suspend(struct usb_interface *interface, > + pm_message_t message) > { > struct drm_device *dev = usb_get_intfdata(interface); > > return drm_mode_config_helper_suspend(dev); > } > > -static __maybe_unused int gm12u320_resume(struct usb_interface *interface) > +static int gm12u320_resume(struct usb_interface *interface) > { > struct drm_device *dev = usb_get_intfdata(interface); > struct gm12u320_device *gm12u320 = to_gm12u320(dev); > @@ -747,11 +748,9 @@ static struct usb_driver gm12u320_usb_driver = { > .probe = gm12u320_usb_probe, > .disconnect = gm12u320_usb_disconnect, > .id_table = id_table, > -#ifdef CONFIG_PM > - .suspend = gm12u320_suspend, > - .resume = gm12u320_resume, > - .reset_resume = gm12u320_resume, > -#endif > + .suspend = pm_ptr(gm12u320_suspend), > + .resume = pm_ptr(gm12u320_resume), > + .reset_resume = pm_ptr(gm12u320_resume), > }; > > module_usb_driver(gm12u320_usb_driver);
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com> To: Paul Cercueil <paul@crapouillou.net>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 24/26] drm: gm12u320: Remove #ifdef guards for PM related functions Date: Mon, 7 Nov 2022 20:43:35 +0100 [thread overview] Message-ID: <00889f1f-d9e5-9607-6932-f72417953ea7@redhat.com> (raw) In-Reply-To: <20221107175510.361051-1-paul@crapouillou.net> Hi, On 11/7/22 18:55, Paul Cercueil wrote: > Use the pm_ptr() macro to handle the .suspend / .resume / .reset_resume > callbacks. > > This macro allows the suspend and resume functions to be automatically > dropped by the compiler when CONFIG_PM is disabled, without having > to use #ifdef guards. > > This has the advantage of always compiling these functions in, > independently of any Kconfig option. Thanks to that, bugs and other > regressions are subsequently easier to catch. It also allows to drop the > __maybe_unused tags. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > Cc: Hans de Goede <hdegoede@redhat.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/gpu/drm/tiny/gm12u320.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/tiny/gm12u320.c b/drivers/gpu/drm/tiny/gm12u320.c > index 7441d992a5d7..0a901201142e 100644 > --- a/drivers/gpu/drm/tiny/gm12u320.c > +++ b/drivers/gpu/drm/tiny/gm12u320.c > @@ -4,6 +4,7 @@ > */ > > #include <linux/module.h> > +#include <linux/pm.h> > #include <linux/usb.h> > > #include <drm/drm_atomic_helper.h> > @@ -718,15 +719,15 @@ static void gm12u320_usb_disconnect(struct usb_interface *interface) > drm_atomic_helper_shutdown(dev); > } > > -static __maybe_unused int gm12u320_suspend(struct usb_interface *interface, > - pm_message_t message) > +static int gm12u320_suspend(struct usb_interface *interface, > + pm_message_t message) > { > struct drm_device *dev = usb_get_intfdata(interface); > > return drm_mode_config_helper_suspend(dev); > } > > -static __maybe_unused int gm12u320_resume(struct usb_interface *interface) > +static int gm12u320_resume(struct usb_interface *interface) > { > struct drm_device *dev = usb_get_intfdata(interface); > struct gm12u320_device *gm12u320 = to_gm12u320(dev); > @@ -747,11 +748,9 @@ static struct usb_driver gm12u320_usb_driver = { > .probe = gm12u320_usb_probe, > .disconnect = gm12u320_usb_disconnect, > .id_table = id_table, > -#ifdef CONFIG_PM > - .suspend = gm12u320_suspend, > - .resume = gm12u320_resume, > - .reset_resume = gm12u320_resume, > -#endif > + .suspend = pm_ptr(gm12u320_suspend), > + .resume = pm_ptr(gm12u320_resume), > + .reset_resume = pm_ptr(gm12u320_resume), > }; > > module_usb_driver(gm12u320_usb_driver);
next prev parent reply other threads:[~2022-11-07 19:43 UTC|newest] Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-07 17:50 [PATCH 00/26] drm: Get rid of #ifdef CONFIG_PM* guards Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` [PATCH 01/26] drm: modeset-helper: Export dev_pm_ops for simple drivers Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-08 12:10 ` Thomas Zimmermann 2022-11-08 12:10 ` Thomas Zimmermann 2022-11-08 12:33 ` Paul Cercueil 2022-11-08 12:33 ` Paul Cercueil 2022-11-07 17:50 ` [PATCH 02/26] drm: bochs: Use the dev_pm_ops provided by modeset helper Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` [PATCH 03/26] drm: imx: " Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` [PATCH 04/26] drm: rockchip: " Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` [PATCH 05/26] drm: tegra: " Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` [PATCH 06/26] drm: sun4i: " Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-14 0:34 ` Samuel Holland 2022-11-14 0:34 ` Samuel Holland 2022-11-14 0:34 ` Samuel Holland 2022-11-07 17:50 ` [PATCH 07/26] drm: msxfb: " Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` [PATCH 08/26] drm: atmel-hlcdc: Remove #ifdef guards for PM related functions Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:53 ` Sam Ravnborg 2022-11-07 17:53 ` Sam Ravnborg 2022-11-07 17:53 ` Sam Ravnborg 2022-11-10 15:28 ` Claudiu.Beznea 2022-11-10 15:28 ` Claudiu.Beznea 2022-11-10 15:28 ` Claudiu.Beznea 2022-11-07 17:50 ` [PATCH 09/26] drm: exynos: " Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-21 4:25 ` Inki Dae 2022-11-21 4:25 ` Inki Dae 2022-11-21 4:25 ` Inki Dae 2022-11-07 17:50 ` [PATCH 10/26] drm: imx/dcss: " Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-07 17:50 ` Paul Cercueil 2022-11-11 14:27 ` Laurentiu Palcu 2022-11-11 14:27 ` Laurentiu Palcu 2022-11-11 14:27 ` Laurentiu Palcu 2022-11-07 17:52 ` [PATCH 11/26] drm: bridge/dw-hdmi: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` [PATCH 12/26] drm: etnaviv: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 18:07 ` Lucas Stach 2022-11-07 18:07 ` Lucas Stach 2022-11-07 21:03 ` Paul Cercueil 2022-11-07 21:03 ` Paul Cercueil 2022-11-07 17:52 ` [PATCH 13/26] drm: fsl-dcu: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` [PATCH 14/26] drm: mediatek: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` [PATCH 15/26] drm: omap: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` [PATCH 16/26] drm: panfrost: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-09 15:16 ` Steven Price 2022-11-09 15:16 ` Steven Price 2022-11-07 17:52 ` [PATCH 17/26] drm: rcar-du: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-16 13:41 ` Kieran Bingham 2022-11-16 13:41 ` Kieran Bingham 2022-11-07 17:52 ` [PATCH 18/26] drm: rockchip: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` [PATCH 19/26] drm: shmobile: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-16 13:41 ` Kieran Bingham 2022-11-16 13:41 ` Kieran Bingham 2022-11-07 17:52 ` [PATCH 20/26] drm: tegra: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` [PATCH 21/26] drm: tilcdc: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 17:52 ` [PATCH 22/26] drm: vboxvideo: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 19:43 ` Hans de Goede 2022-11-07 19:43 ` Hans de Goede 2022-11-07 17:52 ` [PATCH 23/26] drm: vc4: " Paul Cercueil 2022-11-07 17:52 ` Paul Cercueil 2022-11-07 20:27 ` [PATCH 21/26] drm: tilcdc: " sarha 2022-11-07 20:27 ` sarha 2022-11-07 17:55 ` [PATCH 24/26] drm: gm12u320: " Paul Cercueil 2022-11-07 17:55 ` Paul Cercueil 2022-11-07 17:55 ` [PATCH 25/26] drm: tidss: " Paul Cercueil 2022-11-07 17:55 ` Paul Cercueil 2022-11-07 17:55 ` [PATCH 26/26] drm/i915/gt: " Paul Cercueil 2022-11-07 17:55 ` [Intel-gfx] " Paul Cercueil 2022-11-07 17:55 ` Paul Cercueil 2022-11-07 20:31 ` Rodrigo Vivi 2022-11-07 20:31 ` [Intel-gfx] " Rodrigo Vivi 2022-11-07 20:31 ` Rodrigo Vivi 2022-11-07 20:59 ` Paul Cercueil 2022-11-07 20:59 ` [Intel-gfx] " Paul Cercueil 2022-11-07 20:59 ` Paul Cercueil 2022-11-07 19:43 ` Hans de Goede [this message] 2022-11-07 19:43 ` [PATCH 24/26] drm: gm12u320: " Hans de Goede
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=00889f1f-d9e5-9607-6932-f72417953ea7@redhat.com \ --to=hdegoede@redhat.com \ --cc=airlied@gmail.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=paul@crapouillou.net \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.